Version Getter Function #575

muellerr · 2022-03-08T10:09:20+01:00

muellerr commented

2022-03-08 10:09:20 +01:00

No description provided.

muellerr added 2 commits 2022-03-08 10:09:39 +01:00

ca70c8c614 function to get fsfw version

fsfw/fsfw/pipeline/pr-development This commit looks good Details

77e5fba7fd

update changelog

muellerr requested review from gaisser 2022-03-08 10:10:55 +01:00

muellerr added the

feature

label 2022-03-08 10:11:00 +01:00

muellerr added this to the v5.0.0 milestone 2022-03-08 10:40:27 +01:00

gaisser reviewed 2022-03-09 12:55:26 +01:00

src/fsfw/version.h

						
				@ -0,0 +8,4 @@

				struct Version {

				  uint32_t major = 0;

				  uint32_t minor = 0;

				  uint32_t revision = 0;

gaisser commented

2022-03-09 12:55:25 +01:00

Can you changed that to the next milestone 5.0.0?

muellerr commented

2022-03-09 13:11:52 +01:00

AH, you want the struct default value to be the current version? Then it might sense to initialize these values to the preprocessor define values right aways.. which would make the geztter function kind of obsolete..

mohr commented

2022-03-09 18:07:16 +01:00

Good point :)

Still I am with Steffen on this one. How about making the Version members even static const. I think the basic task was to make the Version accessible in a native C way, which fsfw::Version:major in my view is.

Instead of a getter, I would propose to add operators > == < <= >= for Version, to allow doing something with the information, like

if (fsfw::Version >= fsfw::VersionUser(4,3,0))

NB My example would need a non static const Variant of the class, maybe someone finds a more clever version.

Good point :) Still I am with Steffen on this one. How about making the `Version` members even `static const`. I think the basic task was to make the Version accessible in a native C way, which `fsfw::Version:major` in my view is. Instead of a getter, I would propose to add operators `>` `==` `<` `<=` `>=` for Version, to allow doing something with the information, like ``` if (fsfw::Version >= fsfw::VersionUser(4,3,0)) ``` NB My example would need a non static const Variant of the class, maybe someone finds a more clever version.

mohr marked this conversation as resolved

muellerr commented

2022-03-09 19:07:27 +01:00

Implemented extended Version class and const FSFW_VERSION class.

WIP, TODO:

Still need to unit test this. Also, it might be not the most efficient implementation (maybe at least the least simple one for the operators?) but that should not be too concerning for this use-case
Other feature: Implement << operator to print <Major>.<Minor>.<Revision>.
Update CHANGELOG

Implemented extended `Version` class and const `FSFW_VERSION` class. WIP, TODO: - Still need to unit test this. Also, it might be not the most efficient implementation (maybe at least the least simple one for the operators?) but that should not be too concerning for this use-case - Other feature: Implement `<<` operator to print `<Major>.<Minor>.<Revision>.` - Update CHANGELOG

muellerr changed title from ~~Version Getter Function~~ to WIP: Version Getter Function

2022-03-09 19:07:38 +01:00

muellerr added 1 commit 2022-03-09 19:08:18 +01:00

fsfw/fsfw/pipeline/pr-development This commit looks good Details

345a799031 improved version.h

muellerr added 1 commit 2022-03-09 19:10:34 +01:00

fsfw/fsfw/pipeline/pr-development This commit looks good Details

ca508bfe61 getter not required anymore

mohr reviewed 2022-03-09 20:18:12 +01:00

src/fsfw/version.h Outdated

						
				@ -0,0 +28,4 @@

				  friend bool operator<=(const Version& v1, const Version& v2) { return ((v1 == v2) or (v1 < v2)); }

				  friend bool operator>=(const Version& v1, const Version& v2) { return ((v1 == v2) or (v1 > v2)); }

				};