fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

minor event changes #578

Merged
gaisser merged 4 commits from eive/fsfw:mueller/event-update into development 2022-03-14 15:12:22 +01:00
Conversation 0 Commits 4 Files Changed 1 +9 -10
muellerr commented 2022-03-11 14:27:46 +01:00
Owner
Copy Link
  • Use enum instead of four separate static constexpr for Event Severity
  • Add a new type definition for the unique event ID. This is a prepration for an extension of the event generator script to deal with unique event IDs which are defines as variables. The generator needs a hint to parse these IDs to generate a lookup table for IDs which are defines as variables. A unique type can be used for this.
- Use `enum` instead of four separate `static constexpr` for Event Severity - Add a new type definition for the unique event ID. This is a prepration for an extension of the event generator script to deal with unique event IDs which are defines as variables. The generator needs a hint to parse these IDs to generate a lookup table for IDs which are defines as variables. A unique type can be used for this.
muellerr added 1 commit 2022-03-11 14:27:51 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
0bdcb40609 minor event changes
muellerr requested review from gaisser 2022-03-11 14:28:38 +01:00
muellerr added 1 commit 2022-03-14 15:07:28 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
48c5c3fbd5 Merge branch 'development' into mueller/event-update
muellerr added 2 commits 2022-03-14 15:08:56 +01:00
gaisser approved these changes 2022-03-14 15:11:33 +01:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser added this to the v5.0.0 milestone 2022-03-14 15:11:37 +01:00
gaisser added the
Refactor
 label 2022-03-14 15:12:10 +01:00
gaisser merged commit b7a617dab3 into development 2022-03-14 15:12:22 +01:00
gaisser deleted branch mueller/event-update 2022-03-14 15:12:24 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#578
No description provided.
Delete Branch "eive/fsfw:mueller/event-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?