fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Alternative reply ID activation #595

Merged
gaisser merged 2 commits from meier/alternativeReply into development 2022-04-11 14:18:52 +02:00
Conversation 1 Commits 2 Files Changed 2 +28 -9
meierj commented 2022-03-31 14:55:50 +02:00
Owner
Copy Link

Until now it was necessary to enable an alternative reply by overwriting enableReplyInReplyMap although the reply ID has already been provided with fillCommandAndReplyMap. The changes proposed with this PR bypass the extra step of overwriting enableReplyInReplyMap by adding the alternative reply ID directly to the device command info.

Until now it was necessary to enable an alternative reply by overwriting enableReplyInReplyMap although the reply ID has already been provided with fillCommandAndReplyMap. The changes proposed with this PR bypass the extra step of overwriting enableReplyInReplyMap by adding the alternative reply ID directly to the device command info.
meierj added 1 commit 2022-03-31 14:56:00 +02:00
get alternative reply from device command info
All checks were successful
fsfw/fsfw/pipeline/head This commit looks good
Details
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
6c1db8473b
meierj requested review from gaisser 2022-03-31 14:56:15 +02:00
gaisser added the
feature
API Change
 labels 2022-04-04 14:24:57 +02:00
gaisser approved these changes 2022-04-04 14:25:03 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser added 1 commit 2022-04-04 14:25:13 +02:00
Merge branch 'development' into meier/alternativeReply
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
c05184e1c4
gaisser merged commit afe006e234 into development 2022-04-11 14:18:52 +02:00
gaisser deleted branch meier/alternativeReply 2022-04-11 14:18:54 +02:00
gaisser added this to the v5.0.0 milestone 2022-04-11 17:34:54 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
API Change
feature
Milestone
No items
No Milestone v5.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#595
No description provided.
Delete Branch "meier/alternativeReply"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?