fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Fixes to allow compilation on MacOS #611

Merged
gaisser merged 6 commits from mueller/mac-os into development 2022-05-02 15:22:20 +02:00
Conversation 1 Commits 6 Files Changed 25 +121 -112
muellerr commented 2022-05-01 20:43:10 +02:00
Owner
Copy Link

This PR allows compilation of the FSFW with the Host OSAL on the MacOS or on any other Darwin based OS.

Some interesting points

  • Compilation was done with AppleClang version 13.0.0 (LLVM). It has a very useful warning flag on by default: -Winconsistent-missing-override. Some or most GCC warning flags will probably work for clang as well so it might be worth looking into useful additional warning flags for LLVM like it was done for GCC
  • The HAL linux folder could be renamed unix or split up into a linux and a unix folder, where unix contains the files like the termios abstraction and linux contains files which only work on linux systems (e.g. SPI library)
  • Same could be done for the OSAL folder. There are some components which compile but there are also some components like the MQ abstraction which don't work on MacOS (only can use SystemV message queues)
  • clang-tidy is a very useful linter tool which detected a lot of form improvements for the FSFW code
This PR allows compilation of the FSFW with the Host OSAL on the MacOS or on any other Darwin based OS. Some interesting points - Compilation was done with `AppleClang` version 13.0.0 (LLVM). It has a very useful warning flag on by default: `-Winconsistent-missing-override`. Some or most GCC warning flags will probably work for `clang` as well so it might be worth looking into useful additional warning flags for LLVM like it was done for GCC - The HAL `linux` folder could be renamed `unix` or split up into a `linux` and a `unix` folder, where `unix` contains the files like the termios abstraction and `linux` contains files which only work on linux systems (e.g. SPI library) - Same could be done for the OSAL folder. There are some components which compile but there are also some components like the MQ abstraction which don't work on MacOS (only can use SystemV message queues) - `clang-tidy` is a very useful linter tool which detected a lot of form improvements for the FSFW code
muellerr added 3 commits 2022-05-01 20:43:13 +02:00
fsfw/fsfw/pipeline/head There was a failure building this commit Details
afcbc8be0a changes for MacOS
fsfw/fsfw/pipeline/head There was a failure building this commit Details
7d61e67d20 more macos changes
fsfw/fsfw/pipeline/head There was a failure building this commit Details
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
28015c4735 it compiles and runs
muellerr commented 2022-05-02 08:56:03 +02:00
Author
Owner
Copy Link

-Winconsistent-missing-override actually does not exist for GCC..

I wonder if there is an equivalent flag

`-Winconsistent-missing-override` actually does not exist for GCC.. I wonder if there is an equivalent flag
muellerr added 1 commit 2022-05-02 09:10:14 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
77450eb4b7
removed flag which does not exist
muellerr added 6 commits 2022-05-02 09:35:37 +02:00
fsfw/fsfw/pipeline/head This commit looks good Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
64f0166b64
hotfix for new ETL dependency
fsfw/fsfw/pipeline/pr-development This commit looks good Details
17e609c3a5
some more var replacements
fsfw/fsfw/pipeline/pr-development This commit looks good Details
b00d83cb1a
bump ETL revision
fsfw/fsfw/pipeline/pr-development This commit looks good Details
6aa72892ed
clean usage of FetchContent_MakeAvailable
muellerr added a new dependency 2022-05-02 09:36:00 +02:00
#604 Hotfix CMake & ETL
muellerr removed a dependency 2022-05-02 09:36:19 +02:00
#604 Hotfix CMake & ETL
muellerr added a new dependency 2022-05-02 09:36:44 +02:00
#604 Hotfix CMake & ETL
muellerr added 1 commit 2022-05-02 15:15:59 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
cddf16f941 Merge branch 'development' into mueller/mac-os
gaisser approved these changes 2022-05-02 15:21:47 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser added the
cosmetics
 label 2022-05-02 15:21:55 +02:00
gaisser added this to the v5.0.0 milestone 2022-05-02 15:21:59 +02:00
gaisser merged commit c295539c79 into development 2022-05-02 15:22:20 +02:00
gaisser deleted branch mueller/mac-os 2022-05-02 15:22:24 +02:00
gaisser added the
bug
 label 2022-05-02 15:22:52 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#604 Hotfix CMake & ETL
fsfw/fsfw
Reference: fsfw/fsfw#611
No description provided.
Delete Branch "mueller/mac-os"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?