fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Compile Time Size Check fixed #614

Merged
muellerr merged 4 commits from gaisser/fsfw:gaisser_fix_compile_check into development 2022-05-09 16:14:45 +02:00
Conversation 2 Commits 4 Files Changed 1 +2 -3
gaisser commented 2022-05-02 16:18:07 +02:00
Owner
Copy Link

In FixedArrayList.h a static_assert was based on a wrong calculation which made the wild guess that bytes have 8 bits. New version should work with clang as well. I can't check any MS compilers here.

In `` FixedArrayList.h `` a static_assert was based on a wrong calculation which made the wild guess that bytes have 8 bits. New version should work with clang as well. I can't check any MS compilers here.
gaisser added 1 commit 2022-05-02 16:18:19 +02:00
Proposed fix for gcc and clang
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
54feb77770
muellerr commented 2022-05-02 16:18:57 +02:00
Owner
Copy Link

I can check MSVC

I can check MSVC
gaisser added 1 commit 2022-05-02 17:22:50 +02:00
Tested only std::numeric_limits in MSVC
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
3332f68ce7
gaisser commented 2022-05-02 17:23:31 +02:00
Author
Owner
Copy Link

I can check MSVC

I have checked std::numeric_limts in static_asserts in MSVC and it seems to work

> I can check MSVC I have checked std::numeric_limts in static_asserts in MSVC and it seems to work
gaisser requested review from muellerr 2022-05-02 17:52:59 +02:00
gaisser added the
bug
 label 2022-05-02 17:53:04 +02:00
gaisser added this to the v5.0.0 milestone 2022-05-02 17:53:08 +02:00
muellerr added 1 commit 2022-05-09 15:18:01 +02:00
Merge branch 'development' into gaisser_fix_compile_check
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
8b0508d50a
muellerr approved these changes 2022-05-09 15:18:13 +02:00
muellerr added 1 commit 2022-05-09 15:59:49 +02:00
Merge branch 'development' into gaisser_fix_compile_check
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
96eb8fc21f
muellerr merged commit c83cc492c0 into development 2022-05-09 16:14:45 +02:00
muellerr deleted branch gaisser_fix_compile_check 2022-05-09 16:14:47 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
muellerr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#614
No description provided.
Delete Branch "gaisser/fsfw:gaisser_fix_compile_check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?