Compile Time Size Check fixed #614

Merged
muellerr merged 4 commits from gaisser/fsfw:gaisser_fix_compile_check into development 2022-05-09 16:14:45 +02:00
Owner

In FixedArrayList.h a static_assert was based on a wrong calculation which made the wild guess that bytes have 8 bits. New version should work with clang as well. I can't check any MS compilers here.

In `` FixedArrayList.h `` a static_assert was based on a wrong calculation which made the wild guess that bytes have 8 bits. New version should work with clang as well. I can't check any MS compilers here.
gaisser added 1 commit 2022-05-02 16:18:19 +02:00
Proposed fix for gcc and clang
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
54feb77770
Owner

I can check MSVC

I can check MSVC
gaisser added 1 commit 2022-05-02 17:22:50 +02:00
Tested only std::numeric_limits in MSVC
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
3332f68ce7
Author
Owner

I can check MSVC

I have checked std::numeric_limts in static_asserts in MSVC and it seems to work

> I can check MSVC I have checked std::numeric_limts in static_asserts in MSVC and it seems to work
gaisser requested review from muellerr 2022-05-02 17:52:59 +02:00
gaisser added the
bug
label 2022-05-02 17:53:04 +02:00
gaisser added this to the v5.0.0 milestone 2022-05-02 17:53:08 +02:00
muellerr added 1 commit 2022-05-09 15:18:01 +02:00
Merge branch 'development' into gaisser_fix_compile_check
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
8b0508d50a
muellerr approved these changes 2022-05-09 15:18:13 +02:00
muellerr added 1 commit 2022-05-09 15:59:49 +02:00
Merge branch 'development' into gaisser_fix_compile_check
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
96eb8fc21f
muellerr merged commit c83cc492c0 into development 2022-05-09 16:14:45 +02:00
muellerr deleted branch gaisser_fix_compile_check 2022-05-09 16:14:47 +02:00
Sign in to join this conversation.
No description provided.