fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Health Service Bugfix #617

Merged
gaisser merged 4 commits from mueller/health-srv-bugfix into development 2022-05-09 16:08:29 +02:00
Conversation 0 Commits 4 Files Changed 4 +18 -16
muellerr commented 2022-05-09 10:49:10 +02:00
Owner
Copy Link
  • Found this bug using clang-tidy. There was an infinite recursion in the prepareHealthSetReply function
    which is currently unused. Also includes all other clang-tidy suggestions
    which made sense.
- Found this bug using `clang-tidy`. There was an infinite recursion in the `prepareHealthSetReply` function which is currently unused. Also includes all other `clang-tidy` suggestions which made sense.
muellerr added 2 commits 2022-05-09 10:49:15 +02:00
fsfw/fsfw/pipeline/head Build started... Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
e5e163bdbf
mark unused function
muellerr added 1 commit 2022-05-09 10:50:36 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
79f17843d8
update changelog
muellerr added the
bug
 label 2022-05-09 10:50:49 +02:00
muellerr added this to the v5.0.0 milestone 2022-05-09 11:01:51 +02:00
gaisser reviewed 2022-05-09 13:29:16 +02:00
src/fsfw/pus/CService201HealthCommanding.h
@ -45,2 +42,3 @@
const object_id_t *objectId);
ReturnValue_t prepareHealthSetReply(const CommandMessage *reply);
[[maybe_unused]] ReturnValue_t prepareHealthSetReply(const CommandMessage *reply);
gaisser commented 2022-05-09 13:29:16 +02:00
Owner
Copy Link

[[maybe_unused]] is a c++17 feature

``[[maybe_unused]]`` is a c++17 feature
muellerr commented 2022-05-09 13:50:05 +02:00
Author
Owner
Copy Link

This is unfortunate. I can't check this if I am using a more recent compiler. WE should consider upgrading the required version to C++17. Every project using the FSFW so far supports it anyway.

This is unfortunate. I can't check this if I am using a more recent compiler. WE should consider upgrading the required version to C++17. Every project using the FSFW so far supports it anyway.
gaisser marked this conversation as resolved
gaisser reviewed 2022-05-09 15:36:29 +02:00
src/fsfw/pus/CService201HealthCommanding.cpp Outdated
@ -14,3 +14,3 @@
}
CService201HealthCommanding::~CService201HealthCommanding() {}
CService201HealthCommanding::~CService201HealthCommanding() = default;
gaisser commented 2022-05-09 15:36:29 +02:00
Owner
Copy Link

I would move the default to the header and remove the line here but I don't know if this is good practice.

I would move the default to the header and remove the line here but I don't know if this is good practice.
muellerr commented 2022-05-09 15:39:23 +02:00
Author
Owner
Copy Link

Yeah, I can do that too and I have no idea what the best practice is. I think there is none. If i rewrote a header, I would do it there in the future.

Yeah, I can do that too and I have no idea what the best practice is. I think there is none. If i rewrote a header, I would do it there in the future.
muellerr commented 2022-05-09 15:41:24 +02:00
Author
Owner
Copy Link

okay, moved to header

okay, moved to header
gaisser marked this conversation as resolved
muellerr added 1 commit 2022-05-09 15:41:13 +02:00
gaisser approved these changes 2022-05-09 16:06:52 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser merged commit 46cfe65321 into development 2022-05-09 16:08:29 +02:00
gaisser deleted branch mueller/health-srv-bugfix 2022-05-09 16:08:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#617
No description provided.
Delete Branch "mueller/health-srv-bugfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?