important bugfix for TCP server #618

Merged
gaisser merged 5 commits from mueller/tcp-server-bugfix into development 2022-05-09 16:59:55 +02:00
Owner
  • MutexGuard was not created properly in TcpTmTcServer::handleTmSending(socket_t connSocket, bool& tmSent)
  • Introduced a lot of the suggested clang-tidy improvements.
- `MutexGuard` was not created properly in `TcpTmTcServer::handleTmSending(socket_t connSocket, bool& tmSent)` - Introduced a lot of the suggested `clang-tidy` improvements.
muellerr added 1 commit 2022-05-09 10:58:44 +02:00
important bugfix for TCP server
Some checks are pending
fsfw/fsfw/pipeline/head Build started...
fsfw/fsfw/pipeline/pr-development This commit looks good
16e55a98ce
muellerr added 1 commit 2022-05-09 11:00:36 +02:00
update changelog
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
6bfdace512
muellerr added the
bug
label 2022-05-09 11:00:46 +02:00
muellerr added this to the v5.0.0 milestone 2022-05-09 11:01:46 +02:00
gaisser requested changes 2022-05-09 13:27:25 +02:00
gaisser left a comment
Owner

There is a C++17 feature in this pull request.

There is a C++17 feature in this pull request.
@ -263,3 +264,3 @@
ReturnValue_t TcpTmTcServer::handleTmSending(socket_t connSocket, bool& tmSent) {
// Access to the FIFO is mutex protected because it is filled by the bridge
MutexGuard(tmtcBridge->mutex, tmtcBridge->timeoutType, tmtcBridge->mutexTimeoutMs);
MutexGuard mg(tmtcBridge->mutex, tmtcBridge->timeoutType, tmtcBridge->mutexTimeoutMs);
Owner

Oh how did you find that? clang-tidy?

Oh how did you find that? clang-tidy?
Author
Owner

Yes. Marked yelow, complained that it is immediately destroyed after creation.

Yes. Marked yelow, complained that it is immediately destroyed after creation.
gaisser marked this conversation as resolved
@ -101,3 +102,3 @@
ReturnValue_t initializeAfterTaskCreation() override;
std::string getTcpPort() const;
[[nodiscard]] const std::string& getTcpPort() const;
Owner

nodiscard is a c++17 extension. If we want to use that we have to change the minimum C++ Standard for the fsfw

nodiscard is a c++17 extension. If we want to use that we have to change the minimum C++ Standard for the fsfw
gaisser marked this conversation as resolved
gaisser approved these changes 2022-05-09 15:04:53 +02:00
muellerr added 1 commit 2022-05-09 15:55:05 +02:00
Merge remote-tracking branch 'origin/development' into mueller/tcp-server-bugfix
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
88fa4f1d9d
muellerr added 1 commit 2022-05-09 16:14:14 +02:00
Merge remote-tracking branch 'origin/development' into mueller/tcp-server-bugfix
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
ece32f88f4
gaisser added 1 commit 2022-05-09 16:56:10 +02:00
Merge branch 'development' into mueller/tcp-server-bugfix
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
3448292e8a
gaisser merged commit d45cda93b2 into development 2022-05-09 16:59:55 +02:00
gaisser deleted branch mueller/tcp-server-bugfix 2022-05-09 16:59:58 +02:00
Sign in to join this conversation.
No description provided.