important bugfix for TCP server #618

muellerr · 2022-05-09T10:58:41+02:00

muellerr commented

2022-05-09 10:58:41 +02:00

MutexGuard was not created properly in TcpTmTcServer::handleTmSending(socket_t connSocket, bool& tmSent)
Introduced a lot of the suggested clang-tidy improvements.

- `MutexGuard` was not created properly in `TcpTmTcServer::handleTmSending(socket_t connSocket, bool& tmSent)` - Introduced a lot of the suggested `clang-tidy` improvements.

muellerr added 1 commit 2022-05-09 10:58:44 +02:00

fsfw/fsfw/pipeline/head Build started... Details

fsfw/fsfw/pipeline/pr-development This commit looks good Details

16e55a98ce

important bugfix for TCP server

muellerr added 1 commit 2022-05-09 11:00:36 +02:00

fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details

6bfdace512

update changelog

muellerr added the

bug

label 2022-05-09 11:00:46 +02:00

muellerr added this to the v5.0.0 milestone 2022-05-09 11:01:46 +02:00

gaisser requested changes 2022-05-09 13:27:25 +02:00

gaisser left a comment

There is a C++17 feature in this pull request.

src/fsfw/osal/common/TcpTmTcServer.cpp

						
				@ -263,3 +264,3 @@

				ReturnValue_t TcpTmTcServer::handleTmSending(socket_t connSocket, bool& tmSent) {

				  // Access to the FIFO is mutex protected because it is filled by the bridge

				  MutexGuard(tmtcBridge->mutex, tmtcBridge->timeoutType, tmtcBridge->mutexTimeoutMs);

				  MutexGuard mg(tmtcBridge->mutex, tmtcBridge->timeoutType, tmtcBridge->mutexTimeoutMs);

gaisser commented

2022-05-09 13:27:03 +02:00

Oh how did you find that? clang-tidy?

muellerr commented

2022-05-09 13:50:44 +02:00

Yes. Marked yelow, complained that it is immediately destroyed after creation.

gaisser marked this conversation as resolved

src/fsfw/osal/common/TcpTmTcServer.h

						
				@ -101,3 +102,3 @@

				  ReturnValue_t initializeAfterTaskCreation() override;

				  std::string getTcpPort() const;

				  [[nodiscard]] const std::string& getTcpPort() const;