fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

cache the TCP client address now #630

Merged
gaisser merged 3 commits from eive/fsfw:mueller/tcp-server-cache-client-addr into development 2022-05-23 14:42:13 +02:00
Conversation 0 Commits 3 Files Changed 1 +4 -4
muellerr commented 2022-05-17 13:17:22 +02:00
Owner
Copy Link

I don't know why this API was not used. Keep the old call in case issues surface.

I don't know why this API was not used. Keep the old call in case issues surface.
muellerr added 1 commit 2022-05-17 13:17:23 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
e1dd27b9dd cache the TCP client address now
muellerr requested review from mohr 2022-05-17 13:17:29 +02:00
gaisser reviewed 2022-05-17 22:48:39 +02:00
src/fsfw/osal/common/TcpTmTcServer.cpp Outdated
@ -124,2 +124,2 @@
// connSocket = accept(listenerTcpSocket, &clientSockAddr, &connectorSockAddrLen);
connSocket = accept(listenerTcpSocket, nullptr, nullptr);
connSocket = accept(listenerTcpSocket, &clientSockAddr, &connectorSockAddrLen);
// connSocket = accept(listenerTcpSocket, nullptr, nullptr);
gaisser commented 2022-05-17 22:48:39 +02:00
Owner
Copy Link

Do we need that comment?

Do we need that comment?
muellerr commented 2022-05-17 23:32:19 +02:00
Author
Owner
Copy Link

can probably remove it

can probably remove it
muellerr commented 2022-05-18 13:13:37 +02:00
Author
Owner
Copy Link

comment removed

comment removed
gaisser marked this conversation as resolved
muellerr added 1 commit 2022-05-18 13:13:32 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
13cda86d23
remove commented code
muellerr added this to the v5.0.0 milestone 2022-05-20 15:35:51 +02:00
gaisser approved these changes 2022-05-23 14:37:51 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser added 1 commit 2022-05-23 14:38:12 +02:00
gaisser merged commit 5a425a1c58 into development 2022-05-23 14:42:13 +02:00
gaisser deleted branch mueller/tcp-server-cache-client-addr 2022-05-23 14:42:14 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#630
No description provided.
Delete Branch "eive/fsfw:mueller/tcp-server-cache-client-addr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?