fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

rtems fixes #635

Merged
muellerr merged 1 commits from mueller/rtems-fixes into development 2022-06-08 16:12:53 +02:00
Conversation 1 Commits 1 Files Changed 3 +9 -7
muellerr commented 2022-05-30 10:43:15 +02:00
Owner
Copy Link
  • RTEMS OSAL did not compile anymore, missing function override in
    Message Queue implementation
  • Some clang-tidy improvements
  • Line 68 looks a bit like a bug for me. The raw returnvalue from RTEMS was checked against MessageQueueIF::EMPTY. This is something clang-tidy caught.
- RTEMS OSAL did not compile anymore, missing function override in Message Queue implementation - Some `clang-tidy` improvements - Line 68 looks a bit like a bug for me. The raw returnvalue from RTEMS was checked against MessageQueueIF::EMPTY. This is something `clang-tidy` caught.
muellerr requested review from mohr 2022-05-30 10:43:55 +02:00
muellerr requested review from gaisser 2022-05-30 10:43:56 +02:00
muellerr added this to the v5.0.0 milestone 2022-05-30 10:44:00 +02:00
gaisser approved these changes 2022-06-07 22:04:50 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
muellerr added 1 commit 2022-06-08 12:11:30 +02:00
rtems fixes
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
e03f55604a
muellerr merged commit 17f54006b8 into development 2022-06-08 16:12:53 +02:00
muellerr deleted branch mueller/rtems-fixes 2022-06-08 16:12:55 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mohr
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone v5.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#635
No description provided.
Delete Branch "mueller/rtems-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?