fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Semaphore Initialization - Linux and FreeRTOS #89

Merged
gaisser merged 16 commits from KSat/fsfw:mueller_binSemaphoreInit into master 2020-08-28 13:25:07 +02:00
Conversation 3 Commits 16 Files Changed 16 +1210
muellerr commented 2020-05-29 13:50:09 +02:00
Owner
Copy Link

Includes all new semaphore features.

Implemented for Linux and FreeRTOS.

fixes #53

Includes all new semaphore features. Implemented for Linux and FreeRTOS. fixes #53
muellerr added the
feature
 label 2020-05-29 13:50:31 +02:00
muellerr changed title from Semaphore Initialization to Semaphore Initialization - Linux and FreeRTOS 2020-05-29 14:25:31 +02:00
muellerr commented 2020-05-29 14:33:45 +02:00
Author
Owner
Copy Link

I tested this code with an internal unit tester (for linux and freeRTOS, and this test can also be used for rtems when the implementation is finished). I will add the code to the fsfw test repository.

I tested this code with an internal unit tester (for linux and freeRTOS, and this test can also be used for rtems when the implementation is finished). I will add the code to the fsfw test repository.
gaisser self-assigned this 2020-08-25 12:35:41 +02:00
muellerr commented 2020-08-25 18:34:53 +02:00
Author
Owner
Copy Link

UPDATE: interface will be adapted to be similar to new MutexIF interface.
Also, include replacements still missing

UPDATE: interface will be adapted to be similar to new MutexIF interface. Also, include replacements still missing
muellerr changed title from Semaphore Initialization - Linux and FreeRTOS to WIP: Semaphore Initialization - Linux and FreeRTOS 2020-08-25 18:34:59 +02:00
muellerr changed title from WIP: Semaphore Initialization - Linux and FreeRTOS to Semaphore Initialization - Linux and FreeRTOS 2020-08-27 17:15:30 +02:00
gaisser reviewed 2020-08-28 11:46:23 +02:00
tasks/SemaphoreIF.h
@ -0,0 +31,4 @@
virtual~ SemaphoreIF() {};
static const uint8_t INTERFACE_ID = CLASS_ID::SEMAPHORE_IF;
gaisser commented 2020-08-28 11:46:23 +02:00
Owner
Copy Link

I don't see the addition of the class id in FwClassIds. Could you add this change as well?

I don't see the addition of the class id in FwClassIds. Could you add this change as well?
muellerr commented 2020-08-28 12:50:34 +02:00
Author
Owner
Copy Link

It's actually in there, I did a compile check

It's actually in there, I did a compile check
gaisser commented 2020-08-28 13:23:34 +02:00
Owner
Copy Link

Interesting, I don't find it in the commit view.

Interesting, I don't find it in the commit view.
gaisser commented 2020-08-28 13:25:01 +02:00
Owner
Copy Link

Oh it's part of the master.

Oh it's part of the master.
gaisser marked this conversation as resolved
gaisser merged commit ce4d010b5c into master 2020-08-28 13:25:06 +02:00
gaisser deleted branch mueller_binSemaphoreInit 2020-08-28 13:25:11 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
feature
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees gaisser
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#89
No description provided.
Delete Branch "KSat/fsfw:mueller_binSemaphoreInit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?