rust/sat-rs
11
1
Fork 0
Code Issues 7 Pull Requests Projects Releases 29 Wiki Activity

added result return to get_switch_state #30

Merged
muellerr merged 2 commits from power_abstraction_result_return into power_abstractions 2023-02-07 16:04:40 +01:00
Conversation 2 Commits 2 Files Changed 1
+3 -3
lkoester commented 2023-02-07 14:59:36 +01:00
Member
Copy Link
Copy Source

in case an invalid switch_id is given to the function, i.e. a switch_id that the powerswitcher does not implement

in case an invalid switch_id is given to the function, i.e. a switch_id that the powerswitcher does not implement
lkoester added 1 commit 2023-02-07 14:59:38 +01:00
added result return to get_switch_state be1299e7d6
lkoester marked the pull request as work in progress 2023-02-07 14:59:53 +01:00
lkoester marked the pull request as ready for review 2023-02-07 14:59:57 +01:00
lkoester requested review from muellerr 2023-02-07 15:00:09 +01:00
muellerr requested changes 2023-02-07 15:57:54 +01:00
satrs-core/src/power.rs Outdated
@@ -51,3 +51,2 @@
fn get_is_switch_on(&mut self, switch_id: SwitchId) -> bool {
self.get_switch_state(switch_id) == SwitchState::On
fn get_is_switch_on(&mut self, switch_id: SwitchId) -> Result<bool, ()> {
muellerr commented 2023-02-07 15:57:26 +01:00
Owner
Copy Link
Copy Source

I think Result<bool, Self::Error> can be returned here by writing self.get_switch_state(..)? == SwitchState::On

I think `Result<bool, Self::Error>` can be returned here by writing `self.get_switch_state(..)? == SwitchState::On`
lkoester marked this conversation as resolved
lkoester added 1 commit 2023-02-07 16:01:03 +01:00
simplified get is switch on ae8718ed6a
lkoester requested review from muellerr 2023-02-07 16:01:26 +01:00
muellerr approved these changes 2023-02-07 16:04:33 +01:00
muellerr merged commit 69c97459fb into power_abstractions 2023-02-07 16:04:40 +01:00
muellerr deleted branch power_abstraction_result_return 2023-02-07 16:04:41 +01:00
muellerr added this to the satrs v0.1.0 milestone 2023-02-14 16:32:38 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
muellerr
Labels
Clear labels
api
Non-Breaking API change
 b-api
Breaking API change
 bug
Something is not working
 concepts
Conception and ideas for new features
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone satrs v0.1.0
Projects
Clear projects
No project
Assignees
Clear assignees
ahinkel (Andy Hinkel) jenkins_buildfix lkoester meggert (Marius Eggert) meierj (Jakob Meier) mhess mohr (Ulrich Mohr) muellerr (Robin Müller) nehlichp (Paul Nehlich) steinertm (Michael Steinert) tbaumgartl (Tobias Baumgartl)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rust/sat-rs#30
Delete Branch "power_abstraction_result_return"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?