rust/sat-rs
rust/sat-rs
5
1
Fork 0
Code Issues 9 Pull Requests Projects Releases 20 Wiki Activity

added result return to get_switch_state #30

Merged
muellerr merged 2 commits from power_abstraction_result_return into power_abstractions 2023-02-07 16:04:40 +01:00
Conversation 0 Commits 2 Files Changed 1 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
satrs-core/src/power.rs
View File

@ -47,10 +47,10 @@ pub trait PowerSwitcher {
}
/// Retrieve the switch state
fn get_switch_state(&mut self, switch_id: SwitchId) -> SwitchState;
fn get_switch_state(&mut self, switch_id: SwitchId) -> Result<SwitchState, Self::Error>;
fn get_is_switch_on(&mut self, switch_id: SwitchId) -> bool {
self.get_switch_state(switch_id) == SwitchState::On
fn get_is_switch_on(&mut self, switch_id: SwitchId) -> Result<bool, Self::Error> {
lkoester marked this conversation as resolved Outdated
muellerr commented 2023-02-07 15:57:26 +01:00
Outdated
Review
Copy Link

I think Result<bool, Self::Error> can be returned here by writing self.get_switch_state(..)? == SwitchState::On

I think `Result<bool, Self::Error>` can be returned here by writing `self.get_switch_state(..)? == SwitchState::On`
Ok(self.get_switch_state(switch_id)? == SwitchState::On)
}
/// The maximum delay it will take to change a switch.