IMTQ Updates #306

Merged

muellerr merged 13 commits from mueller/imtq-updates into develop 2022-10-25 13:12:19 +02:00

Conversation 2 Commits 13 Files Changed 12 +379 -130

muellerr commented 2022-10-20 16:26:04 +02:00

Owner

Copy Link

Update to allow conveniently setting new torque values in the controller. Is currently asynchronous which I really don't like. Can maybe be fixed with a PST.

Update to allow conveniently setting new torque values in the controller. Is currently asynchronous which I really don't like. Can maybe be fixed with a PST.

muellerr added 11 commits 2022-10-20 16:26:11 +02:00

imtq update a0356a5092

new static variables to make torque status available 386fc60441

bump tmtc 6bdc420d0e

added fat TODO 42bb2f554f

re-use dipole set in IMTQ handler ab273a8a59

this works 2b6334b9dc

some tweaks for dipole set handling 07fe2cb122

removed TODO ada1111252

old code seems to work 29a34256a7

awful solution but works 75a4cd1b69

reformatinng bff4f6fa8d

muellerr added 1 commit 2022-10-20 16:26:38 +02:00

Merge remote-tracking branch 'origin/develop' into mueller/imtq-updates a5f2f3e8ea

muellerr requested review from meggert 2022-10-20 16:26:47 +02:00

muellerr added this to the v1.15.0 milestone 2022-10-20 16:26:52 +02:00

muellerr commented 2022-10-20 16:47:09 +02:00

Author

Owner

Copy Link

Note for future me:

New ACS Task, High priority with the following general order

1. ACS Subsystem
2. Read SPI MGM sensors ACS Board
3. Read ENG HK IMTQ
4. Read Raw MGM IMTQ
5. ACS CTRL
6. IMTQ Torqueing

So basically the performOp step of the Subsystem, then the com sequences for all SPI MGMs, then three com sequences for IMTQ.

At this stage, all important sensor values for the ACS CTRL should be ready, so we execute the ACS CTRL to get the actuator output.

After the ACS CTRL has run, the MGT output should be ready and we can start IMTQ torqueing. We could also put the RWs inside this task so they actuate with the most recent values calculated by the ACS CTRL.

Note for future me: New ACS Task, High priority with the following general order 1. ACS Subsystem 3. Read SPI MGM sensors ACS Board 2. Read ENG HK IMTQ 4. Read Raw MGM IMTQ 5. ACS CTRL 6. IMTQ Torqueing So basically the performOp step of the Subsystem, then the com sequences for all SPI MGMs, then three com sequences for IMTQ. At this stage, all important sensor values for the ACS CTRL should be ready, so we execute the ACS CTRL to get the actuator output. After the ACS CTRL has run, the MGT output should be ready and we can start IMTQ torqueing. We could also put the RWs inside this task so they actuate with the most recent values calculated by the ACS CTRL.

muellerr added 1 commit 2022-10-21 15:33:47 +02:00

Merge remote-tracking branch 'origin/develop' into mueller/imtq-updates 83b8cf3198

meggert approved these changes 2022-10-25 13:06:54 +02:00

muellerr referenced this issue from a commit 2022-10-25 13:12:17 +02:00

Merge pull request 'IMTQ Updates' (#306) from mueller/imtq-updates into develop

muellerr merged commit 5204afb9bd into develop 2022-10-25 13:12:19 +02:00

muellerr deleted branch mueller/imtq-updates 2022-10-25 13:12:21 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

meggert

Labels

Clear labels

OPS TODO

Issues identified by OPS

api change

API change

breaking api change

API change which can break existing code

bug

Something is not working

documentation

Documentation

duplicate

This issue or pull request already exists

feature

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone v1.15.0

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#306

No description provided.