Improve Subsystem DHB logic #112

muellerr · 2022-09-30T15:21:00+02:00

muellerr commented

2022-09-30 15:21:00 +02:00

Improved API and logic for mode tree build up
Dedicated interfaces to expose mode tree functionality
- ModeTreeChildIF for objects which can be mode tree children
- HasModeTreeChildrenIF for parent objects
- ModeTreeConnectionIF for connecting parent and child
The EIVE SW was developed with the V-model, which means that lower level components like assemblies, device handlers and controllers are developed first. The previous implementation meant that objects::NO_OBJECT was passed as the parent parameter everywhere. The parent is now not passed to base classes like SubsystemBase and ControllerBase anymore, and there is a deciated function connectModeTreeParent exposed by the ModeTreeConnectionIF to connect a parent component to a mode tree child.
The new connector function does everything in one place: Registering the child in the parent, and setting the parent command queue in the children. This means there is no confusion about the call direction anymore: This function does both.
DHB is now a regular mode tree object, no need for the ChildHandler just to attach it to a subsystem. In my opinion, not every satellite has or needs an assembly for every device handler

- Improved API and logic for mode tree build up - Dedicated interfaces to expose mode tree functionality - `ModeTreeChildIF` for objects which can be mode tree children - `HasModeTreeChildrenIF` for parent objects - `ModeTreeConnectionIF` for connecting parent and child - The EIVE SW was developed with the V-model, which means that lower level components like assemblies, device handlers and controllers are developed first. The previous implementation meant that `objects::NO_OBJECT` was passed as the parent parameter everywhere. The parent is now not passed to base classes like `SubsystemBase` and `ControllerBase` anymore, and there is a deciated function `connectModeTreeParent` exposed by the `ModeTreeConnectionIF` to connect a parent component to a mode tree child. - The new connector function does everything in one place: Registering the child in the parent, and setting the parent command queue in the children. This means there is no confusion about the call direction anymore: This function does both. - DHB is now a regular mode tree object, no need for the ChildHandler just to attach it to a subsystem. In my opinion, not every satellite has or needs an assembly for every device handler

muellerr added 8 commits 2022-09-30 15:21:02 +02:00

78314ad966

this makes a bit more sense

77f7fa2ef1

typo

f78344b8fb Merge remote-tracking branch 'origin/develop' into mueller/improve-ss-dhb-logic

7c5308429c

this seems to work

f824004897

need to fix all of these TODOs

10dd855244

expose child itself in interface