Storagemanager Refactoring #66
No reviewers
Labels
No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: fsfw/fsfw#66
Loading…
Reference in New Issue
No description provided.
Delete Branch "KSat/fsfw:mueller_localPoolNeat"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
fixes #63. part of #65. related to #12
StorageManagerIF: size_t replacement.
Bugfix for #63
Also introduces a trick to separate template class implementation from interface by exporting the implementation into .tpp files.
mueller_localPoolNeatto Storagemanager Refactoring@ -0,0 +104,4 @@size_list[address->pool_index][address->packet_index] = size;} else {if (!ignoreFault and internalErrorReporter != nullptr) {Bugfix here: nullptr check was missing previously.
This does not fix #65. It includes parts of the idea of separating a template in *.tpp files but only for local pools not all templates.
The bugfix is already merged in part of #64. I will mark #64 as duplicate.
As far as I can see, this pull requests changes all occurrences of pool calls with size_t ?
Yes, all size parameters which were previous uint32_t were replaced by size_t. I also changed all calls using it. new unit tests verify that everything is still working as expected and we don't have signed sizes or overrun checking like SerializeIF has, so there should not be any issues.
Merged upstream master, made sif replacements and improved include guards