fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Refactor Local Pool API #667

Merged
mohr merged 4 commits from mueller/refactor-local-pool-api into development 2022-09-12 14:32:09 +02:00
Conversation 0 Commits 4 Files Changed 8 +160 -58
muellerr commented 2022-08-30 11:04:18 +02:00
Owner
Copy Link

Builds on top #655 .

Improve the core API of ProvidesDataPoolSubscriptionIF by adding functions which take one wrapper struct. This also makes it more flexible. The old API format was kept to ensure that existing code does not break for this PR but is marked as [[deprecated]]

Migration

Calls like this:

poolManager.subscribeForPeriodicPacket(internalErrorSid, false,
      static_cast<float>(getPeriodicOperationFrequency()) / static_cast<float>(1000.0), true);

look like this now

  poolManager.subscribeForDiagPeriodicPacket({internalErrorSid, false,
      static_cast<float>(getPeriodicOperationFrequency()) / static_cast<float>(1000.0)});
Builds on top https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/655 . Improve the core API of `ProvidesDataPoolSubscriptionIF` by adding functions which take one wrapper struct. This also makes it more flexible. The old API format was kept to ensure that existing code does not break for this PR but is marked as `[[deprecated]]` ## Migration Calls like this: ```cpp poolManager.subscribeForPeriodicPacket(internalErrorSid, false, static_cast<float>(getPeriodicOperationFrequency()) / static_cast<float>(1000.0), true); ``` look like this now ```cpp poolManager.subscribeForDiagPeriodicPacket({internalErrorSid, false, static_cast<float>(getPeriodicOperationFrequency()) / static_cast<float>(1000.0)}); ```
muellerr added 131 commits 2022-08-30 11:04:23 +02:00
fsfw/fsfw/pipeline/head There was a failure building this commit Details
d7a2eada94
add space packet creator class
fsfw/fsfw/pipeline/head This commit looks good Details
0c5f623780
additional ctor for space packet creator
fsfw/fsfw/pipeline/head This commit looks good Details
3c72a42ce1
added basic sp creator test
fsfw/fsfw/pipeline/head There was a failure building this commit Details
7e2fdc06cd
hmm this is problematic
fsfw/fsfw/pipeline/head There was a failure building this commit Details
e4d7182d93
update changelog
fsfw/fsfw/pipeline/head This commit looks good Details
ddf38b65c3
apply auto-formatter
fsfw/fsfw/pipeline/head This commit looks good Details
3d2af203f2
finished creator unittests
fsfw/fsfw/pipeline/head There was a failure building this commit Details
5fffbd4a90
start PUS TC refactoring
fsfw/fsfw/pipeline/head There was a failure building this commit Details
6c636661b6
a lot of refactoring
fsfw/fsfw/pipeline/head There was a failure building this commit Details
d80941514f
start refactoring PUS TM handling
fsfw/fsfw/pipeline/head There was a failure building this commit Details
9860061fc6
create new TmSendHelper
fsfw/fsfw/pipeline/head There was a failure building this commit Details
be35bd53a6
switched to new tmtc stack API
fsfw/fsfw/pipeline/head There was a failure building this commit Details
d8b6cb39ac
various bugfixes and improvements
fsfw/fsfw/pipeline/head There was a failure building this commit Details
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
e5ee96259d
some fixes
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
23f264096c
delete a few old classes
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
08e0b0f1a0
added sp reader unittests
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
5af3138e81
fnished PUS TC creator unittests
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
61bc867bed
delete code which is not used anymore
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
0981ee6f7e
minor changes, virtual dtors added
fsfw/fsfw/pipeline/pr-development This commit looks good Details
affde6bad5
rename namespace
fsfw/fsfw/pipeline/pr-development This commit looks good Details
0dfaba81f9
finished basic TC unittests
fsfw/fsfw/pipeline/pr-development This commit looks good Details
bfee4fd90a
add empty test files
fsfw/fsfw/pipeline/pr-development This commit looks good Details
67776241de
verify successfull TM serialization
fsfw/fsfw/pipeline/pr-development This commit looks good Details
9275ccb79b
added some missing implementations
fsfw/fsfw/pipeline/pr-development This commit looks good Details
f28b9ea61b
APID getter bugfix
fsfw/fsfw/pipeline/pr-development This commit looks good Details
cecaec6007
PUS TM creator tests done
fsfw/fsfw/pipeline/pr-development This commit looks good Details
2dfbce6174
start TM reader unittests
fsfw/fsfw/pipeline/pr-development This commit looks good Details
b350018cad
completed basic test set
fsfw/fsfw/pipeline/pr-development This commit looks good Details
cb05329dd9
completed baseline PUS TM unittests
fsfw/fsfw/pipeline/pr-development This commit looks good Details
133894f4ba
add basic CCSDS tests
fsfw/fsfw/pipeline/pr-development This commit looks good Details
f0c8fd2688
some renaming
fsfw/fsfw/pipeline/pr-development This commit looks good Details
4921527022
replace c include
fsfw/fsfw/pipeline/pr-development This commit looks good Details
63ee88af17
added base for tm store test
fsfw/fsfw/pipeline/pr-development This commit looks good Details
832367fb30
replace some API components with references
fsfw/fsfw/pipeline/pr-development This commit looks good Details
4989bd0f02
fixes for Linux OSAL clock
fsfw/fsfw/pipeline/pr-development This commit looks good Details
899d021e00
using uint32_t as store_address requires explicit cast
fsfw/fsfw/pipeline/pr-development This commit looks good Details
973d4ee8a5
some more ref replacements
fsfw/fsfw/pipeline/pr-development This commit looks good Details
e2ad37e3e6
more ref replacements
fsfw/fsfw/pipeline/pr-development This commit looks good Details
36e3956efb
finished tm store helper tests
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
1a7d7b172b
set up new internal error reporter mock
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
5fd5d488ff
Merge remote-tracking branch 'origin/development' into mueller/refactor-tmtc-stack
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
6d0fa36f8a
cleaning up message queue mock and subscription API
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
935e135f1c
normal queue sufficient
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
a88f767cca
all tests running again
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
586993c081
completed send helper tests
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
c83f75c515
some more tests using TM send helper
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
7d87274844
add old api but mark it deprecated
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
6d00fc65c0
fix memory leak
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
c12669fe50
this should fix the mmeory leak
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
db33f9cc7e
maybe this teardown fixes the leak
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
747243684d
more leaks
fsfw/fsfw/pipeline/pr-development This commit looks good Details
e48b6f1432
possible double delete
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
bdf71d4e66
add new HasReturnvaluesIF features
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
4ed028000d Merge branch 'mueller/expand-retval-if' into mueller/refactor-tmtc-stack
fsfw/fsfw/pipeline/pr-development This commit looks good Details
500a5602bd
added additional TM store and send helper
fsfw/fsfw/pipeline/pr-development This commit looks good Details
f1c37203a4
some more API improvements and replacements
fsfw/fsfw/pipeline/pr-development This commit looks good Details
75c824ec80
add new VerificationReporterIF
fsfw/fsfw/pipeline/pr-development This commit looks good Details
146a0e3828
created PSB mock
fsfw/fsfw/pipeline/pr-development This commit looks good Details
f14c812aff
removed some obsolete code
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
d98b79cf5e
adapt PSB so it can be unittested properly
fsfw/fsfw/pipeline/pr-development This commit looks good Details
1954ce0ea4
default PUS receiver set automatically now
fsfw/fsfw/pipeline/pr-development This commit looks good Details
8bf0fb9885
test auto-initializers
fsfw/fsfw/pipeline/pr-development This commit looks good Details
152c01b2ec
psb unittests almost complete
fsfw/fsfw/pipeline/pr-development This commit looks good Details
681738dcc6
PSB unittests complete
fsfw/fsfw/pipeline/pr-development This commit looks good Details
9eb652e585
some printout fixes
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
18ee2ab903
example compiles again
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
064b195c75
some of the deprecation warnings run amok
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
86692e202d
this gets rid of some warnings
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
059fb10558
add helper methods to disable crc calculation
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
740644f2c8
updates for PusDistributor
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
c5ad9b5fa9
switch off debugging switches
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
f591b9793c
pass timeReader to Pus ZC writer
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
234ccdf764
send time stampers properly now
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
0a38d2e22d
small bugfix
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
356d778743
afmt
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
4e571e5082
some more minor fixes
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
d641d63531
set queue of tm send helper
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
f03b7cd660
another bugfix in CSB
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
7e8afcc12f
remove nullptr check
fsfw/fsfw/pipeline/pr-development This commit looks good Details
93acac02f5
tests running again
fsfw/fsfw/pipeline/pr-development This commit looks good Details
85dbef20b0
update serialize IF
fsfw/fsfw/pipeline/pr-development This commit looks good Details
5bb7023ff3
improvements for creator API
fsfw/fsfw/pipeline/pr-development This commit looks good Details
b485afea57
Simple SerializeIF adaptions 
- Returns serialized or deserialized size
fsfw/fsfw/pipeline/pr-development This commit looks good Details
30ba9ab916
some more fixes
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
cb118176a0
completed ZcWriter unittests
fsfw/fsfw/pipeline/pr-development This commit looks good Details
1b5fa2a8fa
test no crc generation
fsfw/fsfw/pipeline/pr-development This commit looks good Details
8f6f0e1d45
some more fail tests
fsfw/fsfw/pipeline/pr-development This commit looks good Details
fc3412fa35
set sec header flag and add unit test for it
fsfw/fsfw/pipeline/head This commit looks good Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
da106fd96f
do not use TC info for failed TC retrieval
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
9796abfc7d Merge branch 'development' into mueller/refactor-tmtc-stack
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
d7ec04bf4b
Merge remote-tracking branch 'origin/development' into mueller/refactor-tmtc-stack
fsfw/fsfw/pipeline/pr-development This commit looks good Details
9e064fe800
fix unittests
fsfw/fsfw/pipeline/head This commit looks good Details
1037102349
merge retval refactoring
fsfw/fsfw/pipeline/pr-development This commit looks good Details
8fd8a37f59
flip verif reporter ctor arguments
fsfw/fsfw/pipeline/pr-development This commit looks good Details
875174c4ad
better name for global object
fsfw/fsfw/pipeline/pr-development This commit looks good Details
239d053562
update changelog
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
ff6de8e378 important bugfix for verif reporter
fsfw/fsfw/pipeline/head There was a failure building this commit Details
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
2a4ab0af7b
Merge branch 'mueller/refactor-tmtc-stack' into mueller/refactor-tmtc-stack-with-retval-refactoring
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
fsfw/fsfw/pipeline/head There was a failure building this commit Details
dab1b1d067
apply auto-formatter
fsfw/fsfw/pipeline/head There was a failure building this commit Details
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
10f34e5a48
Merge remote-tracking branch 'origin/development' into mueller/refactor-tmtc-stack-with-retval-refactoring
fsfw/fsfw/pipeline/pr-development This commit looks good Details
ba5c6410d6
tests running again
fsfw/fsfw/pipeline/pr-development This commit looks good Details
a46d8c34d9
small changelog update
fsfw/fsfw/pipeline/pr-development This commit looks good Details
6bcb208968 Merge branch 'development' into mueller/refactor-tmtc-stack
fsfw/fsfw/pipeline/pr-development This commit looks good Details
b499dedd76
remove TODO
fsfw/fsfw/pipeline/pr-development This commit looks good Details
cb23911ccd
default initialization of CDS short struct
fsfw/fsfw/pipeline/pr-development This commit looks good Details
2cab73d972 avoid duplicate code
fsfw/fsfw/pipeline/head This commit looks good Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
9fedd03ed8
use cfg struct for local pool API
muellerr added a new dependency 2022-08-30 11:04:32 +02:00
#655 Refactor TMTC Stack, improve test framework
muellerr added 1 commit 2022-08-30 15:01:13 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
9131ca688b
make two helper functions protected
muellerr added 10 commits 2022-09-01 17:51:45 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
aea9db75cb
better name
fsfw/fsfw/pipeline/pr-development This commit looks good Details
a9277622ce
move data wrapper
fsfw/fsfw/pipeline/head Build started... Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
20d42add03
add new data wrapper helper type
fsfw/fsfw/pipeline/pr-development This commit looks good Details
0f27c7e7e7
extend data wrapper
fsfw/fsfw/pipeline/pr-development This commit looks good Details
c756297e5c
data wrapper update
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
8e6cee7761
Merge branch 'mueller/data-wrapper' into mueller/refactor-tmtc-stack
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
5c20cc804e Merge remote-tracking branch 'origin/development' into mueller/refactor-tmtc-stack
fsfw/fsfw/pipeline/pr-development This commit looks good Details
04bff7a522
test fix
mohr added the
Breaking API Change
 label 2022-09-12 14:18:02 +02:00
mohr added this to the v6.0.0 milestone 2022-09-12 14:18:10 +02:00
mohr approved these changes 2022-09-12 14:18:52 +02:00
mohr merged commit 9ee1896553 into development 2022-09-12 14:32:09 +02:00
mohr deleted branch mueller/refactor-local-pool-api 2022-09-12 14:32:12 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#655 Refactor TMTC Stack, improve test framework
fsfw/fsfw
Reference: fsfw/fsfw#667
No description provided.
Delete Branch "mueller/refactor-local-pool-api"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?