fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

devicehandler updates #320

Merged
gaisser merged 9 commits from KSat/fsfw:mueller/devicehandlers-update into development 2020-12-22 15:28:46 +01:00
Conversation 1 Commits 9 Files Changed 4 +51 -41
muellerr commented 2020-12-22 12:49:45 +01:00
Owner
Copy Link

getTransitionDelay is now abstract.
setNormalDatapoolEntriesInvalid implementation using local pools provided (still virtual), no abstract method anymore.

Typofix for device command in DeviceHandlerIF .

getTransitionDelay is now abstract. setNormalDatapoolEntriesInvalid implementation using local pools provided (still virtual), no abstract method anymore. Typofix for device command in `DeviceHandlerIF` .
muellerr added the
feature
API Change
 labels 2020-12-22 12:49:45 +01:00
muellerr added 1 commit 2020-12-22 12:49:46 +01:00
muellerr added 1 commit 2020-12-22 12:49:51 +01:00
muellerr added 2 commits 2020-12-22 12:53:32 +01:00
gaisser added 1 commit 2020-12-22 15:08:16 +01:00
gaisser reviewed 2020-12-22 15:10:51 +01:00
devicehandlers/DeviceHandlerBase.cpp
@ -1008,0 +926,4 @@
mySet.read();
if (thermalRequest != ThermalComponentIF::STATE_REQUEST_IGNORE) {
thermalRequest = ThermalComponentIF::STATE_REQUEST_OPERATIONAL;
mySet.commit(PoolVariableIF::VALID);
gaisser commented 2020-12-22 15:10:51 +01:00
Owner
Copy Link

make abstract

make abstract
gaisser marked this conversation as resolved
muellerr added 2 commits 2020-12-22 15:11:52 +01:00
gaisser added this to the ASTP 1.0.0 Local pools milestone 2020-12-22 15:12:57 +01:00
muellerr added 1 commit 2020-12-22 15:26:51 +01:00
gaisser self-assigned this 2020-12-22 15:28:34 +01:00
gaisser added 1 commit 2020-12-22 15:28:39 +01:00
gaisser merged commit 7f3bdb6082 into development 2020-12-22 15:28:46 +01:00
gaisser deleted branch mueller/devicehandlers-update 2020-12-22 15:28:50 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
API Change
feature
Milestone
No items
No Milestone ASTP 1.0.0 Local pools
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran
No Assignees gaisser
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#320
No description provided.
Delete Branch "KSat/fsfw:mueller/devicehandlers-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?