service interface testing for eclipse #52

Closed
muellerr wants to merge 3 commits from mueller_serviceStream_enhancement into master
Owner

Fixes #51 . Fixes #31

Fixes #51 . Fixes #31
muellerr reviewed 2020-04-22 10:05:43 +02:00
@ -8,3 +8,3 @@
#include <cstdio>
//Unfortunately, there must be a forward declaration of log_fe (MUST be defined in main), to let the system know where to write to.
// Unfortunately, there must be a forward declaration of log_fe
Author
Owner

I have not really understood what log_fe is.

I have not really understood what log_fe is.
muellerr added the
bug
feature
labels 2020-04-24 17:10:43 +02:00
Owner

Hm the SIF still has defines for UT699 :(. Hm we have to rethink how we are handling that. log_fe is the front end like debug or error.

Hm the SIF still has defines for UT699 :(. Hm we have to rethink how we are handling that. log_fe is the front end like debug or error.
Author
Owner

Okay. i still think this approach is nice (and eclipse output is neat :-)). I don't know if it is fast than the old approach, but I don't think speed is of high relevance when using stream interfaces.

merged upstream master.

Okay. i still think this approach is nice (and eclipse output is neat :-)). I don't know if it is fast than the old approach, but I don't think speed is of high relevance when using stream interfaces. merged upstream master.
gaisser reviewed 2020-05-08 12:39:16 +02:00
@ -18,3 +19,3 @@
// buffer is not used, then this is called every
// time when characters are put to stream.
virtual int overflow(int c = Traits::eof());
int overflow(int c = Traits::eof()) override;
Owner

Is there a reason to remove the virtual modifier here?

Is there a reason to remove the virtual modifier here?
Author
Owner

Not really. I'll put it back in

Not really. I'll put it back in
muellerr closed this pull request 2020-05-29 20:28:17 +02:00
Author
Owner

Oh, that was not intended.. I will just open a new pull request from the fork.

Oh, that was not intended.. I will just open a new pull request from the fork.

Pull request closed

Sign in to join this conversation.
No description provided.