service interface stream enhancements #93

muellerr · 2020-05-29T20:33:09+02:00

muellerr commented

2020-05-29 20:33:09 +02:00

replacement for #52 .
Fixes #51 .
Fixes #31 .

replacement for #52 . Fixes #51 . Fixes #31 .

muellerr added the

feature

label 2020-05-29 20:33:09 +02:00

muellerr commented

2020-06-03 23:19:13 +02:00

I made some more improvements:

Printout can be redirected to stderr now optionally (can be used on host environments)
printChar takes additional boolean to specify where to print (stderr or stdout)
if stderr is used, mode is unbuffered. Preamble must be printed manually then, new getter function for this
forward declaration of ServiceINterfaceStreams so the public functions (setActive(), getPreamble()) can be used. otherwise, they can only be used in main().
some simplifications and better documentation.

I made some more improvements: 1. Printout can be redirected to stderr now optionally (can be used on host environments) 2. printChar takes additional boolean to specify where to print (stderr or stdout) 3. if stderr is used, mode is unbuffered. Preamble must be printed manually then, new getter function for this 3. forward declaration of ServiceINterfaceStreams so the public functions (setActive(), getPreamble()) can be used. otherwise, they can only be used in main(). 4. some simplifications and better documentation.

muellerr commented

2020-06-04 19:56:29 +02:00

I have rewritten parts of the code.

The only external definitions are the classes itself now (which are already std::ostream's anyway). These can be instantiated somewhere else, and the extra osstreams are not necessary anymore.

I reworked the getPreamble() function to not use dnymaic memory allocation (at runtime), so sprintf is used again.

THere are optional flags to work in unbuffered mode or pipe output to stderr instead of stdout as well.

Small API change: printChar now takes a second parameter, which specifies whether to use stderr or stdout. Can be used on linux for example.

I have rewritten parts of the code. The only external definitions are the classes itself now (which are already std::ostream's anyway). These can be instantiated somewhere else, and the extra osstreams are not necessary anymore. I reworked the getPreamble() function to not use dnymaic memory allocation (at runtime), so sprintf is used again. THere are optional flags to work in unbuffered mode or pipe output to stderr instead of stdout as well. Small API change: printChar now takes a second parameter, which specifies whether to use stderr or stdout. Can be used on linux for example.

muellerr added the

API Change

label 2020-06-04 19:57:56 +02:00

muellerr commented

2020-06-10 18:41:48 +02:00

Old implementation was using dynamic memory allocaton, space for std::string now allocated at initialization only.

gaisser self-assigned this 2020-07-21 12:18:01 +02:00

gaisser referenced this issue from a commit

2020-07-21 12:18:20 +02:00

Merge pull request 'service interface stream enhancements' (#93) from KSat/fsfw:mueller_ServiceStreamEnhancement into master

gaisser closed this pull request

2020-07-21 12:18:20 +02:00