fix compiler warnings and auto-formatting #598

Merged
gaisser merged 7 commits from eive/fsfw:mueller/compiler-warning-fixes-upstream-2 into development 2022-05-02 14:17:01 +02:00
Owner
  • Potential nullptr dereferences found when building in release mode
- Potential `nullptr` dereferences found when building in release mode
muellerr added 1 commit 2022-04-11 16:07:15 +02:00
fix compiler warnings
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
9947a648df
muellerr requested review from gaisser 2022-04-11 16:07:37 +02:00
muellerr added this to the v5.0.0 milestone 2022-04-11 16:07:40 +02:00
gaisser reviewed 2022-04-11 17:02:08 +02:00
@ -11,3 +11,3 @@
HybridIterator(typename LinkedElement<T>::Iterator *iter)
: LinkedElement<T>::Iterator(*iter), value(iter->value), linked(true) {}
: LinkedElement<T>::Iterator(*iter), value(iter->value), linked(true) {
Owner

value is set here before the new check.

value is set here before the new check.
Author
Owner

Hmm, I guess I forgot to completely recompile everything..

Hmm, I guess I forgot to completely recompile everything..
gaisser marked this conversation as resolved
gaisser reviewed 2022-04-11 17:10:12 +02:00
@ -31,3 +31,3 @@
}
if (iter.value == NULL) {
if (iter.value ==nullptr) {
Owner

looks like clang format is not apllied.

looks like clang format is not apllied.
gaisser marked this conversation as resolved
gaisser requested changes 2022-04-11 17:10:43 +02:00
gaisser left a comment
Owner

See comments for requested changes.

See comments for requested changes.
muellerr added 1 commit 2022-04-11 17:14:09 +02:00
afmt
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
cb78fefbb3
muellerr added 1 commit 2022-04-11 17:14:49 +02:00
small fix
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
a1d7a56dfa
muellerr changed title from fix compiler warnings to fix compiler warnings and auto-formatting 2022-04-11 17:15:43 +02:00
gaisser approved these changes 2022-04-11 17:30:24 +02:00
gaisser left a comment
Owner

LGTM

LGTM
muellerr added 1 commit 2022-04-11 17:33:08 +02:00
Merge branch 'development' into mueller/compiler-warning-fixes-upstream-2
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
afce942bf8
muellerr added 1 commit 2022-04-12 17:09:00 +02:00
Merge branch 'development' into mueller/compiler-warning-fixes-upstream-2
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
07f5dbb9ac
muellerr added 1 commit 2022-04-25 15:24:23 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/compiler-warning-fixes-upstream-2
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
80be937d9d
muellerr added 1 commit 2022-04-27 08:47:50 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/compiler-warning-fixes-upstream-2
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
70eb8325a0
gaisser added the
bug
label 2022-05-02 12:34:24 +02:00
gaisser merged commit 7b979eadff into development 2022-05-02 14:17:01 +02:00
gaisser deleted branch mueller/compiler-warning-fixes-upstream-2 2022-05-02 14:17:03 +02:00
Sign in to join this conversation.
No description provided.