fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

fix compiler warnings and auto-formatting #598

Merged
gaisser merged 7 commits from eive/fsfw:mueller/compiler-warning-fixes-upstream-2 into development 2022-05-02 14:17:01 +02:00
Conversation 0 Commits 7 Files Changed 4 +29 -12
muellerr commented 2022-04-11 16:07:13 +02:00
Owner
Copy Link
  • Potential nullptr dereferences found when building in release mode
- Potential `nullptr` dereferences found when building in release mode
muellerr added 1 commit 2022-04-11 16:07:15 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
9947a648df fix compiler warnings
muellerr requested review from gaisser 2022-04-11 16:07:37 +02:00
muellerr added this to the v5.0.0 milestone 2022-04-11 16:07:40 +02:00
gaisser reviewed 2022-04-11 17:02:08 +02:00
src/fsfw/container/HybridIterator.h Outdated
@ -11,3 +11,3 @@
HybridIterator(typename LinkedElement<T>::Iterator *iter)
: LinkedElement<T>::Iterator(*iter), value(iter->value), linked(true) {}
: LinkedElement<T>::Iterator(*iter), value(iter->value), linked(true) {
gaisser commented 2022-04-11 17:02:08 +02:00
Owner
Copy Link

value is set here before the new check.

value is set here before the new check.
muellerr commented 2022-04-11 17:15:02 +02:00
Author
Owner
Copy Link

Hmm, I guess I forgot to completely recompile everything..

Hmm, I guess I forgot to completely recompile everything..
gaisser marked this conversation as resolved
gaisser reviewed 2022-04-11 17:10:12 +02:00
src/fsfw/subsystem/Subsystem.cpp Outdated
@ -31,3 +31,3 @@
}
if (iter.value == NULL) {
if (iter.value ==nullptr) {
gaisser commented 2022-04-11 17:10:12 +02:00
Owner
Copy Link

looks like clang format is not apllied.

looks like clang format is not apllied.
gaisser marked this conversation as resolved
gaisser requested changes 2022-04-11 17:10:43 +02:00
gaisser left a comment
Owner
Copy Link

See comments for requested changes.

See comments for requested changes.
muellerr added 1 commit 2022-04-11 17:14:09 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
cb78fefbb3
afmt
muellerr added 1 commit 2022-04-11 17:14:49 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
a1d7a56dfa
small fix
muellerr changed title from fix compiler warnings to fix compiler warnings and auto-formatting 2022-04-11 17:15:43 +02:00
gaisser approved these changes 2022-04-11 17:30:24 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
muellerr added 1 commit 2022-04-11 17:33:08 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
afce942bf8 Merge branch 'development' into mueller/compiler-warning-fixes-upstream-2
muellerr added 1 commit 2022-04-12 17:09:00 +02:00
muellerr added 1 commit 2022-04-25 15:24:23 +02:00
muellerr added 1 commit 2022-04-27 08:47:50 +02:00
gaisser added the
bug
 label 2022-05-02 12:34:24 +02:00
gaisser merged commit 7b979eadff into development 2022-05-02 14:17:01 +02:00
gaisser deleted branch mueller/compiler-warning-fixes-upstream-2 2022-05-02 14:17:03 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#598
No description provided.
Delete Branch "eive/fsfw:mueller/compiler-warning-fixes-upstream-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?