fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

WIP: TC Packet PUS new serializer/creator function #629

Closed
muellerr wants to merge 13 commits from KSat/fsfw:mueller/tc-packet-pus-improvement into development
pull from: KSat/fsfw:mueller/tc-packet-pus-improvement
merge into: fsfw:development
Conversation 3 Commits 13 Files Changed 4 +89 -3
muellerr commented 2022-05-17 10:17:22 +02:00
Owner
Copy Link
  • Add function to set the application data field
  • Make function to initialize the packet public
- Add function to set the application data field - Make function to initialize the packet public
muellerr added 2 commits 2022-05-17 10:17:23 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
618f76ae78
improved TcPacketPus API
muellerr requested review from mohr 2022-05-17 10:17:34 +02:00
muellerr requested review from gaisser 2022-05-18 13:13:49 +02:00
muellerr added this to the v5.0.0 milestone 2022-05-20 15:36:01 +02:00
gaisser requested changes 2022-05-23 14:50:06 +02:00
gaisser left a comment
Owner
Copy Link

Hm setApplicationData is not able to check any length or do I miss something there? This seems to be a fancy wrapper for memcpy without any possible check for the size of this->tcData->appdata. So, everything must be checked by the user before. We should add this in the documentation. If not used correctly, this introduces issues which are difficult to track.

Hm `` setApplicationData `` is not able to check any length or do I miss something there? This seems to be a fancy wrapper for memcpy without any possible check for the size of ``this->tcData->appdata``. So, everything must be checked by the user before. We should add this in the documentation. If not used correctly, this introduces issues which are difficult to track.
muellerr added 1 commit 2022-05-23 15:56:34 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
9368ae81e5 Merge branch 'development' into mueller/tc-packet-pus-improvement
muellerr commented 2022-05-23 15:58:12 +02:00
Author
Owner
Copy Link

I can look into adding that documentation or whether a size check is possible.

I can look into adding that documentation or whether a size check is possible.
muellerr added 1 commit 2022-05-27 15:15:44 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
b9fbb4fd4c Merge branch 'development' into mueller/tc-packet-pus-improvement
muellerr added 1 commit 2022-06-13 16:13:22 +02:00
muellerr added 1 commit 2022-06-13 16:13:45 +02:00
muellerr added 2 commits 2022-06-13 16:14:36 +02:00
muellerr commented 2022-06-13 16:15:52 +02:00
Author
Owner
Copy Link

Refactored this to leave TcPacketPus untouched and circumvent store with new function which can serialize and initialize TC packets into a given buffer. Still needs to be tested.

This class is then only intended for serialization/packet creation. It has the same style as the CFDP PDU serializer classes. I will also probably unit test this class.

Refactored this to leave `TcPacketPus` untouched and circumvent store with new function which can serialize and initialize TC packets into a given buffer. Still needs to be tested. This class is then only intended for serialization/packet creation. It has the same style as the CFDP PDU serializer classes. I will also probably unit test this class.
muellerr changed title from TC Packet PUS improvements to WIP: TC Packet PUS new serializer/creator function 2022-06-13 16:16:09 +02:00
muellerr added 1 commit 2022-06-13 16:20:38 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
15d69e64f3
renamed new class, small tweak
gaisser approved these changes 2022-06-13 16:33:36 +02:00
gaisser left a comment
Owner
Copy Link

Just small remarks

Just small remarks
src/fsfw/tmtcpacket/pus/tc/TcPacketSerializer.cpp
@ -0,0 +16,4 @@
return RETURN_OK;
}
size_t TcPacketSerializer::getSerializedSize() const { return TC_PACKET_MIN_SIZE + cfg.appDataLen; }
gaisser commented 2022-06-13 16:32:44 +02:00
Owner
Copy Link

TC_PACKET_MIN_SIZE is compile time fix for a specific pus version. PusConfig allows for different PusVersions. This might be an issue for PUS A usage at compile time and PUS C usage here.

TC_PACKET_MIN_SIZE is compile time fix for a specific pus version. PusConfig allows for different PusVersions. This might be an issue for PUS A usage at compile time and PUS C usage here.
gaisser marked this conversation as resolved
src/fsfw/tmtcpacket/pus/tc/TcPacketSerializer.h Outdated
@ -0,0 +14,4 @@
uint16_t sourceId = 0;
uint8_t* appData = nullptr;
size_t appDataLen = 0;
pus::PusVersion pusVersion = pus::PusVersion::PUS_C_VERSION;
gaisser commented 2022-06-13 16:33:21 +02:00
Owner
Copy Link

Maybe fix this at compile time to be disallow problems with TC_PACKET_MIN_SIZE

Maybe fix this at compile time to be disallow problems with TC_PACKET_MIN_SIZE
gaisser requested changes 2022-06-13 16:35:54 +02:00
gaisser left a comment
Owner
Copy Link

Mis-clicked previous review. :( See comments above.

Mis-clicked previous review. :( See comments above.
muellerr added 1 commit 2022-06-13 16:45:39 +02:00
muellerr added 1 commit 2022-06-13 16:45:47 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
5bd3abed8b Merge branch 'development' into mueller/tc-packet-pus-improvement
gaisser approved these changes 2022-06-14 18:41:29 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
muellerr added 1 commit 2022-07-05 17:55:17 +02:00
muellerr added 1 commit 2022-07-18 08:50:22 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
5916763483 Merge branch 'development' into mueller/tc-packet-pus-improvement
gaisser modified the milestone from v5.0.0 to v6.0.0 2022-07-18 14:55:11 +02:00
muellerr commented 2022-07-27 22:35:29 +02:00
Author
Owner
Copy Link

Will be obsolete with #655

Will be obsolete with #655
muellerr closed this pull request 2022-08-22 16:24:39 +02:00
mohr removed this from the v6.0.0 milestone 2023-02-09 16:06:11 +01:00
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
mohr
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#629
No description provided.
Delete Branch "KSat/fsfw:mueller/tc-packet-pus-improvement"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?