fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

moved TCScheduling Service to use timeval internally #735

Open
mohr wants to merge 7 commits from mohr/timetag_fix into development
pull from: mohr/timetag_fix
merge into: fsfw:development
Conversation 0 Commits 7 Files Changed 3 +45 -18
mohr commented 2023-02-07 14:30:25 +01:00
Owner
Copy Link

Compiler was warning about comparisons between signed and unsigned so I just used timeval internally to be safe (and exact).

In the future we could think about moving to 64 bit in the TC as well...

Compiler was warning about comparisons between signed and unsigned so I just used timeval internally to be safe (and exact). In the future we could think about moving to 64 bit in the TC as well...
mohr added 1 commit 2023-02-07 14:30:27 +01:00
moved TCScheduling Service to use timeval internally
Some checks failed
fsfw/fsfw/pipeline/head There was a failure building this commit
Details
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
61620bfce7
mohr added 1 commit 2023-02-09 12:07:52 +01:00
Merge branch 'development' into mohr/timetag_fix
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
9a09cadb4f
mohr added 1 commit 2023-02-09 13:20:39 +01:00
missed one
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
319199cb22
muellerr requested changes 2023-02-10 13:59:43 +01:00
src/fsfw/pus/Service11TelecommandScheduling.tpp Outdated
@ -163,1 +168,3 @@
if (timestamp - tNow.tv_sec <= RELEASE_TIME_MARGIN_SECONDS) {
timeval timeDifference = scheduledTime - tNow;
// round subseconds up
if (timeDifference.tv_sec + 1 <= RELEASE_TIME_MARGIN_SECONDS) {
muellerr commented 2023-02-10 13:59:31 +01:00
Owner
Copy Link

Is timeval guaranteed to be signed?
This also rounds up when subsecond micros are 0, is this intended?

Is timeval guaranteed to be signed? This also rounds up when subsecond micros are 0, is this intended?
mohr commented 2023-02-10 20:55:14 +01:00
Author
Owner
Copy Link
  1. Yes, timeval is using time_t in unixoides and long in windows.
  2. Admittedly I was lazy, I will change it so that 0 does not round up.
1) Yes, timeval is using time_t in unixoides and long in windows. 2) Admittedly I was lazy, I will change it so that 0 does not round up.
muellerr commented 2023-02-20 18:14:46 +01:00
Owner
Copy Link

Can we use timestamp <= tNow.tv_sec + RELEASE_TIME_MARGIN_SECONDS compare logic instead?

That is a bit more readable in my opinion.

Can we use `timestamp <= tNow.tv_sec + RELEASE_TIME_MARGIN_SECONDS` compare logic instead? That is a bit more readable in my opinion.
mohr commented 2023-05-08 15:17:31 +02:00
Author
Owner
Copy Link

Changed rounding to be correct.
The unreadable comparison is removed with this PR.

Changed rounding to be correct. The unreadable comparison is removed with this PR.
mohr added 3 commits 2023-05-08 15:16:18 +02:00
CHANGELOG
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
5a35f8e50b
mohr added 1 commit 2023-05-08 15:30:00 +02:00
Merge branch 'development' into mohr/timetag_fix
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
027d309a7a
muellerr added this to the vNext milestone 2023-09-01 12:21:48 +02:00
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
This pull request has changes conflicting with the target branch.
  • CHANGELOG.md
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin mohr/timetag_fix:mohr/timetag_fix
git checkout mohr/timetag_fix
Sign in to join this conversation.
Reviewers
No reviewers
muellerr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
vNext
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#735
No description provided.
Delete Branch "mohr/timetag_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?