Merge pull request 'v6.0.0' (#729) from development into master

Reviewed-on: fsfw/fsfw#729

.gitmodules

@@ -1,3 +0,0 @@
-[submodule "automation/msvc-wine"]
-	path = automation/msvc-wine
-	url = https://github.com/mstorsjo/msvc-wine

CHANGELOG.md

@@ -8,24 +8,38 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 # [unreleased]
 
-# [v6.0.0]
+# [v6.0.0] 2023-02-10
 
 ## Fixes
 
+- Mode Service: Add allowed subservice
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/739
+- `CService200ModeManagement`: Various bugfixes which lead to now execution complete being generated
+  on mode announcements, duplicate mode reply generated on announce commands, and the mode read
+  subservice not working properly.
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/736
+- Memory leak fixes for the TCP/IP TMTC bridge.
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/737
 - `Service9TimeManagement`: Fix the time dump at the `SET_TIME` subservice: Include clock timeval
   seconds instead of uptime.
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/726
 - HAL MGM3100 Handler: Use axis specific gain/scaling factors. Previously,
   only the X scaling factor was used.
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/724
+- HAL MGM3100 Handler: Z value was previously calculated with bytes of the X value.
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/733
 - DHB `setNormalDatapoolEntriesInvalid`: The default implementation did not set the validity
   to false correctly because the `read` and `write` calls were missing.
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/728
 - PUS TMTC creator module: Sequence flags were set to continuation segment (0b00) instead
   of the correct unsegmented flags (0b11) as specified in the standard.
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/727
 - TC Scheduler Service 11: Add size and CRC check for contained TC.
+  Bug: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/issues/719
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/720
 - Only delete health table entry in `HealthHelper` destructor if
   health table was set.
-  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/710/files
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/710
 - I2C Bugfixes: Do not keep iterator as member and fix some incorrect handling with the iterator.
   Also properly reset the reply size for successfull transfers and erroneous transfers.
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/700
@@ -35,9 +49,41 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - `TcpTmTcServer.cpp`: The server was actually not able to handle
   CCSDS packets which were clumped together. This has been fixed now.
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/673
+- `CServiceHealthCommanding`: Add announce all health info implementation
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/725
+- various fixes related to linux Unittests and memory leaks
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/715
+- small fix to allow teardown handling
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/713
+- fix compiler warning for fixed array list copy ctor
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/704
+- missing include
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/703
+- defaultconfig did not build anymore
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/702
+- hotfix
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/699
+- small fix for helper
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/698
+- missing retval conv
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/697
+- DHB Countdown Bug
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/693
+- doc corrections
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/687
+- better error printout
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/686
+- include correction
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/683
+- better warning for missing include paths
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/676
+- Service 11 regression
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/670
 
 ## Added
 
+- Empty constructor for `CdsShortTimeStamper` which does not do an object manager registration.
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/730
 - `Service9TimeManagement`: Add `DUMP_TIME` (129) subservice.
 - `TcpTmTcServer`: Allow setting the `SO_REUSEADDR` and `SO_REUSEPORT`
   option on the TCP server. CTOR prototype has changed and expects an explicit
@@ -49,13 +95,36 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/709
 - Add new `UnsignedByteField` class
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/660
+- publish documentation for development and master branch
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/681
+- Add Linux HAL options
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/663
+- Expand SerializeIF
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/656
+- PUS Service 11: Additional Safety Check
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/666
+- improvements for auto-formatter script
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/665
+- provide a weak print char impl
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/674
+
+## Removed
+
+- now that doc server is up, remove markdown files
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/688
+- remove bsp specific code
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/679
 
 ## Changes
 
+- `CService201HealthCommanding` renamed to `CServiceHealthCommanding`,
+  service ID customizable now. `CServiceHealthCommanding` expects configuration struct
+  `HealthServiceCfg` now
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/725
 - `AcceptsTelemetryIF`: `getReportReceptionQueue` is const now
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/712
 - Moved some container returnvalues to dedicated header and namespace
-  to they can be used without template specification.
+  so they can be used without template specification.
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/707
 - Remove default secondary header argument for
   `uint16_t getTcSpacePacketIdFromApid(uint16_t apid, bool secondaryHeaderFlag)` and
@@ -85,18 +154,41 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - `DeviceHandlerBase`: New signature of `handleDeviceTm` which expects
   a `const SerializeIF&` and additional helper variant which expects `const uint8_t*`
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/671
-- Move some generic `StorageManagerIF` implementations from `LocalPool` to
-  interface itself so it can be re-used more easily. Also add new
-  abstract function `bool hasDataAtId(store_address_t storeId) const`.
-  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/685
 - Improvements for `AcceptsTelemetryIF` and `AcceptsTelecommandsIF`:
   - Make functions `const` where it makes sense
   - Add `const char* getName const` abstract function
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/684
-- Move some generic `StorageManagerIF` implementations from `LocalPool` to
+- Generic TMTC Bridge Update
-  interface itself so it can be re-used more easily. Also add new
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/734
-  abstract function `bool hasDataAtId(store_address_t storeId) const`.
+- comment tweak to event parser can read everything
-  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/685
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/732
+- CMakeLists file updates
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/731
+- improve srv20 error messages
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/723
+- I2C Linux: remove duplicate printout
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/718
+- printout handling improvements
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/717
+- vec getter, reset for content
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/716
+- updates for source sequence counter
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/714
+- SP reader getPacketData is const now
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/708
+- refactoring of serial drivers for linux
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/705
+- Local Pool Update Remove Add Data Ignore Fault Argument
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/701
+- Switch to new documentation server
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/694
+- Windows Tweaks
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/691
+- Refactor Local Pool API
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/667
+- group MGM data in local pool vectors
+  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/664
+
 
 ## CFDP
 
@@ -116,7 +208,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
      implementation without an extra component
   PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/682
 
-# [v5.0.0] 25.07.2022
+# [v5.0.0] 2022-07-25
 
 ## Changes
 

CMakeLists.txt

@@ -13,7 +13,7 @@ list(APPEND CMAKE_MODULE_PATH
 # Version file handling  #
 # ##############################################################################
 
-set(FSFW_VERSION_IF_GIT_FAILS 5)
+set(FSFW_VERSION_IF_GIT_FAILS 6)
 set(FSFW_SUBVERSION_IF_GIT_FAILS 0)
 set(FSFW_REVISION_IF_GIT_FAILS 0)
 
@@ -64,13 +64,6 @@ elseif(${CMAKE_CXX_STANDARD} LESS 17)
       "${MSG_PREFIX} Compiling the FSFW requires a minimum of C++17 support")
 endif()
 
-if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
-  # Manually tweak MSVC to emit (about) the same warnings as clang and gcc on linux
-  # needs to be done here using add_compile_definitions() (as opposed to target_compile_definitions()) to be available for all binaries and libraries
-  add_compile_options("/permissive-" /wd4267 /wd4244 /wd4244 /wd4305 /wd4805 /wd4267 /wd4646 /wd4065 /wd4996 /Dand=&& /Dor=|| /Dnot=!)
-  add_compile_definitions(NOMINMAX)
-endif()
-
 set(FSFW_SOURCES_DIR "${CMAKE_SOURCE_DIR}/src/fsfw")
 
 set(FSFW_ETL_LIB_NAME etl)
@@ -165,7 +158,7 @@ if(FSFW_BUILD_TESTS)
   if(NOT Catch2_FOUND)
     message(
       STATUS
-        "${MSG_PREFIX} Catch2 installation not found. Downloading Catch2 library with FetchContent"
+        "${MSG_PREFIX} Catch2 installation not found. Downloading Catch2 library with FetchContent."
     )
     include(FetchContent)
 
@@ -181,27 +174,6 @@ if(FSFW_BUILD_TESTS)
   configure_file(unittests/testcfg/FSFWConfig.h.in FSFWConfig.h)
   configure_file(unittests/testcfg/TestsConfig.h.in tests/TestsConfig.h)
 
-  if(FSFW_OSAL MATCHES "freertos")
-    message(STATUS "${MSG_PREFIX} Downloading FreeRTOS with FetchContent")
-    include(FetchContent)
-
-    set(FreeRTOS_PORT posix)
-
-    FetchContent_Declare(
-      FreeRTOS
-      GIT_REPOSITORY https://egit.irs.uni-stuttgart.de/fsfw/FreeRTOS-LTS
-      GIT_TAG develop
-      GIT_SUBMODULES FreeRTOS/FreeRTOS-Kernel)
-
-    FetchContent_MakeAvailable(FreeRTOS)
-
-    set(LIB_OS_NAME FreeRTOS)
-    target_include_directories(FreeRTOS PUBLIC unittests/testcfg/freertos)
-    set(THREADS_PREFER_PTHREAD_FLAG ON)
-    find_package(Threads REQUIRED)
-    target_link_libraries(FreeRTOS PRIVATE ${CMAKE_THREAD_LIBS_INIT})
-  endif()
-
   project(${FSFW_TEST_TGT} CXX C)
   add_executable(${FSFW_TEST_TGT})
   if(IPO_SUPPORTED AND FSFW_ENABLE_IPO)
@@ -229,8 +201,8 @@ find_package(${FSFW_ETL_LIB_NAME} ${FSFW_ETL_LIB_MAJOR_VERSION} QUIET)
 if(NOT ${FSFW_ETL_LIB_NAME}_FOUND)
   message(
     STATUS
-      "${MSG_PREFIX} No ETL installation was found with find_package. Installing and providing "
+      "${MSG_PREFIX} ETL installation not found. Downloading ETL with FetchContent."
-      "etl with FindPackage")
+  )
   include(FetchContent)
 
   FetchContent_Declare(
@@ -254,7 +226,6 @@ if(FSFW_FETCH_CONTENT_TARGETS)
     # GitHub issue: https://github.com/catchorg/Catch2/issues/2417
     set_target_properties(Catch2 PROPERTIES DEBUG_POSTFIX "")
   endif()
-
 endif()
 
 set(FSFW_CORE_INC_PATH "inc")
@@ -389,9 +360,6 @@ if(FSFW_BUILD_TESTS)
   endif()
   target_link_libraries(${FSFW_TEST_TGT} PRIVATE Catch2::Catch2
                                                  ${LIB_FSFW_NAME})
-  if(FSFW_OSAL MATCHES "freertos")
-    target_link_libraries(${FSFW_TEST_TGT} PRIVATE FreeRTOS)
-  endif()
 endif()
 
 # The project CMakeLists file has to set the FSFW_CONFIG_PATH and add it. If
@@ -479,47 +447,8 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
 
 endif()
 
-if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
-  set(FSFW_WARNING_FLAGS 
+  set(COMPILER_FLAGS "/permissive-")
-  -Weverything 
-
-  -Wno-gnu-anonymous-struct 
-  -Wno-c++98-compat
-  -Wno-c++98-compat-pedantic
-  -Wno-covered-switch-default
-  -Wno-padded 
-  -Wno-documentation
-  -Wno-weak-vtables
-  -Wno-c++98-c++11-compat-binary-literal
-  -Wno-documentation-unknown-command
-  -Wno-reserved-macro-identifier
-  -Wno-global-constructors
-  -Wno-reserved-identifier
-  -Wno-switch-enum
-
-  -Werror
-  #WTH?
-  -Wno-ctad-maybe-unsupported
-  #WIP
-  -Wno-undefined-func-template
-  -Wno-suggest-destructor-override
-  -Wno-suggest-override
-  -Wno-inconsistent-missing-destructor-override
-  -Wno-extra-semi
-  #could be useful:
-  -Wno-sign-conversion
-  -Wno-implicit-int-conversion
-  -Wno-shorten-64-to-32
-  -Wno-double-promotion
-  -Wno-float-conversion
-  -Wno-implicit-int-float-conversion
-  -Wno-implicit-float-conversion
-  -Wno-shadow-field-in-constructor
-  -Wno-shadow-field
-  -Wno-shadow
-  -Wno-unused-parameter
-
-  )
 endif()
 
 # Required include paths to compile the FSFW

automation/Dockerfile

@@ -5,7 +5,7 @@ RUN apt-get --yes upgrade
 
 #tzdata is a dependency, won't install otherwise
 ARG DEBIAN_FRONTEND=noninteractive
-RUN apt-get --yes install ca-certificates clang cmake doxygen g++ gcc git graphviz iputils-ping lcov make msitools nano ninja-build pip python3 python3-simplejson python3-six qemu-system-arm rsync valgrind wget winbind
+RUN apt-get --yes install gcc g++ cmake make lcov git valgrind nano iputils-ping python3 pip doxygen graphviz rsync
 
 RUN python3 -m pip install sphinx breathe
 
@@ -21,36 +21,8 @@ RUN git clone https://github.com/ETLCPP/etl.git && \
         cmake -B build . && \
         cmake --install build/
 
-        
-# install our own rtems build
-RUN wget -qO- https://buggy.irs.uni-stuttgart.de/rtems_releases/rtems6-12.2.1.tar.bz2 | tar -xj -C /opt/
-ENV PATH="$PATH:/opt/rtems/6/bin"
-
-# install modern wine for MSVC, removing a conflicting file
-RUN dpkg --add-architecture i386 && \
-    mkdir -pm755 /etc/apt/keyrings && \
-    wget -O /etc/apt/keyrings/winehq-archive.key https://dl.winehq.org/wine-builds/winehq.key && \
-    wget -NP /etc/apt/sources.list.d/ https://dl.winehq.org/wine-builds/ubuntu/dists/focal/winehq-focal.sources && \
-    apt-get update && \
-    apt-get --yes install winehq-stable
-# silence wine
-ENV WINEDEBUG=-all 
-
-
-# install MSVC using https://github.com/mstorsjo/msvc-wine
-# see msvc-wine/LICENSE.txt
-COPY msvc-wine/lowercase msvc-wine/fixinclude msvc-wine/install.sh msvc-wine/vsdownload.py ./
-COPY msvc-wine/wrappers/* ./wrappers/
-RUN PYTHONUNBUFFERED=1 ./vsdownload.py --accept-license --dest /opt/msvc && \
-    ./install.sh /opt/msvc && \
-    rm lowercase fixinclude install.sh vsdownload.py && \
-    rm -rf wrappers
-RUN wine64 wineboot --init && \
-    while pgrep wineserver > /dev/null; do sleep 1; done
-
-
 #ssh needs a valid user to work
-RUN addgroup -q --gid 117 jenkins && adduser -q --uid 114 --gid 117 jenkins
+RUN adduser --uid 114 jenkins
 
 #add documentation server to known hosts
 RUN echo "|1|/LzCV4BuTmTb2wKnD146l9fTKgQ=|NJJtVjvWbtRt8OYqFgcYRnMQyVw= ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBNL8ssTonYtgiR/6RRlSIK9WU1ywOcJmxFTLcEblAwH7oifZzmYq3XRfwXrgfMpylEfMFYfCU8JRqtmi19xc21A=" >> /etc/ssh/ssh_known_hosts

automation/Jenkinsfile

@@ -2,73 +2,87 @@ pipeline {
     environment {
         BUILDDIR_HOST = 'cmake-build-tests-host'
         BUILDDIR_LINUX = 'cmake-build-tests-linux'
-        BUILDDIR_FREERTOS = 'cmake-build-tests-freertos'
-        BUILDDIR_RTEMS = 'cmake-build-tests-rtems'
-        BUILDDIR_WIN = 'cmake-build-tests-windows'
         DOCDDIR = 'cmake-build-documentation'
     }
     agent {
         docker { 
-            image 'fsfw-ci:d9'
+            image 'fsfw-ci:d6'
             args '--network host --sysctl fs.mqueue.msg_max=100'
         }
     }
     stages {
-        stage('Host-clang') {
+        stage('Host') {
+            stages{
+                stage('Clean') {
                     steps {
                         sh 'rm -rf $BUILDDIR_HOST'
-
+                    }
+                }
+                stage('Configure') {
+                    steps {
+                        dir(BUILDDIR_HOST) {
+                            sh 'cmake -DFSFW_OSAL=host -DFSFW_BUILD_TESTS=ON -DFSFW_CICD_BUILD=ON ..'
+                        }
+                    }
+                }
+                stage('Build') {
+                    steps {
                         dir(BUILDDIR_HOST) {
-                    sh 'CC=clang CXX=clang++ cmake -DFSFW_OSAL=host -DFSFW_BUILD_TESTS=ON -DFSFW_CICD_BUILD=ON ..'
                             sh 'cmake --build . -j4'
+                        }
+                    }
+                }
+                stage('Unittests') {
+                    steps {
+                        dir(BUILDDIR_HOST) {
+                            sh 'cmake --build . -- fsfw-tests_coverage -j4'
+                        }
+                    }
+                }
+                stage('Valgrind') {
+                    steps {
+                        dir(BUILDDIR_HOST) {
                             sh 'valgrind --leak-check=full --error-exitcode=1 ./fsfw-tests'
                         }
                     }
                 }
-        stage('Linux-gcc') {
+            }
+        }
+        stage('Linux') {
+            stages{
+                stage('Clean') {
                     steps {
                         sh 'rm -rf $BUILDDIR_LINUX'
-
+                    }
+                }
+                stage('Configure') {
+                    steps {
                         dir(BUILDDIR_LINUX) {
                             sh 'cmake -DFSFW_OSAL=linux -DFSFW_BUILD_TESTS=ON -DFSFW_CICD_BUILD=ON ..'
+                        }
+                    }
+                }
+                stage('Build') {
+                    steps {
+                        dir(BUILDDIR_LINUX) {
                             sh 'cmake --build . -j4'
+                        }
+                    }
+                }
+                stage('Unittests') {
+                    steps {
+                        dir(BUILDDIR_LINUX) {
                             sh 'cmake --build . -- fsfw-tests_coverage -j4'
+                        }
+                    }
+                }
+                stage('Valgrind') {
+                    steps {
+                        dir(BUILDDIR_LINUX) {
                             sh 'valgrind --leak-check=full --error-exitcode=1 ./fsfw-tests'
                         }
                     }
                 }
-        stage('FreeRTOS-gcc') {
-            steps {
-                sh 'rm -rf $BUILDDIR_FREERTOS'
-
-                dir(BUILDDIR_FREERTOS) {
-                    sh 'cmake -DFSFW_OSAL=freertos -DFSFW_BUILD_TESTS=ON -DFSFW_CICD_BUILD=ON ..'
-                    sh 'cmake --build . -j4'
-                    sh './fsfw-tests'
-                    //sh 'valgrind --leak-check=full --error-exitcode=1 ./fsfw-tests'
-                }
-            }
-        }
-        stage('rtems-gcc') {
-            steps {
-                sh 'rm -rf $BUILDDIR_RTEMS'
-
-                dir(BUILDDIR_RTEMS) {
-                    sh 'cmake -DFSFW_OSAL=rtems -DFSFW_BUILD_TESTS=ON -DFSFW_TESTS_GEN_COV=OFF -DFSFW_CICD_BUILD=ON -DCMAKE_TOOLCHAIN_FILE=../unittests/testcfg/rtems/cmake/aarch64-rtems6-toolchain.cmake ..'
-                    sh 'cmake --build . -j4'
-                    sh 'qemu-system-aarch64 -no-reboot -nographic -serial mon:stdio -semihosting -machine virt,gic-version=3 -cpu cortex-a72 -m 4000  -kernel fsfw-tests'
-                }
-            }
-        }
-        stage('Host-msvc') {
-            steps {
-                sh 'rm -rf $BUILDDIR_WIN'
-
-                dir(BUILDDIR_WIN) {
-                    sh 'cmake -DFSFW_OSAL=host -DFSFW_BUILD_TESTS=ON -DFSFW_TESTS_GEN_COV=OFF -DFSFW_CICD_BUILD=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE=../unittests/testcfg/windows/cmake/x64-windows-toolchain.cmake -GNinja ..'
-                    sh 'cmake --build . -j4'
-                    sh 'wine64 fsfw-tests.exe'
-                }
             }
         }
         stage('Documentation') {
@@ -83,7 +97,7 @@ pipeline {
                         sh 'rsync -r --delete docs/sphinx/* buildfix@documentation.irs.uni-stuttgart.de:/fsfw/development'
                     }
                 }
-                dir(BUILDDIR_LINUX) {
+                dir(BUILDDIR) {
                     sshagent(credentials: ['documentation-buildfix']) {
                         sh 'rsync -r --delete fsfw-tests_coverage/* buildfix@documentation.irs.uni-stuttgart.de:/fsfw/coverage/development'
                     }
@@ -102,7 +116,7 @@ pipeline {
                         sh 'rsync -r --delete docs/sphinx/* buildfix@documentation.irs.uni-stuttgart.de:/fsfw/master'
                     }
                 }
-                dir(BUILDDIR_LINUX) {
+                dir(BUILDDIR) {
                     sshagent(credentials: ['documentation-buildfix']) {
                         sh 'rsync -r --delete fsfw-tests_coverage/* buildfix@documentation.irs.uni-stuttgart.de:/fsfw/coverage/master'
                     }

scripts/check_release.py

@@ -0,0 +1,110 @@
+#! /bin/python
+
+
+import argparse
+import json
+import urllib.request
+import re
+from pathlib import Path
+
+def main() -> None:
+    parser = argparse.ArgumentParser(
+        description="List undocumented PRs"
+    )
+    parser.add_argument("-v", "--version", type=str, required=True)
+    args = parser.parse_args()
+    
+    match = re.search("([0-9]+\.[0-9]+\.[0-9]+)", args.version)
+    
+    if not match:
+        print("invalid version")
+        exit(1)
+    
+    version = "v" + match.group(1)
+    
+    print("looking for milestone for " + version + " ...")
+    
+    
+    with urllib.request.urlopen("https://egit.irs.uni-stuttgart.de/api/v1/repos/fsfw/fsfw/milestones?name=" + version) as milestone_json:
+        milestones = json.load(milestone_json)
+        if (len(milestones) == 0):
+            print("did not find any milestone")
+            exit(1)
+        if (len(milestones) > 1):
+            print("found multiple milestons")
+        milestone_title = milestones[0]['title']
+        milestone = str(milestones[0]['id'])
+        print("Using Milestone \""+ milestone_title + "\" with id " + milestone)
+    
+    milestone_prs = []
+    
+    page = 1
+    last_count = 1;
+    while last_count != 0:
+        with urllib.request.urlopen("https://egit.irs.uni-stuttgart.de/api/v1/repos/fsfw/fsfw/pulls?state=closed&milestone=" + str(milestone) + "&limit=100&page=" + str(page)) as pull_requests_json:
+            pull_requests = json.load(pull_requests_json)
+            for pr in pull_requests:
+                milestone_prs.append({'number': str(pr['number']), 'title' : pr['title']})
+            page += 1
+            last_count = len(pull_requests)
+    
+    print("Found " + str(len(milestone_prs)) + " closed PRs in Milestone")
+    
+    print("looking for CHANGELOG.md ...")
+    
+    path = Path(".")
+    
+    files = list(path.glob("CHANGELOG.md"))
+    
+    if (len(files) != 1):
+        files = list(path.glob("../CHANGELOG.md"))
+        
+    if (len(files) != 1):
+        print("did not find CHANGELOG.md. Run script in either root directory or scripts subfolder.")
+        exit(1)
+        
+    print("Scanning CHANGELOG.md ...")
+    
+    changelog_prs = []
+    
+    with open(files[0]) as changelog:
+        line = changelog.readline()
+        while (line):
+            #print("line: " + line)
+            match = re.search("\#.+(v[0-9]+\.[0-9]+\.[0-9]+)", line)
+            if (match):
+                if match.group(1) == version:
+                    #print("found version")
+                    line = changelog.readline()
+                    continue
+                else:
+                    #print("done with " + match.group(1))
+                    break
+            
+            match = re.search("PR: https://egit\.irs\.uni-stuttgart\.de/fsfw/fsfw/pulls/([0-9]+)", line)
+            if match:
+                changelog_prs.append(match.group(1))
+                
+            line = changelog.readline()
+    
+    print("Found " + str(len(changelog_prs)) + " PRs in CHANGELOG.md")
+    
+    print("")
+    
+    copy_array = changelog_prs.copy()
+    print("PRs in CHANGELOG.md that are not in Milestone:")
+    for pr in milestone_prs:
+        if pr['number'] in copy_array:
+            copy_array.remove(pr['number'])
+    for pr in copy_array:
+        print("https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/" + pr)
+
+    print("")
+
+    print("PRs in milestone that are not in CHANGELOG.md:")
+    
+    for pr in milestone_prs:
+        if pr['number'] not in changelog_prs:
+            print("- " + pr['title'] + "\n  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/" + pr['number'])
+
+main()

src/fsfw/cfdp/FileSize.h

@@ -21,7 +21,7 @@ struct FileSize : public SerializeIF {
     this->largeFile = isLarge;
     return serialize(buffer, size, maxSize, streamEndianness);
   }
-  using SerializeIF::serialize;
+
   ReturnValue_t serialize(uint8_t **buffer, size_t *size, size_t maxSize,
                           Endianness streamEndianness) const override {
     if (not largeFile) {

src/fsfw/cfdp/VarLenFields.cpp

@@ -3,7 +3,7 @@
 #include "fsfw/serialize/SerializeAdapter.h"
 #include "fsfw/serviceinterface.h"
 
-cfdp::VarLenField::VarLenField(cfdp::WidthInBytes width, uint64_t value) : VarLenField() {
+cfdp::VarLenField::VarLenField(cfdp::WidthInBytes width, size_t value) : VarLenField() {
   ReturnValue_t result = this->setValue(width, value);
   if (result != returnvalue::OK) {
 #if FSFW_DISABLE_PRINTOUT == 0
@@ -20,7 +20,7 @@ cfdp::VarLenField::VarLenField() : width(cfdp::WidthInBytes::ONE_BYTE) { value.o
 
 cfdp::WidthInBytes cfdp::VarLenField::getWidth() const { return width; }
 
-ReturnValue_t cfdp::VarLenField::setValue(cfdp::WidthInBytes widthInBytes, uint64_t value_) {
+ReturnValue_t cfdp::VarLenField::setValue(cfdp::WidthInBytes widthInBytes, size_t value_) {
   switch (widthInBytes) {
     case (cfdp::WidthInBytes::ONE_BYTE): {
       if (value_ > UINT8_MAX) {
@@ -51,7 +51,7 @@ ReturnValue_t cfdp::VarLenField::setValue(cfdp::WidthInBytes widthInBytes, uint6
   return returnvalue::OK;
 }
 
-uint64_t cfdp::VarLenField::getValue() const {
+size_t cfdp::VarLenField::getValue() const {
   switch (width) {
     case (cfdp::WidthInBytes::ONE_BYTE): {
       return value.oneByte;

src/fsfw/cfdp/VarLenFields.h

@@ -25,13 +25,13 @@ class VarLenField : public SerializeIF {
   template <typename T>
   explicit VarLenField(UnsignedByteField<T> byteField);
 
-  VarLenField(cfdp::WidthInBytes width, uint64_t value);
+  VarLenField(cfdp::WidthInBytes width, size_t value);
 
   bool operator==(const VarLenField &other) const;
   bool operator!=(const VarLenField &other) const;
   bool operator<(const VarLenField &other) const;
 
-  ReturnValue_t setValue(cfdp::WidthInBytes, uint64_t value);
+  ReturnValue_t setValue(cfdp::WidthInBytes, size_t value);
 
   ReturnValue_t serialize(uint8_t **buffer, size_t *size, size_t maxSize,
                           Endianness streamEndianness) const override;
@@ -42,7 +42,7 @@ class VarLenField : public SerializeIF {
                             Endianness streamEndianness);
 
   [[nodiscard]] cfdp::WidthInBytes getWidth() const;
-  [[nodiscard]] uint64_t getValue() const;
+  [[nodiscard]] size_t getValue() const;
 
 #if FSFW_CPP_OSTREAM_ENABLED == 1
   friend std::ostream &operator<<(std::ostream &os, const VarLenField &id) {
@@ -53,7 +53,6 @@ class VarLenField : public SerializeIF {
 #endif
 
  private:
-  using SerializeIF::deSerialize;
   ReturnValue_t deSerialize(const uint8_t **buffer, size_t *size,
                             Endianness streamEndianness) override;
 

src/fsfw/cfdp/definitions.h

@@ -9,11 +9,6 @@
 #include "fsfw/returnvalues/FwClassIds.h"
 #include "fsfw/returnvalues/returnvalue.h"
 
-// Thanks, windows
-#ifdef NO_ERROR
-#undef NO_ERROR
-#endif
-
 namespace cfdp {
 
 static constexpr char CFDP_VERSION_2_NAME[] = "CCSDS 727.0-B-5";

src/fsfw/cfdp/handler/UserBase.h

@@ -68,7 +68,6 @@ class UserBase {
 
  public:
   explicit UserBase(HasFileSystemIF& vfs);
-  virtual ~UserBase() = default;
 
   virtual void transactionIndication(const TransactionId& id) = 0;
   virtual void eofSentIndication(const TransactionId& id) = 0;

src/fsfw/cfdp/helpers.cpp

@@ -1,6 +1,6 @@
 #include "helpers.h"
 
-static const char* COND_CODE_STRINGS[14] = {"Unknown",
+const char* COND_CODE_STRINGS[14] = {"Unknown",
                                      "No Error",
                                      "Positive ACK Limit Reached",
                                      "Keep Alive Limit Reached",

src/fsfw/cfdp/pdu/EofInfo.cpp

@@ -42,6 +42,6 @@ size_t EofInfo::getSerializedSize(bool fssLarge) {
   return size;
 }
 
-ReturnValue_t EofInfo::setFileSize(uint64_t fileSize, bool isLarge) {
+ReturnValue_t EofInfo::setFileSize(size_t fileSize, bool isLarge) {
   return this->fileSize.setFileSize(fileSize, isLarge);
 }

src/fsfw/cfdp/pdu/EofInfo.h

@@ -21,7 +21,7 @@ struct EofInfo {
   void setChecksum(uint32_t checksum);
   void setConditionCode(cfdp::ConditionCode conditionCode);
   void setFaultLoc(EntityIdTlv* faultLoc);
-  ReturnValue_t setFileSize(uint64_t size, bool isLarge);
+  ReturnValue_t setFileSize(size_t size, bool isLarge);
 
  private:
   cfdp::ConditionCode conditionCode;

src/fsfw/cfdp/pdu/FinishedPduReader.cpp

@@ -1,10 +1,5 @@
 #include "FinishedPduReader.h"
 
-// Thanks, windows
-#ifdef NO_ERROR
-#undef NO_ERROR
-#endif
-
 FinishPduReader::FinishPduReader(const uint8_t* pduBuf, size_t maxSize, FinishedInfo& info)
     : FileDirectiveReader(pduBuf, maxSize), finishedInfo(info) {}
 

src/fsfw/cfdp/tlv/EntityIdTlv.h

@@ -23,7 +23,6 @@ class EntityIdTlv : public TlvIF {
    */
   ReturnValue_t deSerialize(cfdp::Tlv& tlv, Endianness endianness);
 
-  using SerializeIF::deSerialize;
   ReturnValue_t deSerialize(const uint8_t** buffer, size_t* size,
                             Endianness streamEndianness) override;
 

src/fsfw/cfdp/tlv/FilestoreRequestTlv.h

@@ -26,7 +26,6 @@ class FilestoreRequestTlv : public cfdp::FilestoreTlvBase {
    */
   ReturnValue_t deSerialize(cfdp::Tlv &tlv, Endianness endianness);
 
-  using SerializeIF::deSerialize;
   ReturnValue_t deSerialize(const uint8_t **buffer, size_t *size,
                             Endianness streamEndianness) override;
 

src/fsfw/cfdp/tlv/FilestoreResponseTlv.h

@@ -29,7 +29,6 @@ class FilestoreResponseTlv : public cfdp::FilestoreTlvBase {
    */
   ReturnValue_t deSerialize(const cfdp::Tlv& tlv, Endianness endianness);
 
-  using SerializeIF::deSerialize;
   ReturnValue_t deSerialize(const uint8_t** buffer, size_t* size,
                             Endianness streamEndianness) override;
 

src/fsfw/container/BinaryTree.h

@@ -8,7 +8,7 @@
 template <typename Tp>
 class BinaryNode {
  public:
-  BinaryNode(Tp* setValue) : value(setValue), left(nullptr), right(nullptr), parent(nullptr) {}
+  BinaryNode(Tp* setValue) : value(setValue), left(NULL), right(NULL), parent(NULL) {}
   Tp* value;
   BinaryNode* left;
   BinaryNode* right;
@@ -23,31 +23,31 @@ class ExplicitNodeIterator {
   typedef Tp value_type;
   typedef Tp* pointer;
   typedef Tp& reference;
-  ExplicitNodeIterator() : element(nullptr) {}
+  ExplicitNodeIterator() : element(NULL) {}
   ExplicitNodeIterator(_Node* node) : element(node) {}
   BinaryNode<Tp>* element;
   _Self up() { return _Self(element->parent); }
   _Self left() {
-    if (element != nullptr) {
+    if (element != NULL) {
       return _Self(element->left);
     } else {
-      return _Self(nullptr);
+      return _Self(NULL);
     }
   }
   _Self right() {
-    if (element != nullptr) {
+    if (element != NULL) {
       return _Self(element->right);
     } else {
-      return _Self(nullptr);
+      return _Self(NULL);
     }
   }
   bool operator==(const _Self& __x) const { return element == __x.element; }
   bool operator!=(const _Self& __x) const { return element != __x.element; }
   pointer operator->() const {
-    if (element != nullptr) {
+    if (element != NULL) {
       return element->value;
     } else {
-      return nullptr;
+      return NULL;
     }
   }
   pointer operator*() const { return this->operator->(); }
@@ -62,13 +62,13 @@ class BinaryTree {
   typedef ExplicitNodeIterator<Tp> iterator;
   typedef BinaryNode<Tp> Node;
   typedef std::pair<iterator, iterator> children;
-  BinaryTree() : rootNode(nullptr) {}
+  BinaryTree() : rootNode(NULL) {}
   BinaryTree(Node* rootNode) : rootNode(rootNode) {}
   iterator begin() const { return iterator(rootNode); }
-  static iterator end() { return iterator(nullptr); }
+  static iterator end() { return iterator(NULL); }
   iterator insert(bool insertLeft, iterator parentNode, Node* newNode) {
     newNode->parent = parentNode.element;
-    if (parentNode.element != nullptr) {
+    if (parentNode.element != NULL) {
       if (insertLeft) {
         parentNode.element->left = newNode;
       } else {
@@ -84,13 +84,13 @@ class BinaryTree {
   children erase(iterator node) {
     if (node.element == rootNode) {
       // We're root node
-      rootNode = nullptr;
+      rootNode = NULL;
     } else {
       // Delete parent's reference
       if (node.up().left() == node) {
-        node.up().element->left = nullptr;
+        node.up().element->left = NULL;
       } else {
-        node.up().element->right = nullptr;
+        node.up().element->right = NULL;
       }
     }
     return children(node.element->left, node.element->right);

src/fsfw/container/PlacementFactory.h

@@ -61,7 +61,7 @@ class PlacementFactory {
     // Need to call destructor first, in case something was allocated by the object (shouldn't do
     // that, however).
     thisElement->~T();
-    uint8_t* pointer = static_cast<uint8_t*>(thisElement);
+    uint8_t* pointer = (uint8_t*)(thisElement);
     return dataBackend->deleteData(pointer, sizeof(T));
   }
 

src/fsfw/datapoollocal/LocalDataPoolManager.cpp

@@ -286,6 +286,7 @@ ReturnValue_t LocalDataPoolManager::addUpdateToStore(HousekeepingSnapshot& updat
   result = updatePacket.serialize(&storePtr, &serializedSize, updatePacketSize,
                                   SerializeIF::Endianness::MACHINE);
   return result;
+  ;
 }
 
 void LocalDataPoolManager::handleChangeResetLogic(DataType type, DataId dataId,

src/fsfw/datapoollocal/LocalDataPoolManager.h

@@ -364,10 +364,6 @@ class LocalDataPoolManager : public ProvidesDataPoolSubscriptionIF, public Acces
   void printWarningOrError(sif::OutputTypes outputType, const char* functionName,
                            ReturnValue_t errorCode = returnvalue::FAILED,
                            const char* errorPrint = nullptr);
-
- private:
-  using ProvidesDataPoolSubscriptionIF::subscribeForPeriodicPacket;
-  using ProvidesDataPoolSubscriptionIF::subscribeForUpdatePacket;
 };
 
 template <class T>

src/fsfw/devicehandlers/ChildHandlerBase.cpp

@@ -27,7 +27,7 @@ ReturnValue_t ChildHandlerBase::initialize() {
 
   if (parentId != objects::NO_OBJECT) {
     SubsystemBase* parent = ObjectManager::instance()->get<SubsystemBase>(parentId);
-    if (parent == nullptr) {
+    if (parent == NULL) {
       return returnvalue::FAILED;
     }
     parentQueue = parent->getCommandQueue();

src/fsfw/devicehandlers/DeviceHandlerBase.cpp

@@ -322,7 +322,8 @@ void DeviceHandlerBase::doStateMachine() {
       if (mode != currentMode) {
         break;
       }
-      uint32_t currentUptime = Clock::getUptime_ms();
+      uint32_t currentUptime;
+      Clock::getUptime(&currentUptime);
       if (currentUptime - timeoutStart >= childTransitionDelay) {
 #if FSFW_VERBOSE_LEVEL >= 1 && FSFW_OBJ_EVENT_TRANSLATION == 0
         char printout[60];
@@ -346,7 +347,8 @@ void DeviceHandlerBase::doStateMachine() {
       setMode(_MODE_WAIT_ON);
       break;
     case _MODE_WAIT_ON: {
-      uint32_t currentUptime = Clock::getUptime_ms();
+      uint32_t currentUptime;
+      Clock::getUptime(&currentUptime);
       if (powerSwitcher != nullptr and
           currentUptime - timeoutStart >= powerSwitcher->getSwitchDelayMs()) {
         triggerEvent(MODE_TRANSITION_FAILED, PowerSwitchIF::SWITCH_TIMEOUT, 0);
@@ -365,7 +367,8 @@ void DeviceHandlerBase::doStateMachine() {
       }
     } break;
     case _MODE_WAIT_OFF: {
-      uint32_t currentUptime = Clock::getUptime_ms();
+      uint32_t currentUptime;
+      Clock::getUptime(&currentUptime);
 
       if (powerSwitcher == nullptr) {
         setMode(MODE_OFF);
@@ -575,7 +578,7 @@ void DeviceHandlerBase::setMode(Mode_t newMode, uint8_t newSubmode) {
     modeHelper.modeChanged(newMode, newSubmode);
     announceMode(false);
   }
-  timeoutStart = Clock::getUptime_ms();
+  Clock::getUptime(&timeoutStart);
 
   if (mode == MODE_OFF and thermalSet != nullptr) {
     ReturnValue_t result = thermalSet->read();
@@ -934,14 +937,19 @@ DeviceHandlerIF::CommunicationAction DeviceHandlerBase::getComAction() {
   switch (pstStep) {
     case 0:
       return CommunicationAction::PERFORM_OPERATION;
+      break;
     case 1:
       return CommunicationAction::SEND_WRITE;
+      break;
     case 2:
       return CommunicationAction::GET_WRITE;
+      break;
     case 3:
       return CommunicationAction::SEND_READ;
+      break;
     case 4:
       return CommunicationAction::GET_READ;
+      break;
     default:
       break;
   }
@@ -957,7 +965,7 @@ void DeviceHandlerBase::buildRawDeviceCommand(CommandMessage* commandMessage) {
     replyReturnvalueToCommand(result, RAW_COMMAND_ID);
     storedRawData.raw = StorageManagerIF::INVALID_ADDRESS;
   } else {
-    cookieInfo.pendingCommand = deviceCommandMap.find(static_cast<DeviceCommandId_t>(RAW_COMMAND_ID));
+    cookieInfo.pendingCommand = deviceCommandMap.find((DeviceCommandId_t)RAW_COMMAND_ID);
     cookieInfo.pendingCommand->second.isExecuting = true;
     cookieInfo.state = COOKIE_WRITE_READY;
   }

src/fsfw/devicehandlers/DeviceHandlerBase.h

@@ -206,9 +206,9 @@ class DeviceHandlerBase : public DeviceHandlerIF,
 
   Mode_t getTransitionSourceMode() const;
   Submode_t getTransitionSourceSubMode() const;
-  virtual void getMode(Mode_t *mode, Submode_t *submode) override;
+  virtual void getMode(Mode_t *mode, Submode_t *submode);
-  HealthState getHealth() override;
+  HealthState getHealth();
-  ReturnValue_t setHealth(HealthState health) override;
+  ReturnValue_t setHealth(HealthState health);
   virtual ReturnValue_t getParameter(uint8_t domainId, uint8_t uniqueId,
                                      ParameterWrapper *parameterWrapper,
                                      const ParameterWrapper *newValues,
@@ -1073,7 +1073,7 @@ class DeviceHandlerBase : public DeviceHandlerIF,
                       bool forceDirectTm = false);
 
   virtual ReturnValue_t checkModeCommand(Mode_t mode, Submode_t submode,
-                                         uint32_t *msToReachTheMode) override;
+                                         uint32_t *msToReachTheMode);
 
   virtual ReturnValue_t letChildHandleMessage(CommandMessage *message);
 

src/fsfw/devicehandlers/DeviceHandlerMessage.cpp

@@ -72,7 +72,7 @@ void DeviceHandlerMessage::clear(CommandMessage* message) {
         ipcStore->deleteData(getStoreAddress(message));
       }
     }
-      [[fallthrough]];
+      /* NO BREAK falls through*/
     case CMD_SWITCH_ADDRESS:
     case CMD_WIRETAPPING:
       message->setCommand(CommandMessage::CMD_NONE);

src/fsfw/events/EventManager.h

@@ -28,23 +28,22 @@ class EventManager : public EventManagerIF, public ExecutableObjectIF, public Sy
 
   void setMutexTimeout(MutexIF::TimeoutType timeoutType, uint32_t timeoutMs);
 
-  MessageQueueId_t getEventReportQueue() override;
+  MessageQueueId_t getEventReportQueue();
 
-  ReturnValue_t registerListener(MessageQueueId_t listener,
+  ReturnValue_t registerListener(MessageQueueId_t listener, bool forwardAllButSelected = false);
-                                 bool forwardAllButSelected = false) override;
   ReturnValue_t unregisterListener(MessageQueueId_t listener) override;
-  ReturnValue_t subscribeToEvent(MessageQueueId_t listener, EventId_t event) override;
+  ReturnValue_t subscribeToEvent(MessageQueueId_t listener, EventId_t event);
-  ReturnValue_t subscribeToAllEventsFrom(MessageQueueId_t listener, object_id_t object) override;
+  ReturnValue_t subscribeToAllEventsFrom(MessageQueueId_t listener, object_id_t object);
   ReturnValue_t subscribeToEventRange(MessageQueueId_t listener, EventId_t idFrom = 0,
                                       EventId_t idTo = 0, bool idInverted = false,
                                       object_id_t reporterFrom = 0, object_id_t reporterTo = 0,
-                                      bool reporterInverted = false) override;
+                                      bool reporterInverted = false);
-  ReturnValue_t unsubscribeFromAllEvents(MessageQueueId_t listener, object_id_t object) override;
+  ReturnValue_t unsubscribeFromAllEvents(MessageQueueId_t listener, object_id_t object);
   ReturnValue_t unsubscribeFromEventRange(MessageQueueId_t listener, EventId_t idFrom = 0,
                                           EventId_t idTo = 0, bool idInverted = false,
                                           object_id_t reporterFrom = 0, object_id_t reporterTo = 0,
-                                          bool reporterInverted = false) override;
+                                          bool reporterInverted = false);
-  ReturnValue_t performOperation(uint8_t opCode) override;
+  ReturnValue_t performOperation(uint8_t opCode);
 
  protected:
   MessageQueueIF* eventReportQueue = nullptr;

src/fsfw/globalfunctions/DleParser.cpp

@@ -52,7 +52,6 @@ ReturnValue_t DleParser::parseRingBuf(size_t& readSize) {
         // without skipping the STX
         readSize = vectorIdx;
         ErrorInfo info;
-        info.len = vectorIdx;
         setErrorContext(ErrorTypes::CONSECUTIVE_STX_CHARS, info);
         return POSSIBLE_PACKET_LOSS;
       }

src/fsfw/globalfunctions/Type.h

@@ -58,7 +58,7 @@ class Type : public SerializeIF {
 
 template <typename T>
 struct PodTypeConversion {
-  static_assert(!std::is_same<T, bool>::value,
+  static_assert(not std::is_same<T, bool>::value,
                 "Do not use boolean for the PoolEntry type, use uint8_t "
                 "instead! The ECSS standard defines a boolean as a one bit "
                 "field. Therefore it is preferred to store a boolean as an "

src/fsfw/globalfunctions/arrayprinter.cpp

@@ -37,16 +37,16 @@ void arrayprinter::print(const uint8_t *data, size_t size, OutputType type, bool
   }
 }
 
-void arrayprinter::printHex(const uint8_t *data, size_t datasize, size_t maxCharPerLine) {
+void arrayprinter::printHex(const uint8_t *data, size_t size, size_t maxCharPerLine) {
 #if FSFW_CPP_OSTREAM_ENABLED == 1
   if (sif::info.crAdditionEnabled()) {
     std::cout << "\r" << std::endl;
   }
 
   std::cout << "hex [" << std::setfill('0') << std::hex;
-  for (size_t i = 0; i < datasize; i++) {
+  for (size_t i = 0; i < size; i++) {
     std::cout << std::setw(2) << static_cast<int>(data[i]);
-    if (i < datasize - 1) {
+    if (i < size - 1) {
       std::cout << ",";
       if (i > 0 and (i + 1) % maxCharPerLine == 0) {
         std::cout << std::endl;
@@ -56,11 +56,27 @@ void arrayprinter::printHex(const uint8_t *data, size_t datasize, size_t maxChar
   std::cout << std::dec << std::setfill(' ');
   std::cout << "]" << std::endl;
 #else
-  printf("hex [");
+  // General format: 0x01, 0x02, 0x03 so it is number of chars times 6
-  for (size_t i = 0; i < datasize; i++) {
+  // plus line break plus small safety margin.
-    printf("0x%02x ", data[i]);
+  char printBuffer[(size + 1) * 7 + 1] = {};
+  size_t currentPos = 0;
+  for (size_t i = 0; i < size; i++) {
+    // To avoid buffer overflows.
+    if (sizeof(printBuffer) - currentPos <= 7) {
+      break;
     }
-  printf("]\n");
+
+    currentPos += snprintf(printBuffer + currentPos, 6, "%02x", data[i]);
+    if (i < size - 1) {
+      currentPos += sprintf(printBuffer + currentPos, ",");
+      if ((i + 1) % maxCharPerLine == 0) {
+        currentPos += sprintf(printBuffer + currentPos, "\n");
+      }
+    }
+  }
+#if FSFW_DISABLE_PRINTOUT == 0
+  printf("hex [%s]\n", printBuffer);
+#endif /* FSFW_DISABLE_PRINTOUT == 0 */
 #endif
 }
 
@@ -84,10 +100,26 @@ void arrayprinter::printDec(const uint8_t *data, size_t size, size_t maxCharPerL
 #else
   // General format: 32,243,-12 so it is number of chars times 4
   // plus line break plus small safety margin.
-
+  uint16_t expectedLines = ceil((double)size / maxCharPerLine);
+  char printBuffer[size * 4 + 1 + expectedLines] = {};
+  size_t currentPos = 0;
   for (size_t i = 0; i < size; i++) {
-    // TODO
+    // To avoid buffer overflows.
+    if (sizeof(printBuffer) - currentPos <= 4) {
+      break;
     }
+
+    currentPos += snprintf(printBuffer + currentPos, 4, "%d", data[i]);
+    if (i < size - 1) {
+      currentPos += sprintf(printBuffer + currentPos, ",");
+      if ((i + 1) % maxCharPerLine == 0) {
+        currentPos += sprintf(printBuffer + currentPos, "\n");
+      }
+    }
+  }
+#if FSFW_DISABLE_PRINTOUT == 0
+  printf("dec [%s]\n", printBuffer);
+#endif /* FSFW_DISABLE_PRINTOUT == 0 */
 #endif
 }
 

src/fsfw/health/HasHealthIF.h

@@ -16,26 +16,24 @@ class HasHealthIF {
   };
 
   static const uint8_t INTERFACE_ID = CLASS_ID::HAS_HEALTH_IF;
-  static const ReturnValue_t OBJECT_NOT_HEALTHY = MAKE_RETURN_CODE(1);
+  static constexpr ReturnValue_t OBJECT_NOT_HEALTHY = returnvalue::makeCode(INTERFACE_ID, 1);
-  static const ReturnValue_t INVALID_HEALTH_STATE = MAKE_RETURN_CODE(2);
+  static constexpr ReturnValue_t INVALID_HEALTH_STATE = returnvalue::makeCode(INTERFACE_ID, 2);
+  static constexpr ReturnValue_t IS_EXTERNALLY_CONTROLLED = returnvalue::makeCode(INTERFACE_ID, 3);
 
   static const uint8_t SUBSYSTEM_ID = SUBSYSTEM_ID::SYSTEM_MANAGER_1;
+  //! P1: New Health, P2: Old Health
   static const Event HEALTH_INFO = MAKE_EVENT(6, severity::INFO);
   static const Event CHILD_CHANGED_HEALTH = MAKE_EVENT(7, severity::INFO);
   static const Event CHILD_PROBLEMS = MAKE_EVENT(8, severity::LOW);
-  static const Event OVERWRITING_HEALTH =
+  //! Assembly overwrites health information of children to keep satellite alive.
-      MAKE_EVENT(9, severity::LOW);  //!< Assembly overwrites health information of children to keep
+  static const Event OVERWRITING_HEALTH = MAKE_EVENT(9, severity::LOW);
-                                     //!< satellite alive.
+  //! Someone starts a recovery of a component (typically power-cycle). No parameters.
-  static const Event TRYING_RECOVERY =
+  static const Event TRYING_RECOVERY = MAKE_EVENT(10, severity::MEDIUM);
-      MAKE_EVENT(10, severity::MEDIUM);  //!< Someone starts a recovery of a component (typically
+  //! Recovery is ongoing. Comes twice during recovery.
-                                         //!< power-cycle). No parameters.
+  //! P1: 0 for the first, 1 for the second event. P2: 0
-  static const Event RECOVERY_STEP =
+  static const Event RECOVERY_STEP = MAKE_EVENT(11, severity::MEDIUM);
-      MAKE_EVENT(11, severity::MEDIUM);  //!< Recovery is ongoing. Comes twice during recovery. P1:
+  //! Recovery was completed. Not necessarily successful. No parameters.
-                                         //!< 0 for the first, 1 for the second event. P2: 0
+  static const Event RECOVERY_DONE = MAKE_EVENT(12, severity::MEDIUM);
-  static const Event RECOVERY_DONE = MAKE_EVENT(
-      12,
-      severity::MEDIUM);  //!< Recovery was completed. Not necessarily successful. No parameters.
-
   virtual ~HasHealthIF() {}
 
   virtual MessageQueueId_t getCommandQueue() const = 0;

src/fsfw/health/HealthTable.h

@@ -8,6 +8,8 @@
 #include "HealthTableIF.h"
 
 class HealthTable : public HealthTableIF, public SystemObject {
+  friend class CServiceHealthCommanding;
+
  public:
   explicit HealthTable(object_id_t objectid);
   ~HealthTable() override;

src/fsfw/housekeeping/HousekeepingSnapshot.h

@@ -55,7 +55,7 @@ class HousekeepingSnapshot : public SerializeIF {
       : timeStamp(timeStamp), timeStampSize(timeStampSize), updateData(dataSetPtr){};
 
   virtual ReturnValue_t serialize(uint8_t** buffer, size_t* size, size_t maxSize,
-                                  Endianness streamEndianness) const override {
+                                  Endianness streamEndianness) const {
     if (timeStamp != nullptr) {
       /* Endianness will always be MACHINE, so we can simply use memcpy
       here. */
@@ -70,7 +70,7 @@ class HousekeepingSnapshot : public SerializeIF {
     return updateData->serialize(buffer, size, maxSize, streamEndianness);
   }
 
-  virtual size_t getSerializedSize() const override {
+  virtual size_t getSerializedSize() const {
     if (updateData == nullptr) {
       return 0;
     }

src/fsfw/ipc/CommandMessage.h

@@ -48,7 +48,7 @@ class CommandMessage : public MessageQueueMessage, public CommandMessageIF {
   /**
    * @brief 	Default Destructor
    */
-  ~CommandMessage() override {}
+  virtual ~CommandMessage() {}
 
   /**
    * Read the DeviceHandlerCommand_t that is stored in the message,

src/fsfw/ipc/CommandMessageIF.h

@@ -37,7 +37,7 @@ class CommandMessageIF {
   //! par1 should contain the error code
   static const Command_t REPLY_REJECTED = MAKE_COMMAND_ID(2);
 
-  virtual ~CommandMessageIF() = default;
+  virtual ~CommandMessageIF(){};
 
   /**
    * A command message shall have a uint16_t command ID field.

src/fsfw/ipc/definitions.h

@@ -5,7 +5,7 @@
 #include <fsfw/objectmanager/frameworkObjects.h>
 
 struct MqArgs {
-  MqArgs(){}
+  MqArgs(){};
   MqArgs(object_id_t objectId, void* args = nullptr) : objectId(objectId), args(args) {}
   object_id_t objectId = objects::NO_OBJECT;
   void* args = nullptr;

src/fsfw/modes/ModeMessage.cpp

@@ -24,3 +24,19 @@ void ModeMessage::setCantReachMode(CommandMessage* message, ReturnValue_t reason
   message->setParameter(reason);
   message->setParameter2(0);
 }
+
+void ModeMessage::setModeAnnounceMessage(CommandMessage& message, bool recursive) {
+  Command_t cmd;
+  if (recursive) {
+    cmd = CMD_MODE_ANNOUNCE_RECURSIVELY;
+  } else {
+    cmd = CMD_MODE_ANNOUNCE;
+  }
+  message.setCommand(cmd);
+}
+
+void ModeMessage::setCmdModeMessage(CommandMessage& message, Mode_t mode, Submode_t submode) {
+  setModeMessage(&message, CMD_MODE_COMMAND, mode, submode);
+}
+
+void ModeMessage::setModeReadMessage(CommandMessage& message) { message.setCommand(CMD_MODE_READ); }

src/fsfw/modes/ModeMessage.h

@@ -45,6 +45,9 @@ class ModeMessage {
 
   static void setModeMessage(CommandMessage* message, Command_t command, Mode_t mode,
                              Submode_t submode);
+  static void setCmdModeMessage(CommandMessage& message, Mode_t mode, Submode_t submode);
+  static void setModeAnnounceMessage(CommandMessage& message, bool recursive);
+  static void setModeReadMessage(CommandMessage& message);
   static void setCantReachMode(CommandMessage* message, ReturnValue_t reason);
   static void clear(CommandMessage* message);
 };

src/fsfw/monitoring/AbsLimitMonitor.h

@@ -18,7 +18,7 @@ class AbsLimitMonitor : public MonitorBase<T> {
         violationEvent(violationEvent),
         aboveIsViolation(aboveIsViolation) {}
   virtual ~AbsLimitMonitor() {}
-  ReturnValue_t checkSample(T sample, T *crossedLimit) override {
+  virtual ReturnValue_t checkSample(T sample, T *crossedLimit) {
     *crossedLimit = limit;
     if (aboveIsViolation) {
       if ((std::abs(sample) > limit)) {
@@ -32,9 +32,9 @@ class AbsLimitMonitor : public MonitorBase<T> {
     return returnvalue::OK;  // We're not out of range.
   }
 
-  ReturnValue_t getParameter(uint8_t domainId, uint8_t parameterId,
+  virtual ReturnValue_t getParameter(uint8_t domainId, uint16_t parameterId,
-                             ParameterWrapper *parameterWrapper, const ParameterWrapper *newValues,
+                                     ParameterWrapper *parameterWrapper,
-                             uint16_t startAtIndex) override {
+                                     const ParameterWrapper *newValues, uint16_t startAtIndex) {
     ReturnValue_t result = this->MonitorBase<T>::getParameter(
         domainId, parameterId, parameterWrapper, newValues, startAtIndex);
     // We'll reuse the DOMAIN_ID of MonitorReporter,
@@ -61,7 +61,7 @@ class AbsLimitMonitor : public MonitorBase<T> {
   void setLimit(T value) { limit = value; }
 
  protected:
-  void sendTransitionEvent(T currentValue, ReturnValue_t state) override {
+  void sendTransitionEvent(T currentValue, ReturnValue_t state) {
     switch (state) {
       case MonitoringIF::OUT_OF_RANGE:
         EventManagerIF::triggerEvent(this->reportingId, violationEvent, this->globalPoolId.objectId,

src/fsfw/objectmanager/ObjectManagerIF.h

@@ -40,7 +40,7 @@ class ObjectManagerIF {
   /**
    * @brief	This is the empty virtual destructor as requested by C++ interfaces.
    */
-  virtual ~ObjectManagerIF(void){}
+  virtual ~ObjectManagerIF(void){};
   /**
    * @brief	With this call, new objects are inserted to the list.
    * @details	The implementation shall return an error code in case the

src/fsfw/objectmanager/SystemObject.h

@@ -45,7 +45,7 @@ class SystemObject : public SystemObjectIF {
   /**
    * @brief	On destruction, the object removes itself from the list.
    */
-  ~SystemObject() override;
+  virtual ~SystemObject();
   object_id_t getObjectId() const override;
   virtual ReturnValue_t initialize() override;
   virtual ReturnValue_t checkObjectConnections() override;

src/fsfw/objectmanager/SystemObjectIF.h

@@ -36,7 +36,7 @@ class SystemObjectIF : public EventReportingProxyIF {
   /**
    * The empty virtual destructor as required for C++ interfaces.
    */
-  ~SystemObjectIF() override {}
+  virtual ~SystemObjectIF() {}
   /**
    * @brief   Initializes the object.
    * There are initialization steps which can also be done in the constructor.

src/fsfw/osal/CMakeLists.txt

@@ -18,7 +18,10 @@ elseif(FSFW_OSAL MATCHES "host")
   endif()
   set(FSFW_OSAL_HOST 1)
 else()
-  message(WARNING "The OS_FSFW variable was not set. Assuming host OS..")
+  message(
+    WARNING
+      "${MSG_PREFIX} The FSFW_OSAL variable was not set. Assuming host OS..")
+
   # Not set. Assumuing this is a host build, try to determine host OS
   if(WIN32)
     add_subdirectory(host)

src/fsfw/osal/Endiness.h

@@ -24,11 +24,8 @@
 #else
 
 #ifdef WIN32
-// Thanks, windows
-// clang-format off
-#include <winsock2.h>
 #include <windows.h>
-// clang-format on
+#include <winsock2.h>
 #if REG_DWORD == REG_DWORD_LITTLE_ENDIAN
 #define BYTE_ORDER_SYSTEM LITTLE_ENDIAN
 #else

src/fsfw/osal/common/TcpTmTcServer.cpp

@@ -16,7 +16,7 @@
 
 #ifdef PLATFORM_WIN
 #include <winsock2.h>
-typedef SSIZE_T ssize_t;
+#include <ws2tcpip.h>
 #elif defined(PLATFORM_UNIX)
 #include <netdb.h>
 

src/fsfw/osal/common/TcpTmTcServer.h

@@ -78,7 +78,6 @@ class TcpTmTcServer : public SystemObject, public TcpIpBase, public ExecutableOb
      * https://man7.org/linux/man-pages/man7/socket.7.html for more details.
      */
     bool reusePort = false;
-
   };
   enum class ReceptionModes { SPACE_PACKETS };
 
@@ -131,7 +130,7 @@ class TcpTmTcServer : public SystemObject, public TcpIpBase, public ExecutableOb
 
   ReceptionModes receptionMode;
   TcpConfig tcpConfig;
-  // struct sockaddr tcpAddress = {};
+  struct sockaddr tcpAddress = {};
   socket_t listenerTcpSocket = 0;
 
   MessageQueueId_t targetTcDestination = MessageQueueIF::NO_QUEUE;

src/fsfw/osal/common/UdpTcPollingTask.cpp

@@ -8,7 +8,6 @@
 
 #ifdef PLATFORM_WIN
 #include <winsock2.h>
-typedef SSIZE_T ssize_t;
 #elif defined(PLATFORM_UNIX)
 #include <sys/socket.h>
 #include <sys/types.h>

src/fsfw/osal/common/UdpTmTcBridge.cpp

@@ -7,7 +7,6 @@
 
 #ifdef PLATFORM_WIN
 #include <ws2tcpip.h>
-typedef SSIZE_T ssize_t;
 #elif defined(PLATFORM_UNIX)
 #include <arpa/inet.h>
 #include <netdb.h>

src/fsfw/osal/freertos/BinSemaphUsingTask.h

@@ -40,7 +40,7 @@ class BinarySemaphoreUsingTask : public SemaphoreIF {
   void refreshTaskHandle();
 
   ReturnValue_t acquire(TimeoutType timeoutType = TimeoutType::BLOCKING,
-                        uint32_t timeoutMs = 0) override;
+                        uint32_t timeoutMs = portMAX_DELAY) override;
   ReturnValue_t release() override;
   uint8_t getSemaphoreCounter() const override;
   static uint8_t getSemaphoreCounter(TaskHandle_t taskHandle);

src/fsfw/osal/freertos/BinarySemaphore.h

@@ -51,7 +51,7 @@ class BinarySemaphore : public SemaphoreIF {
    *         -@c SemaphoreIF::SEMAPHORE_TIMEOUT on timeout
    */
   ReturnValue_t acquire(TimeoutType timeoutType = TimeoutType::BLOCKING,
-                        uint32_t timeoutMs = 0) override;
+                        uint32_t timeoutMs = portMAX_DELAY) override;
 
   /**
    * Same as lockBinarySemaphore() with timeout in FreeRTOS ticks.

src/fsfw/osal/freertos/Clock.cpp

@@ -11,6 +11,19 @@
 // TODO sanitize input?
 // TODO much of this code can be reused for tick-only systems
 
+uint32_t Clock::getTicksPerSecond(void) { return 1000; }
+
+ReturnValue_t Clock::setClock(const TimeOfDay_t* time) {
+  timeval time_timeval;
+
+  ReturnValue_t result = convertTimeOfDayToTimeval(time, &time_timeval);
+  if (result != returnvalue::OK) {
+    return result;
+  }
+
+  return setClock(&time_timeval);
+}
+
 ReturnValue_t Clock::setClock(const timeval* time) {
   timeval uptime = getUptime();
 
@@ -31,12 +44,81 @@ ReturnValue_t Clock::getClock_timeval(timeval* time) {
   return returnvalue::OK;
 }
 
+ReturnValue_t Clock::getUptime(timeval* uptime) {
+  *uptime = getUptime();
+
+  return returnvalue::OK;
+}
+
 timeval Clock::getUptime() {
   TickType_t ticksSinceStart = xTaskGetTickCount();
   return Timekeeper::ticksToTimeval(ticksSinceStart);
 }
 
+ReturnValue_t Clock::getUptime(uint32_t* uptimeMs) {
+  timeval uptime = getUptime();
+  *uptimeMs = uptime.tv_sec * 1000 + uptime.tv_usec / 1000;
+  return returnvalue::OK;
+}
+
 // uint32_t Clock::getUptimeSeconds() {
 //	timeval uptime = getUptime();
 //	return uptime.tv_sec;
 // }
+
+ReturnValue_t Clock::getClock_usecs(uint64_t* time) {
+  timeval time_timeval;
+  ReturnValue_t result = getClock_timeval(&time_timeval);
+  if (result != returnvalue::OK) {
+    return result;
+  }
+  *time = time_timeval.tv_sec * 1000000 + time_timeval.tv_usec;
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::getDateAndTime(TimeOfDay_t* time) {
+  timeval time_timeval;
+  ReturnValue_t result = getClock_timeval(&time_timeval);
+  if (result != returnvalue::OK) {
+    return result;
+  }
+  struct tm time_tm;
+
+  gmtime_r(&time_timeval.tv_sec, &time_tm);
+
+  time->year = time_tm.tm_year + 1900;
+  time->month = time_tm.tm_mon + 1;
+  time->day = time_tm.tm_mday;
+
+  time->hour = time_tm.tm_hour;
+  time->minute = time_tm.tm_min;
+  time->second = time_tm.tm_sec;
+
+  time->usecond = time_timeval.tv_usec;
+
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::convertTimeOfDayToTimeval(const TimeOfDay_t* from, timeval* to) {
+  struct tm time_tm = {};
+
+  time_tm.tm_year = from->year - 1900;
+  time_tm.tm_mon = from->month - 1;
+  time_tm.tm_mday = from->day;
+
+  time_tm.tm_hour = from->hour;
+  time_tm.tm_min = from->minute;
+  time_tm.tm_sec = from->second;
+
+  time_t seconds = mktime(&time_tm);
+
+  to->tv_sec = seconds;
+  to->tv_usec = from->usecond;
+  // Fails in 2038..
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::convertTimevalToJD2000(timeval time, double* JD2000) {
+  *JD2000 = (time.tv_sec - 946728000. + time.tv_usec / 1000000.) / 24. / 3600.;
+  return returnvalue::OK;
+}

src/fsfw/osal/freertos/CountingSemaphUsingTask.h

@@ -34,7 +34,7 @@ class CountingSemaphoreUsingTask : public SemaphoreIF {
    *         -@c SemaphoreIF::SEMAPHORE_TIMEOUT on timeout
    */
   ReturnValue_t acquire(TimeoutType timeoutType = TimeoutType::BLOCKING,
-                        uint32_t timeoutMs = 0) override;
+                        uint32_t timeoutMs = portMAX_DELAY) override;
 
   /**
    * Release a semaphore, increasing the number of available counting

src/fsfw/osal/freertos/FixedTimeslotTask.cpp

@@ -56,9 +56,7 @@ ReturnValue_t FixedTimeslotTask::startTask() {
   // start time for the first entry.
   auto slotListIter = pollingSeqTable.current;
 
-  ReturnValue_t result = pollingSeqTable.intializeSequenceAfterTaskCreation();
+  pollingSeqTable.intializeSequenceAfterTaskCreation();
-  // Ignore returnvalue for now
-  static_cast<void>(result);
 
   // The start time for the first entry is read.
   uint32_t intervalMs = slotListIter->pollingTimeMs;

src/fsfw/osal/freertos/Mutex.cpp

@@ -22,7 +22,7 @@ ReturnValue_t Mutex::lockMutex(TimeoutType timeoutType, uint32_t timeoutMs) {
     return MutexIF::MUTEX_NOT_FOUND;
   }
   // If the timeout type is BLOCKING, this will be the correct value.
-  TickType_t timeout = portMAX_DELAY;
+  uint32_t timeout = portMAX_DELAY;
   if (timeoutType == TimeoutType::POLLING) {
     timeout = 0;
   } else if (timeoutType == TimeoutType::WAITING) {

src/fsfw/osal/freertos/TaskManagement.cpp

@@ -3,16 +3,16 @@
 void TaskManagement::vRequestContextSwitchFromTask() { vTaskDelay(0); }
 
 void TaskManagement::requestContextSwitch(CallContext callContext = CallContext::TASK) {
-  //   if (callContext == CallContext::ISR) {
+  if (callContext == CallContext::ISR) {
-  //     // This function depends on the partmacro.h definition for the specific device
+    // This function depends on the partmacro.h definition for the specific device
-  //     vRequestContextSwitchFromISR();
+    vRequestContextSwitchFromISR();
-  //   } else {
+  } else {
     vRequestContextSwitchFromTask();
-  //   }
+  }
 }
 
 TaskHandle_t TaskManagement::getCurrentTaskHandle() { return xTaskGetCurrentTaskHandle(); }
 
-// size_t TaskManagement::getTaskStackHighWatermark(TaskHandle_t task) {
+size_t TaskManagement::getTaskStackHighWatermark(TaskHandle_t task) {
-//   return uxTaskGetStackHighWaterMark(task) * sizeof(StackType_t);
+  return uxTaskGetStackHighWaterMark(task) * sizeof(StackType_t);
-// }
+}

src/fsfw/osal/freertos/TaskManagement.h

@@ -11,7 +11,7 @@
  * Architecture dependant portmacro.h function call.
  * Should be implemented in bsp.
  */
-// extern "C" void vRequestContextSwitchFromISR();
+extern "C" void vRequestContextSwitchFromISR();
 
 /*!
  * Used by functions to tell if they are being called from
@@ -53,7 +53,7 @@ TaskHandle_t getCurrentTaskHandle();
  * @return Smallest value of stack remaining since the task was started in
  * 		   words.
  */
-// size_t getTaskStackHighWatermark(TaskHandle_t task = nullptr);
+size_t getTaskStackHighWatermark(TaskHandle_t task = nullptr);
 
 };  // namespace TaskManagement
 

src/fsfw/osal/host/Clock.cpp

@@ -15,6 +15,27 @@
 
 using SystemClock = std::chrono::system_clock;
 
+uint32_t Clock::getTicksPerSecond(void) {
+#if FSFW_CPP_OSTREAM_ENABLED == 1
+  sif::warning << "Clock::getTicksPerSecond: Not implemented for host OSAL" << std::endl;
+#else
+  sif::printWarning("Clock::getTicksPerSecond: Not implemented for host OSAL\n");
+#endif
+  /* To avoid division by zero */
+  return 1;
+}
+
+ReturnValue_t Clock::setClock(const TimeOfDay_t* time) {
+  /* I don't know why someone would need to set a clock which is probably perfectly fine on a
+  host system with internet access so this is not implemented for now. */
+#if FSFW_CPP_OSTREAM_ENABLED == 1
+  sif::warning << "Clock::setClock: Not implemented for host OSAL" << std::endl;
+#else
+  sif::printWarning("Clock::setClock: Not implemented for host OSAL\n");
+#endif
+  return returnvalue::OK;
+}
+
 ReturnValue_t Clock::setClock(const timeval* time) {
   /* I don't know why someone would need to set a clock which is probably perfectly fine on a
   host system with internet access so this is not implemented for now. */
@@ -45,7 +66,6 @@ ReturnValue_t Clock::getClock_timeval(timeval* time) {
   time->tv_usec = timeUnix.tv_nsec / 1000.0;
   return returnvalue::OK;
 #else
-#warning Clock::getClock_timeval() not implemented for your platform
 #if FSFW_CPP_OSTREAM_ENABLED == 1
   sif::warning << "Clock::getUptime: Not implemented for found OS!" << std::endl;
 #else
@@ -55,6 +75,15 @@ ReturnValue_t Clock::getClock_timeval(timeval* time) {
 #endif
 }
 
+ReturnValue_t Clock::getClock_usecs(uint64_t* time) {
+  if (time == nullptr) {
+    return returnvalue::FAILED;
+  }
+  using namespace std::chrono;
+  *time = duration_cast<microseconds>(system_clock::now().time_since_epoch()).count();
+  return returnvalue::OK;
+}
+
 timeval Clock::getUptime() {
   timeval timeval;
 #if defined(PLATFORM_WIN)
@@ -71,10 +100,73 @@ timeval Clock::getUptime() {
     timeval.tv_usec = uptimeSeconds * (double)1e6 - (timeval.tv_sec * 1e6);
   }
 #else
-#warning Clock::getUptime() not implemented for your platform
 #if FSFW_CPP_OSTREAM_ENABLED == 1
   sif::warning << "Clock::getUptime: Not implemented for found OS" << std::endl;
 #endif
 #endif
   return timeval;
 }
+
+ReturnValue_t Clock::getUptime(timeval* uptime) {
+  *uptime = getUptime();
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::getUptime(uint32_t* uptimeMs) {
+  timeval uptime = getUptime();
+  *uptimeMs = uptime.tv_sec * 1000 + uptime.tv_usec / 1000;
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::getDateAndTime(TimeOfDay_t* time) {
+  /* Do some magic with chrono (C++20!) */
+  /* Right now, the library doesn't have the new features to get the required values yet.
+  so we work around that for now. */
+  auto now = SystemClock::now();
+  auto seconds = std::chrono::time_point_cast<std::chrono::seconds>(now);
+  auto fraction = now - seconds;
+  time_t tt = SystemClock::to_time_t(now);
+  ReturnValue_t result = checkOrCreateClockMutex();
+  if (result != returnvalue::OK) {
+    return result;
+  }
+  MutexGuard helper(timeMutex);
+  // gmtime writes its output in a global buffer which is not Thread Safe
+  // Therefore we have to use a Mutex here
+  struct tm* timeInfo;
+  timeInfo = gmtime(&tt);
+  time->year = timeInfo->tm_year + 1900;
+  time->month = timeInfo->tm_mon + 1;
+  time->day = timeInfo->tm_mday;
+  time->hour = timeInfo->tm_hour;
+  time->minute = timeInfo->tm_min;
+  time->second = timeInfo->tm_sec;
+  auto usecond = std::chrono::duration_cast<std::chrono::microseconds>(fraction);
+  time->usecond = usecond.count();
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::convertTimeOfDayToTimeval(const TimeOfDay_t* from, timeval* to) {
+  struct tm time_tm {};
+
+  time_tm.tm_year = from->year - 1900;
+  time_tm.tm_mon = from->month - 1;
+  time_tm.tm_mday = from->day;
+
+  time_tm.tm_hour = from->hour;
+  time_tm.tm_min = from->minute;
+  time_tm.tm_sec = from->second;
+  time_tm.tm_isdst = 0;
+
+  time_t seconds = timegm(&time_tm);
+
+  to->tv_sec = seconds;
+  to->tv_usec = from->usecond;
+  // Fails in 2038..
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::convertTimevalToJD2000(timeval time, double* JD2000) {
+  *JD2000 = (time.tv_sec - 946728000. + time.tv_usec / 1000000.) / 24. / 3600.;
+  return returnvalue::OK;
+}

src/fsfw/osal/host/PeriodicTask.cpp

@@ -9,6 +9,7 @@
 #include "fsfw/serviceinterface/ServiceInterface.h"
 
 #if defined(PLATFORM_WIN)
+#include <processthreadsapi.h>
 
 #include "fsfw/osal/windows/winTaskHelpers.h"
 #elif defined(PLATFORM_UNIX)

src/fsfw/osal/host/TaskFactory.cpp

@@ -50,6 +50,6 @@ void TaskFactory::printMissedDeadline() {
 #if FSFW_CPP_OSTREAM_ENABLED == 1
   sif::warning << "TaskFactory::printMissedDeadline: " << name << std::endl;
 #else
-  sif::printWarning("TaskFactory::printMissedDeadline: %s\n", name.c_str());
+  sif::printWarning("TaskFactory::printMissedDeadline: %s\n", name);
 #endif /* FSFW_CPP_OSTREAM_ENABLED == 1 */
 }

src/fsfw/osal/host/taskHelpers.h

@@ -3,7 +3,6 @@
 
 #include <fsfw/returnvalues/returnvalue.h>
 
-#include <string>
 #include <thread>
 
 namespace tasks {

src/fsfw/osal/linux/Clock.cpp

@@ -10,6 +10,26 @@
 #include "fsfw/ipc/MutexGuard.h"
 #include "fsfw/serviceinterface/ServiceInterface.h"
 
+uint32_t Clock::getTicksPerSecond() {
+  uint32_t ticks = sysconf(_SC_CLK_TCK);
+  return ticks;
+}
+
+ReturnValue_t Clock::setClock(const TimeOfDay_t* time) {
+  timespec timeUnix{};
+  timeval timeTimeval{};
+  convertTimeOfDayToTimeval(time, &timeTimeval);
+  timeUnix.tv_sec = timeTimeval.tv_sec;
+  timeUnix.tv_nsec = (__syscall_slong_t)timeTimeval.tv_usec * 1000;
+
+  int status = clock_settime(CLOCK_REALTIME, &timeUnix);
+  if (status != 0) {
+    // TODO errno
+    return returnvalue::FAILED;
+  }
+  return returnvalue::OK;
+}
+
 ReturnValue_t Clock::setClock(const timeval* time) {
   timespec timeUnix{};
   timeUnix.tv_sec = time->tv_sec;
@@ -33,12 +53,104 @@ ReturnValue_t Clock::getClock_timeval(timeval* time) {
   return returnvalue::OK;
 }
 
+ReturnValue_t Clock::getClock_usecs(uint64_t* time) {
+  timeval timeVal{};
+  ReturnValue_t result = getClock_timeval(&timeVal);
+  if (result != returnvalue::OK) {
+    return result;
+  }
+  *time = static_cast<uint64_t>(timeVal.tv_sec) * 1e6 + timeVal.tv_usec;
+
+  return returnvalue::OK;
+}
+
 timeval Clock::getUptime() {
-  timeval uptime{0, 0};
+  timeval uptime{};
-  double uptimeSeconds;
+  auto result = getUptime(&uptime);
-  if (std::ifstream("/proc/uptime", std::ios::in) >> uptimeSeconds) {
+  if (result != returnvalue::OK) {
-    uptime.tv_sec = uptimeSeconds;
+#if FSFW_CPP_OSTREAM_ENABLED == 1
-    uptime.tv_usec = uptimeSeconds * (double)1e6 - (uptime.tv_sec * 1e6);
+    sif::error << "Clock::getUptime: Error getting uptime" << std::endl;
+#endif
   }
   return uptime;
 }
+
+ReturnValue_t Clock::getUptime(timeval* uptime) {
+  // TODO This is not posix compatible and delivers only seconds precision
+  //  Linux specific file read but more precise.
+  double uptimeSeconds;
+  if (std::ifstream("/proc/uptime", std::ios::in) >> uptimeSeconds) {
+    uptime->tv_sec = uptimeSeconds;
+    uptime->tv_usec = uptimeSeconds * (double)1e6 - (uptime->tv_sec * 1e6);
+  }
+  return returnvalue::OK;
+}
+
+// Wait for new FSFW Clock function delivering seconds uptime.
+// uint32_t Clock::getUptimeSeconds() {
+//	//TODO This is not posix compatible and delivers only seconds precision
+//	struct sysinfo sysInfo;
+//	int result = sysinfo(&sysInfo);
+//	if(result != 0){
+//		return returnvalue::FAILED;
+//	}
+//	return sysInfo.uptime;
+//}
+
+ReturnValue_t Clock::getUptime(uint32_t* uptimeMs) {
+  timeval uptime{};
+  ReturnValue_t result = getUptime(&uptime);
+  if (result != returnvalue::OK) {
+    return result;
+  }
+  *uptimeMs = uptime.tv_sec * 1e3 + uptime.tv_usec / 1e3;
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::getDateAndTime(TimeOfDay_t* time) {
+  timespec timeUnix{};
+  int status = clock_gettime(CLOCK_REALTIME, &timeUnix);
+  if (status != 0) {
+    // TODO errno
+    return returnvalue::FAILED;
+  }
+  ReturnValue_t result = checkOrCreateClockMutex();
+  if (result != returnvalue::OK) {
+    return result;
+  }
+  MutexGuard helper(timeMutex);
+  // gmtime writes its output in a global buffer which is not Thread Safe
+  // Therefore we have to use a Mutex here
+  struct std::tm* timeInfo;
+  timeInfo = gmtime(&timeUnix.tv_sec);
+  time->year = timeInfo->tm_year + 1900;
+  time->month = timeInfo->tm_mon + 1;
+  time->day = timeInfo->tm_mday;
+  time->hour = timeInfo->tm_hour;
+  time->minute = timeInfo->tm_min;
+  time->second = timeInfo->tm_sec;
+  time->usecond = timeUnix.tv_nsec / 1000.0;
+
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::convertTimeOfDayToTimeval(const TimeOfDay_t* from, timeval* to) {
+  std::tm fromTm{};
+  // Note: Fails for years before AD
+  fromTm.tm_year = from->year - 1900;
+  fromTm.tm_mon = from->month - 1;
+  fromTm.tm_mday = from->day;
+  fromTm.tm_hour = from->hour;
+  fromTm.tm_min = from->minute;
+  fromTm.tm_sec = from->second;
+  fromTm.tm_isdst = 0;
+
+  to->tv_sec = timegm(&fromTm);
+  to->tv_usec = from->usecond;
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::convertTimevalToJD2000(timeval time, double* JD2000) {
+  *JD2000 = (time.tv_sec - 946728000. + time.tv_usec / 1000000.) / 24. / 3600.;
+  return returnvalue::OK;
+}

src/fsfw/osal/rtems/BinarySemaphore.cpp

@@ -2,8 +2,6 @@
 
 #include <rtems/rtems/sem.h>
 
-// TODO
-
 BinarySemaphore::BinarySemaphore() {}
 
 BinarySemaphore::~BinarySemaphore() {}

src/fsfw/osal/rtems/Clock.cpp

@@ -6,21 +6,20 @@
 #include "fsfw/ipc/MutexGuard.h"
 #include "fsfw/osal/rtems/RtemsBasic.h"
 
-ReturnValue_t Clock::setClock(const timeval* time) {
+uint32_t Clock::getTicksPerSecond(void) {
-  TimeOfDay_t time_tod;
+  rtems_interval ticks_per_second = rtems_clock_get_ticks_per_second();
-  ReturnValue_t result = convertTimevalToTimeOfDay(time, &time_tod);
+  return static_cast<uint32_t>(ticks_per_second);
-  if (result != returnvalue::OK) {
+}
-    return result;
+
-  }
+ReturnValue_t Clock::setClock(const TimeOfDay_t* time) {
   rtems_time_of_day timeRtems;
-  timeRtems.year = time_tod.year;
+  timeRtems.year = time->year;
-  timeRtems.month = time_tod.month;
+  timeRtems.month = time->month;
-  timeRtems.day = time_tod.day;
+  timeRtems.day = time->day;
-  timeRtems.hour = time_tod.hour;
+  timeRtems.hour = time->hour;
-  timeRtems.minute = time_tod.minute;
+  timeRtems.minute = time->minute;
-  timeRtems.second = time_tod.second;
+  timeRtems.second = time->second;
-  timeRtems.ticks =
+  timeRtems.ticks = time->usecond * getTicksPerSecond() / 1e6;
-      static_cast<uint64_t>(time_tod.usecond) * rtems_clock_get_ticks_per_second() / 1e6;
   rtems_status_code status = rtems_clock_set(&timeRtems);
   switch (status) {
     case RTEMS_SUCCESSFUL:
@@ -34,6 +33,27 @@ ReturnValue_t Clock::setClock(const timeval* time) {
   }
 }
 
+ReturnValue_t Clock::setClock(const timeval* time) {
+  timespec newTime;
+  newTime.tv_sec = time->tv_sec;
+  if (time->tv_usec < 0) {
+    // better returnvalue.
+    return returnvalue::FAILED;
+  }
+  newTime.tv_nsec = time->tv_usec * TOD_NANOSECONDS_PER_MICROSECOND;
+
+  ISR_lock_Context context;
+  _TOD_Lock();
+  _TOD_Acquire(&context);
+  Status_Control status = _TOD_Set(&newTime, &context);
+  _TOD_Unlock();
+  if (status == STATUS_SUCCESSFUL) {
+    return returnvalue::OK;
+  }
+  // better returnvalue
+  return returnvalue::FAILED;
+}
+
 ReturnValue_t Clock::getClock_timeval(timeval* time) {
   // Callable from ISR
   rtems_status_code status = rtems_clock_get_tod_timeval(time);
@@ -47,13 +67,86 @@ ReturnValue_t Clock::getClock_timeval(timeval* time) {
   }
 }
 
-timeval Clock::getUptime() {
+ReturnValue_t Clock::getUptime(timeval* uptime) {
   // According to docs.rtems.org for rtems 5 this method is more accurate than
   // rtems_clock_get_ticks_since_boot
-  timeval time_timeval;
   timespec time;
   rtems_status_code status = rtems_clock_get_uptime(&time);
-  time_timeval.tv_sec = time.tv_sec;
+  uptime->tv_sec = time.tv_sec;
-  time_timeval.tv_usec = time.tv_nsec / 1000;
+  time.tv_nsec = time.tv_nsec / 1000;
-  return time_timeval;
+  uptime->tv_usec = time.tv_nsec;
+  switch (status) {
+    case RTEMS_SUCCESSFUL:
+      return returnvalue::OK;
+    default:
+      return returnvalue::FAILED;
+  }
+}
+
+ReturnValue_t Clock::getUptime(uint32_t* uptimeMs) {
+  // This counter overflows after 50 days
+  *uptimeMs = rtems_clock_get_ticks_since_boot();
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::getClock_usecs(uint64_t* time) {
+  timeval temp_time;
+  rtems_status_code returnValue = rtems_clock_get_tod_timeval(&temp_time);
+  *time = ((uint64_t)temp_time.tv_sec * 1000000) + temp_time.tv_usec;
+  switch (returnValue) {
+    case RTEMS_SUCCESSFUL:
+      return returnvalue::OK;
+    default:
+      return returnvalue::FAILED;
+  }
+}
+
+ReturnValue_t Clock::getDateAndTime(TimeOfDay_t* time) {
+  /* For all but the last field, the struct will be filled with the correct values */
+  rtems_time_of_day timeRtems;
+  rtems_status_code status = rtems_clock_get_tod(&timeRtems);
+  switch (status) {
+    case RTEMS_SUCCESSFUL: {
+      /* The last field now contains the RTEMS ticks of the seconds from 0
+      to rtems_clock_get_ticks_per_second() minus one.
+      We calculate the microseconds accordingly */
+      time->day = timeRtems.day;
+      time->hour = timeRtems.hour;
+      time->minute = timeRtems.minute;
+      time->month = timeRtems.month;
+      time->second = timeRtems.second;
+      time->usecond =
+          static_cast<float>(timeRtems.ticks) / rtems_clock_get_ticks_per_second() * 1e6;
+      time->year = timeRtems.year;
+      return returnvalue::OK;
+    }
+    case RTEMS_NOT_DEFINED:
+      /* System date and time is not set */
+      return returnvalue::FAILED;
+    case RTEMS_INVALID_ADDRESS:
+      /* time_buffer is NULL */
+      return returnvalue::FAILED;
+    default:
+      return returnvalue::FAILED;
+  }
+}
+
+ReturnValue_t Clock::convertTimeOfDayToTimeval(const TimeOfDay_t* from, timeval* to) {
+  // Fails in 2038..
+  rtems_time_of_day timeRtems;
+  timeRtems.year = from->year;
+  timeRtems.month = from->month;
+  timeRtems.day = from->day;
+  timeRtems.hour = from->hour;
+  timeRtems.minute = from->minute;
+  timeRtems.second = from->second;
+  timeRtems.ticks = from->usecond * getTicksPerSecond() / 1e6;
+  to->tv_sec = _TOD_To_seconds(&timeRtems);
+  to->tv_usec = from->usecond;
+  return returnvalue::OK;
+}
+
+ReturnValue_t Clock::convertTimevalToJD2000(timeval time, double* JD2000) {
+  *JD2000 = (time.tv_sec - 946728000. + time.tv_usec / 1000000.) / 24. / 3600.;
+  return returnvalue::OK;
 }

src/fsfw/osal/rtems/CpuUsage.cpp

@@ -93,8 +93,8 @@ ReturnValue_t CpuUsage::serialize(uint8_t** buffer, size_t* size, size_t maxSize
                                                        streamEndianness);
 }
 
-size_t CpuUsage::getSerializedSize() const {
+uint32_t CpuUsage::getSerializedSize() const {
-  size_t size = 0;
+  uint32_t size = 0;
 
   size += sizeof(timeSinceLastReset);
   size += SerialArrayListAdapter<ThreadData>::getSerializedSize(&threadData);
@@ -136,8 +136,8 @@ ReturnValue_t CpuUsage::ThreadData::serialize(uint8_t** buffer, size_t* size, si
   return returnvalue::OK;
 }
 
-size_t CpuUsage::ThreadData::getSerializedSize() const {
+uint32_t CpuUsage::ThreadData::getSerializedSize() const {
-  size_t size = 0;
+  uint32_t size = 0;
 
   size += sizeof(id);
   size += MAX_LENGTH_OF_THREAD_NAME;

src/fsfw/osal/rtems/InternalErrorCodes.cpp

@@ -35,9 +35,10 @@ ReturnValue_t InternalErrorCodes::translate(uint8_t code) {
       return OUT_OF_PROXIES;
     case INTERNAL_ERROR_INVALID_GLOBAL_ID:
       return INVALID_GLOBAL_ID;
-    // TODO this one is not there anymore in rtems-6 (5 as well?)
+#ifndef STM32H743ZI_NUCLEO
-    // case INTERNAL_ERROR_BAD_STACK_HOOK:
+    case INTERNAL_ERROR_BAD_STACK_HOOK:
-    //   return BAD_STACK_HOOK;
+      return BAD_STACK_HOOK;
+#endif
       //	case INTERNAL_ERROR_BAD_ATTRIBUTES:
       //		return BAD_ATTRIBUTES;
       //	case INTERNAL_ERROR_IMPLEMENTATION_KEY_CREATE_INCONSISTENCY:

src/fsfw/osal/rtems/SemaphoreFactory.cpp

@@ -18,9 +18,7 @@ SemaphoreFactory* SemaphoreFactory::instance() {
 }
 
 SemaphoreIF* SemaphoreFactory::createBinarySemaphore(uint32_t argument) {
-  return nullptr;
+  return new BinarySemaphore();
-  // TODO
-  // return new BinarySemaphore();
 }
 
 SemaphoreIF* SemaphoreFactory::createCountingSemaphore(uint8_t maxCount, uint8_t initCount,

src/fsfw/osal/windows/winTaskHelpers.h

@@ -5,11 +5,7 @@
 
 #ifdef _WIN32
 
-// Thanks, windows
+#include <minwindef.h>
-// clang-format off
-#include <windows.h>
-#include <processthreadsapi.h>
-// clang-format on
 
 namespace tasks {
 

src/fsfw/parameters/ParameterWrapper.h

@@ -45,7 +45,6 @@ class ParameterWrapper : public SerializeIF {
 
   virtual size_t getSerializedSize() const override;
 
-  using SerializeIF::deSerialize;
   virtual ReturnValue_t deSerialize(const uint8_t **buffer, size_t *size,
                                     Endianness streamEndianness) override;
 

src/fsfw/power/Fuse.h

@@ -62,13 +62,13 @@ class Fuse : public SystemObject,
                             SerializeIF::Endianness streamEndianness) override;
   void setAllMonitorsToUnchecked();
   ReturnValue_t performOperation(uint8_t opCode);
-  MessageQueueId_t getCommandQueue() const override;
+  MessageQueueId_t getCommandQueue() const;
   void setDataPoolEntriesInvalid();
-  ReturnValue_t setHealth(HealthState health) override;
+  ReturnValue_t setHealth(HealthState health);
-  HasHealthIF::HealthState getHealth() override;
+  HasHealthIF::HealthState getHealth();
 
   ReturnValue_t getParameter(uint8_t domainId, uint8_t uniqueId, ParameterWrapper *parameterWrapper,
-                             const ParameterWrapper *newValues, uint16_t startAtIndex) override;
+                             const ParameterWrapper *newValues, uint16_t startAtIndex);
 
  private:
   uint8_t oldFuseState;

src/fsfw/power/PowerComponent.h

@@ -10,15 +10,15 @@ class PowerComponent : public PowerComponentIF {
   PowerComponent(object_id_t setId, uint8_t moduleId, float minPower, float maxPower,
                  uint8_t switchId1, bool twoSwitches = false, uint8_t switchId2 = 0xFF);
 
-  object_id_t getDeviceObjectId() override;
+  virtual object_id_t getDeviceObjectId();
 
-  uint8_t getSwitchId1() override;
+  virtual uint8_t getSwitchId1();
-  uint8_t getSwitchId2() override;
+  virtual uint8_t getSwitchId2();
 
-  bool hasTwoSwitches() override;
+  bool hasTwoSwitches();
 
-  float getMin() override;
+  float getMin();
-  float getMax() override;
+  float getMax();
 
   ReturnValue_t serialize(uint8_t** buffer, size_t* size, size_t maxSize,
                           Endianness streamEndianness) const override;
@@ -29,7 +29,7 @@ class PowerComponent : public PowerComponentIF {
                             Endianness streamEndianness) override;
 
   ReturnValue_t getParameter(uint8_t domainId, uint8_t uniqueId, ParameterWrapper* parameterWrapper,
-                             const ParameterWrapper* newValues, uint16_t startAtIndex) override;
+                             const ParameterWrapper* newValues, uint16_t startAtIndex);
 
  private:
   const object_id_t deviceObjectId = objects::NO_OBJECT;

src/fsfw/pus/CMakeLists.txt

@@ -9,4 +9,4 @@ target_sources(
           Service17Test.cpp
           Service20ParameterManagement.cpp
           CService200ModeCommanding.cpp
-          CService201HealthCommanding.cpp)
+          CServiceHealthCommanding.cpp)

src/fsfw/pus/CService200ModeCommanding.cpp

@@ -19,7 +19,8 @@ ReturnValue_t CService200ModeCommanding::isValidSubservice(uint8_t subservice) {
   switch (subservice) {
     case (Subservice::COMMAND_MODE_COMMAND):
     case (Subservice::COMMAND_MODE_READ):
-    case (Subservice::COMMAND_MODE_ANNCOUNCE):
+    case (Subservice::COMMAND_MODE_ANNOUNCE):
+    case (Subservice::COMMAND_MODE_ANNOUNCE_RECURSIVELY):
       return returnvalue::OK;
     default:
       return AcceptsTelecommandsIF::INVALID_SUBSERVICE;
@@ -53,6 +54,9 @@ ReturnValue_t CService200ModeCommanding::checkInterfaceAndAcquireMessageQueue(
 ReturnValue_t CService200ModeCommanding::prepareCommand(CommandMessage *message, uint8_t subservice,
                                                         const uint8_t *tcData, size_t tcDataLen,
                                                         uint32_t *state, object_id_t objectId) {
+  bool recursive = false;
+  switch (subservice) {
+    case (Subservice::COMMAND_MODE_COMMAND): {
       ModePacket modeCommandPacket;
       ReturnValue_t result =
           modeCommandPacket.deSerialize(&tcData, &tcDataLen, SerializeIF::Endianness::BIG);
@@ -60,9 +64,22 @@ ReturnValue_t CService200ModeCommanding::prepareCommand(CommandMessage *message,
         return result;
       }
 
-  ModeMessage::setModeMessage(message, ModeMessage::CMD_MODE_COMMAND, modeCommandPacket.getMode(),
+      ModeMessage::setModeMessage(message, ModeMessage::CMD_MODE_COMMAND,
-                              modeCommandPacket.getSubmode());
+                                  modeCommandPacket.getMode(), modeCommandPacket.getSubmode());
-  return result;
+      return returnvalue::OK;
+    }
+    case (Subservice::COMMAND_MODE_ANNOUNCE_RECURSIVELY):
+      recursive = true;
+      [[fallthrough]];
+    case (Subservice::COMMAND_MODE_ANNOUNCE):
+      ModeMessage::setModeAnnounceMessage(*message, recursive);
+      return EXECUTION_COMPLETE;
+    case (Subservice::COMMAND_MODE_READ):
+      ModeMessage::setModeReadMessage(*message);
+      return returnvalue::OK;
+    default:
+      return CommandingServiceBase::INVALID_SUBSERVICE;
+  }
 }
 
 ReturnValue_t CService200ModeCommanding::handleReply(const CommandMessage *reply,
@@ -73,8 +90,10 @@ ReturnValue_t CService200ModeCommanding::handleReply(const CommandMessage *reply
   ReturnValue_t result = returnvalue::FAILED;
   switch (replyId) {
     case (ModeMessage::REPLY_MODE_REPLY): {
-      result = prepareModeReply(reply, objectId);
+      if (previousCommand != ModeMessage::CMD_MODE_COMMAND) {
-      break;
+        return prepareModeReply(reply, objectId);
+      }
+      return returnvalue::OK;
     }
     case (ModeMessage::REPLY_WRONG_MODE_REPLY): {
       result = prepareWrongModeReply(reply, objectId);

src/fsfw/pus/CService200ModeCommanding.h

@@ -52,7 +52,7 @@ class CService200ModeCommanding : public CommandingServiceBase {
     COMMAND_MODE_READ = 3,
     //!< [EXPORT] : [COMMAND] Trigger an ModeInfo Event.
     //! This command does NOT have a reply
-    COMMAND_MODE_ANNCOUNCE = 4,
+    COMMAND_MODE_ANNOUNCE = 4,
     //!< [EXPORT] : [COMMAND] Trigger a ModeInfo Event and to send this
     //! command to every child. This command does NOT have a reply.
     COMMAND_MODE_ANNOUNCE_RECURSIVELY = 5,

src/fsfw/pus/CService201HealthCommanding.cpp

@@ -1,106 +0,0 @@
-#include "fsfw/pus/CService201HealthCommanding.h"
-
-#include "fsfw/health/HasHealthIF.h"
-#include "fsfw/health/HealthMessage.h"
-#include "fsfw/objectmanager/ObjectManager.h"
-#include "fsfw/pus/servicepackets/Service201Packets.h"
-#include "fsfw/serviceinterface/ServiceInterface.h"
-
-CService201HealthCommanding::CService201HealthCommanding(object_id_t objectId, uint16_t apid,
-                                                         uint8_t serviceId,
-                                                         uint8_t numParallelCommands,
-                                                         uint16_t commandTimeoutSeconds)
-    : CommandingServiceBase(objectId, apid, "PUS 201 Health MGMT", serviceId, numParallelCommands,
-                            commandTimeoutSeconds) {}
-
-ReturnValue_t CService201HealthCommanding::isValidSubservice(uint8_t subservice) {
-  switch (subservice) {
-    case (Subservice::COMMAND_SET_HEALTH):
-    case (Subservice::COMMAND_ANNOUNCE_HEALTH):
-    case (Subservice::COMMAND_ANNOUNCE_HEALTH_ALL):
-      return returnvalue::OK;
-    default:
-#if FSFW_CPP_OSTREAM_ENABLED == 1
-      sif::error << "Invalid Subservice" << std::endl;
-#endif
-      return AcceptsTelecommandsIF::INVALID_SUBSERVICE;
-  }
-}
-
-ReturnValue_t CService201HealthCommanding::getMessageQueueAndObject(uint8_t subservice,
-                                                                    const uint8_t *tcData,
-                                                                    size_t tcDataLen,
-                                                                    MessageQueueId_t *id,
-                                                                    object_id_t *objectId) {
-  if (tcDataLen < sizeof(object_id_t)) {
-    return CommandingServiceBase::INVALID_TC;
-  }
-  SerializeAdapter::deSerialize(objectId, &tcData, &tcDataLen, SerializeIF::Endianness::BIG);
-
-  return checkInterfaceAndAcquireMessageQueue(id, objectId);
-}
-
-ReturnValue_t CService201HealthCommanding::checkInterfaceAndAcquireMessageQueue(
-    MessageQueueId_t *messageQueueToSet, const object_id_t *objectId) {
-  auto *destination = ObjectManager::instance()->get<HasHealthIF>(*objectId);
-  if (destination == nullptr) {
-    return CommandingServiceBase::INVALID_OBJECT;
-  }
-
-  *messageQueueToSet = destination->getCommandQueue();
-  return returnvalue::OK;
-}
-
-ReturnValue_t CService201HealthCommanding::prepareCommand(CommandMessage *message,
-                                                          uint8_t subservice, const uint8_t *tcData,
-                                                          size_t tcDataLen, uint32_t *state,
-                                                          object_id_t objectId) {
-  ReturnValue_t result = returnvalue::OK;
-  switch (subservice) {
-    case (Subservice::COMMAND_SET_HEALTH): {
-      HealthSetCommand healthCommand;
-      result = healthCommand.deSerialize(&tcData, &tcDataLen, SerializeIF::Endianness::BIG);
-      if (result != returnvalue::OK) {
-        break;
-      }
-      HealthMessage::setHealthMessage(message, HealthMessage::HEALTH_SET,
-                                      healthCommand.getHealth());
-      break;
-    }
-    case (Subservice::COMMAND_ANNOUNCE_HEALTH): {
-      HealthMessage::setHealthMessage(message, HealthMessage::HEALTH_ANNOUNCE);
-      break;
-    }
-    case (Subservice::COMMAND_ANNOUNCE_HEALTH_ALL): {
-      HealthMessage::setHealthMessage(message, HealthMessage::HEALTH_ANNOUNCE_ALL);
-      break;
-    }
-    default: {
-      // Should never happen, subservice was already checked
-      result = returnvalue::FAILED;
-    }
-  }
-  return result;
-}
-
-ReturnValue_t CService201HealthCommanding::handleReply(const CommandMessage *reply,
-                                                       Command_t previousCommand, uint32_t *state,
-                                                       CommandMessage *optionalNextCommand,
-                                                       object_id_t objectId, bool *isStep) {
-  Command_t replyId = reply->getCommand();
-  if (replyId == HealthMessage::REPLY_HEALTH_SET) {
-    return EXECUTION_COMPLETE;
-  } else if (replyId == CommandMessageIF::REPLY_REJECTED) {
-    return reply->getReplyRejectedReason();
-  }
-  return CommandingServiceBase::INVALID_REPLY;
-}
-
-// Not used for now, health state already reported by event
-[[maybe_unused]] ReturnValue_t CService201HealthCommanding::prepareHealthSetReply(
-    const CommandMessage *reply) {
-  auto health = static_cast<uint8_t>(HealthMessage::getHealth(reply));
-  auto oldHealth = static_cast<uint8_t>(HealthMessage::getOldHealth(reply));
-  HealthSetReply healthSetReply(health, oldHealth);
-  return sendTmPacket(Subservice::REPLY_HEALTH_SET, healthSetReply);
-}

src/fsfw/pus/CServiceHealthCommanding.cpp

@@ -0,0 +1,158 @@
+#include <fsfw/events/EventManagerIF.h>
+#include <fsfw/pus/CServiceHealthCommanding.h>
+
+#include "fsfw/health/HasHealthIF.h"
+#include "fsfw/health/HealthMessage.h"
+#include "fsfw/objectmanager/ObjectManager.h"
+#include "fsfw/pus/servicepackets/Service201Packets.h"
+#include "fsfw/serviceinterface/ServiceInterface.h"
+
+CServiceHealthCommanding::CServiceHealthCommanding(HealthServiceCfg args)
+    : CommandingServiceBase(args.objectId, args.apid, "PUS 201 Health MGMT", args.service,
+                            args.numParallelCommands, args.commandTimeoutSeconds),
+      healthTableId(args.table),
+      maxNumHealthInfoPerCycle(args.maxNumHealthInfoPerCycle) {}
+
+ReturnValue_t CServiceHealthCommanding::initialize() {
+  ReturnValue_t result = CommandingServiceBase::initialize();
+  if (result != returnvalue::OK) {
+    return result;
+  }
+
+  healthTable = ObjectManager::instance()->get<HealthTable>(healthTableId);
+  if (healthTable == nullptr) {
+    return returnvalue::FAILED;
+  }
+
+  return returnvalue::OK;
+}
+
+ReturnValue_t CServiceHealthCommanding::isValidSubservice(uint8_t subservice) {
+  switch (subservice) {
+    case (Subservice::COMMAND_SET_HEALTH):
+    case (Subservice::COMMAND_ANNOUNCE_HEALTH):
+    case (Subservice::COMMAND_ANNOUNCE_HEALTH_ALL):
+      return returnvalue::OK;
+    default:
+#if FSFW_CPP_OSTREAM_ENABLED == 1
+      sif::error << "Invalid Subservice" << std::endl;
+#endif
+      return AcceptsTelecommandsIF::INVALID_SUBSERVICE;
+  }
+}
+
+ReturnValue_t CServiceHealthCommanding::getMessageQueueAndObject(uint8_t subservice,
+                                                                 const uint8_t *tcData,
+                                                                 size_t tcDataLen,
+                                                                 MessageQueueId_t *id,
+                                                                 object_id_t *objectId) {
+  switch (subservice) {
+    case (Subservice::COMMAND_SET_HEALTH):
+    case (Subservice::COMMAND_ANNOUNCE_HEALTH): {
+      if (tcDataLen < sizeof(object_id_t)) {
+        return CommandingServiceBase::INVALID_TC;
+      }
+      SerializeAdapter::deSerialize(objectId, &tcData, &tcDataLen, SerializeIF::Endianness::BIG);
+
+      return checkInterfaceAndAcquireMessageQueue(id, objectId);
+    }
+    case (Subservice::COMMAND_ANNOUNCE_HEALTH_ALL): {
+      return returnvalue::OK;
+    }
+    default: {
+      return returnvalue::FAILED;
+    }
+  }
+}
+
+ReturnValue_t CServiceHealthCommanding::checkInterfaceAndAcquireMessageQueue(
+    MessageQueueId_t *messageQueueToSet, const object_id_t *objectId) {
+  auto *destination = ObjectManager::instance()->get<HasHealthIF>(*objectId);
+  if (destination == nullptr) {
+    return CommandingServiceBase::INVALID_OBJECT;
+  }
+
+  *messageQueueToSet = destination->getCommandQueue();
+  return returnvalue::OK;
+}
+
+ReturnValue_t CServiceHealthCommanding::prepareCommand(CommandMessage *message, uint8_t subservice,
+                                                       const uint8_t *tcData, size_t tcDataLen,
+                                                       uint32_t *state, object_id_t objectId) {
+  ReturnValue_t result = returnvalue::OK;
+  switch (subservice) {
+    case (Subservice::COMMAND_SET_HEALTH): {
+      HealthSetCommand healthCommand;
+      result = healthCommand.deSerialize(&tcData, &tcDataLen, SerializeIF::Endianness::BIG);
+      if (result != returnvalue::OK) {
+        break;
+      }
+      HealthMessage::setHealthMessage(message, HealthMessage::HEALTH_SET,
+                                      healthCommand.getHealth());
+      break;
+    }
+    case (Subservice::COMMAND_ANNOUNCE_HEALTH): {
+      HealthMessage::setHealthMessage(message, HealthMessage::HEALTH_ANNOUNCE);
+      break;
+    }
+    case (Subservice::COMMAND_ANNOUNCE_HEALTH_ALL): {
+      ReturnValue_t result = iterateHealthTable(true);
+      if (result == returnvalue::OK) {
+        reportAllHealth = true;
+        return EXECUTION_COMPLETE;
+      }
+      return result;
+    }
+    default: {
+      // Should never happen, subservice was already checked
+      result = returnvalue::FAILED;
+    }
+  }
+  return result;
+}
+
+ReturnValue_t CServiceHealthCommanding::handleReply(const CommandMessage *reply,
+                                                    Command_t previousCommand, uint32_t *state,
+                                                    CommandMessage *optionalNextCommand,
+                                                    object_id_t objectId, bool *isStep) {
+  Command_t replyId = reply->getCommand();
+  if (replyId == HealthMessage::REPLY_HEALTH_SET) {
+    return EXECUTION_COMPLETE;
+  } else if (replyId == CommandMessageIF::REPLY_REJECTED) {
+    return reply->getReplyRejectedReason();
+  }
+  return CommandingServiceBase::INVALID_REPLY;
+}
+
+void CServiceHealthCommanding::doPeriodicOperation() {
+  if (reportAllHealth) {
+    for (uint8_t i = 0; i < maxNumHealthInfoPerCycle; i++) {
+      ReturnValue_t result = iterateHealthTable(false);
+      if (result != returnvalue::OK) {
+        reportAllHealth = false;
+        break;
+      }
+    }
+  }
+}
+
+// Not used for now, health state already reported by event
+[[maybe_unused]] ReturnValue_t CServiceHealthCommanding::prepareHealthSetReply(
+    const CommandMessage *reply) {
+  auto health = static_cast<uint8_t>(HealthMessage::getHealth(reply));
+  auto oldHealth = static_cast<uint8_t>(HealthMessage::getOldHealth(reply));
+  HealthSetReply healthSetReply(health, oldHealth);
+  return sendTmPacket(Subservice::REPLY_HEALTH_SET, healthSetReply);
+}
+
+ReturnValue_t CServiceHealthCommanding::iterateHealthTable(bool reset) {
+  std::pair<object_id_t, HasHealthIF::HealthState> pair;
+
+  ReturnValue_t result = healthTable->iterate(&pair, reset);
+  if (result != returnvalue::OK) {
+    return result;
+  } else {
+    EventManagerIF::triggerEvent(pair.first, HasHealthIF::HEALTH_INFO, pair.second, pair.second);
+    return returnvalue::OK;
+  }
+}

src/fsfw/pus/CServiceHealthCommanding.h

@@ -1,8 +1,26 @@
 #ifndef FSFW_PUS_CSERVICE201HEALTHCOMMANDING_H_
 #define FSFW_PUS_CSERVICE201HEALTHCOMMANDING_H_
 
+#include <fsfw/health/HealthTable.h>
+
 #include "fsfw/tmtcservices/CommandingServiceBase.h"
 
+struct HealthServiceCfg {
+  HealthServiceCfg(object_id_t objectId, uint16_t apid, object_id_t healthTable,
+                   uint16_t maxNumHealthInfoPerCycle)
+      : objectId(objectId),
+        apid(apid),
+        table(healthTable),
+        maxNumHealthInfoPerCycle(maxNumHealthInfoPerCycle) {}
+  object_id_t objectId;
+  uint16_t apid;
+  object_id_t table;
+  uint16_t maxNumHealthInfoPerCycle;
+  uint8_t service = 201;
+  uint8_t numParallelCommands = 4;
+  uint16_t commandTimeoutSeconds = 60;
+};
+
 /**
  * @brief   Custom PUS service to set health of all objects
  *          implementing hasHealthIF.
@@ -17,11 +35,12 @@
  * child class like this service
  *
  */
-class CService201HealthCommanding : public CommandingServiceBase {
+class CServiceHealthCommanding : public CommandingServiceBase {
  public:
-  CService201HealthCommanding(object_id_t objectId, uint16_t apid, uint8_t serviceId,
+  CServiceHealthCommanding(HealthServiceCfg args);
-                              uint8_t numParallelCommands = 4, uint16_t commandTimeoutSeconds = 60);
+  ~CServiceHealthCommanding() override = default;
-  ~CService201HealthCommanding() override = default;
+
+  ReturnValue_t initialize() override;
 
  protected:
   /* CSB abstract function implementations */
@@ -37,7 +56,14 @@ class CService201HealthCommanding : public CommandingServiceBase {
                             CommandMessage *optionalNextCommand, object_id_t objectId,
                             bool *isStep) override;
 
+  void doPeriodicOperation() override;
+
  private:
+  const object_id_t healthTableId;
+  HealthTable *healthTable;
+  uint16_t maxNumHealthInfoPerCycle = 0;
+  bool reportAllHealth = false;
+  ReturnValue_t iterateHealthTable(bool reset);
   static ReturnValue_t checkInterfaceAndAcquireMessageQueue(MessageQueueId_t *MessageQueueToSet,
                                                             const object_id_t *objectId);
 

src/fsfw/pus/Service1TelecommandVerification.cpp

@@ -13,7 +13,7 @@ Service1TelecommandVerification::Service1TelecommandVerification(object_id_t obj
                                                                  uint16_t messageQueueDepth,
                                                                  TimeWriterIF* timeStamper)
     : SystemObject(objectId),
-      //      apid(apid),
+      apid(apid),
       serviceId(serviceId),
       targetDestination(targetDestination),
       storeHelper(apid),

src/fsfw/pus/Service1TelecommandVerification.h

@@ -72,7 +72,7 @@ class Service1TelecommandVerification : public AcceptsVerifyMessageIF,
   ReturnValue_t initialize() override;
 
  private:
-  // uint16_t apid = 0;
+  uint16_t apid = 0;
   uint8_t serviceId = 0;
 
   object_id_t targetDestination = objects::NO_OBJECT;

src/fsfw/pus/servicepackets/Service1Packets.h

@@ -69,7 +69,7 @@ class FailureReport : public SerializeIF {  //!< [EXPORT] : [SUBSERVICE] 2, 4, 6
     return result;
   }
 
-  virtual size_t getSerializedSize() const override {
+  virtual size_t getSerializedSize() const {
     size_t size = 0;
     size += SerializeAdapter::getSerializedSize(&packetId);
     size += sizeof(packetSequenceControl);

src/fsfw/serialize/SerialBufferAdapter.cpp

@@ -20,6 +20,9 @@ SerialBufferAdapter<count_t>::SerialBufferAdapter(uint8_t* buffer, count_t buffe
       buffer(buffer),
       bufferLength(bufferLength) {}
 
+template <typename count_t>
+SerialBufferAdapter<count_t>::~SerialBufferAdapter() = default;
+
 template <typename count_t>
 ReturnValue_t SerialBufferAdapter<count_t>::serialize(uint8_t** buffer_, size_t* size,
                                                       size_t maxSize,

src/fsfw/serialize/SerialBufferAdapter.h

@@ -41,7 +41,7 @@ class SerialBufferAdapter : public SerializeIF {
    */
   SerialBufferAdapter(uint8_t* buffer, count_t bufferLength, bool serializeLength = false);
 
-  ~SerialBufferAdapter() override = default;
+  ~SerialBufferAdapter() override;
 
   ReturnValue_t serialize(uint8_t** buffer, size_t* size, size_t maxSize,
                           Endianness streamEndianness) const override;
@@ -74,10 +74,4 @@ class SerialBufferAdapter : public SerializeIF {
   count_t bufferLength = 0;
 };
 
-// declaration of explicit instantiations (which are in the cpp)
-extern template class SerialBufferAdapter<uint8_t>;
-extern template class SerialBufferAdapter<uint16_t>;
-extern template class SerialBufferAdapter<uint32_t>;
-extern template class SerialBufferAdapter<uint64_t>;
-
 #endif /* SERIALBUFFERADAPTER_H_ */

src/fsfw/serialize/SerialLinkedListAdapter.h

@@ -33,7 +33,7 @@
  * @author baetz
  * @ingroup serialize
  */
-template <typename T, typename count_t = size_t>
+template <typename T, typename count_t = uint8_t>
 class SerialLinkedListAdapter : public SinglyLinkedList<T>, public SerializeIF {
  public:
   SerialLinkedListAdapter(typename LinkedElement<T>::Iterator start, bool printCount = false)

src/fsfw/serialize/SerializeIF.h

@@ -35,12 +35,6 @@ class SerializeIF {
       MAKE_RETURN_CODE(3);  // !< There are too many elements to be deserialized
 
   virtual ~SerializeIF() = default;
-  // C++11 deprecates automatic generation of copy ctor and assignment operator when
-  // a destructor is defined, so we need to explicitely set them to default
-  SerializeIF(const SerializeIF&) = default;
-  SerializeIF() = default;
-  SerializeIF& operator= ( const SerializeIF & ) = default;
-
   /**
    * @brief
    * Function to serialize the object into a buffer with maxSize. Size represents the written

src/fsfw/storagemanager/LocalPool.cpp

@@ -109,8 +109,7 @@ ReturnValue_t LocalPool::deleteData(uint8_t* ptr, size_t size, store_address_t*
   ReturnValue_t result = ILLEGAL_ADDRESS;
   for (uint16_t n = 0; n < NUMBER_OF_SUBPOOLS; n++) {
     // Not sure if new allocates all stores in order. so better be careful.
-    if ((store[n].data() <= ptr) and
+    if ((store[n].data() <= ptr) and (&store[n][numberOfElements[n] * elementSizes[n]] > ptr)) {
-        (&store[n][numberOfElements[n] * elementSizes[n] - 1] >= ptr)) {
       localId.poolIndex = n;
       uint32_t deltaAddress = ptr - store[n].data();
       // Getting any data from the right "block" is ok.

src/fsfw/storagemanager/storeAddress.h

@@ -22,7 +22,7 @@ union store_address_t {
    */
   explicit store_address_t(uint32_t rawAddress) : raw(rawAddress) {}
 
-  static store_address_t invalid() { return {}; }
+  static store_address_t invalid() { return {}; };
 
   /**
    * Constructor to create an address object using pool

src/fsfw/subsystem/Subsystem.cpp

@@ -91,10 +91,11 @@ void Subsystem::performChildOperation() {
       }
       if (currentSequenceIterator->getWaitSeconds() != 0) {
         if (uptimeStartTable == 0) {
-          uptimeStartTable = Clock::getUptime_ms();
+          Clock::getUptime(&uptimeStartTable);
           return;
         } else {
-          uint32_t uptimeNow = Clock::getUptime_ms();
+          uint32_t uptimeNow;
+          Clock::getUptime(&uptimeNow);
           if ((uptimeNow - uptimeStartTable) < (currentSequenceIterator->getWaitSeconds() * 1000)) {
             return;
           }
@@ -585,12 +586,7 @@ void Subsystem::sendSerializablesAsCommandMessage(Command_t command, SerializeIF
     return;
   }
   for (uint8_t i = 0; i < count; i++) {
-    result = elements[i]->serialize(&storeBuffer, &size, maxSize, SerializeIF::Endianness::BIG);
+    elements[i]->serialize(&storeBuffer, &size, maxSize, SerializeIF::Endianness::BIG);
-    if (result != returnvalue::OK) {
-      replyToCommand(result, 0);
-      IPCStore->deleteData(address);
-      return;
-    }
   }
   CommandMessage reply;
   ModeSequenceMessage::setModeSequenceMessage(&reply, command, address);

src/fsfw/tasks/ExecutableObjectIF.h

@@ -34,7 +34,7 @@ class ExecutableObjectIF {
    * a reference to the executing task
    * @param task_ Pointer to the taskIF of this task
    */
-  virtual void setTaskIF(PeriodicTaskIF* task_){}
+  virtual void setTaskIF(PeriodicTaskIF* task_){};
 
   /**
    * This function should be called after the object was assigned to a

src/fsfw/tasks/FixedTimeslotTaskBase.h

@@ -9,6 +9,7 @@ class FixedTimeslotTaskBase : public FixedTimeslotTaskIF {
  public:
   explicit FixedTimeslotTaskBase(TaskPeriod period, TaskDeadlineMissedFunction dlmFunc = nullptr);
   ~FixedTimeslotTaskBase() override = default;
+  ;
 
  protected:
   /**

src/fsfw/thermal/Heater.cpp

@@ -196,11 +196,12 @@ void Heater::setSwitch(uint8_t number, ReturnValue_t state, uint32_t* uptimeOfSw
   if (powerSwitcher->getSwitchState(number) == state) {
     *uptimeOfSwitching = INVALID_UPTIME;
   } else {
-    if (*uptimeOfSwitching == INVALID_UPTIME) {
+    if ((*uptimeOfSwitching == INVALID_UPTIME)) {
       powerSwitcher->sendSwitchCommand(number, state);
-      *uptimeOfSwitching = Clock::getUptime_ms();
+      Clock::getUptime(uptimeOfSwitching);
     } else {
-      uint32_t currentUptime = Clock::getUptime_ms();
+      uint32_t currentUptime;
+      Clock::getUptime(&currentUptime);
       if (currentUptime - *uptimeOfSwitching > powerSwitcher->getSwitchDelayMs()) {
         *uptimeOfSwitching = INVALID_UPTIME;
         if (healthHelper.healthTable->isHealthy(getObjectId())) {

src/fsfw/timemanager/CCSDSTime.cpp

@@ -552,7 +552,10 @@ ReturnValue_t CCSDSTime::convertFromCDS(timeval* to, const CCSDSTime::CDS_short*
   if (to == nullptr or from == nullptr) {
     return returnvalue::FAILED;
   }
-  int32_t days = (from->dayMSB << 8) + from->dayLSB;
+  uint16_t days = (from->dayMSB << 8) + from->dayLSB;
+  if (days <= DAYS_CCSDS_TO_UNIX_EPOCH) {
+    return INVALID_TIME_FORMAT;
+  }
   days -= DAYS_CCSDS_TO_UNIX_EPOCH;
   to->tv_sec = days * SECONDS_PER_DAY;
   uint32_t msDay =

src/fsfw/timemanager/CMakeLists.txt

@@ -1,9 +1,4 @@
 target_sources(
   ${LIB_FSFW_NAME}
-  PRIVATE CCSDSTime.cpp
+  PRIVATE CCSDSTime.cpp Countdown.cpp Stopwatch.cpp TimeMessage.cpp
-          Countdown.cpp
+          CdsShortTimeStamper.cpp ClockCommon.cpp)
-          Stopwatch.cpp
-          TimeMessage.cpp
-          CdsShortTimeStamper.cpp
-          ClockCommon.cpp
-          boost_timegm.cpp)

src/fsfw/timemanager/CdsShortTimeStamper.cpp

@@ -4,6 +4,8 @@
 
 #include "fsfw/timemanager/Clock.h"
 
+CdsShortTimeStamper::CdsShortTimeStamper() : SystemObject(0, false) {}
+
 CdsShortTimeStamper::CdsShortTimeStamper(object_id_t objectId) : SystemObject(objectId) {}
 
 ReturnValue_t CdsShortTimeStamper::serialize(uint8_t **buffer, size_t *size, size_t maxSize,

src/fsfw/timemanager/CdsShortTimeStamper.h

@@ -18,6 +18,7 @@
 class CdsShortTimeStamper : public TimeWriterIF, public TimeReaderIF, public SystemObject {
  public:
   static constexpr size_t TIMESTAMP_LEN = 7;
+  CdsShortTimeStamper();
   /**
    * @brief   Default constructor which also registers the time stamper as a
    *          system object so it can be found with the #objectManager.

src/fsfw/timemanager/Clock.h

@@ -16,7 +16,6 @@
 
 class Clock {
  public:
-  // https://xkcd.com/927/
   typedef struct {
     uint32_t year;     //!< Year, A.D.
     uint32_t month;    //!< Month, 1 .. 12.
@@ -27,6 +26,14 @@ class Clock {
     uint32_t usecond;  //!< Microseconds, 0 .. 999999
   } TimeOfDay_t;
 
+  /**
+   * This method returns the number of clock ticks per second.
+   * In RTEMS, this is typically 1000.
+   * @return	The number of ticks.
+   *
+   * @deprecated, we should not worry about ticks, but only time
+   */
+  static uint32_t getTicksPerSecond();
   /**
    * This system call sets the system time.
    * To set the time, it uses a TimeOfDay_t struct.
@@ -54,8 +61,13 @@ class Clock {
   /**
    * Get the time since boot in a timeval struct
    *
-   * @return a timeval struct where the uptime is stored
+   * @param[out] time A pointer to a timeval struct where the uptime is stored.
+   * @return @c returnvalue::OK on success. Otherwise, the OS failure code is returned.
+   *
+   * @deprecated, I do not think this should be able to fail, use timeval getUptime()
    */
+  static ReturnValue_t getUptime(timeval *uptime);
+
   static timeval getUptime();
 
   /**
@@ -67,7 +79,7 @@ class Clock {
    * @param ms uptime in ms
    * @return returnvalue::OK on success. Otherwise, the OS failure code is returned.
    */
-  static uint32_t getUptime_ms();
+  static ReturnValue_t getUptime(uint32_t *uptimeMs);
 
   /**
    * Returns the time in microseconds since an OS-defined epoch.
@@ -78,7 +90,6 @@ class Clock {
    *  - Otherwise, the OS failure code is returned.
    */
   static ReturnValue_t getClock_usecs(uint64_t *time);
-
   /**
    * Returns the time in a TimeOfDay_t struct.
    * @param time A pointer to a TimeOfDay_t struct.
@@ -95,7 +106,6 @@ class Clock {
    * @return
    */
   static ReturnValue_t convertTimevalToTimeOfDay(const timeval *from, TimeOfDay_t *to);
-
   /**
    * Converts a time of day struct to POSIX seconds.
    * @param time The time of day as input

src/fsfw/timemanager/ClockCommon.cpp

@@ -1,7 +1,5 @@
-#include <cstdlib>
 #include <ctime>
 
-#include "boost_timegm.h"
 #include "fsfw/ipc/MutexGuard.h"
 #include "fsfw/timemanager/Clock.h"
 
@@ -55,58 +53,34 @@ ReturnValue_t Clock::getLeapSeconds(uint16_t* leapSeconds_) {
 }
 
 ReturnValue_t Clock::convertTimevalToTimeOfDay(const timeval* from, TimeOfDay_t* to) {
-  struct tm time_tm;
+  struct tm* timeInfo;
-  // WINDOWS does not provide gmtime_r, but gmtime_s
+  // According to https://en.cppreference.com/w/c/chrono/gmtime, the implementation of gmtime_s
-#ifdef _MSC_VER
+  // in the Windows CRT is incompatible with the C standard but this should not be an issue for
-  time_t seconds = from->tv_sec;
+  // this implementation
-  errno_t result = gmtime_s(&time_tm, &seconds);
+  ReturnValue_t result = checkOrCreateClockMutex();
-  if (result != 0) {
+  if (result != returnvalue::OK) {
-    return returnvalue::FAILED;
+    return result;
   }
+  // gmtime writes its output in a global buffer which is not Thread Safe
+  // Therefore we have to use a Mutex here
+  MutexGuard helper(timeMutex);
+#ifdef PLATFORM_WIN
+  time_t time;
+  time = from->tv_sec;
+  timeInfo = gmtime(&time);
 #else
-  void* result = gmtime_r(&from->tv_sec, &time_tm);
+  timeInfo = gmtime(&from->tv_sec);
-
-  if (result == nullptr) {
-    return returnvalue::FAILED;
-  }
 #endif
-
+  to->year = timeInfo->tm_year + 1900;
-  to->year = time_tm.tm_year + 1900;
+  to->month = timeInfo->tm_mon + 1;
-  to->month = time_tm.tm_mon + 1;
+  to->day = timeInfo->tm_mday;
-  to->day = time_tm.tm_mday;
+  to->hour = timeInfo->tm_hour;
-  to->hour = time_tm.tm_hour;
+  to->minute = timeInfo->tm_min;
-  to->minute = time_tm.tm_min;
+  to->second = timeInfo->tm_sec;
-  to->second = time_tm.tm_sec;
   to->usecond = from->tv_usec;
   return returnvalue::OK;
 }
 
-ReturnValue_t Clock::convertTimeOfDayToTimeval(const TimeOfDay_t* from, timeval* to) {
-  struct tm time_tm = {};
-
-  time_tm.tm_year = from->year - 1900;
-  time_tm.tm_mon = from->month - 1;
-  time_tm.tm_mday = from->day;
-
-  time_tm.tm_hour = from->hour;
-  time_tm.tm_min = from->minute;
-  time_tm.tm_sec = from->second;
-
-  time_tm.tm_isdst = 0;
-
-  time_t seconds = internal_timegm(&time_tm);
-
-  to->tv_sec = seconds;
-  to->tv_usec = from->usecond;
-
-  return returnvalue::OK;
-}
-
-ReturnValue_t Clock::convertTimevalToJD2000(timeval time, double* JD2000) {
-  *JD2000 = (time.tv_sec - 946728000. + time.tv_usec / 1000000.) / 24. / 3600.;
-  return returnvalue::OK;
-}
-
 ReturnValue_t Clock::checkOrCreateClockMutex() {
   if (timeMutex == nullptr) {
     MutexFactory* mutexFactory = MutexFactory::instance();
@@ -120,37 +94,3 @@ ReturnValue_t Clock::checkOrCreateClockMutex() {
   }
   return returnvalue::OK;
 }
-
-ReturnValue_t Clock::getDateAndTime(TimeOfDay_t* time) {
-  timeval time_timeval;
-  ReturnValue_t result = getClock_timeval(&time_timeval);
-  if (result != returnvalue::OK) {
-    return result;
-  }
-  return convertTimevalToTimeOfDay(&time_timeval, time);
-}
-
-ReturnValue_t Clock::getClock_usecs(uint64_t* time) {
-  timeval timeVal{};
-  ReturnValue_t result = getClock_timeval(&timeVal);
-  if (result != returnvalue::OK) {
-    return result;
-  }
-  *time = static_cast<uint64_t>(timeVal.tv_sec) * 1e6 + timeVal.tv_usec;
-
-  return returnvalue::OK;
-}
-
-ReturnValue_t Clock::setClock(const TimeOfDay_t* time) {
-  timeval timeTimeval{};
-  ReturnValue_t result = convertTimeOfDayToTimeval(time, &timeTimeval);
-  if (result != returnvalue::OK) {
-    return result;
-  }
-  return setClock(&timeTimeval);
-}
-uint32_t Clock::getUptime_ms() {
-  timeval uptime = getUptime();
-  // TODO verify that overflow is correct
-  return uptime.tv_sec * 1e3 + uptime.tv_usec / 1e3;
-}

src/fsfw/timemanager/Countdown.cpp

@@ -7,9 +7,9 @@ Countdown::Countdown(uint32_t initialTimeout) : timeout(initialTimeout) {
 Countdown::~Countdown() {}
 
 ReturnValue_t Countdown::setTimeout(uint32_t milliseconds) {
-  startTime = Clock::getUptime_ms();
+  ReturnValue_t returnValue = Clock::getUptime(&startTime);
   timeout = milliseconds;
-  return returnvalue::OK;
+  return returnValue;
 }
 
 bool Countdown::hasTimedOut() const {
@@ -38,4 +38,8 @@ uint32_t Countdown::getRemainingMillis() const {
   }
 }
 
-uint32_t Countdown::getCurrentTime() const { return Clock::getUptime_ms(); }
+uint32_t Countdown::getCurrentTime() const {
+  uint32_t currentTime;
+  Clock::getUptime(&currentTime);
+  return currentTime;
+}

src/fsfw/timemanager/Stopwatch.cpp

@@ -9,10 +9,10 @@
 Stopwatch::Stopwatch(bool displayOnDestruction, StopwatchDisplayMode displayMode)
     : displayOnDestruction(displayOnDestruction), displayMode(displayMode) {
   // Measures start time on initialization.
-  startTime = Clock::getUptime();
+  Clock::getUptime(&startTime);
 }
 
-void Stopwatch::start() { startTime = Clock::getUptime(); }
+void Stopwatch::start() { Clock::getUptime(&startTime); }
 
 dur_millis_t Stopwatch::stop(bool display) {
   stopInternal();
@@ -62,6 +62,7 @@ void Stopwatch::setDisplayMode(StopwatchDisplayMode displayMode) {
 StopwatchDisplayMode Stopwatch::getDisplayMode() const { return displayMode; }
 
 void Stopwatch::stopInternal() {
-  timeval endTime = Clock::getUptime();
+  timeval endTime;
+  Clock::getUptime(&endTime);
   elapsedTime = endTime - startTime;
 }

src/fsfw/timemanager/TimeReaderIF.h

@@ -3,17 +3,12 @@
 
 #include <cstdio>
 #include <cstdlib>
-#include <ctime>
 
 #include "fsfw/platform.h"
 
 #ifdef PLATFORM_WIN
 // wtf? Required for timeval!
-// Thanks, windows
-// clang-format off
-#include <winsock2.h>
 #include <winsock.h>
-// clang-format off
 #endif
 
 #include "TimeStampIF.h"

src/fsfw/timemanager/boost_timegm.cpp

@@ -1,66 +0,0 @@
-//  (C) Copyright Howard Hinnant
-//  (C) Copyright 2010-2011 Vicente J. Botet Escriba
-//  Use, modification and distribution are subject to the Boost Software License,
-//  Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at
-//  http://www.boost.org/LICENSE_1_0.txt).
-
-//===-------------------------- locale ------------------------------------===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is dual licensed under the MIT and the University of Illinois Open
-// Source Licenses. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-// This code was adapted by Vicente from Howard Hinnant's experimental work
-// on chrono i/o to Boost and some functions from libc++/locale to emulate the missing
-// time_get::get()
-
-#include "boost_timegm.h"
-
-#include <cstdint>
-
-int32_t is_leap(int32_t year) {
-  if (year % 400 == 0) return 1;
-  if (year % 100 == 0) return 0;
-  if (year % 4 == 0) return 1;
-  return 0;
-}
-int32_t days_from_0(int32_t year) {
-  year--;
-  return 365 * year + (year / 400) - (year / 100) + (year / 4);
-}
-int32_t days_from_1970(int32_t year) {
-  static const int32_t days_from_0_to_1970 = days_from_0(1970);
-  return days_from_0(year) - days_from_0_to_1970;
-}
-int32_t days_from_1jan(int32_t year, int32_t month, int32_t day) {
-  static const int32_t days[2][12] = {{0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334},
-                                      {0, 31, 60, 91, 121, 152, 182, 213, 244, 274, 305, 335}};
-
-  return days[is_leap(year)][month - 1] + day - 1;
-}
-
-time_t internal_timegm(std::tm const *t) {
-  int year = t->tm_year + 1900;
-  int month = t->tm_mon;
-  if (month > 11) {
-    year += month / 12;
-    month %= 12;
-  } else if (month < 0) {
-    int years_diff = (-month + 11) / 12;
-    year -= years_diff;
-    month += 12 * years_diff;
-  }
-  month++;
-  int day = t->tm_mday;
-  int day_of_year = days_from_1jan(year, month, day);
-  int days_since_epoch = days_from_1970(year) + day_of_year;
-
-  time_t seconds_in_day = 3600 * 24;
-  time_t result =
-      seconds_in_day * days_since_epoch + 3600 * t->tm_hour + 60 * t->tm_min + t->tm_sec;
-
-  return result;
-}