Merge pull request 'action reply update' (#299) from small-action-reply-update into main

Reviewed-on: #299
Reviewed-by: Marius Eggert <eggertm@irs.uni-stuttgart.de>

CHANGELOG.md

@@ -10,6 +10,14 @@ list yields a list of all related PRs for each release.
 
 # [unreleased]
 
+# [v7.0.0] 2024-05-06
+
+- Reworked PLOC MPSoC commanding to be inline with OBSW update.
+
+## Fixed
+
+- GNSS commands working again (again).
+
 ## Added
 
 - Added handling for new clock events.

eive_tmtc/cfdp/handler.py

@@ -62,13 +62,7 @@ class CfdpHandler:
         )
 
     def put_request(self, request: PutRequest):
-        if not self.remote_cfg_table.get_cfg(request.destination_id):
+        self.source_handler.put_request(request)
-            raise ValueError(
-                f"No remote CFDP config found for entity ID {request.destination_id}"
-            )
-        self.source_handler.put_request(
-            request, self.remote_cfg_table.get_cfg(request.destination_id)  # type: ignore
-        )
 
     def pull_next_source_packet(self) -> Optional[PduHolder]:
         res = self.source_handler.state_machine()

eive_tmtc/config/definitions.py

@@ -17,6 +17,7 @@ TM_DB_PATH = "tm.db"
 
 # TODO: The cleanest way would be to load those from the config file..
 PRINT_RAW_HK_B64_STR = False
+PRINT_RAW_ACTION_DATA_REPLY_B64_STR = True
 PRINT_RAW_EVENTS_B64_STR = False
 
 PUS_APID = 0x65

eive_tmtc/config/events.csv

@@ -128,14 +128,15 @@ Event ID (dec); Event ID (hex); Name; Severity; Description; File Path
 11506;0x2cf2;DEPL_SA1_GPIO_SWTICH_OFF_FAILED;HIGH;No description;mission/SolarArrayDeploymentHandler.h
 11507;0x2cf3;DEPL_SA2_GPIO_SWTICH_OFF_FAILED;HIGH;No description;mission/SolarArrayDeploymentHandler.h
 11508;0x2cf4;AUTONOMOUS_DEPLOYMENT_COMPLETED;INFO;No description;mission/SolarArrayDeploymentHandler.h
-11601;0x2d51;MEMORY_READ_RPT_CRC_FAILURE;LOW;PLOC crc failure in telemetry packet;linux/payload/PlocMpsocHandler.h
+11601;0x2d51;MEMORY_READ_RPT_CRC_FAILURE;LOW;PLOC crc failure in telemetry packet;linux/payload/plocMpsocHelpers.h
-11602;0x2d52;ACK_FAILURE;LOW;PLOC receive acknowledgment failure report P1: Command Id which leads the acknowledgment failure report P2: The status field inserted by the MPSoC into the data field;linux/payload/PlocMpsocHandler.h
+11602;0x2d52;ACK_FAILURE;LOW;PLOC receive acknowledgment failure report P1: Command Id which leads the acknowledgment failure report P2: The status field inserted by the MPSoC into the data field;linux/payload/plocMpsocHelpers.h
-11603;0x2d53;EXE_FAILURE;LOW;PLOC receive execution failure report P1: Command Id which leads the execution failure report P2: The status field inserted by the MPSoC into the data field;linux/payload/PlocMpsocHandler.h
+11603;0x2d53;EXE_FAILURE;LOW;PLOC receive execution failure report P1: Command Id which leads the execution failure report P2: The status field inserted by the MPSoC into the data field;linux/payload/plocMpsocHelpers.h
-11604;0x2d54;MPSOC_HANDLER_CRC_FAILURE;LOW;PLOC reply has invalid crc;linux/payload/PlocMpsocHandler.h
+11604;0x2d54;MPSOC_HANDLER_CRC_FAILURE;LOW;PLOC reply has invalid crc;linux/payload/plocMpsocHelpers.h
-11605;0x2d55;MPSOC_HANDLER_SEQUENCE_COUNT_MISMATCH;LOW;Packet sequence count in received space packet does not match expected count P1: Expected sequence count P2: Received sequence count;linux/payload/PlocMpsocHandler.h
+11605;0x2d55;MPSOC_HANDLER_SEQUENCE_COUNT_MISMATCH;LOW;Packet sequence count in received space packet does not match expected count P1: Expected sequence count P2: Received sequence count;linux/payload/plocMpsocHelpers.h
-11606;0x2d56;MPSOC_SHUTDOWN_FAILED;HIGH;Supervisor fails to shutdown MPSoC. Requires to power off the PLOC and thus also to shutdown the supervisor.;linux/payload/PlocMpsocHandler.h
+11606;0x2d56;MPSOC_SHUTDOWN_FAILED;HIGH;Supervisor fails to shutdown MPSoC. Requires to power off the PLOC and thus also to shutdown the supervisor.;linux/payload/plocMpsocHelpers.h
-11607;0x2d57;SUPV_NOT_ON;LOW;SUPV not on for boot or shutdown process. P1: 0 for OFF transition, 1 for ON transition.;linux/payload/PlocMpsocHandler.h
+11607;0x2d57;SUPV_NOT_ON;LOW;SUPV not on for boot or shutdown process. P1: 0 for OFF transition, 1 for ON transition.;linux/payload/plocMpsocHelpers.h
-11608;0x2d58;SUPV_REPLY_TIMEOUT;LOW;No description;linux/payload/PlocMpsocHandler.h
+11608;0x2d58;SUPV_REPLY_TIMEOUT;LOW;SUPV reply timeout.;linux/payload/plocMpsocHelpers.h
+11609;0x2d59;CAM_MUST_BE_ON_FOR_SNAPSHOT_MODE;LOW;Camera must be commanded on first.;linux/payload/plocMpsocHelpers.h
 11701;0x2db5;SELF_TEST_I2C_FAILURE;LOW;Get self test result returns I2C failure P1: Indicates on which axis the failure occurred. 0 -> INIT, 1 -> +X, 2 -> -X, 3 -> +Y, 4 -> -Y, 5 -> +Z, 6 -> -Z, 7 -> FINA;mission/acs/ImtqHandler.h
 11702;0x2db6;SELF_TEST_SPI_FAILURE;LOW;Get self test result returns SPI failure. This concerns the MTM connectivity. P1: Indicates on which axis the failure occurred. 0 -> INIT, 1 -> +X, 2 -> -X, 3 -> +Y, 4 -> -Y, 5 -> +Z, 6 -> -Z, 7 -> FINA;mission/acs/ImtqHandler.h
 11703;0x2db7;SELF_TEST_ADC_FAILURE;LOW;Get self test result returns failure in measurement of current and temperature. P1: Indicates on which axis the failure occurred. 0 -> INIT, 1 -> +X, 2 -> -X, 3 -> +Y, 4 -> -Y, 5 -> +Z, 6 -> -Z, 7 -> FINA;mission/acs/ImtqHandler.h

eive_tmtc/config/hook.py

@@ -52,7 +52,7 @@ from eive_tmtc.tmtc.wdt import create_wdt_node
 
 class EiveHookObject(HookBase):
     def __init__(self, json_cfg_path: str):
-        super().__init__(json_cfg_path=json_cfg_path)
+        super().__init__(json_cfg_path)
 
     def get_command_definitions(self) -> CmdTreeNode:
         root_node = CmdTreeNode.root_node()

eive_tmtc/config/objects.csv

@@ -56,6 +56,7 @@
 0x44330015;PLOC_MPSOC_HANDLER
 0x44330016;PLOC_SUPERVISOR_HANDLER
 0x44330017;PLOC_SUPERVISOR_HELPER
+0x44330018;PLOC_MPSOC_COMMUNICATION
 0x44330032;SCEX
 0x444100A2;SOLAR_ARRAY_DEPL_HANDLER
 0x444100A4;HEATER_HANDLER

eive_tmtc/config/returnvalues.csv

@@ -561,16 +561,17 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x67a2;SADPL_MainSwitchTimeoutFailure;No description;162;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
 0x67a3;SADPL_SwitchingDeplSa1Failed;No description;163;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
 0x67a4;SADPL_SwitchingDeplSa2Failed;No description;164;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
-0x68a0;MPSOCRTVIF_CrcFailure;Space Packet received from PLOC has invalid CRC;160;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x6810;MPSOCRTVIF_CommandTimeout;Command has timed out.;16;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
-0x68a1;MPSOCRTVIF_ReceivedAckFailure;Received ACK failure reply from PLOC;161;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x68a0;MPSOCRTVIF_CrcFailure;Space Packet received from PLOC has invalid CRC;160;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
-0x68a2;MPSOCRTVIF_ReceivedExeFailure;Received execution failure reply from PLOC;162;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x68a1;MPSOCRTVIF_ReceivedAckFailure;Received ACK failure reply from PLOC;161;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
-0x68a3;MPSOCRTVIF_InvalidApid;Received space packet with invalid APID from PLOC;163;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x68a2;MPSOCRTVIF_ReceivedExeFailure;Received execution failure reply from PLOC;162;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
-0x68a4;MPSOCRTVIF_InvalidLength;Received command with invalid length;164;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x68a3;MPSOCRTVIF_InvalidApid;Received space packet with invalid APID from PLOC;163;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
-0x68a5;MPSOCRTVIF_FilenameTooLong;Filename of file in OBC filesystem is too long;165;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x68a4;MPSOCRTVIF_InvalidLength;Received command with invalid length;164;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
-0x68a6;MPSOCRTVIF_MpsocHelperExecuting;MPSoC helper is currently executing a command;166;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x68a5;MPSOCRTVIF_FilenameTooLong;Filename of file in OBC filesystem is too long;165;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
-0x68a7;MPSOCRTVIF_MpsocFilenameTooLong;Filename of MPSoC file is to long (max. 256 bytes);167;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x68a6;MPSOCRTVIF_MpsocHelperExecuting;MPSoC helper is currently executing a command;166;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
-0x68a8;MPSOCRTVIF_InvalidParameter;Command has invalid parameter;168;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x68a7;MPSOCRTVIF_MpsocFilenameTooLong;Filename of MPSoC file is to long (max. 256 bytes);167;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
-0x68a9;MPSOCRTVIF_NameTooLong;Received command has file string with invalid length;169;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x68a8;MPSOCRTVIF_InvalidParameter;Command has invalid parameter;168;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a9;MPSOCRTVIF_NameTooLong;Received command has file string with invalid length;169;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
 0x69a0;SPVRTVIF_CrcFailure;Space Packet received from PLOC supervisor has invalid CRC;160;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
 0x69a1;SPVRTVIF_InvalidServiceId;No description;161;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
 0x69a2;SPVRTVIF_ReceivedAckFailure;Received ACK failure reply from PLOC supervisor;162;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
@@ -626,4 +627,7 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x6f02;TMS_NoWriteActive;No description;2;TM_SINK;mission/tmtc/DirectTmSinkIF.h
 0x6f03;TMS_Timeout;No description;3;TM_SINK;mission/tmtc/DirectTmSinkIF.h
 0x7000;VCS_ChannelDoesNotExist;No description;0;VIRTUAL_CHANNEL;mission/com/VirtualChannel.h
-0x7200;SCBU_KeyNotFound;No description;0;SCRATCH_BUFFER;bsp_q7s/memory/scratchApi.h
+0x7100;PLMPCOM_PacketReceived;No description;0;PLOC_MPSOC_COM;linux/payload/MpsocCommunication.h
+0x7101;PLMPCOM_FaultyPacketSize;No description;1;PLOC_MPSOC_COM;linux/payload/MpsocCommunication.h
+0x7102;PLMPCOM_CrcCheckFailed;No description;2;PLOC_MPSOC_COM;linux/payload/MpsocCommunication.h
+0x7300;SCBU_KeyNotFound;No description;0;SCRATCH_BUFFER;bsp_q7s/memory/scratchApi.h

eive_tmtc/pus_tc/cmd_demux.py

@@ -227,7 +227,7 @@ def handle_acs_procedure(queue_helper: DefaultPusQueueHelper, cmd_path_list: Lis
                 object_id=RW4_ID, rw_idx=4, q=queue_helper, cmd_str=cmd_path_list[2]
             )
 
-    if cmd_path_list[0] == "gnss_devs":
+    if cmd_path_list[0] == "gnss_ctrl":
         return pack_gps_command(
             object_id=oids.GPS_CONTROLLER, q=queue_helper, cmd_str=cmd_path_list[1]
         )

eive_tmtc/pus_tc/tc_handler.py

@@ -68,8 +68,8 @@ class TcHandler(TcHandlerBase):
 
     def feed_cb(self, info: ProcedureWrapper, wrapper: FeedWrapper):
         self.queue_helper.queue_wrapper = wrapper.queue_wrapper
-        if info.proc_type == TcProcedureType.DEFAULT:
+        if info.proc_type == TcProcedureType.TREE_COMMANDING:
-            handle_pus_procedure(info.to_def_procedure(), self.queue_helper)
+            handle_pus_procedure(info.to_tree_commanding_procedure(), self.queue_helper)
         elif info.proc_type == TcProcedureType.CFDP:
             self.handle_cfdp_procedure(info)
 
@@ -155,7 +155,7 @@ class TcHandler(TcHandlerBase):
     def queue_finished_cb(self, info: ProcedureWrapper):
         if info is not None:
             if info.proc_type == TcQueueEntryType.PUS_TC:
-                def_proc = info.to_def_procedure()
+                def_proc = info.to_tree_commanding_procedure()
                 _LOGGER.info(f"Finished queue for command {def_proc.cmd_path}")
             elif info.proc_type == TcProcedureType.CFDP:
                 _LOGGER.info("Finished CFDP queue")

eive_tmtc/pus_tm/action_reply_handler.py

@@ -1,5 +1,10 @@
+import base64
 import logging
 import struct
+
+from spacepackets.ecss import PusTm
+from tmtccmd.pus.s8_fsfw_action_defs import CustomSubservice
+from eive_tmtc.config.definitions import PRINT_RAW_ACTION_DATA_REPLY_B64_STR
 from eive_tmtc.config.object_ids import (
     ACU_HANDLER_ID,
     PDU_1_HANDLER_ID,
@@ -20,31 +25,36 @@ from eive_tmtc.tmtc.payload.ploc_supervisor import SupvActionId
 from eive_tmtc.tmtc.acs.star_tracker import handle_star_tracker_action_replies
 from eive_tmtc.tmtc.acs.acs_ctrl import handle_acs_ctrl_action_replies
 from eive_tmtc.tmtc.power.tm import handle_get_param_data_reply
-from tmtccmd.pus.s8_fsfw_action import Service8FsfwTm
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
 from spacepackets.ccsds.time import CdsShortTimestamp
-from tmtccmd.util import ObjectIdDictT
+from tmtccmd.util import ObjectIdBase, ObjectIdDictT, ObjectIdU32
 
 _LOGGER = logging.getLogger(__name__)
 
 
-def handle_action_reply(
+_LOGGER = logging.getLogger(__name__)
-    raw_tm: bytes, printer: FsfwTmTcPrinter, obj_id_dict: ObjectIdDictT
+
+
+def handle_action_service_tm(
+    raw_tm: bytes, pw: PrintWrapper, obj_id_dict: ObjectIdDictT
 ):
     """Core Action reply handler
     :return:
     """
-    tm_packet = Service8FsfwTm.unpack(
+    tm_packet = PusTm.unpack(raw_tm, timestamp_len=CdsShortTimestamp.TIMESTAMP_SIZE)
-        raw_telemetry=raw_tm, time_reader=CdsShortTimestamp.empty()
+    if len(tm_packet.source_data) < 8:
+        _LOGGER.warning(
+            "received action service reply with source data smaller than 8 bytes"
         )
-    object_id = obj_id_dict.get(tm_packet.source_object_id_as_bytes)
+        return
-    pw = PrintWrapper(printer.file_logger)
+    object_id_raw = struct.unpack("!I", tm_packet.source_data[0:4])[0]
-    custom_data = tm_packet.custom_data
+    action_id = struct.unpack("!I", tm_packet.source_data[4:8])[0]
-    action_id = tm_packet.action_id
+    object_id = obj_id_dict.get(object_id_raw)
-    generic_print_str = printer.generic_action_packet_tm_print(
+    custom_data = tm_packet.source_data[8:]
-        packet=tm_packet, obj_id=object_id
+    if object_id is None:
-    )
+        object_id = ObjectIdU32(object_id_raw, "Unknown ID")
-    pw.dlog(generic_print_str)
+    if tm_packet.subservice == CustomSubservice.TM_DATA_REPLY:
+        if PRINT_RAW_ACTION_DATA_REPLY_B64_STR:
+            print(f"PUS TM Base64: {base64.b64encode(raw_tm)}")
         if object_id.as_bytes == IMTQ_HANDLER_ID:
             return handle_imtq_replies(action_id, pw, custom_data)
         elif object_id.as_bytes == PLOC_MPSOC_ID:
@@ -65,11 +75,26 @@ def handle_action_reply(
         ]:
             return handle_get_param_data_reply(object_id, action_id, pw, custom_data)
         else:
-        pw.dlog(f"No dedicated action reply handler found for reply from {object_id}")
+            # TODO: Could add a handler here depending on action ID and object ID.
-        pw.dlog(f"Raw Data: {tm_packet.custom_data.hex(sep=',')}")
+            handle_action_data_reply(tm_packet, object_id, action_id, pw)
+    else:
+        pw.dlog(
+            f"service 8 packet from {object_id} with action ID {action_id} "
+            f"and unknown subservice {tm_packet.subservice}"
+        )
 
 
-def handle_imtq_replies(action_id: int, pw: PrintWrapper, custom_data: bytearray):
+def handle_action_data_reply(
+    tm_packet: PusTm, named_obj_id: ObjectIdBase, action_id: int, printer: PrintWrapper
+):
+    print_string = (
+        f"service 8 data reply from {named_obj_id} with action ID {action_id} "
+        f"and data size {len(tm_packet.tm_data[8:])}"
+    )
+    printer.dlog(print_string)
+
+
+def handle_imtq_replies(action_id: int, pw: PrintWrapper, custom_data: bytes):
     if action_id == struct.unpack("!I", ImtqActionId.get_commanded_dipole)[0]:
         header_list = [
             "Commanded X-Dipole",
@@ -82,7 +107,7 @@ def handle_imtq_replies(action_id: int, pw: PrintWrapper, custom_data: bytearray
         pw.dlog(f"{content_list}")
 
 
-def handle_supervisor_replies(action_id: int, pw: PrintWrapper, custom_data: bytearray):
+def handle_supervisor_replies(action_id: int, pw: PrintWrapper, custom_data: bytes):
     if action_id == SupvActionId.DUMP_MRAM:
         header_list = ["MRAM Dump"]
         content_list = [custom_data[: len(custom_data)]]

eive_tmtc/pus_tm/event_handler.py

@@ -25,7 +25,7 @@ def handle_event_packet(  # noqa C901: Complexity okay here
 ):  # noqa C901: Complexity okay here
     if PRINT_RAW_EVENTS_B64_STR:
         print(f"PUS Event TM Base64: {base64.b64encode(raw_tm)}")
-    tm = Service5Tm.unpack(data=raw_tm, time_reader=CdsShortTimestamp.empty())
+    tm = Service5Tm.unpack(data=raw_tm, timestamp_len=CdsShortTimestamp.TIMESTAMP_SIZE)
     event_dict = get_event_dict()
     event_def = tm.event_definition
     info = event_dict.get(event_def.event_id)
@@ -40,10 +40,10 @@ def handle_event_packet(  # noqa C901: Complexity okay here
         obj_name = event_def.reporter_id.hex(sep=",")
     else:
         obj_name = obj_id_obj.name
-    assert tm.time_provider is not None
+    timestamp = CdsShortTimestamp.unpack(tm.timestamp)
     generic_event_string = (
         f"Object {obj_name} generated Event {info.name} (ID: {event_def.event_id:#04x})"
-        f" at {tm.time_provider.as_date_time()}"
+        f" at {timestamp.as_date_time()}"
     )
     _LOGGER.info(generic_event_string)
     pw.file_logger.info(

eive_tmtc/pus_tm/hk.py

@@ -2,20 +2,17 @@ import uuid
 import dataclasses
 import datetime
 import sqlite3
-from tmtccmd.pus.tm.s3_fsfw_hk import Service3FsfwTm
+from spacepackets.ecss.tm import CdsShortTimestamp, PusTm
 
 
 @dataclasses.dataclass
 class HkTmInfo:
     packet_uuid: uuid.UUID
-    hk_packet: Service3FsfwTm
+    hk_packet: PusTm
+    set_id: int
     db_con: sqlite3.Connection
     hk_data: bytes
 
     @property
     def packet_datetime(self) -> datetime.datetime:
-        return self.hk_packet.pus_tm.time_provider.as_datetime()
+        return CdsShortTimestamp.unpack(self.hk_packet.timestamp).as_datetime()
-
-    @property
-    def set_id(self) -> int:
-        return self.hk_packet.set_id

eive_tmtc/pus_tm/hk_handler.py

@@ -2,10 +2,14 @@
 
 import dataclasses
 import logging
-import base64  # noqa
+import base64
 import sqlite3
+import struct
 from typing import List, cast
 from uuid import UUID
+
+from spacepackets.ccsds.time import CdsShortTimestamp
+from spacepackets.ecss import PusTm
 from eive_tmtc.config.definitions import PRINT_RAW_HK_B64_STR
 from eive_tmtc.pus_tm.hk import HkTmInfo
 
@@ -23,9 +27,6 @@ from eive_tmtc.tmtc.power.pwr_ctrl import handle_pwr_ctrl_hk_data
 from eive_tmtc.tmtc.com.syrlinks_handler import handle_syrlinks_hk_data
 from eive_tmtc.tmtc.tcs import handle_thermal_controller_hk_data
 from eive_tmtc.tmtc.tcs.tmp1075 import handle_tmp_1075_hk_data
-from tmtccmd.pus.tm.s3_fsfw_hk import (
-    Service3FsfwTm,
-)
 from tmtccmd.pus.tm.s3_hk_base import HkContentType
 from tmtccmd.util.obj_id import ObjectIdU32, ObjectIdDictT
 
@@ -68,17 +69,20 @@ def handle_hk_packet(
     hk_level: int,
     db_con: sqlite3.Connection,
 ):
-    tm_packet = Service3FsfwTm.unpack(raw_telemetry=raw_tm, custom_hk_handling=False)
+    tm_packet = PusTm.unpack(raw_tm, CdsShortTimestamp.TIMESTAMP_SIZE)
-    named_obj_id = cast(ObjectIdU32, obj_id_dict.get(tm_packet.object_id.as_bytes))
+    obj_id_raw = struct.unpack("!I", tm_packet.tm_data[0:4])[0]
+    named_obj_id = cast(ObjectIdU32, obj_id_dict.get(obj_id_raw))
     if named_obj_id is None:
-        named_obj_id = tm_packet.object_id
+        named_obj_id = ObjectIdU32(obj_id_raw, "Unknown ID")
     if tm_packet.subservice == 25 or tm_packet.subservice == 26:
+        set_id = struct.unpack("!I", tm_packet.tm_data[4:8])[0]
         hk_data = tm_packet.tm_data[8:]
         if named_obj_id.as_bytes in hk_filter.object_ids:
             if PRINT_RAW_HK_B64_STR:
                 print(f"PUS TM Base64: {base64.b64encode(raw_tm)}")
             handle_regular_hk_print(
                 printer=printer,
+                set_id=set_id,
                 packet_uuid=packet_uuid,
                 object_id=named_obj_id,
                 hk_packet=tm_packet,
@@ -89,11 +93,12 @@ def handle_hk_packet(
         try:
             if hk_level >= 1:
                 printer.generic_hk_tm_print(
-                    HkContentType.HK, named_obj_id, tm_packet.set_id, hk_data
+                    HkContentType.HK, named_obj_id, set_id, hk_data
                 )
             if hk_level >= 1:
                 handle_regular_hk_print(
                     printer=printer,
+                    set_id=set_id,
                     packet_uuid=packet_uuid,
                     object_id=named_obj_id,
                     hk_packet=tm_packet,
@@ -109,7 +114,8 @@ def handle_hk_packet(
 
 
 def handle_regular_hk_print(  # noqa C901: Complexity okay here
-    hk_packet: Service3FsfwTm,
+    hk_packet: PusTm,
+    set_id: int,
     packet_uuid: UUID,
     hk_data: bytes,
     db: sqlite3.Connection,
@@ -117,12 +123,15 @@ def handle_regular_hk_print(  # noqa C901: Complexity okay here
     printer: FsfwTmTcPrinter,
 ):
     objb = object_id.as_bytes
-    set_id = hk_packet.set_id
     hk_info = HkTmInfo(
-        packet_uuid=packet_uuid, hk_packet=hk_packet, db_con=db, hk_data=hk_data
+        packet_uuid=packet_uuid,
+        hk_packet=hk_packet,
+        db_con=db,
+        hk_data=hk_data,
+        set_id=set_id,
     )
-    assert hk_packet.pus_tm.time_provider is not None
+    timestamp = CdsShortTimestamp.unpack(hk_packet.timestamp)
-    packet_dt = hk_packet.pus_tm.time_provider.as_date_time()
+    packet_dt = timestamp.as_datetime()
     pw = PrintWrapper(printer.file_logger)
     """This function is called when a Service 3 Housekeeping packet is received."""
     if objb in [obj_ids.RW1_ID, obj_ids.RW2_ID, obj_ids.RW3_ID, obj_ids.RW4_ID]:
@@ -139,7 +148,7 @@ def handle_regular_hk_print(  # noqa C901: Complexity okay here
             pw=pw,
             set_id=set_id,
             hk_data=hk_data,
-            packet_time=packet_dt,
+            packet_time=timestamp.as_datetime(),
         )
     elif objb == obj_ids.PCDU_HANDLER_ID:
         return handle_pcdu_hk(pw=pw, set_id=set_id, hk_data=hk_data)

eive_tmtc/pus_tm/pus_handler.py

@@ -22,7 +22,7 @@ from eive_tmtc.config.definitions import TM_DB_PATH, PUS_APID
 
 from eive_tmtc.config.object_ids import get_object_ids
 
-from .action_reply_handler import handle_action_reply
+from .action_reply_handler import handle_action_service_tm
 from .defs import PrintWrapper
 from .event_handler import handle_event_packet
 from .hk_handler import HkFilter, handle_hk_packet
@@ -63,15 +63,22 @@ class PusHandler(SpecificApidHandlerBase):
             _LOGGER.warning("Detected packet shorter than 8 bytes!")
             return
         try:
-            tm_packet = PusTelemetry.unpack(packet, CdsShortTimestamp.empty())
+            tm_packet = PusTelemetry.unpack(packet, CdsShortTimestamp.TIMESTAMP_SIZE)
             # _LOGGER.info(f"Sequence count: {tm_packet.seq_count}")
         except ValueError as value_error:
             _LOGGER.warning(f"{value_error}")
             _LOGGER.warning("Could not generate PUS TM object from raw data")
             _LOGGER.warning(f"Raw Packet: [{packet.hex(sep=',')}], REPR: {packet!r}")
             return
+        timestamp = CdsShortTimestamp.unpack(tm_packet.timestamp)
         db_con = sqlite3.connect(TM_DB_PATH)
-        self._store_packet_in_db(db_con, packet, tm_packet, packet_uuid)
+        self._store_packet_in_db(
+            db_con=db_con,
+            packet=packet,
+            tm_packet=tm_packet,
+            timestamp=timestamp,
+            packet_uuid=packet_uuid,
+        )
         service = tm_packet.service
         dedicated_handler = True
         if service == 1:
@@ -89,12 +96,12 @@ class PusHandler(SpecificApidHandlerBase):
         elif service == 5:
             handle_event_packet(raw_tm=packet, pw=self.pw)
         elif service == 8:
-            handle_action_reply(
+            handle_action_service_tm(
-                raw_tm=packet, printer=self.printer, obj_id_dict=self.obj_id_dict
+                raw_tm=packet, pw=self.pw, obj_id_dict=self.obj_id_dict
             )
         elif service == 17:
             pus17_tm = Service17Tm.unpack(
-                data=packet, time_reader=CdsShortTimestamp.empty()
+                data=packet, timestamp_len=CdsShortTimestamp.TIMESTAMP_SIZE
             )
             if pus17_tm.subservice == 2:
                 self.verif_wrapper.dlog("Received Ping Reply TM[17,2]")
@@ -119,11 +126,11 @@ class PusHandler(SpecificApidHandlerBase):
         self,
         db_con: sqlite3.Connection,
         packet: bytes,
+        timestamp: CdsShortTimestamp,
         tm_packet: PusTelemetry,
         packet_uuid: uuid.UUID,
     ):
         cursor = db_con.cursor()
-        assert tm_packet.time_provider is not None
         cursor.execute(
             """
             CREATE TABLE IF NOT EXISTS pus_tm(
@@ -139,7 +146,7 @@ class PusHandler(SpecificApidHandlerBase):
             "INSERT INTO pus_tm VALUES(?, ?, ?, ?, ?, ?)",
             (
                 str(packet_uuid),
-                tm_packet.time_provider.as_datetime(),
+                timestamp.as_datetime(),
                 tm_packet.service,
                 tm_packet.subservice,
                 len(packet),
@@ -150,7 +157,7 @@ class PusHandler(SpecificApidHandlerBase):
 
     def _handle_param_packet(self, raw_data: bytes, tm_packet: PusTelemetry):
         param_packet = Service20FsfwTm.unpack(
-            raw_telemetry=raw_data, time_reader=CdsShortTimestamp.empty()
+            raw_telemetry=raw_data, timestamp_len=CdsShortTimestamp.TIMESTAMP_SIZE
         )
         if tm_packet.subservice == ParamSubservice.TM_DUMP_REPLY:
             param_wrapper = Service20ParamDumpWrapper(param_tm=param_packet)

eive_tmtc/pus_tm/verification_handler.py

@@ -17,7 +17,7 @@ def handle_service_1_fsfw_packet(wrapper: VerificationWrapper, raw_tm: bytes):
         )
     # Error code with length 2 is FSFW specific
     tm_packet = Service1Tm.unpack(
-        data=raw_tm, params=UnpackParams(CdsShortTimestamp.empty(), 1, 2)
+        data=raw_tm, params=UnpackParams(CdsShortTimestamp.TIMESTAMP_SIZE, 1, 2)
     )
     fsfw_wrapper = Service1FsfwWrapper(tm_packet)
     res = wrapper.verificator.add_tm(tm_packet)

eive_tmtc/tmtc/acs/acs_ctrl.py

@@ -8,7 +8,7 @@ from socket import AF_INET
 from typing import Tuple
 
 from tmtccmd.config.tmtc import CmdTreeNode
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 from tmtccmd.pus.s8_fsfw_action import create_action_cmd
 from tmtccmd.pus.s20_fsfw_param import create_load_param_cmd
 from tmtccmd.pus.s20_fsfw_param_defs import (
@@ -557,7 +557,7 @@ def handle_acs_ctrl_sus_raw_data(pw: PrintWrapper, hk_data: bytes):
         sus_list_formatted = vec_fmt.format(*sus_list)
         current_idx += length
         pw.dlog(f"SUS {idx} RAW: {sus_list_formatted}")
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=12))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=12))
 
 
 def handle_acs_ctrl_sus_processed_data(pw: PrintWrapper, hk_data: bytes):
@@ -593,7 +593,7 @@ def handle_acs_ctrl_sus_processed_data(pw: PrintWrapper, hk_data: bytes):
     sun_ijk_model = vec_fmt.format(*sun_ijk_model)
     current_idx += inc_len
     pw.dlog(f"{'SUS ijk Model'.ljust(25)}: {sun_ijk_model}")
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=15))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=15))
 
 
 def handle_raw_mgm_data(pw: PrintWrapper, hk_data: bytes):
@@ -649,7 +649,7 @@ def handle_raw_mgm_data(pw: PrintWrapper, hk_data: bytes):
         pw.dlog(f"{entry[0].ljust(28)}: {entry[1]}")
     current_idx += 1
     assert current_idx == 61
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=6))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=6))
 
 
 def handle_mgm_data_processed(pw: PrintWrapper, hk_data: bytes):
@@ -703,7 +703,7 @@ def handle_mgm_data_processed(pw: PrintWrapper, hk_data: bytes):
     current_idx += inc_len
     if PERFORM_MGM_CALIBRATION:
         perform_mgm_calibration(pw, mgm_3)
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=8))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=8))
 
 
 def handle_gyr_data_raw(pw: PrintWrapper, hk_data: bytes):
@@ -737,7 +737,7 @@ def handle_gyr_data_raw(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"{'GYR 1 L3'.ljust(15)}: {float_str_fmt.format(*gyr_1_l3)}")
     pw.dlog(f"{'GYR 2 ADIS'.ljust(15)}: {float_str_fmt.format(*gyr_2_adis)}")
     pw.dlog(f"{'GYR 3 L3'.ljust(15)}: {float_str_fmt.format(*gyr_3_l3)}")
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], 4))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], 4))
 
 
 GYR_NAMES = ["GYR 0 ADIS", "GYR 1 L3", "GYR 2 ADIS", "GYR 3 L3"]
@@ -763,7 +763,7 @@ def handle_gyr_data_processed(pw: PrintWrapper, hk_data: bytes):
     ]
     pw.dlog(f"GYR Vec Total: {gyr_vec_tot}")
     current_idx += inc_len
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=5))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=5))
 
 
 def handle_gps_data_processed(pw: PrintWrapper, hk_data: bytes):
@@ -826,7 +826,7 @@ def handle_gps_data_processed(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"GPS Altitude: {alt} [m]")
     pw.dlog(f"GPS Position: {pos} [m]")
     pw.dlog(f"GPS Velocity: {velo} [m/s]")
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=6))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=6))
 
 
 def handle_attitude_estimation_data(pw: PrintWrapper, hk_data: bytes):
@@ -881,9 +881,9 @@ def handle_attitude_estimation_data(pw: PrintWrapper, hk_data: bytes):
         )
         current_idx += inc_len_quat
         pw.dlog(f"{'QUEST Quaternion'.ljust(25)}: {fmt_str_4.format(*quest_quat)}")
-        pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=4))
+        pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=4))
         return
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=3))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=3))
 
 
 def handle_ctrl_val_data(pw: PrintWrapper, hk_data: bytes):
@@ -940,7 +940,7 @@ def handle_ctrl_val_data(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"Control Values Error Quaternion: {err_quat}")
     pw.dlog(f"Control Values Error Angle: {err_ang} [deg]")
     pw.dlog(f"Control Values Target Rotational Rate: {tgt_rot} [deg/s]")
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=5))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=5))
 
 
 def handle_act_cmd_data(pw: PrintWrapper, hk_data: bytes):
@@ -979,7 +979,7 @@ def handle_act_cmd_data(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"Actuator Commands RW Target Torque: {rw_tgt_torque}")
     pw.dlog(f"Actuator Commands RW Target Speed: {rw_tgt_speed}")
     pw.dlog(f"Actuator Commands MTQ Target Dipole: {mtq_tgt_dipole}")
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=3))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=3))
 
 
 def handle_fused_rot_rate_data(pw: PrintWrapper, hk_data: bytes):
@@ -1030,9 +1030,9 @@ def handle_fused_rot_rate_data(pw: PrintWrapper, hk_data: bytes):
             )
         else:
             pw.dlog(f"Ctrl Strategy (key unknown): {rot_rate_source}")
-        pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=4))
+        pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=4))
         return
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=3))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=3))
 
 
 def handle_fused_rot_rate_source_data(pw: PrintWrapper, hk_data: bytes):
@@ -1087,7 +1087,7 @@ def handle_fused_rot_rate_source_data(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"Fused Rotational Rate Total SUSMGM: {rot_rate_total_susmgm} [deg/s]")
     pw.dlog(f"Fused Rotational Rate Total QUEST: {rot_rate_total_quest} [deg/s]")
     pw.dlog(f"Fused Rotational Rate Total STR: {rot_rate_total_str} [deg/s]")
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=5))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=5))
 
 
 def handle_acs_ctrl_action_replies(

eive_tmtc/tmtc/acs/gps.py

@@ -14,7 +14,7 @@ from tmtccmd.pus.tc.s3_fsfw_hk import (
     create_disable_periodic_hk_command_with_diag,
 )
 from tmtccmd.pus.tc.s8_fsfw_action import create_action_cmd
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -23,7 +23,11 @@ class GpsInfo:
     MAX_SATELLITES = 30
 
 
-class GnssChip(enum.IntEnum):
+class ActIds:
+    RESET_GNSS = 5
+
+
+class AcsBoardSides(enum.IntEnum):
     A_SIDE = 0
     B_SIDE = 1
 
@@ -37,7 +41,7 @@ class OpCode:
     REQ_SKYVIEW_HK = "skyview_hk_request"
     ENABLE_SKYVIEW_HK = "skyview_hk_enable"
     DISABLE_SKYVIEW_HK = "skyview_hk_disable"
-    RESET_GNSS = "reset"
+    RESET_GNSS = "reset_gnss"
 
 
 class Info:
@@ -63,7 +67,7 @@ def create_gnss_node() -> CmdTreeNode:
     ]
     info_strs = [getattr(Info, key) for key in dir(OpCode) if not key.startswith("__")]
     combined_dict = dict(zip(op_code_strs, info_strs))
-    node = CmdTreeNode("gnss_devs", "GNSS Controller", hide_children_for_print=True)
+    node = CmdTreeNode("gnss_ctrl", "GNSS Ctrl", hide_children_for_print=True)
     for op_code, info in combined_dict.items():
         node.add_child(CmdTreeNode(op_code, info))
     return node
@@ -73,16 +77,17 @@ def pack_gps_command(  # noqa: C901
     object_id: bytes, q: DefaultPusQueueHelper, cmd_str: str
 ):  # noqa: C901:
     if cmd_str == OpCode.RESET_GNSS:
-        for val in GnssChip:
+        for val in AcsBoardSides:
             print("{:<2}: {:<20}".format(val, val.name))
-        chip: str = ""
+        board_side = int(input("Select Board Side \n" ""))
-        while chip not in ["0", "1"]:
+        q.add_log_cmd(f"GPS: {Info.RESET_GNSS}")
-            chip = input("Please specify which chip to reset: ")
-        q.add_log_cmd(f"gps: {Info.DISABLE_CORE_HK}")
         q.add_pus_tc(
-            create_action_cmd(object_id=object_id, action_id=5, user_data=chip.encode())
+            create_action_cmd(
+                object_id=object_id,
+                action_id=ActIds.RESET_GNSS,
+                user_data=bytearray([board_side]),
+            )
         )
-        _LOGGER.warning("Reset pin handling needs to be re-implemented")
     if cmd_str == OpCode.ENABLE_CORE_HK:
         interval = float(input("Please specify interval in floating point seconds: "))
         if interval <= 0:
@@ -198,9 +203,7 @@ def handle_core_data(pw: PrintWrapper, hk_data: bytes):
     )
     pw.dlog(f"GNSS Date: {date_string}")
     pw.dlog(f"Unix seconds {unix_seconds}")
-    FsfwTmTcPrinter.get_validity_buffer(
+    pw.dlog(get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=14))
-        validity_buffer=hk_data[current_idx:], num_vars=14
-    )
 
 
 def handle_skyview_data(pw: PrintWrapper, hk_data: bytes):
@@ -260,6 +263,4 @@ def handle_skyview_data(pw: PrintWrapper, hk_data: bytes):
                 used[idx],
             )
         )
-    FsfwTmTcPrinter.get_validity_buffer(
+    pw.dlog(get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=6))
-        validity_buffer=hk_data[current_idx:], num_vars=6
-    )

eive_tmtc/tmtc/acs/imtq.py

@@ -31,7 +31,7 @@ from tmtccmd.pus.tc.s3_fsfw_hk import (
 )
 from tmtccmd.pus.s200_fsfw_mode import pack_mode_data, Mode
 from tmtccmd.util import ObjectIdU32
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 
 _LOGGER = logging.getLogger(__name__)
@@ -543,7 +543,7 @@ def handle_dipole_set(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"Dipole Y: {dipole_y}")
     pw.dlog(f"Dipole Z: {dipole_z}")
     pw.dlog(f"Current torque duration: {current_torque_duration}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[fmt_len:], 2)
+    pw.dlog(get_validity_buffer_str(hk_data[fmt_len:], 2))
 
 
 def unpack_eng_hk(hk_data: bytes) -> List:
@@ -583,9 +583,7 @@ def handle_eng_set(pw: PrintWrapper, hk_data: bytes, torque_on: bool):
     for k, v in zip(ENG_HK_HEADERS, content_list):
         pw.dlog(f"{k.ljust(30)}: {v}")
     pw.dlog(
-        FsfwTmTcPrinter.get_validity_buffer(
+        get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=num_of_vars)
-            validity_buffer=validity_buffer, num_vars=num_of_vars
-        )
     )
 
 
@@ -597,9 +595,7 @@ def handle_status_set(pw: PrintWrapper, hk_data: bytes):
     for k, v in zip(STATUS_HEADERS, content_list):
         pw.dlog(f"{k.ljust(30)}: {v}")
     pw.dlog(
-        FsfwTmTcPrinter.get_validity_buffer(
+        get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=num_of_vars)
-            validity_buffer=validity_buffer, num_vars=num_of_vars
-        )
     )
 
 
@@ -620,9 +616,7 @@ def handle_calibrated_mtm_measurement(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(str(header_list))
     pw.dlog(str(content_list))
     pw.dlog(
-        FsfwTmTcPrinter.get_validity_buffer(
+        get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=num_of_vars)
-            validity_buffer=validity_buffer, num_vars=num_of_vars
-        )
     )
 
 
@@ -644,9 +638,7 @@ def handle_raw_mtm_measurement(pw: PrintWrapper, hk_data: bytes, torque_status:
     pw.dlog(str(header_list))
     pw.dlog(str(content_list))
     pw.dlog(
-        FsfwTmTcPrinter.get_validity_buffer(
+        get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=num_of_vars)
-            validity_buffer=validity_buffer, num_vars=num_of_vars
-        )
     )
 
 
@@ -783,7 +775,5 @@ def handle_self_test_data(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(str(header_list))
     pw.dlog(str(content_list))
     pw.dlog(
-        FsfwTmTcPrinter.get_validity_buffer(
+        get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=num_of_vars)
-            validity_buffer=validity_buffer, num_vars=num_of_vars
-        )
     )

eive_tmtc/tmtc/acs/reaction_wheels.py

@@ -23,7 +23,7 @@ from tmtccmd.pus.s8_fsfw_action import create_action_cmd
 from spacepackets.ecss.tc import PusTelecommand
 from tmtccmd.pus.s200_fsfw_mode import pack_mode_data, Mode, Subservice
 from tmtccmd.util import ObjectIdU32
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 
 class OpCodesDev:
@@ -301,7 +301,7 @@ def handle_rw_hk_data(
             f"Current Limit Control mode {clc_mode}. 0: Low Current Mode (0.3 A), "
             "1: High Current Mode (0.6 A)"
         )
-        pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], 5))
+        pw.dlog(get_validity_buffer_str(hk_data[current_idx:], 5))
     if set_id == RwSetId.LAST_RESET:
         pw.dlog(
             f"Received Last Reset HK (ID {set_id}) from Reaction Wheel {object_id.name}"
@@ -390,7 +390,7 @@ def handle_rw_hk_data(
         )
         if current_idx > 0:
             pw.dlog(
-                FsfwTmTcPrinter.get_validity_buffer(
+                get_validity_buffer_str(
                     validity_buffer=hk_data[current_idx:], num_vars=27
                 )
             )

eive_tmtc/tmtc/acs/star_tracker.py

@@ -27,7 +27,7 @@ from tmtccmd.pus.s8_fsfw_action import create_action_cmd
 from tmtccmd.tmtc import DefaultPusQueueHelper
 from tmtccmd.pus.s200_fsfw_mode import pack_mode_data, Mode
 from tmtccmd.util import ObjectIdU32
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 from eive_tmtc.config.object_ids import STR_ASSEMBLY, STAR_TRACKER_ID
 
 _LOGGER = logging.getLogger(__name__)
@@ -750,12 +750,13 @@ def create_update_firmware_target_cmd(
     else:
         param_id = ParamId.FIRMWARE_TARGET
     return create_load_param_cmd(
-        create_scalar_u8_parameter(
+        parameter=create_scalar_u8_parameter(
             STAR_TRACKER_ID,
             0,
             param_id,
             fw_target,
-        )
+        ),
+        apid=0,
     )
 
 
@@ -930,7 +931,7 @@ def handle_version_set(hk_data: bytes, pw: PrintWrapper):
     minor = struct.unpack("!B", hk_data[current_idx : current_idx + 1])[0]
     pw.dlog(f"Minor: {minor}")
     current_idx += 1
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=5))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=5))
 
 
 def handle_temperature_set(hk_data: bytes, pw: PrintWrapper):
@@ -947,7 +948,7 @@ def handle_temperature_set(hk_data: bytes, pw: PrintWrapper):
     pw.dlog(f"CMOS Temperature: {cmos_temp}")
     pw.dlog(f"FPGA Temperature: {fpga_temp}")
     current_idx += fmt_len
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], 5)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], 5))
 
 
 def handle_solution_set(hk_data: bytes, pw: PrintWrapper):
@@ -1021,7 +1022,7 @@ def handle_solution_set(hk_data: bytes, pw: PrintWrapper):
     solution_strategy = hk_data[current_idx]
     pw.dlog(f"Solution strategy: {solution_strategy}")
     current_idx += 1
-    print(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], 23))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], 23))
 
 
 def handle_blob_set(hk_data: bytes, pw: PrintWrapper):
@@ -1032,7 +1033,7 @@ def handle_blob_set(hk_data: bytes, pw: PrintWrapper):
     current_idx = unpack_time_hk(hk_data, 0, pw)
     blob_count = struct.unpack("!I", hk_data[current_idx : current_idx + 4])[0]
     pw.dlog(f"Blob count: {blob_count}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx + 4 :], num_vars=3)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx + 4 :], num_vars=3))
 
 
 def handle_blobs_set(hk_data: bytes, pw: PrintWrapper):
@@ -1060,7 +1061,7 @@ def handle_blobs_set(hk_data: bytes, pw: PrintWrapper):
     for idx in range(8):
         pw.dlog("{:<8} {:<8}".format(x_coords[idx], y_coords[idx]))
     assert current_idx == len(hk_data) - 1
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=7)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=7))
 
 
 def handle_centroid_set(hk_data: bytes, pw: PrintWrapper):
@@ -1074,7 +1075,7 @@ def handle_centroid_set(hk_data: bytes, pw: PrintWrapper):
     current_idx += 4
     pw.dlog(f"Centroid count: {centroid_count}")
     assert current_idx == len(hk_data) - 1
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=3)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=3))
 
 
 def handle_centroids_set(hk_data: bytes, pw: PrintWrapper):
@@ -1101,7 +1102,7 @@ def handle_centroids_set(hk_data: bytes, pw: PrintWrapper):
             )
         )
     assert current_idx == len(hk_data) - 1
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=6)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=6))
 
 
 def handle_matched_centroids_set(hk_data: bytes, pw: PrintWrapper):
@@ -1145,7 +1146,7 @@ def handle_matched_centroids_set(hk_data: bytes, pw: PrintWrapper):
             )
         )
     assert current_idx == len(hk_data) - 1
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=8)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=8))
 
 
 def handle_auto_blob_set(hk_data: bytes, pw: PrintWrapper):
@@ -1163,7 +1164,7 @@ def handle_auto_blob_set(hk_data: bytes, pw: PrintWrapper):
     current_idx += inc_len
     assert current_idx == len(hk_data) - 1
     pw.dlog(f"Threshold {threshold}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=3)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=3))
 
 
 def handle_histo_or_contrast_set(name: str, hk_data: bytes, pw: PrintWrapper):
@@ -1239,7 +1240,7 @@ def handle_blob_stats_set(hk_data: bytes, pw: PrintWrapper):
                 i, noise_list[i], threshold_list[i], lvalid_list[i], oflow_list[i]
             )
         )
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=6))
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=6))
 
 
 def handle_star_tracker_action_replies(

eive_tmtc/tmtc/acs/sus.py

@@ -3,7 +3,7 @@ import struct
 
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from tmtccmd.util import ObjectIdU32
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 
 class SetId(enum.IntEnum):
@@ -26,6 +26,6 @@ def handle_sus_hk(
         pw.dlog("AIN Channel | Raw Value (hex) | Raw Value (dec)")
         for idx, val in enumerate(channels):
             pw.dlog(f"{idx} | {val[0]:#06x} |" + str(val[0]).ljust(5))
-        FsfwTmTcPrinter.get_validity_buffer(
+        pw.dlog(
-            validity_buffer=hk_data[current_idx:], num_vars=7
+            get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=7)
         )

eive_tmtc/tmtc/com/pdec_handler.py

@@ -78,12 +78,13 @@ def pack_pdec_handler_commands(
         pw = int(input("Specify positive window to set: "))
         q.add_pus_tc(
             create_load_param_cmd(
-                create_scalar_u8_parameter(
+                parameter=create_scalar_u8_parameter(
                     object_id,
                     0,
                     ParameterId.POSITIVE_WINDOW,
                     pw,
-                )
+                ),
+                apid=0,
             )
         )
     if cmd_str == OpCode.NEGATIVE_WINDOW:
@@ -91,12 +92,13 @@ def pack_pdec_handler_commands(
         nw = int(input("Specify negative window to set: "))
         q.add_pus_tc(
             create_load_param_cmd(
-                create_scalar_u8_parameter(
+                parameter=create_scalar_u8_parameter(
                     object_id,
                     0,
                     ParameterId.NEGATIVE_WINDOW,
                     nw,
-                )
+                ),
+                apid=0,
             )
         )
     if cmd_str == OpCode.RESET_NO_INIT:

eive_tmtc/tmtc/com/syrlinks_handler.py

@@ -17,7 +17,7 @@ from tmtccmd.config.tmtc import (
     TmtcDefinitionWrapper,
     tmtc_definitions_provider,
 )
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 from tmtccmd.pus.s200_fsfw_mode import Mode, create_mode_command
 from tmtccmd.pus.tc.s3_fsfw_hk import (
     create_disable_periodic_hk_command_with_diag,
@@ -297,7 +297,7 @@ def handle_syrlinks_temp_dataset(hk_info: HkTmInfo, pw: PrintWrapper):
     temp_baseband_board = struct.unpack("!f", hk_data[4:8])[0]
     pw.dlog(f"Temperatur Power Amplifier [C]: {temp_power_amplifier}")
     pw.dlog(f"Temperatur Baseband Board [C]: {temp_baseband_board}")
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[8:], 2))
+    pw.dlog(get_validity_buffer_str(hk_data[8:], 2))
 
 
 def handle_syrlinks_rx_registers_dataset(
@@ -364,9 +364,7 @@ def handle_syrlinks_rx_registers_dataset(
     validity_buffer = hk_data[22:]
     for header, content in zip(header_list, content_list):
         pw.dlog(f"{header}: {content}")
-    pw.dlog(
+    pw.dlog(get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=8))
-        FsfwTmTcPrinter.get_validity_buffer(validity_buffer=validity_buffer, num_vars=8)
-    )
     print(f"Carrier Detect: {carrier_detect}")
     print(f"Carrier Lock: {carrier_lock}")
     print(f"Data Lock (data clock recovery loop lock status): {data_lock}")
@@ -394,7 +392,7 @@ def handle_syrlinks_rx_registers_dataset(
         "INSERT INTO syrlinks_rx_regs VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?)",
         (
             str(hk_info.packet_uuid),
-            hk_info.hk_packet.pus_tm.time_provider.as_datetime(),  # type: ignore
+            hk_info.packet_datetime,
             carrier_detect,
             carrier_lock,
             data_lock,
@@ -470,9 +468,7 @@ def handle_syrlinks_tx_registers_dataset(
     validity_buffer = hk_info.hk_data[4:]
     for header, content in zip(header_list, content_list):
         pw.dlog(f"{header}: {content}")
-    pw.dlog(
+    pw.dlog(get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=3))
-        FsfwTmTcPrinter.get_validity_buffer(validity_buffer=validity_buffer, num_vars=3)
-    )
     # pw.dlog(f"TX CONV: {tx_conv!r}")
     # pw.dlog(f"TX DIFF (differential encoder enable): {tx_diff_encoder_enable}")
     print(f"TX Status: {tx_status_status!r}")
@@ -504,7 +500,7 @@ def handle_syrlinks_tx_registers_dataset(
         "INSERT INTO syrlinks_tx_regs VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)",
         (
             str(hk_info.packet_uuid),
-            hk_info.hk_packet.pus_tm.time_provider.as_datetime(),  # type: ignore
+            hk_info.packet_datetime,
             tx_status_status,
             tx_status_status.name,
             tx_conf_set,

eive_tmtc/tmtc/core.py

@@ -15,7 +15,7 @@ from tmtccmd.pus.s20_fsfw_param import (
     create_scalar_u8_parameter,
     create_load_param_cmd,
 )
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 from tmtccmd.pus.s11_tc_sched import (
     create_enable_tc_sched_cmd,
     create_disable_tc_sched_cmd,
@@ -399,12 +399,13 @@ def pack_core_commands(  # noqa C901
             raise ValueError("Only 0 or 1 allowed for preferred SD card")
         q.add_pus_tc(
             create_load_param_cmd(
-                create_scalar_u8_parameter(
+                parameter=create_scalar_u8_parameter(
                     object_id=CORE_CONTROLLER_ID,
                     domain_id=0,
                     unique_id=ParamId.PREF_SD,
                     parameter=pref_sd,
-                )
+                ),
+                apid=0,
             )
         )
     elif cmd_str == OpCode.CP_HELPER:
@@ -632,9 +633,7 @@ def handle_core_hk_data(pw: PrintWrapper, set_id: int, hk_data: bytes):
             f"PL Voltage [mV] {pl_voltage}"
         )
         pw.dlog(printout)
-        FsfwTmTcPrinter.get_validity_buffer(
+        pw.dlog(get_validity_buffer_str(validity_buffer=hk_data[inc_len:], num_vars=3))
-            validity_buffer=hk_data[inc_len:], num_vars=3
-        )
 
 
 def handle_core_ctrl_action_replies(

eive_tmtc/tmtc/internal_err_reporter.py

@@ -1,9 +1,8 @@
 import enum
 import struct
 
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
-
 from eive_tmtc.pus_tm.defs import PrintWrapper
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 
 class SetId(enum.IntEnum):
@@ -21,4 +20,4 @@ def handle_ier_hk_data(pw: PrintWrapper, hk_data: bytes, set_id: int):
         pw.dlog(f"TM Errors: {tm_errors}")
         pw.dlog(f"Queue Errors: {queue_errors}")
         pw.dlog(f"Store Errors: {store_hits}")
-        pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[inc_len:], 3))
+        pw.dlog(get_validity_buffer_str(hk_data[inc_len:], 3))

eive_tmtc/tmtc/payload/ploc_mpsoc.py

@@ -11,19 +11,15 @@ import logging
 import struct
 import enum
 
-from eive_tmtc.config.definitions import CustomServiceList
 from eive_tmtc.config.object_ids import get_object_ids, PLOC_MPSOC_ID
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from tmtccmd.config.tmtc import (
     CmdTreeNode,
-    tmtc_definitions_provider,
-    OpCodeEntry,
-    TmtcDefinitionWrapper,
 )
 from spacepackets.ecss.tc import PusTelecommand
 from tmtccmd.tmtc import DefaultPusQueueHelper
 from eive_tmtc.utility.input_helper import InputHelper
-from tmtccmd.pus.s200_fsfw_mode import pack_mode_data, Mode
+from tmtccmd.pus.s200_fsfw_mode import pack_mode_data, Mode, create_mode_command
 from tmtccmd.pus.s20_fsfw_param import create_load_param_cmd, create_scalar_u8_parameter
 from tmtccmd.pus.s8_fsfw_action import create_action_cmd
 
@@ -31,6 +27,8 @@ _LOGGER = logging.getLogger(__name__)
 
 MANUAL_INPUT = "1"
 
+CRIT_CMD_APID_DICT = {"1": ("flash_mkfs", 0x12A)}
+
 OBC_WRITE_FILE_DICT = {
     MANUAL_INPUT: ("manual input", ""),
     "2": ("/mnt/sd0/ploc/mpsoc/flash_write.bin", "/mnt/sd0/ploc/mpsoc/flash_write.bin"),
@@ -86,12 +84,22 @@ class ActionId(enum.IntEnum):
     SET_UART_TX_TRISTATE = 20
     RELEASE_UART_TX = 21
     TC_CAM_TAKE_PIC = 22
-    TC_SIMPLEX_SEND_FILE = 23
+    TC_SIMPLEX_STREAM_FILE = 23
     TC_DOWNLINK_DATA_MODULATE = 24
     TC_MODE_SNAPSHOT = 25
     TC_FLASH_DIR_GET_CONTENT = 28
     TM_FLASH_DIRECTORY_CONTENT = 29
     TC_FLASH_READ_FULL_FILE = 30
+    TC_SPLIT_FILE = 31
+    TC_VERIFY_BOOT = 32
+    TC_ENABLE_TC_EXECUTION = 33
+    TC_FLASH_MKFS = 34
+
+
+class Submode(enum.IntEnum):
+    IDLE_OR_NONE = 0
+    REPLAY = 1
+    SNAPSHOT = 2
 
 
 class ParamId(enum.IntEnum):
@@ -103,8 +111,6 @@ class OpCode:
     OFF = "off"
     NORMAL = "normal"
     VERIFY_BOOT = "verify_boot"
-    MODE_REPLAY = "mode_replay"
-    MODE_IDLE = "mode_idle"
     REPLAY_WRITE_SEQ = "replay_write"
     DOWNLINK_PWR_ON = "downlink_pwr_on"
     MEM_WRITE = "memory_write"
@@ -116,12 +122,18 @@ class OpCode:
     FLASH_GET_DIR_CONTENT = "flash_get_dir_content"
     REPLAY_STOP = "replay_stop"
     REPLAY_START = "replay_start"
+    CAM_CMD_SEND = "cam_cmd_send"
     CAM_TAKE_PIC = "cam_take_pic"
-    SIMPLEX_SEND_FILE = "simplex_send_file"
+    SIMPLEX_STREAM_FILE = "simplex_stream_file"
+    SPLIT_FILE = "split_file"
     DOWNLINK_DATA_MODULATE = "downlink_data_modulate"
-    MODE_SNAPSHOT = "mode_snapshot"
     ENABLE_PLOC_SUPV_COMMANDING_TO_ON = "enable_ploc_supv_cmd_to_on"
     DISABLE_PLOC_SUPV_COMMANDING_TO_ON = "disable_ploc_supv_cmd_to_on"
+    MODE_IDLE = "mode_idle"
+    MODE_REPLAY = "mode_replay"
+    MODE_SNAPSHOT = "mode_snapshot"
+    ENABLE_TC_EXECUTION = "enable_tc_exec"
+    FLASH_MKFS = "flash_mkfs"
 
 
 class Info:
@@ -139,7 +151,9 @@ class Info:
     MEM_READ = "Read from Memory"
     REPLAY_START = "Replay Start"
     CAM_TAKE_PIC = "Cam Take Picture"
-    SIMPLEX_SEND_FILE = "Simplex Send File"
+    CAM_CMD_SEND = "Send Camera Command"
+    SIMPLEX_STREAM_FILE = "Simplex Stream File with E-Band"
+    SPLIT_FILE = "Split file on MPSoC Flash"
     FLASH_READ_FILE = "Copy file from MPSoC to OBC"
     FLASH_WRITE_FILE = "Copy file from OBC to MPSoC"
     FLASH_DELETE_FILE = "Delete file on MPSoC"
@@ -150,6 +164,8 @@ class Info:
     DISABLE_PLOC_SUPV_COMMANDING_TO_ON = (
         "Disable PLOC SUPV commanding when switching ON"
     )
+    ENABLE_TC_EXECUTION = "Enable execution of critical commands"
+    FLASH_MKFS = "Flash MKFS command"
 
 
 class MemAddresses(enum.IntEnum):
@@ -168,45 +184,6 @@ def create_ploc_mpsoc_node() -> CmdTreeNode:
     return node
 
 
-# Legacy command definitions.
-@tmtc_definitions_provider
-def add_ploc_mpsoc_cmds(defs: TmtcDefinitionWrapper):
-    oce = OpCodeEntry()
-    oce.add(OpCode.OFF, Info.OFF)
-    oce.add(OpCode.ON, Info.ON)
-    oce.add(OpCode.NORMAL, Info.NORMAL)
-    oce.add(OpCode.MEM_WRITE, "Ploc MPSoC: Memory write")
-    oce.add(OpCode.MEM_READ, "Ploc MPSoC: Memory read")
-    oce.add(OpCode.FLASH_WRITE_FILE, Info.FLASH_WRITE_FILE)
-    oce.add(OpCode.FLASH_READ_FILE, Info.FLASH_READ_FILE)
-    oce.add(OpCode.FLASH_DELETE_FILE, Info.FLASH_DELETE_FILE)
-    oce.add(OpCode.FLASH_GET_DIR_CONTENT, Info.FLASH_GET_DIR_CONTENT)
-    oce.add(OpCode.REPLAY_START, Info.REPLAY_START)
-    oce.add(OpCode.REPLAY_STOP, Info.REPLAY_STOP)
-    oce.add(OpCode.DOWNLINK_PWR_ON, Info.DOWNLINK_PWR_ON)
-    oce.add(OpCode.DOWNLINK_PWR_OFF, Info.DOWNLINK_PWR_OFF)
-    oce.add(OpCode.REPLAY_WRITE_SEQ, Info.REPLAY_WRITE_SEQ)
-    oce.add("12", "Ploc MPSoC: OBSW reset sequence count")
-    oce.add(OpCode.VERIFY_BOOT, Info.VERIFY_BOOT)
-    oce.add(OpCode.MODE_REPLAY, Info.MODE_REPLAY)
-    oce.add(OpCode.MODE_IDLE, Info.MODE_IDLE)
-    oce.add("16", "Ploc MPSoC: Tc cam command send")
-    oce.add("17", "Ploc MPSoC: Set UART TX tristate")
-    oce.add("18", "Ploc MPSoC: Relesase UART TX")
-    oce.add(OpCode.CAM_TAKE_PIC, Info.CAM_TAKE_PIC)
-    oce.add(OpCode.SIMPLEX_SEND_FILE, Info.SIMPLEX_SEND_FILE)
-    oce.add(OpCode.DOWNLINK_DATA_MODULATE, Info.DOWNLINK_DATA_MODULATE)
-    oce.add(OpCode.MODE_SNAPSHOT, Info.MODE_SNAPSHOT)
-    oce.add(
-        OpCode.ENABLE_PLOC_SUPV_COMMANDING_TO_ON, Info.ENABLE_PLOC_SUPV_COMMANDING_TO_ON
-    )
-    oce.add(
-        OpCode.DISABLE_PLOC_SUPV_COMMANDING_TO_ON,
-        Info.DISABLE_PLOC_SUPV_COMMANDING_TO_ON,
-    )
-    defs.add_service(CustomServiceList.PLOC_MPSOC.value, "Ploc MPSoC", oce)
-
-
 def pack_ploc_mpsoc_commands(
     q: DefaultPusQueueHelper, cmd_str: str
 ):  # noqa C901: Complexity okay here.
@@ -290,25 +267,11 @@ def pack_ploc_mpsoc_commands(
         data = object_id.as_bytes + struct.pack("!I", ActionId.OBSW_RESET_SEQ_COUNT)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
     if cmd_str == OpCode.VERIFY_BOOT:
-        num_words = 1
         q.add_log_cmd(f"{prefix} {Info.VERIFY_BOOT}")
-        data = (
+        app_data = object_id.as_bytes + struct.pack("!I", ActionId.TC_VERIFY_BOOT)
-            object_id.as_bytes
+        q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=app_data))
-            + struct.pack("!I", ActionId.TC_MEM_READ)
+    if cmd_str == OpCode.CAM_CMD_SEND:
-            + struct.pack("!I", MemAddresses.DEADBEEF)
+        q.add_log_cmd(Info.CAM_CMD_SEND)
-            + struct.pack("!H", num_words)
-        )
-        q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if cmd_str == OpCode.MODE_REPLAY:
-        q.add_log_cmd("PLOC MPSoC: Tc mode replay")
-        data = object_id.as_bytes + struct.pack("!I", ActionId.TC_MODE_REPLAY)
-        q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if cmd_str == OpCode.MODE_IDLE:
-        q.add_log_cmd("PLOC MPSoC: Tc mode idle")
-        data = object_id.as_bytes + struct.pack("!I", ActionId.TC_MODE_IDLE)
-        q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if cmd_str == "16":
-        q.add_log_cmd("PLOC MPSoC: Tc cam command send")
         cam_cmd = input("Specify cam command string: ")
         data = (
             object_id.as_bytes
@@ -316,6 +279,44 @@ def pack_ploc_mpsoc_commands(
             + bytearray(cam_cmd, "utf-8")
         )
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
+    if cmd_str == OpCode.ENABLE_TC_EXECUTION:
+        q.add_log_cmd(Info.ENABLE_TC_EXECUTION)
+        while True:
+            for key, val in CRIT_CMD_APID_DICT.items():
+                print(f"{key}: {val[0]} with APID {val[1]}")
+            key = input("Please specify the command to enable by key: ")
+            if key not in CRIT_CMD_APID_DICT:
+                print("invalid key")
+                continue
+            apid = CRIT_CMD_APID_DICT[key][1]
+            break
+        app_data = struct.pack("!H", apid)
+        q.add_pus_tc(
+            create_action_cmd(PLOC_MPSOC_ID, ActionId.TC_ENABLE_TC_EXECUTION, app_data)
+        )
+    if cmd_str == OpCode.FLASH_MKFS:
+        q.add_log_cmd(Info.FLASH_MKFS)
+        while True:
+            flash_select = int(input("Please select the flash ID (0 or 1): "))
+            if flash_select != 0 and flash_select != 1:
+                _LOGGER.warn("invalid flash select")
+                continue
+            break
+        q.add_pus_tc(
+            create_action_cmd(
+                PLOC_MPSOC_ID, ActionId.TC_FLASH_MKFS, bytes([flash_select])
+            )
+        )
+
+    if cmd_str == OpCode.SPLIT_FILE:
+        q.add_log_cmd(Info.SPLIT_FILE)
+        q.add_pus_tc(
+            create_action_cmd(
+                PLOC_MPSOC_ID,
+                ActionId.TC_SPLIT_FILE,
+                user_data=prepare_simplex_store_file_user_data(),
+            )
+        )
     if cmd_str == "17":
         q.add_log_cmd("PLOC MPSoC: Set UART TX tristate")
         data = object_id.as_bytes + struct.pack("!I", ActionId.SET_UART_TX_TRISTATE)
@@ -328,18 +329,30 @@ def pack_ploc_mpsoc_commands(
         q.add_log_cmd("PLOC MPSoC: Cam take picture")
         data = prepare_cam_take_pic_cmd(object_id.as_bytes)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if cmd_str == OpCode.SIMPLEX_SEND_FILE:
+    if cmd_str == OpCode.SIMPLEX_STREAM_FILE:
-        q.add_log_cmd("PLOC MPSoC: Simplex send file")
+        q.add_log_cmd(Info.SIMPLEX_STREAM_FILE)
-        data = prepare_simplex_send_file_cmd(object_id.as_bytes)
+        data = prepare_simplex_stream_file_user_data()
-        q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
+        q.add_pus_tc(
+            create_action_cmd(
+                PLOC_MPSOC_ID, ActionId.TC_SIMPLEX_STREAM_FILE, user_data=data
+            )
+        )
     if cmd_str == OpCode.DOWNLINK_DATA_MODULATE:
         q.add_log_cmd("PLOC MPSoC: Downlink data modulate")
         data = prepare_downlink_data_modulate_cmd(object_id.as_bytes)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
     if cmd_str == OpCode.MODE_SNAPSHOT:
-        q.add_log_cmd("PLOC MPSoC: Mode snapshot")
+        q.add_log_cmd(Info.MODE_SNAPSHOT)
-        data = object_id.as_bytes + struct.pack("!I", ActionId.TC_MODE_SNAPSHOT)
+        mode = prompt_mode_for_submode_change()
-        q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
+        q.add_pus_tc(create_mode_command(PLOC_MPSOC_ID, mode, Submode.SNAPSHOT))
+    if cmd_str == OpCode.MODE_IDLE:
+        q.add_log_cmd(Info.MODE_IDLE)
+        mode = prompt_mode_for_submode_change()
+        q.add_pus_tc(create_mode_command(PLOC_MPSOC_ID, mode, Submode.IDLE_OR_NONE))
+    if cmd_str == OpCode.MODE_REPLAY:
+        q.add_log_cmd(Info.MODE_REPLAY)
+        mode = prompt_mode_for_submode_change()
+        q.add_pus_tc(create_mode_command(PLOC_MPSOC_ID, mode, Submode.REPLAY))
     if cmd_str == OpCode.ENABLE_PLOC_SUPV_COMMANDING_TO_ON:
         q.add_log_cmd(Info.ENABLE_PLOC_SUPV_COMMANDING_TO_ON)
         q.add_pus_tc(
@@ -360,6 +373,20 @@ def pack_ploc_mpsoc_commands(
         )
 
 
+def prompt_mode_for_submode_change() -> int:
+    while True:
+        mode = input("Please specify primary mode [0: ON, 1: NORMAL]: ")
+        if mode == "0":
+            mode = Mode.ON
+        elif mode == "1":
+            mode = Mode.NORMAL
+        else:
+            print("Invalid mode")
+            continue
+        break
+    return mode
+
+
 def generate_write_mem_command(
     object_id: bytes, memory_address: int, memory_data: int, mem_len: int
 ) -> bytearray:
@@ -467,10 +494,10 @@ def prepare_replay_write_sequence_cmd(object_id: bytes) -> bytearray:
     return bytearray(command)
 
 
-def prepare_cam_take_pic_cmd(object_id: bytes) -> bytearray:
+def prepare_cam_take_pic_cmd(object_id: bytes) -> bytes:
-    selection = input("Use default parameter? (Y/N): ")
+    filename = input("Specify target filename: ")
+    selection = input("Use default parameter? (y/n): ")
     if selection.lower() in ["y", "1", "yes"]:
-        filename = "0:/test"
         encoder_setting_y = 7
         quantization_y = 0
         encoder_setting_cb = 7
@@ -479,7 +506,6 @@ def prepare_cam_take_pic_cmd(object_id: bytes) -> bytearray:
         quantization_cr = 0
         bypass_compressor = 0
     else:
-        filename = input("Specify filename: ")
         encoder_setting_y = int(input("Specify encoderSetting_Y: "))
         quantization_y = int(input("Specify quantization_Y: "))
         encoder_setting_cb = int(input("Specify encoderSetting_Cb: "))
@@ -490,7 +516,7 @@ def prepare_cam_take_pic_cmd(object_id: bytes) -> bytearray:
     command = (
         object_id
         + struct.pack("!I", ActionId.TC_CAM_TAKE_PIC)
-        + bytearray(filename, "utf-8")
+        + filename.encode()
         + bytes([0])
         + struct.pack("!B", encoder_setting_y)
         + struct.pack("!Q", quantization_y)
@@ -500,18 +526,23 @@ def prepare_cam_take_pic_cmd(object_id: bytes) -> bytearray:
         + struct.pack("!Q", quantization_cr)
         + struct.pack("!B", bypass_compressor)
     )
-    return bytearray(command)
+    return command
 
 
-def prepare_simplex_send_file_cmd(object_id: bytes) -> bytearray:
+def prepare_simplex_stream_file_user_data() -> bytes:
+    filename = input("Specify filename: ")
+    command = filename.encode() + bytes([0])
+    return command
+
+
+def prepare_simplex_store_file_user_data() -> bytes:
+    num_of_chunks = int(input("Please specify the number of chunks: "))
+    assert num_of_chunks >= 0
     filename = input("Specify filename: ")
     command = (
-        object_id
+        struct.pack("!I", num_of_chunks) + bytearray(filename, "utf-8") + bytes([0])
-        + struct.pack("!I", ActionId.TC_SIMPLEX_SEND_FILE)
-        + bytearray(filename, "utf-8")
-        + bytes([0])
     )
-    return bytearray(command)
+    return command
 
 
 def prepare_downlink_data_modulate_cmd(object_id: bytes) -> bytearray:
@@ -686,7 +717,7 @@ class DirElement:
     size: int
 
 
-def handle_mpsoc_data_reply(action_id: int, pw: PrintWrapper, custom_data: bytearray):
+def handle_mpsoc_data_reply(action_id: int, pw: PrintWrapper, custom_data: bytes):
     if action_id == ActionId.TM_MEM_READ_RPT:
         header_list = [
             "PLOC Memory Address",
@@ -714,11 +745,13 @@ def handle_mpsoc_data_reply(action_id: int, pw: PrintWrapper, custom_data: bytea
                 "PLOC MPSoC flash directory data shorter than minimum 16 bytes"
             )
         current_idx = 0
-        dir_name_short = custom_data[current_idx : current_idx + 12].decode("utf-8")
+        end_of_str = custom_data[current_idx : current_idx + 12].index(b"\x00")
+        dir_name_short = custom_data[current_idx : current_idx + end_of_str].decode()
         current_idx += 12
         num_elements = struct.unpack("!I", custom_data[current_idx : current_idx + 4])[
             0
         ]
+        current_idx += 4
         elem_names = []
         elem_attrs = []
         elem_sizes = []
@@ -734,9 +767,7 @@ def handle_mpsoc_data_reply(action_id: int, pw: PrintWrapper, custom_data: bytea
         # It is as weird as it looks..
         for _ in range(num_elements):
             end_of_str = custom_data[current_idx : current_idx + 12].index(b"\x00")
-            elem_name = custom_data[current_idx : current_idx + end_of_str].decode(
+            elem_name = custom_data[current_idx : current_idx + end_of_str].decode()
-                "utf-8"
-            )
             current_idx += 12
             elem_names.append(elem_name)
         for _ in range(num_elements):

eive_tmtc/tmtc/payload/ploc_supervisor.py

@@ -19,7 +19,7 @@ from tmtccmd.config.tmtc import CmdTreeNode
 from tmtccmd.tmtc import DefaultPusQueueHelper
 from tmtccmd.pus.s200_fsfw_mode import pack_mode_data, Mode
 from tmtccmd.pus.s8_fsfw_action import create_action_cmd
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 from eive_tmtc.utility.input_helper import InputHelper
 
 _LOGGER = logging.getLogger(__name__)
@@ -112,7 +112,7 @@ class SupvActionId(enum.IntEnum):
     REQUEST_ADC_REPORT = 57
     RESET_PL = 58
     ENABLE_NVMS = 59
-    CONTINUE_UPDATE = 60
+    RESUME_UPDATE = 60
     MEM_CHECK = 61
 
 
@@ -137,7 +137,7 @@ class OpCode:
     SET_TIME_REF = "set_time_ref"
     FACTORY_FLASH = "factory_flash"
     START_UPDATE = "start_update"
-    PERFORM_UPDATE = "update"
+    RESUME_UPDATE = "resum_update"
     FACTORY_RESET = "factory_reset"
     MEM_CHECK = "mem_check"
     RESET_MPSOC = "reset_mpsoc"
@@ -156,7 +156,7 @@ class Info(str, enum.Enum):
     SHUTDOWN_MPSOC = "Shutdown MPSoC"
     SET_TIME_REF = "Set time reference"
     FACTORY_FLASH = "Factory Flash Mode"
-    PERFORM_UPDATE = "Start or continue MPSoC SW update at starting bytes"
+    RESUME_UPDATE = "Start or continue MPSoC SW update at starting bytes"
     START_UPDATE = "Start new MPSoC SW update"
     FACTORY_RESET = "Factory Reset of loggers"
     MEM_CHECK = "Memory Check"
@@ -331,7 +331,7 @@ def pack_ploc_supv_commands(q: DefaultPusQueueHelper, cmd_str: str):  # noqa C90
         q.add_log_cmd("PLOC Supversior: Start new MPSoC SW update")
         command = pack_update_command(object_id.as_bytes, True)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
-    if cmd_str in OpCode.PERFORM_UPDATE:
+    if cmd_str in OpCode.RESUME_UPDATE:
         q.add_log_cmd("PLOC Supervisor: Perform MPSoC SW update")
         command = pack_update_command(object_id.as_bytes, False)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
@@ -370,7 +370,7 @@ def pack_ploc_supv_commands(q: DefaultPusQueueHelper, cmd_str: str):  # noqa C90
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
     if cmd_str == "58":
         q.add_log_cmd("PLOC Supervisor: Continue update")
-        command = object_id.as_bytes + struct.pack("!I", SupvActionId.CONTINUE_UPDATE)
+        command = object_id.as_bytes + struct.pack("!I", SupvActionId.RESUME_UPDATE)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
     if cmd_str == OpCode.MEM_CHECK:
         custom_data = bytearray()
@@ -650,8 +650,10 @@ def get_event_buffer_path() -> str:
 class SocState(enum.IntEnum):
     OFF = 0
     BOOTING = 1
-    OPERATIONAL = 2
+    UPDATE = 2
-    SHUTDOWN = 3
+    OPERATIONAL = 3
+    RESET = 4
+    FAULTY = 5
 
 
 def handle_supv_hk_data(set_id: int, hk_data: bytes, pw: PrintWrapper):
@@ -691,12 +693,15 @@ def handle_hk_report(hk_data: bytes, pw: PrintWrapper):
     pw.dlog(f"Temp PS {temp_ps} C | Temp PL {temp_pl} C | Temp SUP {temp_sup} C")
     pw.dlog(f"Uptime {uptime} | CPU Load {cpu_load} | Avail Heap {avail_heap}")
     pw.dlog(f"Number TCs {num_tcs} | Number TMs {num_tms}")
+    try:
         pw.dlog(f"SOC state {SocState(soc_state)}")
+    except ValueError:
+        pw.dlog(f"Invalid SOC state {soc_state}")
     pw.dlog(f"NVM 01 State {nvm_0_1_state}")
     pw.dlog(f"NVM 3 State {nvm_3_state}")
     pw.dlog(f"Mission IO state {mission_io_state}")
     pw.dlog(f"FMC state {fmc_state}")
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[inc_len:], 13))
+    pw.dlog(get_validity_buffer_str(hk_data[inc_len:], 13))
 
 
 def handle_boot_report(hk_data: bytes, pw: PrintWrapper):
@@ -725,7 +730,7 @@ def handle_boot_report(hk_data: bytes, pw: PrintWrapper):
     pw.dlog(f"Active NVM: {active_nvm}")
     pw.dlog(f"BP0 State {bp_0_state} | BP1 State {bp_1_state} | BP2 State {bp_2_state}")
     pw.dlog(f"Boot State {boot_state} | Boot Cycles {boot_cycles}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], 10)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], 10))
 
 
 def handle_adc_report(hk_data: bytes):

eive_tmtc/tmtc/payload/plpcdu.py

@@ -28,7 +28,7 @@ from tmtccmd.pus.s20_fsfw_param import (
 )
 from spacepackets.ecss.tc import PusTelecommand
 from eive_tmtc.config.object_ids import PL_PCDU_ID
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -615,8 +615,8 @@ def handle_plpcdu_hk(pw: PrintWrapper, set_id: int, hk_data: bytes):
         pw.dlog(ch_print)
         for i in range(12):
             pw.dlog(f"{ADC_CHANNELS_NAMED[i].ljust(24)} | {processed_vals[i]}")
-        FsfwTmTcPrinter.get_validity_buffer(
+        pw.dlog(
-            validity_buffer=hk_data[current_idx:], num_vars=3
+            get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=3)
         )
 
 

eive_tmtc/tmtc/payload/rad_sensor.py

@@ -18,7 +18,7 @@ from tmtccmd.tmtc import DefaultPusQueueHelper
 from tmtccmd.pus.s200_fsfw_mode import Mode, pack_mode_data
 from tmtccmd.pus.tc.s3_fsfw_hk import generate_one_hk_command, make_sid
 from tmtccmd.util import ObjectIdU32
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 
 class SetId(enum.IntEnum):
@@ -115,6 +115,6 @@ def handle_rad_sensor_data(pw: PrintWrapper, set_id: int, hk_data: bytes):
         for idx, val in ain_dict.items():
             pw.dlog(f"{idx} | {val:#06x} | {str(val).ljust(5)}")
         current_idx += inc_len
-        FsfwTmTcPrinter.get_validity_buffer(
+        pw.dlog(
-            validity_buffer=hk_data[current_idx:], num_vars=7
+            get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=7)
         )

eive_tmtc/tmtc/power/acu.py

@@ -82,7 +82,7 @@ def pack_acu_commands(object_id: ObjectIdU32, q: DefaultPusQueueHelper, cmd_str:
 
 
 def acu_req_hk_cmds(q: DefaultPusQueueHelper, op_code: str):
-    req_hk_cmds("ACU", q, op_code, ACU_HANDLER_ID, [SetId.CORE, SetId.AUX])
+    req_hk_cmds("ACU", q, op_code, ACU_HANDLER_ID, (SetId.CORE, SetId.AUX))
 
 
 class ACUTestProcedure:

eive_tmtc/tmtc/power/bpx_batt.py

@@ -5,7 +5,7 @@ from spacepackets.ecss import PusTelecommand
 from tmtccmd.config.tmtc import (
     CmdTreeNode,
 )
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 from tmtccmd.pus.s8_fsfw_action import create_action_cmd
 from tmtccmd.pus.s200_fsfw_mode import Mode, pack_mode_data
 from tmtccmd.pus.s200_fsfw_mode import Subservice as ModeSubservices
@@ -213,9 +213,7 @@ def handle_bpx_hk_data(pw: PrintWrapper, set_id: int, hk_data: bytes):
         validity_buffer = hk_data[inc_len:]
         pw.dlog(str(HEADER_LIST))
         pw.dlog(str(content_list))
-        FsfwTmTcPrinter.get_validity_buffer(
+        pw.dlog(get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=10))
-            validity_buffer=validity_buffer, num_vars=10
-        )
     elif set_id == BpxSetId.GET_CFG_SET:
         battheat_mode = hk_data[0]
         battheat_low = struct.unpack("!b", hk_data[1:2])[0]
@@ -229,6 +227,4 @@ def handle_bpx_hk_data(pw: PrintWrapper, set_id: int, hk_data: bytes):
         validity_buffer = hk_data[3:]
         pw.dlog(str(header_list))
         pw.dlog(str(content_list))
-        FsfwTmTcPrinter.get_validity_buffer(
+        pw.dlog(get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=10))
-            validity_buffer=validity_buffer, num_vars=10
-        )

eive_tmtc/tmtc/power/p60dock.py

@@ -259,4 +259,4 @@ def create_p60_dock_node() -> CmdTreeNode:
 
 
 def p60_dock_req_hk_cmds(q: DefaultPusQueueHelper, op_code: str):
-    req_hk_cmds("P60 Dock", q, op_code, P60_DOCK_HANDLER, [SetId.CORE, SetId.AUX])
+    req_hk_cmds("P60 Dock", q, op_code, P60_DOCK_HANDLER, (SetId.CORE, SetId.AUX))

eive_tmtc/tmtc/power/pdu1.py

@@ -98,7 +98,7 @@ def pack_pdu1_commands(object_id: ObjectIdU32, q: DefaultPusQueueHelper, cmd_str
 
 
 def pdu1_req_hk_cmds(q: DefaultPusQueueHelper, op_code: str):
-    req_hk_cmds("PDU1", q, op_code, PDU_1_HANDLER_ID, [SetId.CORE, SetId.AUX])
+    req_hk_cmds("PDU1", q, op_code, PDU_1_HANDLER_ID, (SetId.CORE, SetId.AUX))
 
 
 def info_on_pdu1(base: str) -> str:

eive_tmtc/tmtc/power/pdu2.py

@@ -332,7 +332,7 @@ def add_pdu2_common_defs(oce: OpCodeEntry):
 
 
 def pdu2_req_hk_cmds(q: DefaultPusQueueHelper, op_code: str):
-    req_hk_cmds("PDU2", q, op_code, PDU_2_HANDLER_ID, [SetId.CORE, SetId.AUX])
+    req_hk_cmds("PDU2", q, op_code, PDU_2_HANDLER_ID, (SetId.CORE, SetId.AUX))
 
 
 def pl_pcdu_bat_nom_on_cmd(q: DefaultPusQueueHelper):

eive_tmtc/tmtc/power/pwr_ctrl.py

@@ -6,7 +6,7 @@ import struct
 from tmtccmd.config.tmtc import (
     CmdTreeNode,
 )
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 from tmtccmd.pus.s20_fsfw_param import create_load_param_cmd
 from tmtccmd.pus.s20_fsfw_param_defs import (
     create_scalar_double_parameter,
@@ -268,7 +268,7 @@ def handle_core_hk_data(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"Total Battery Current: {total_battery_current} [mA]")
     pw.dlog(f"Open Circuit Voltage Charge: {open_circuit_voltage_charge*100:8.3f} [%]")
     pw.dlog(f"Coulomb Counter Charge: {coulomb_counter_charge*100:8.3f} [%]")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=3)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=3))
 
 
 def handle_enable_pl_data(pw: PrintWrapper, hk_data: bytes):
@@ -284,4 +284,4 @@ def handle_enable_pl_data(pw: PrintWrapper, hk_data: bytes):
     )[0]
     current_idx += inc_len_uint16
     pw.dlog(f"PL Use Allowed: {pl_use_allowed}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=1)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=1))

eive_tmtc/tmtc/power/tm.py

@@ -13,7 +13,7 @@ from eive_tmtc.tmtc.power.common_power import (
 )
 from eive_tmtc.tmtc.power.power import PcduSetIds
 from tmtccmd.util import ObjectIdBase
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter, get_validity_buffer_str
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from eive_tmtc.gomspace.gomspace_common import GomspaceDeviceActionId
 from eive_tmtc.config.object_ids import (
@@ -125,6 +125,8 @@ class DevicesInfoParser:
         return current_idx
 
     def print(self, pw: PrintWrapper):
+        if self.dev_types is None or self.dev_statuses is None:
+            return
         pw.dlog("Device Type | Device State (0:None | 1:OK | 3:ERROR | 4:NOT FOUND)")
         for i in range(len(self.dev_types)):
             pw.dlog(
@@ -372,8 +374,8 @@ def handle_p60_hk_data(pw: PrintWrapper, set_id: int, hk_data: bytes):
         temps = f"In C: Temp 0 {temp_0} | Temp 1 {temp_1} | "
         pw.dlog(temps)
         pw.dlog(batt_info)
-        FsfwTmTcPrinter.get_validity_buffer(
+        pw.dlog(
-            validity_buffer=hk_data[current_idx:], num_vars=9
+            get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=9)
         )
     if set_id == SetId.AUX:
         pw.dlog("Received P60 AUX HK. Voltages in mV, currents in mA")
@@ -440,8 +442,8 @@ def handle_p60_hk_data(pw: PrintWrapper, set_id: int, hk_data: bytes):
             "6:TempSens(BatPack)|7:TempSens(BatPack)"
         )
         dev_parser.print(pw=pw)
-        FsfwTmTcPrinter.get_validity_buffer(
+        pw.dlog(
-            validity_buffer=hk_data[current_idx:], num_vars=27
+            get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=27)
         )
 
 
@@ -493,8 +495,8 @@ def handle_acu_hk_data(pw: PrintWrapper, set_id: int, hk_data: bytes):
             f"Boot Count {bootcnt} | Uptime {uptime} sec | "
             f"MPPT Time {mppt_time} msec | MPPT Period {mppt_period} msec"
         )
-        FsfwTmTcPrinter.get_validity_buffer(
+        pw.dlog(
-            validity_buffer=hk_data[current_idx:], num_vars=12
+            get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=12)
         )
     if set_id == SetId.AUX:
         current_idx = 0
@@ -531,13 +533,13 @@ def handle_acu_hk_data(pw: PrintWrapper, set_id: int, hk_data: bytes):
             "ACU Dev Types: 0:FRAM|1:ADC|2:ADC|3:DAC|4:DAC|5:DAC|6:TempSens|7:Reserved"
         )
         dev_parser.print(pw=pw)
-        FsfwTmTcPrinter.get_validity_buffer(
+        pw.dlog(
-            validity_buffer=hk_data[current_idx:], num_vars=8
+            get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=8)
         )
 
 
 def handle_get_param_data_reply(
-    obj_id: ObjectIdBase, action_id: int, pw: PrintWrapper, custom_data: bytearray
+    obj_id: ObjectIdBase, action_id: int, pw: PrintWrapper, custom_data: bytes
 ):
     if action_id == GomspaceDeviceActionId.PARAM_GET:
         pw.dlog(f"Parameter Get Request received for object {obj_id}")
@@ -677,4 +679,4 @@ def handle_pcdu_hk(pw: PrintWrapper, set_id: int, hk_data: bytes):
             pw.dlog(f"{name.ljust(25)}: {val}")
         pw.dlog(f"{'P60 Dock 5V Stack'.ljust(25)}: {p60_stack_5v_val}")
         pw.dlog(f"{'P60 Dock 3V3 Stack'.ljust(25)}: {p60_stack_3v3_val}")
-        FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], 4)
+        pw.dlog(get_validity_buffer_str(hk_data[current_idx:], 4))

eive_tmtc/tmtc/tcs/rtd.py

@@ -13,7 +13,7 @@ from tmtccmd.util import ObjectIdU32
 from tmtccmd.pus.s200_fsfw_mode import Mode, pack_mode_data, Subservice
 import eive_tmtc.config.object_ids as oids
 from eive_tmtc.config.object_ids import get_object_ids
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 RTD_IDS = [
     oids.RTD_0_PLOC_HSPD,
@@ -170,7 +170,7 @@ def handle_rtd_hk(object_id: bytes, hk_data: bytes, pw: PrintWrapper):
     pw.dlog(f"RTD Value: {rtd_val}")
     pw.dlog(f"Error Byte: {error_byte}")
     pw.dlog(f"Last Error Byte: {last_err_byte}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[fmt_len:], 4)
+    pw.dlog(get_validity_buffer_str(hk_data[fmt_len:], 4))
 
 
 def prompt_rtd_idx():

eive_tmtc/tmtc/tcs/tmp1075.py

@@ -18,7 +18,7 @@ from tmtccmd.config.tmtc import (
     TmtcDefinitionWrapper,
     OpCodeEntry,
 )
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 from tmtccmd.tmtc import DefaultPusQueueHelper
 from tmtccmd.pus.s200_fsfw_mode import Mode, pack_mode_data
 from tmtccmd.pus.tc.s3_fsfw_hk import create_request_one_hk_command, make_sid
@@ -96,4 +96,4 @@ def handle_tmp_1075_hk_data(set_id: int, hk_data: bytes, pw: PrintWrapper):
     if set_id == SetId.TEMPERATURE:
         temp = struct.unpack("!f", hk_data[0:4])[0]
         pw.dlog(f"TMP1075 Temperature: {temp}")
-        pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[4:], 1))
+        pw.dlog(get_validity_buffer_str(hk_data[4:], 1))

pyproject.toml

@@ -6,7 +6,7 @@ build-backend = "setuptools.build_meta"
 name = "eive-tmtc"
 description = "TMTC Commander EIVE"
 readme = "README.md"
-version = "6.2.0"
+version = "7.1.0"
 requires-python = ">=3.10"
 license = {text = "Apache-2.0"}
 authors = [
@@ -29,9 +29,9 @@ classifiers = [
   "Topic :: Scientific/Engineering"
 ]
 dependencies = [
-  # "tmtccmd~=8.0.0rc2",
+  "tmtccmd ~= 8.0.1",
-  "cfdp-py~=0.1.1",
+  # "tmtccmd @ git+https://github.com/robamu-org/tmtccmd@main",
-  "tmtccmd @ git+https://github.com/robamu-org/tmtccmd@main",
+  "cfdp-py~=0.1.0",
   "python-dateutil ~= 2.8",
 ]
 
@@ -45,7 +45,7 @@ include-package-data = true
 [tool.setuptools.packages]
 find = {}
 
-[tool.ruff]
+[tool.ruff.lint]
 ignore = ["E501"]
-[tool.ruff.extend-per-file-ignores]
+[tool.ruff.lint.extend-per-file-ignores]
 "__init__.py" = ["F401"]

tmtcc.py

@@ -97,8 +97,8 @@ def setup_params() -> Tuple[SetupWrapper, int]:
         hk_level = int(post_arg_parsing_wrapper.args_raw.hk)
     else:
         hk_level = 0
-    if params.tc_params.print_tree:
+    if params.cmd_params.print_tree:
-        perform_tree_printout(params.tc_params, hook_obj.get_command_definitions())
+        perform_tree_printout(params.cmd_params, hook_obj.get_command_definitions())
         sys.exit(0)
     params.apid = PUS_APID
     if params.com_if is None:
@@ -232,7 +232,6 @@ def main():  # noqa C901: Complexity okay here.
             state = tmtc_backend.periodic_op(None)
             tc_handler.cfdp_in_ccsds_handler.state_machine()
             if state.request == BackendRequest.TERMINATION_NO_ERROR:
-                tmtc_backend.close_com_if()
                 sys.exit(0)
             elif state.request == BackendRequest.DELAY_IDLE:
                 _LOGGER.info("TMTC Client in IDLE mode")
@@ -253,7 +252,6 @@ def main():  # noqa C901: Complexity okay here.
             elif state.request == BackendRequest.CALL_NEXT:
                 pass
     except KeyboardInterrupt:
-        tmtc_backend.close_com_if()
         sys.exit(0)