Merge pull request 'Fix for Heater Cmd' (#284) from heater-health into main

Reviewed-on: #284

CHANGELOG.md

@@ -10,6 +10,20 @@ list yields a list of all related PRs for each release.
 
 # [unreleased]
 
+## Added
+
+- Added version set for STR
+
+## Fixed
+
+- EPS power commands working again.
+
+# [v6.1.1] 2024-03-06
+
+## Added
+
+- Added Core Ctrl cmd to update leap seconds.
+
 # [v6.1.0] 2024-02-29
 
 ## Added

eive_tmtc/pus_tc/cmd_demux.py

@@ -116,9 +116,9 @@ def handle_pus_procedure(
 
 def handle_eps_procedure(queue_helper: DefaultPusQueueHelper, cmd_path_list: List[str]):
     obj_id_man = get_object_ids()
-    if len(cmd_path_list) == 1:
-        return pack_power_commands(queue_helper, cmd_path_list[0])
-    assert len(cmd_path_list) >= 2
+    assert len(cmd_path_list) >= 1
+    if cmd_path_list[0] == "power":
+        return pack_power_commands(queue_helper, cmd_path_list[1])
     if cmd_path_list[0] == "pwr_ctrl":
         return pack_power_ctrl_command(queue_helper, cmd_path_list[1])
     if cmd_path_list[0] == "p60_dock":

eive_tmtc/tmtc/acs/acs_ctrl.py

@@ -7,12 +7,7 @@ import struct
 from socket import AF_INET
 from typing import Tuple
 
-from tmtccmd.config.tmtc import (
-    CmdTreeNode,
-    OpCodeEntry,
-    TmtcDefinitionWrapper,
-    tmtc_definitions_provider,
-)
+from tmtccmd.config.tmtc import CmdTreeNode
 from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
 from tmtccmd.pus.s8_fsfw_action import create_action_cmd
 from tmtccmd.pus.s20_fsfw_param import create_load_param_cmd
@@ -37,7 +32,6 @@ from tmtccmd.pus.tc.s3_fsfw_hk import (
 )
 from tmtccmd.tmtc.queue import DefaultPusQueueHelper
 
-from eive_tmtc.config.definitions import CustomServiceList
 from eive_tmtc.config.object_ids import ACS_CONTROLLER
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from eive_tmtc.tmtc.acs.defs import AcsMode, SafeSubmode

eive_tmtc/tmtc/acs/star_tracker.py

@@ -140,9 +140,15 @@ class OpCode:
     SELECT_TARGET_FIRMWARE_BACKUP = "fw_backup"
     SELECT_TARGET_FIRMWARE_MAIN_PERSISTENT = "fw_main_persistent"
     SELECT_TARGET_FIRMWARE_BACKUP_PERSISTENT = "fw_backup_persistent"
+    REQUEST_VERSION = "request_version"
 
 
 class Info:
+    ON_BOOTLOADER = "Switch to Mode On, Submode Bootloder"
+    ON_FIRMWARE = "Switch to Mode On, Submode Firmware"
+    NORMAL = "Switch to Mode Normal"
+    OFF = "Switch to Mode Off"
+    PING = "Send Ping"
     ONE_SHOOT_HK = "One shoot HK Set"
     ENABLE_HK = "Enable Periodic HK"
     DISABLE_HK = "Disable Periodic HK"
@@ -163,6 +169,7 @@ class Info:
     SELECT_TARGET_FIRMWARE_BACKUP_PERSISTENT = (
         "Select backup firmware slot persistently"
     )
+    REQUEST_VERSION = "Request the active Firmware Version"
 
 
 class SetId(enum.IntEnum):
@@ -316,10 +323,6 @@ def pack_star_tracker_commands(  # noqa C901
         q.add_log_cmd("Star tracker: Temperature request")
         data = obyt + struct.pack("!I", StarTrackerActionId.REQ_TEMPERATURE)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if cmd_str == "8":
-        q.add_log_cmd("Star tracker: Request version")
-        data = obyt + struct.pack("!I", StarTrackerActionId.REQ_VERSION)
-        q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
     if cmd_str == "9":
         q.add_log_cmd("Star tracker: Request interface")
         data = obyt + struct.pack("!I", StarTrackerActionId.REQ_INTERFACE)
@@ -730,6 +733,13 @@ def pack_star_tracker_commands(  # noqa C901
     if cmd_str == OpCode.SELECT_TARGET_FIRMWARE_BACKUP_PERSISTENT:
         q.add_log_cmd(Info.SELECT_TARGET_FIRMWARE_BACKUP)
         q.add_pus_tc(create_update_firmware_target_cmd(True, FirmwareTarget.BACKUP))
+    if cmd_str == OpCode.REQUEST_VERSION:
+        q.add_log_cmd(Info.REQUEST_VERSION)
+        q.add_pus_tc(
+            create_action_cmd(
+                object_id=STAR_TRACKER_ID, action_id=StarTrackerActionId.REQ_VERSION
+            )
+        )
 
 
 def create_update_firmware_target_cmd(
@@ -880,6 +890,8 @@ def handle_str_hk_data(set_id: int, hk_data: bytes, pw: PrintWrapper):
         handle_contrast_set(hk_data, pw)
     elif set_id == SetId.BLOB_STATS:
         handle_blob_stats_set(hk_data, pw)
+    elif set_id == SetId.VERSION:
+        handle_version_set(hk_data, pw)
     else:
         _LOGGER.warning(f"HK parsing for Star Tracker set ID {set_id} unimplemented")
 
@@ -902,6 +914,25 @@ def unpack_time_hk(hk_data: bytes, current_idx: int, pw: PrintWrapper) -> int:
     return current_idx
 
 
+def handle_version_set(hk_data: bytes, pw: PrintWrapper):
+    pw.dlog("Received Version Set")
+    if len(hk_data) != 16:
+        _LOGGER.warning(
+            f"Version dataset HK with length {len(hk_data)} of unexpected size"
+        )
+    current_idx = unpack_time_hk(hk_data, 0, pw)
+    program = struct.unpack("!B", hk_data[current_idx : current_idx + 1])[0]
+    pw.dlog(f"Program: {program}")
+    current_idx += 1
+    major = struct.unpack("!B", hk_data[current_idx : current_idx + 1])[0]
+    pw.dlog(f"Major: {major}")
+    current_idx += 1
+    minor = struct.unpack("!B", hk_data[current_idx : current_idx + 1])[0]
+    pw.dlog(f"Minor: {minor}")
+    current_idx += 1
+    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=5))
+
+
 def handle_temperature_set(hk_data: bytes, pw: PrintWrapper):
     pw.dlog("Received temperature set")
     if len(hk_data) < 24:
@@ -1208,7 +1239,7 @@ def handle_blob_stats_set(hk_data: bytes, pw: PrintWrapper):
                 i, noise_list[i], threshold_list[i], lvalid_list[i], oflow_list[i]
             )
         )
-    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=4))
+    pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=6))
 
 
 def handle_star_tracker_action_replies(
@@ -1251,60 +1282,15 @@ def handle_read_secondary_tm_set(pw: PrintWrapper, custom_data: bytes):
 
 
 def create_str_node() -> CmdTreeNode:
+    # Zip the two classes together into a dictionary
+    op_code_strs = [
+        getattr(OpCode, key) for key in dir(OpCode) if not key.startswith("__")
+    ]
+    info_strs = [getattr(Info, key) for key in dir(OpCode) if not key.startswith("__")]
+    combined_dict = dict(zip(op_code_strs, info_strs))
     node = CmdTreeNode(
         "str", "Star Tracker Device", hide_children_which_are_leaves=True
     )
-    node.add_child(CmdTreeNode(OpCode.ON_BOOTLOADER, "Mode On, Submode Bootloader"))
-    node.add_child(CmdTreeNode(OpCode.ON_FIRMWARE, "Mode On, Submode Firmware"))
-    node.add_child(CmdTreeNode(OpCode.NORMAL, "Mode Normal"))
-    node.add_child(CmdTreeNode(OpCode.OFF, "Mode Off"))
-    node.add_child(CmdTreeNode(OpCode.PING, "Star Tracker: Ping"))
-    node.add_child(CmdTreeNode(OpCode.TAKE_IMAGE, "Take Image"))
-    node.add_child(CmdTreeNode(OpCode.UPLOAD_IMAGE, Info.UPLOAD_IMAGE))
-    node.add_child(CmdTreeNode(OpCode.DOWNLOAD_IMAGE, Info.DOWNLOAD_IMAGE))
-    node.add_child(CmdTreeNode(OpCode.ONE_SHOOT_HK, Info.ONE_SHOOT_HK))
-    node.add_child(CmdTreeNode(OpCode.ENABLE_HK, Info.ENABLE_HK))
-    node.add_child(CmdTreeNode(OpCode.DISABLE_HK, Info.DISABLE_HK))
-    node.add_child(
-        CmdTreeNode(OpCode.SET_IMG_PROCESSOR_MODE, Info.SET_IMG_PROCESSOR_MODE)
-    )
-    node.add_child(
-        CmdTreeNode(
-            OpCode.ADD_SECONDARY_TM_TO_NORMAL_MODE,
-            Info.ADD_SECONDARY_TM_TO_NORMAL_MODE,
-        )
-    )
-    node.add_child(
-        CmdTreeNode(OpCode.READ_SECONDARY_TM_SET, Info.READ_SECONDARY_TM_SET)
-    )
-    node.add_child(
-        CmdTreeNode(OpCode.RESET_SECONDARY_TM_SET, Info.RESET_SECONDARY_TM_SET)
-    )
-    node.add_child(CmdTreeNode(OpCode.FW_UPDATE_MAIN, Info.FW_UPDATE_MAIN))
-    node.add_child(CmdTreeNode(OpCode.FW_UPDATE_BACKUP, Info.FW_UPDATE_BACKUP))
-    node.add_child(
-        CmdTreeNode(
-            OpCode.SELECT_TARGET_FIRMWARE_MAIN, Info.SELECT_TARGET_FIRMWARE_MAIN
-        )
-    )
-    node.add_child(
-        CmdTreeNode(
-            OpCode.SELECT_TARGET_FIRMWARE_BACKUP, Info.SELECT_TARGET_FIRMWARE_BACKUP
-        )
-    )
-    node.add_child(
-        CmdTreeNode(
-            OpCode.SELECT_TARGET_FIRMWARE_MAIN_PERSISTENT,
-            Info.SELECT_TARGET_FIRMWARE_MAIN_PERSISTENT,
-        )
-    )
-    node.add_child(
-        CmdTreeNode(
-            OpCode.SELECT_TARGET_FIRMWARE_BACKUP_PERSISTENT,
-            Info.SELECT_TARGET_FIRMWARE_BACKUP_PERSISTENT,
-        )
-    )
-    node.add_child(
-        CmdTreeNode(OpCode.SET_TIME_FROM_SYS_TIME, Info.SET_TIME_FROM_SYS_TIME)
-    )
+    for op_code, info in combined_dict.items():
+        node.add_child(CmdTreeNode(op_code, info))
     return node

eive_tmtc/tmtc/core.py

@@ -6,7 +6,7 @@ from pathlib import Path
 from typing import Tuple
 
 from spacepackets.ecss import PusTelecommand
-from tmtccmd.config import CmdTreeNode, TmtcDefinitionWrapper
+from tmtccmd.config import CmdTreeNode
 
 from tmtccmd.tmtc import DefaultPusQueueHelper
 from tmtccmd.pus.s8_fsfw_action import create_action_cmd
@@ -15,14 +15,12 @@ from tmtccmd.pus.s20_fsfw_param import (
     create_scalar_u8_parameter,
     create_load_param_cmd,
 )
-from tmtccmd.config.tmtc import OpCodeEntry, tmtc_definitions_provider
 from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
 from tmtccmd.pus.s11_tc_sched import (
     create_enable_tc_sched_cmd,
     create_disable_tc_sched_cmd,
 )
 
-from eive_tmtc.config.definitions import CustomServiceList
 from eive_tmtc.config.object_ids import CORE_CONTROLLER_ID
 from eive_tmtc.pus_tm.defs import PrintWrapper
 
@@ -71,6 +69,7 @@ class ActionId(enum.IntEnum):
     RM_HELPER = 54
     MKDIR_HELPER = 55
     ENABLE_SCHEDULER = 56
+    UPDATE_LEAP_SECONRS = 60
 
 
 class ParamId(enum.IntEnum):
@@ -122,6 +121,7 @@ class OpCode:
     AUTO_SWITCH_DISABLE = "auto_switch_disable"
     ENABLE_SCHEDULER = "enable_scheduler"
     DISABLE_SCHEDULER = "disable_scheduler"
+    UPDATE_LEAP_SECONDS = "leap_seconds_update"
 
 
 class Info:
@@ -165,6 +165,7 @@ class Info:
     AUTO_SWITCH_DISABLE = "Disable Auto-Switch Feature"
     ENABLE_SCHEDULER = "Enable scheduler"
     DISABLE_SCHEDULER = "Disable scheduler"
+    UPDATE_LEAP_SECONDS = "Updates the Leap Seconds"
 
 
 class Chip(enum.IntEnum):
@@ -197,90 +198,6 @@ def create_core_node() -> CmdTreeNode:
     return node
 
 
-@tmtc_definitions_provider
-def add_core_controller_definitions(defs: TmtcDefinitionWrapper):
-    oce = OpCodeEntry()
-    oce.add(keys=OpCode.ANNOUNCE_VERSION, info=Info.ANNOUNCE_VERSION)
-    oce.add(keys=OpCode.ANNOUNCE_CURRENT_IMAGE, info=Info.ANNOUNCE_CURRENT_IMAGE)
-    oce.add(keys=OpCode.ANNOUNCE_BOOT_COUNTS, info=Info.ANNOUNCE_BOOT_COUNTS)
-    oce.add(keys=OpCode.REBOOT_XSC, info=Info.REBOOT_XSC)
-    oce.add(keys=OpCode.REBOOT_XSC, info=Info.REBOOT_XSC)
-    oce.add(keys=OpCode.REBOOT_FULL, info=Info.REBOOT_FULL)
-    oce.add(keys=OpCode.XSC_REBOOT_SELF, info="Reboot Self")
-    oce.add(keys=OpCode.XSC_REBOOT_0_0, info="Reboot 0 0")
-    oce.add(keys=OpCode.XSC_REBOOT_0_1, info="Reboot 0 1")
-    oce.add(keys=OpCode.XSC_REBOOT_1_0, info="Reboot 1 0")
-    oce.add(keys=OpCode.XSC_REBOOT_1_1, info="Reboot 1 1")
-    oce.add(keys=OpCode.SET_PREF_SD, info=Info.SET_PREF_SD)
-    oce.add(
-        keys=OpCode.READ_REBOOT_MECHANISM_INFO, info=Info.READ_REBOOT_MECHANISM_INFO
-    )
-    oce.add(keys=OpCode.OBSW_UPDATE_FROM_TMP, info=Info.OBSW_UPDATE_FROM_TMP)
-    oce.add(keys=OpCode.OBSW_UPDATE_FROM_SD_0, info=Info.OBSW_UPDATE_FROM_SD_0)
-    oce.add(keys=OpCode.OBSW_UPDATE_FROM_SD_1, info=Info.OBSW_UPDATE_FROM_SD_1)
-    oce.add(keys=OpCode.AUTO_SWITCH_ENABLE, info=Info.AUTO_SWITCH_ENABLE)
-    oce.add(keys=OpCode.AUTO_SWITCH_DISABLE, info=Info.AUTO_SWITCH_DISABLE)
-    oce.add(keys=OpCode.SYSTEMCTL_CMD_EXECUTOR, info=Info.SYSTEMCTL_CMD_EXECUTOR)
-    oce.add(
-        keys=OpCode.EXECUTE_SHELL_CMD_BLOCKING, info=Info.EXECUTE_SHELL_CMD_BLOCKING
-    )
-    oce.add(
-        keys=OpCode.EXECUTE_SHELL_CMD_NON_BLOCKING,
-        info=Info.EXECUTE_SHELL_CMD_NON_BLOCKING,
-    )
-    oce.add(
-        keys=OpCode.GET_HK,
-        info="Request housekeeping set",
-    )
-    oce.add(
-        keys=OpCode.ENABLE_REBOOT_FILE_HANDLING,
-        info="Enable reboot file handling",
-    )
-    oce.add(
-        keys=OpCode.DISABLE_REBOOT_FILE_HANDLING,
-        info="Disable reboot file handling",
-    )
-    oce.add(
-        keys=OpCode.RESET_ALL_REBOOT_COUNTERS,
-        info="Reset all reboot counters",
-    )
-    oce.add(
-        keys=OpCode.RWD_RESET_REBOOT_COUNTER_00,
-        info="Reset reboot counter 0 0",
-    )
-    oce.add(
-        keys=OpCode.RWD_RESET_REBOOT_COUNTER_01,
-        info="Reset reboot counter 0 1",
-    )
-    oce.add(
-        keys=OpCode.RWD_RESET_REBOOT_COUNTER_10,
-        info="Reset reboot counter 1 0",
-    )
-    oce.add(
-        keys=OpCode.RWD_RESET_REBOOT_COUNTER_11,
-        info="Reset reboot counter 1 1",
-    )
-    oce.add(
-        keys=OpCode.RWD_SET_MAX_REBOOT_CNT,
-        info="Reset max reboot count for reboot watchdog",
-    )
-    oce.add(keys=OpCode.OBSW_UPDATE_FROM_SD_0, info=Info.OBSW_UPDATE_FROM_SD_0)
-    oce.add(keys=OpCode.OBSW_UPDATE_FROM_SD_1, info=Info.OBSW_UPDATE_FROM_SD_1)
-    oce.add(keys=OpCode.OBSW_UPDATE_FROM_TMP, info=Info.OBSW_UPDATE_FROM_TMP)
-    oce.add(keys=OpCode.SWITCH_TO_SD_0, info=Info.SWITCH_TO_SD_0)
-    oce.add(keys=OpCode.SWITCH_TO_SD_1, info=Info.SWITCH_TO_SD_1)
-    oce.add(keys=OpCode.SWITCH_TO_BOTH_SD_CARDS, info=Info.SWITCH_TO_BOTH_SD_CARDS)
-    oce.add(keys=OpCode.LIST_DIR_INTO_FILE, info=Info.LIST_DIR_INTO_FILE)
-    oce.add(keys=OpCode.LIST_DIR_DUMP_DIRECTLY, info=Info.LIST_DIR_DUMP_DIRECTLY)
-    oce.add(keys=OpCode.MV_HELPER, info=Info.MV_HELPER)
-    oce.add(keys=OpCode.CP_HELPER, info=Info.CP_HELPER)
-    oce.add(keys=OpCode.RM_HELPER, info=Info.RM_HELPER)
-    oce.add(keys=OpCode.MKDIR_HELPER, info=Info.MKDIR_HELPER)
-    oce.add(keys=OpCode.ENABLE_SCHEDULER, info=Info.ENABLE_SCHEDULER)
-    oce.add(keys=OpCode.DISABLE_SCHEDULER, info=Info.DISABLE_SCHEDULER)
-    defs.add_service(CustomServiceList.CORE.value, "Core Controller", oce)
-
-
 def pack_core_commands(  # noqa C901
     q: DefaultPusQueueHelper, cmd_str: str
 ):  # noqa: C901 , complexity okay here
@@ -557,6 +474,16 @@ def pack_core_commands(  # noqa C901
     elif cmd_str == OpCode.DISABLE_SCHEDULER:
         q.add_log_cmd(Info.DISABLE_SCHEDULER)
         q.add_pus_tc(create_disable_tc_sched_cmd())
+    elif cmd_str == OpCode.UPDATE_LEAP_SECONDS:
+        q.add_log_cmd(Info.UPDATE_LEAP_SECONDS)
+        leap_seconds = int(input("Specify new Leap Seconds Value: ")).to_bytes(
+            length=2, signed=False, byteorder="big"
+        )
+        q.add_pus_tc(
+            create_action_cmd(
+                CORE_CONTROLLER_ID, ActionId.UPDATE_LEAP_SECONRS, leap_seconds
+            )
+        )
     else:
         _LOGGER.warning(
             f"Unknown operation code {cmd_str} for core controller commands"

eive_tmtc/tmtc/tcs/heater.py

@@ -59,7 +59,7 @@ CTN = CmdTreeNode
 
 
 def create_heater_node() -> CmdTreeNode:
-    node = CmdTreeNode("heater", "Heater Device", hide_children_which_are_leaves=True)
+    node = CmdTreeNode("heaters", "Heater Device", hide_children_which_are_leaves=True)
     node.add_child(CTN(OpCode.HEATER_CMD, Info.HEATER_CMD))
     node.add_child(CTN(OpCode.HEATER_HEALTHY_CMD, Info.HEATER_HEALTHY_CMD))
     node.add_child(CTN(OpCode.HEATER_EXT_CTRL, Info.HEATER_EXT_CTRL))

pyproject.toml

@@ -6,7 +6,7 @@ build-backend = "setuptools.build_meta"
 name = "eive-tmtc"
 description = "TMTC Commander EIVE"
 readme = "README.md"
-version = "6.1.0"
+version = "6.1.1"
 requires-python = ">=3.10"
 license = {text = "Apache-2.0"}
 authors = [