fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

DeviceHandlerBase: All Refactoring #44

Merged
mohr merged 56 commits from KSat/fsfw:mueller_DeviceHandlerBase_AllRefactoring into master 2020-07-03 11:48:56 +02:00
Conversation 0 Commits 56 Files Changed 12 +974 -688

56 Commits

Author SHA1 Message Date
Robin Müller cda3130b34 periodic reply map param is bool now 2020-06-19 01:05:51 +02:00
Robin Müller b412ef587a Merge remote-tracking branch 'upstream/master' into mueller_DeviceHandlerBase_AllRefactoring 2020-06-19 00:45:02 +02:00
Robin Müller 9c766c123d device command iter was uninitialized 2020-06-06 20:56:09 +02:00
Robin Müller ca74e0c0f2 removed comments 2020-05-26 16:07:32 +02:00
Robin Müller 9951b59627 DHB retval fixes 2020-05-25 23:45:32 +02:00
Robin Müller dd5b301980 improved returnvalues 2020-05-25 23:38:11 +02:00
Robin Müller 5de68fcc6e some returnvalue comments 2020-05-25 23:36:47 +02:00
Robin Müller 112779d91f cleaned up returnvlaues 2020-05-25 23:31:13 +02:00
Robin Müller 98449ddc7f comment removed 2020-05-25 23:17:15 +02:00
Robin Müller 19b4332801 some little tweaks 2020-05-25 23:16:46 +02:00
Robin Müller df7be467eb nullptr replacements 2020-05-17 17:54:21 +02:00
Robin Müller 0bf8e97830 better error output for invalid passed cookie 2020-05-17 17:49:32 +02:00
Robin Müller 80c6eff8a6 added error output for passed nullptr cookie 2020-05-17 17:46:27 +02:00
Robin Müller deb8ce3744 merged upstream master 2020-05-17 15:53:29 +02:00
Robin Müller e8a1912fda Merge remote-tracking branch 'upstram/master' into mueller_DeviceHandlerBase_AllRefactoring 2020-05-17 15:50:40 +02:00
Robin Müller f4ad38f07f replyMap insertion improvements 2020-05-17 15:47:17 +02:00
Robin Müller 7ceb6f3c96 override for executeAction() 2020-05-17 15:43:45 +02:00
Robin Müller fb0834ffe1 added cookie caching and deletion 2020-05-17 15:28:00 +02:00
Robin Müller b8e7b12a63 commented whole SWITCH IO BOARD block 2020-05-17 13:10:09 +02:00
Robin Müller 614deea323 last size_t replacements 2020-05-07 23:38:28 +02:00
Robin Müller 33eae034c7 replace device comIF uint32_t with size_t 2020-05-07 23:14:29 +02:00
Robin Müller b78b3ac68a added performOperationHook() 2020-04-19 22:17:14 +02:00
Robin Müller 225e1b98a0 some bugfixes in cpp file to enable compilation 2020-04-19 22:10:02 +02:00
Robin Müller 3bd83c00f5 freeRTOS with included with extern"C" 2020-04-19 21:52:13 +02:00
Robin Müller fd100cb994 header function order change 
fillCOmmandANdREplyMAp is now closer to its helper functions
 2020-04-19 16:10:44 +02:00
Robin Müller f4c925e671 Merge branch 'mueller_DeviceHandlerBase_API_change_CookieIF' into mueller_DeviceHandlerBase_AllRefactoring 2020-04-19 15:57:39 +02:00
Robin Müller 7f08bb3506 removed ioboardAddress, max reply Len 2020-04-19 15:54:28 +02:00
Robin Müller 36dbf6e1ce Merge branch 'mueller_DeviceHandlerBase_ctor_reduction' into mueller_DeviceHandlerBase_AllRefactoring 2020-04-19 15:51:58 +02:00
Robin Müller 1820ad14b7 API change introduced, using new device comIF 
also changed child handler base.
 2020-04-19 15:48:17 +02:00
Robin Müller c8983650f7 Merge branch 'mueller_DeviceHandlerBase_Changes' into mueller_newDeviceCommunicationIF 2020-04-19 15:36:42 +02:00
Robin Müller bb650ac784 Merge remote-tracking branch 'origin/mueller_CookieToCookieIF' into mueller_newDeviceCommunicationIF 2020-04-19 15:30:14 +02:00
Robin Müller ff47fa191a Communication interface rework 
As discussed, open/reOpen not used anymore, replaced by
initializeInterface call.
Using CookieIF.
 2020-04-19 15:25:17 +02:00
Robin Müller 520ed881bb wrong function call fixed 2020-04-19 15:16:44 +02:00
Robin Müller ce554c615c reduced massive ctor size 
this was done by moving zero or nullptr initialization
into the header file
 2020-04-19 15:15:33 +02:00
Robin Müller eacedf7ed6 DHB: replyLen in replyMap now 
both maps are closer together now as well
 2020-04-19 15:01:27 +02:00
Robin Müller 74b8c3eef4 new returnvalue DeviceComIF 
explicitely setting receivedDataLen to 0 in readReceivedMessage() does
not trigger error anymore
 2020-04-19 14:52:27 +02:00
Robin Müller 62644bdfc9 DeviceHandlerIF fixed some indentation error 
still some unclarities about returnvalues
so I added a comment on what the returnvalues
in DHB and DH interface mean
 2020-04-19 14:45:28 +02:00
Robin Müller 1ec1d057b8 renamed rmap to com (more generic) 2020-04-19 14:08:20 +02:00
Robin Müller 7126c19ee0 Restructured header file 
Abstract functions are closer to the top
because they must be implemented and documentation
should be near the top.
Important virtual functions moved up too.
Additional documentation added and existing adapted
to 80 column width.
I tried to reduce the number of included files and sorted them a bit
 2020-04-19 14:03:47 +02:00
Robin Müller 574d6051ba new returnvalue for scanForReply 
to ignore full packet
DeviceCommunicationIF sendMessage function takes const data pointer now
 2020-04-19 13:41:43 +02:00
Robin Müller 0c0c8ec448 device handler base indentation 2020-04-19 13:29:50 +02:00
Robin Müller eb9f43d202 Merge remote-tracking branch 'upstream/master' into mueller_DeviceHandlerBase_Changes 2020-04-19 13:27:20 +02:00
Robin Müller 0cb2abfe7e old cookie added again 
will be replaced in separate branch/pull request
 2020-04-19 13:26:40 +02:00
Robin Müller abe7239018 reset, splitting up merge request 2020-04-19 13:24:10 +02:00
Robin Müller a1f36e6ae5 added std:: before uint32_t typedef 2020-04-18 15:05:51 +02:00
Robin Müller db34c45b67 removed self-inclusion 2020-04-18 14:16:46 +02:00
Robin Müller 9c958c06fe Changed Cookie to CookieIF 2020-04-18 14:10:38 +02:00
Robin Müller 81ab5a6914 As discussed, renamed Cookie to CookieIF. 
Also added documentation on the purpose of this class
 2020-04-18 14:03:37 +02:00
Robin Müller ee23a7c0b5 fix 2020-04-06 14:02:33 +02:00
Robin Müller 511c0db8c7 Cookie -> CookieIF, DHB changes 
According to changes agreed on 01.04.2020,
slight refactoring of DHB:
requestLen is set to 0 if no respective reply is enabled
 2020-04-01 12:43:53 +02:00
Robin Müller ac4275ef05 some minor changes 2020-03-27 14:44:54 +01:00
Robin Müller bfb0234d41 more refactoring 2020-03-24 15:59:08 +01:00
Robin Müller ea41514553 new cookie.cpp + cookieIF.h 2020-03-23 19:17:53 +01:00
Robin Müller 59812199fd new cookieIF 2020-03-23 19:16:01 +01:00
Robin Müller 029b2133e6 new adaptions for cookie + comIF changes 
hook for performOp() added
 2020-03-23 18:03:00 +01:00
Robin Müller e03aff3731 Device Handler Base Proposals 
1. Interface functions moved closer to top (and functions which should
be implemented)
2. ioBoardAddress renamed to logicalAddress. getter FUnction added.
3. debug interface for easier debugging of device handlers
4. new documentation
5. new return value for scanForReply to ignore full packet
 2020-02-03 22:34:15 +01:00