Power Switcher Component #596

Merged
muellerr merged 9 commits from eive/fsfw:mueller/power-switcher-component-upstream into development 2022-05-13 22:42:23 +02:00
Owner

Extends #590 , adding a PowerSwitchComponent

Allows to create an power switch object with its own mode and health

This basic component allows to create an object which is solely responsible for managing a switch. It also has a mode and a health by implementing the respective interface components which allows integrating this component into a system mode tree.

Extends #590 , adding a `PowerSwitchComponent` ### Allows to create an power switch object with its own mode and health This basic component allows to create an object which is solely responsible for managing a switch. It also has a mode and a health by implementing the respective interface components which allows integrating this component into a system mode tree.
muellerr added 6 commits 2022-04-01 17:32:30 +02:00
refactor power module
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
6f0362b956
this should compile
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
b32d1da421
small tweaks
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
23af170229
make dummy power switcher a system object
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
b42987059a
change switch type in header as well
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
c20be13733
add new power switcher component
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
c7daf697a8
muellerr added a new dependency 2022-04-01 17:32:53 +02:00
gaisser requested changes 2022-04-04 19:45:57 +02:00
gaisser left a comment
Owner

See comments.

See comments.
@ -0,0 +23,4 @@
}
ReturnValue_t DummyPowerSwitcher::sendFuseOnCommand(uint8_t fuseNr) {
if (fuseNr < fuseList.capacity()) {
Owner

Why do you use capacity() and not size()?

Why do you use capacity() and not size()?
muellerr marked this conversation as resolved
@ -0,0 +30,4 @@
}
ReturnValue_t DummyPowerSwitcher::getSwitchState(power::Switch_t switchNr) const {
if (switchNr < switcherList.capacity()) {
Owner

Why do you use capacity() and not size()?

Why do you use capacity() and not size()?
muellerr marked this conversation as resolved
@ -0,0 +37,4 @@
}
ReturnValue_t DummyPowerSwitcher::getFuseState(uint8_t fuseNr) const {
if (fuseNr < fuseList.capacity()) {
Owner

Why do you use capacity() and not size()?

Why do you use capacity() and not size()?
muellerr marked this conversation as resolved
@ -17,2 +17,3 @@
limits.voltageMin, limits.voltageMax, events.voltageLow, events.voltageHigh) {
commandQueue = QueueFactory::instance()->createMessageQueue();
commandQueue =
QueueFactory::instance()->createMessageQueue(3, MessageQueueMessage::MAX_MESSAGE_SIZE);
Owner

Is the 3 here a specific requiremenet and the MessageQueueSize?

Is the 3 here a specific requiremenet and the MessageQueueSize?
muellerr marked this conversation as resolved
muellerr added 1 commit 2022-04-11 16:08:30 +02:00
Merge branch 'development' into mueller/power-switcher-component-upstream
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
dd1b0a9380
muellerr added 2 commits 2022-04-11 16:09:39 +02:00
muellerr added 1 commit 2022-04-11 16:10:25 +02:00
use default call
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
7af1c86f1c
muellerr added this to the v5.0.0 milestone 2022-04-11 17:34:02 +02:00
muellerr added 1 commit 2022-04-25 15:14:41 +02:00
Merge branch 'development' into mueller/power-switcher-component-upstream
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
50ce13d596
muellerr added 1 commit 2022-05-09 15:51:26 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/power-switcher-component-upstream
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
eb494707af
muellerr added 1 commit 2022-05-12 19:07:18 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/power-switcher-component-upstream
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
171c48495c
muellerr added 1 commit 2022-05-13 13:25:17 +02:00
Merge branch 'development' into mueller/power-switcher-component-upstream
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
e98aa005cb
gaisser approved these changes 2022-05-13 21:46:54 +02:00
gaisser left a comment
Owner

LGTM

LGTM
muellerr merged commit eed6a64597 into development 2022-05-13 22:42:23 +02:00
muellerr deleted branch mueller/power-switcher-component-upstream 2022-05-13 22:42:24 +02:00
Sign in to join this conversation.
No description provided.