fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Power Switcher Component #596

Merged
muellerr merged 9 commits from eive/fsfw:mueller/power-switcher-component-upstream into development 2022-05-13 22:42:23 +02:00
Conversation 0 Commits 9 Files Changed 5 +178 -6
muellerr commented 2022-04-01 17:32:23 +02:00
Owner
Copy Link

Extends #590 , adding a PowerSwitchComponent

Allows to create an power switch object with its own mode and health

This basic component allows to create an object which is solely responsible for managing a switch. It also has a mode and a health by implementing the respective interface components which allows integrating this component into a system mode tree.

Extends #590 , adding a `PowerSwitchComponent` ### Allows to create an power switch object with its own mode and health This basic component allows to create an object which is solely responsible for managing a switch. It also has a mode and a health by implementing the respective interface components which allows integrating this component into a system mode tree.
muellerr added 6 commits 2022-04-01 17:32:30 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
6f0362b956
refactor power module
fsfw/fsfw/pipeline/pr-development This commit looks good Details
b32d1da421
this should compile
fsfw/fsfw/pipeline/pr-development This commit looks good Details
23af170229
small tweaks
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
b42987059a
make dummy power switcher a system object
fsfw/fsfw/pipeline/pr-development This commit looks good Details
c20be13733
change switch type in header as well
fsfw/fsfw/pipeline/pr-development This commit looks good Details
c7daf697a8
add new power switcher component
muellerr added a new dependency 2022-04-01 17:32:53 +02:00
#590 refactor power module
gaisser requested changes 2022-04-04 19:45:57 +02:00
gaisser left a comment
Owner
Copy Link

See comments.

See comments.
src/fsfw/power/DummyPowerSwitcher.cpp Outdated
@ -0,0 +23,4 @@
}
ReturnValue_t DummyPowerSwitcher::sendFuseOnCommand(uint8_t fuseNr) {
if (fuseNr < fuseList.capacity()) {
gaisser commented 2022-04-04 19:33:02 +02:00
Owner
Copy Link

Why do you use capacity() and not size()?

Why do you use capacity() and not size()?
muellerr marked this conversation as resolved
src/fsfw/power/DummyPowerSwitcher.cpp Outdated
@ -0,0 +30,4 @@
}
ReturnValue_t DummyPowerSwitcher::getSwitchState(power::Switch_t switchNr) const {
if (switchNr < switcherList.capacity()) {
gaisser commented 2022-04-04 19:33:23 +02:00
Owner
Copy Link

Why do you use capacity() and not size()?

Why do you use capacity() and not size()?
muellerr marked this conversation as resolved
src/fsfw/power/DummyPowerSwitcher.cpp Outdated
@ -0,0 +37,4 @@
}
ReturnValue_t DummyPowerSwitcher::getFuseState(uint8_t fuseNr) const {
if (fuseNr < fuseList.capacity()) {
gaisser commented 2022-04-04 19:33:09 +02:00
Owner
Copy Link

Why do you use capacity() and not size()?

Why do you use capacity() and not size()?
muellerr marked this conversation as resolved
src/fsfw/power/PowerSensor.cpp Outdated
@ -17,2 +17,3 @@
limits.voltageMin, limits.voltageMax, events.voltageLow, events.voltageHigh) {
commandQueue = QueueFactory::instance()->createMessageQueue();
commandQueue =
QueueFactory::instance()->createMessageQueue(3, MessageQueueMessage::MAX_MESSAGE_SIZE);
gaisser commented 2022-04-04 19:37:30 +02:00
Owner
Copy Link

Is the 3 here a specific requiremenet and the MessageQueueSize?

Is the 3 here a specific requiremenet and the MessageQueueSize?
muellerr marked this conversation as resolved
muellerr added 1 commit 2022-04-11 16:08:30 +02:00
muellerr added 2 commits 2022-04-11 16:09:39 +02:00
muellerr added 1 commit 2022-04-11 16:10:25 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
7af1c86f1c
use default call
muellerr added this to the v5.0.0 milestone 2022-04-11 17:34:02 +02:00
muellerr added 1 commit 2022-04-25 15:14:41 +02:00
muellerr added 1 commit 2022-05-09 15:51:26 +02:00
muellerr added 1 commit 2022-05-12 19:07:18 +02:00
muellerr added 1 commit 2022-05-13 13:25:17 +02:00
gaisser approved these changes 2022-05-13 21:46:54 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
muellerr merged commit eed6a64597 into development 2022-05-13 22:42:23 +02:00
muellerr deleted branch mueller/power-switcher-component-upstream 2022-05-13 22:42:24 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#590 refactor power module
fsfw/fsfw
Reference: fsfw/fsfw#596
No description provided.
Delete Branch "eive/fsfw:mueller/power-switcher-component-upstream"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?