refactor power module #590

Merged
gaisser merged 20 commits from eive/fsfw:mueller/refactor-power-switch-if-etc into development 2022-05-12 18:37:46 +02:00
Owner
  • Remove const specifier from sendSwitchCommand and sendFuseOnCommand and also specify a ReturnValue_t return type. The const specifier can make the API cumbersome and awkward to use.

Concerning repercusions if thread-safety is/might be an issue:

In my opinion, this should be mentioned in the code documentations and implemented by the user, not be enforced with const, which can make the API difficult and/or awkward to use.

  • Add a DummyPowerSwitcher module, which can be useful for test setups when no PCDU is available.
  • Add new definitions file, add new typedef for switches
  • Extend PowerSwitcher to optionally check current state when calling turnOn or turnOff. No need to command the switches if they are already in the correct state
  • Apply auto-formatter
  • Add power switch mock object for unit tests
- Remove `const` specifier from `sendSwitchCommand` and `sendFuseOnCommand` and also specify a `ReturnValue_t` return type. The const specifier can make the API cumbersome and awkward to use. Concerning repercusions if thread-safety is/might be an issue: In my opinion, this should be mentioned in the code documentations and implemented by the user, not be enforced with `const`, which can make the API difficult and/or awkward to use. - Add a `DummyPowerSwitcher` module, which can be useful for test setups when no PCDU is available. - Add new definitions file, add new typedef for switches - Extend `PowerSwitcher` to optionally check current state when calling `turnOn` or `turnOff`. No need to command the switches if they are already in the correct state - Apply auto-formatter - Add power switch mock object for unit tests
muellerr added 1 commit 2022-03-28 12:54:29 +02:00
refactor power module
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
6f0362b956
muellerr added 1 commit 2022-03-28 12:57:21 +02:00
this should compile
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
b32d1da421
muellerr added 1 commit 2022-03-28 12:59:13 +02:00
small tweaks
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
23af170229
muellerr added the
Breaking API Change
label 2022-03-28 13:01:48 +02:00
muellerr changed title from refactor power module to WIP: refactor power module 2022-03-28 13:29:39 +02:00
muellerr added 1 commit 2022-03-30 17:41:55 +02:00
make dummy power switcher a system object
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
b42987059a
muellerr added 1 commit 2022-04-01 16:40:40 +02:00
change switch type in header as well
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
c20be13733
muellerr added 1 commit 2022-04-01 17:28:19 +02:00
Merge branch 'development' into mueller/refactor-power-switch-if-etc
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
cab508fd64
muellerr added a new dependency 2022-04-01 17:32:53 +02:00
muellerr added 2 commits 2022-04-01 18:38:42 +02:00
muellerr added 1 commit 2022-04-01 18:39:03 +02:00
applied afmt
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
2d0e4ba951
muellerr added 1 commit 2022-04-01 18:43:55 +02:00
added more unit tests
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
b764194ed0
muellerr added 1 commit 2022-04-11 16:11:30 +02:00
Merge branch 'development' into mueller/refactor-power-switch-if-etc
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
4ed9cc933f
muellerr added this to the v5.0.0 milestone 2022-04-11 17:34:58 +02:00
muellerr added 1 commit 2022-04-25 15:37:10 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/refactor-power-switch-if-etc
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
88051c9302
muellerr added 1 commit 2022-04-25 15:42:55 +02:00
improve changelog, add entry
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
572d602b72
muellerr added 1 commit 2022-04-25 15:44:54 +02:00
added missing PR cross-ref
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
b94685e045
muellerr added 1 commit 2022-04-27 08:45:09 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/refactor-power-switch-if-etc
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
2c8531ea48
muellerr added 1 commit 2022-05-09 11:02:52 +02:00
Merge branch 'development' into mueller/refactor-power-switch-if-etc
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
c78b7c432b
muellerr changed title from WIP: refactor power module to refactor power module 2022-05-09 11:02:54 +02:00
muellerr added 1 commit 2022-05-09 15:37:38 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/refactor-power-switch-if-etc
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
15352b539d
muellerr added 1 commit 2022-05-10 09:58:51 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/refactor-power-switch-if-etc
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
c5b4499d98
gaisser reviewed 2022-05-11 14:00:50 +02:00
@ -0,0 +8,4 @@
#include "definitions.h"
#include "fsfw/objectmanager/SystemObject.h"
class DummyPowerSwitcher : public SystemObject, public PowerSwitchIF {
Owner

I think we should mention the intenion of this object.

I think we should mention the intenion of this object.
Author
Owner

good ideal will add

good ideal will add
gaisser marked this conversation as resolved
muellerr added 1 commit 2022-05-12 15:02:55 +02:00
update dummy power switcher docs
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
d11f898f70
muellerr added 1 commit 2022-05-12 17:09:30 +02:00
Merge branch 'development' into mueller/refactor-power-switch-if-etc
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
c561271070
gaisser approved these changes 2022-05-12 18:37:25 +02:00
gaisser left a comment
Owner

LGTM

LGTM
gaisser merged commit a83b86ccd2 into development 2022-05-12 18:37:46 +02:00
gaisser deleted branch mueller/refactor-power-switch-if-etc 2022-05-12 18:37:49 +02:00
Sign in to join this conversation.
No description provided.