fsfw/fsfw
12
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

refactor power module #590

Merged
gaisser merged 20 commits from eive/fsfw:mueller/refactor-power-switch-if-etc into development 2022-05-12 18:37:46 +02:00
Conversation 2 Commits 20 Files Changed 17
+403 -51
muellerr commented 2022-03-28 12:54:25 +02:00
Owner
Copy Link
Copy Source
  • Remove const specifier from sendSwitchCommand and sendFuseOnCommand and also specify a ReturnValue_t return type. The const specifier can make the API cumbersome and awkward to use.

Concerning repercusions if thread-safety is/might be an issue:

In my opinion, this should be mentioned in the code documentations and implemented by the user, not be enforced with const, which can make the API difficult and/or awkward to use.

  • Add a DummyPowerSwitcher module, which can be useful for test setups when no PCDU is available.
  • Add new definitions file, add new typedef for switches
  • Extend PowerSwitcher to optionally check current state when calling turnOn or turnOff. No need to command the switches if they are already in the correct state
  • Apply auto-formatter
  • Add power switch mock object for unit tests
- Remove `const` specifier from `sendSwitchCommand` and `sendFuseOnCommand` and also specify a `ReturnValue_t` return type. The const specifier can make the API cumbersome and awkward to use. Concerning repercusions if thread-safety is/might be an issue: In my opinion, this should be mentioned in the code documentations and implemented by the user, not be enforced with `const`, which can make the API difficult and/or awkward to use. - Add a `DummyPowerSwitcher` module, which can be useful for test setups when no PCDU is available. - Add new definitions file, add new typedef for switches - Extend `PowerSwitcher` to optionally check current state when calling `turnOn` or `turnOff`. No need to command the switches if they are already in the correct state - Apply auto-formatter - Add power switch mock object for unit tests
muellerr added 1 commit 2022-03-28 12:54:29 +02:00
refactor power module
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
6f0362b956
muellerr added 1 commit 2022-03-28 12:57:21 +02:00
this should compile
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
b32d1da421
muellerr added 1 commit 2022-03-28 12:59:13 +02:00
small tweaks
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
23af170229
muellerr added the Breaking API Change label 2022-03-28 13:01:48 +02:00
muellerr marked the pull request as work in progress 2022-03-28 13:29:39 +02:00
muellerr added 1 commit 2022-03-30 17:41:55 +02:00
make dummy power switcher a system object
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
b42987059a
muellerr added 1 commit 2022-04-01 16:40:40 +02:00
change switch type in header as well
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
c20be13733
muellerr added 1 commit 2022-04-01 17:28:19 +02:00
Merge branch 'development' into mueller/refactor-power-switch-if-etc
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
cab508fd64
muellerr added a new dependency 2022-04-01 17:32:53 +02:00
#596 Power Switcher Component
muellerr added 2 commits 2022-04-01 18:38:42 +02:00
added unit tests, minor API change 738f572043
Merge branch 'mueller/refactor-power-switch-if-etc' of https://egit.irs.uni-stuttgart.de/eive/fsfw into mueller/refactor-power-switch-if-etc
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
0d549b687d
muellerr added 1 commit 2022-04-01 18:39:03 +02:00
applied afmt
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
2d0e4ba951
muellerr added 1 commit 2022-04-01 18:43:55 +02:00
added more unit tests
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
b764194ed0
muellerr added 1 commit 2022-04-11 16:11:30 +02:00
Merge branch 'development' into mueller/refactor-power-switch-if-etc
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
4ed9cc933f
muellerr added this to the v5.0.0 milestone 2022-04-11 17:34:58 +02:00
muellerr added 1 commit 2022-04-25 15:37:10 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/refactor-power-switch-if-etc
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
88051c9302
muellerr added 1 commit 2022-04-25 15:42:55 +02:00
improve changelog, add entry
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
572d602b72
muellerr added 1 commit 2022-04-25 15:44:54 +02:00
added missing PR cross-ref
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
b94685e045
muellerr added 1 commit 2022-04-27 08:45:09 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/refactor-power-switch-if-etc
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
2c8531ea48
muellerr added 1 commit 2022-05-09 11:02:52 +02:00
Merge branch 'development' into mueller/refactor-power-switch-if-etc
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
c78b7c432b
muellerr marked the pull request as ready for review 2022-05-09 11:02:54 +02:00
muellerr added 1 commit 2022-05-09 15:37:38 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/refactor-power-switch-if-etc
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
15352b539d
muellerr added 1 commit 2022-05-10 09:58:51 +02:00
Merge remote-tracking branch 'upstream/development' into mueller/refactor-power-switch-if-etc
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
c5b4499d98
gaisser reviewed 2022-05-11 14:00:50 +02:00
src/fsfw/power/DummyPowerSwitcher.h Outdated
@@ -0,0 +8,4 @@
#include "definitions.h"
#include "fsfw/objectmanager/SystemObject.h"
class DummyPowerSwitcher : public SystemObject, public PowerSwitchIF {
gaisser commented 2022-05-11 14:00:50 +02:00
Owner
Copy Link
Copy Source

I think we should mention the intenion of this object.

I think we should mention the intenion of this object.
muellerr commented 2022-05-11 14:02:23 +02:00
Author
Owner
Copy Link
Copy Source

good ideal will add

good ideal will add
gaisser marked this conversation as resolved
muellerr added 1 commit 2022-05-12 15:02:55 +02:00
update dummy power switcher docs
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
d11f898f70
muellerr added 1 commit 2022-05-12 17:09:30 +02:00
Merge branch 'development' into mueller/refactor-power-switch-if-etc
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
c561271070
gaisser approved these changes 2022-05-12 18:37:25 +02:00
gaisser left a comment
Owner
Copy Link
Copy Source

LGTM

LGTM
gaisser merged commit a83b86ccd2 into development 2022-05-12 18:37:46 +02:00
gaisser deleted branch mueller/refactor-power-switch-if-etc 2022-05-12 18:37:49 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label Breaking API Change
Milestone
No items
No Milestone v5.0.0
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#596 Power Switcher Component
fsfw/fsfw
Reference: fsfw/fsfw#590
Delete Branch "eive/fsfw:mueller/refactor-power-switch-if-etc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?