fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

preproc guards #612

Merged
muellerr merged 10 commits from eive/fsfw:mueller/missing-preproc-defs into development 2022-05-13 13:22:39 +02:00
Conversation 4 Commits 10 Files Changed 1 +14
muellerr commented 2022-05-02 15:14:53 +02:00
Owner
Copy Link

Those were missing

Those were missing
muellerr added 1 commit 2022-05-02 15:14:56 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
a3617cad11
preproc guards
muellerr requested review from mohr 2022-05-02 15:15:03 +02:00
muellerr added 1 commit 2022-05-02 15:16:41 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
57e6c46e72 Merge branch 'development' into mueller/missing-preproc-defs
muellerr added this to the v5.0.0 milestone 2022-05-02 16:16:03 +02:00
muellerr added 1 commit 2022-05-02 16:16:42 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
2fbf847367 Merge branch 'development' into mueller/missing-preproc-defs
muellerr added 1 commit 2022-05-09 15:35:53 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
4015e85506 Merge branch 'development' into mueller/missing-preproc-defs
gaisser requested changes 2022-05-09 17:01:36 +02:00
gaisser left a comment
Owner
Copy Link

Missing in Line 219 4015e85506/hal/src/fsfw_hal/linux/gpio/LinuxLibgpioIF.cpp (L219)

Missing in Line 219 https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/commit/4015e85506aa8befd63c43f0ea7b4fa90b07102d/hal/src/fsfw_hal/linux/gpio/LinuxLibgpioIF.cpp#L219
gaisser requested changes 2022-05-09 17:03:43 +02:00
gaisser left a comment
Owner
Copy Link

There is only a "switch" left in parseFindeLineResult. This seems strange to me.

There is only a "switch" left in ``parseFindeLineResult``. This seems strange to me.
muellerr added 1 commit 2022-05-09 17:21:54 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
18c2847b08 Merge branch 'development' into mueller/missing-preproc-defs
mohr commented 2022-05-10 09:29:12 +02:00
Owner
Copy Link

Re: the switch, this is correct. The #if as well as the #else path both have (redundant) cases, so there will always be some.

Re: the switch, this is correct. The `#if` as well as the `#else` path both have (redundant) cases, so there will always be some.
muellerr added 1 commit 2022-05-10 09:56:33 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
458aa5c265 Merge branch 'development' into mueller/missing-preproc-defs
gaisser commented 2022-05-10 11:54:49 +02:00
Owner
Copy Link

Re: the switch, this is correct. The #if as well as the #else path both have (redundant) cases, so there will always be some.

Ah sorry, my fault.

> Re: the switch, this is correct. The `#if` as well as the `#else` path both have (redundant) cases, so there will always be some. Ah sorry, my fault.
muellerr added 1 commit 2022-05-12 17:11:01 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
2d9d83a1c5 Merge branch 'development' into mueller/missing-preproc-defs
muellerr commented 2022-05-12 17:11:06 +02:00
Author
Owner
Copy Link

Good to merge?

Good to merge?
gaisser commented 2022-05-12 23:52:16 +02:00
Owner
Copy Link

Good to merge?

I think my other comment is correct

Missing in Line 219 4015e85506/hal/src/fsfw_hal/linux/gpio/LinuxLibgpioIF.cpp (L219)

sif::warning << "LinuxLibgpioIF::pullHigh: Unknown GPIO ID " << gpioId << std::endl;

> Good to merge? I think my other comment is correct > Missing in Line 219 4015e85506/hal/src/fsfw_hal/linux/gpio/LinuxLibgpioIF.cpp (L219) sif::warning << "LinuxLibgpioIF::pullHigh: Unknown GPIO ID " << gpioId << std::endl;
muellerr added 1 commit 2022-05-13 00:24:07 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
ccadbb5942 Merge branch 'development' into mueller/missing-preproc-defs
muellerr added 1 commit 2022-05-13 00:26:19 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
c215508a12
another missing preproc guard
gaisser approved these changes 2022-05-13 11:42:27 +02:00
gaisser left a comment
Owner
Copy Link

There are a few prints that will only perform if the ostreams are used but I'm ok with that.

There are a few prints that will only perform if the ostreams are used but I'm ok with that.
muellerr added 1 commit 2022-05-13 11:50:31 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
00952e15b0 Merge branch 'development' into mueller/missing-preproc-defs
muellerr merged commit e3d1308205 into development 2022-05-13 13:22:39 +02:00
muellerr deleted branch mueller/missing-preproc-defs 2022-05-13 13:22:40 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#612
No description provided.
Delete Branch "eive/fsfw:mueller/missing-preproc-defs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?