fsfw/fsfw
12
3 Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

preproc guards #612

Merged
muellerr merged 10 commits from eive/fsfw:mueller/missing-preproc-defs into development 2022-05-13 13:22:39 +02:00
Conversation 7 Commits 10 Files Changed 1
+14
muellerr commented 2022-05-02 15:14:53 +02:00
Owner
Copy link
Copy source

Those were missing

Those were missing
muellerr added 1 commit 2022-05-02 15:14:56 +02:00
preproc guards
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
a3617cad11
muellerr requested review from mohr 2022-05-02 15:15:03 +02:00
muellerr added 1 commit 2022-05-02 15:16:41 +02:00
Merge branch 'development' into mueller/missing-preproc-defs
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
57e6c46e72
muellerr added this to the v5.0.0 milestone 2022-05-02 16:16:03 +02:00
muellerr added 1 commit 2022-05-02 16:16:42 +02:00
Merge branch 'development' into mueller/missing-preproc-defs
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
2fbf847367
muellerr added 1 commit 2022-05-09 15:35:53 +02:00
Merge branch 'development' into mueller/missing-preproc-defs
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
4015e85506
gaisser left a comment
Owner
Copy link
Copy source

Missing in Line 219

fsfw/hal/src/fsfw_hal/linux/gpio/LinuxLibgpioIF.cpp Line 219 in 4015e85506
sif::warning << "LinuxLibgpioIF::pullHigh: Unknown GPIO ID " << gpioId << std::endl;

Missing in Line 219 https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/commit/4015e85506aa8befd63c43f0ea7b4fa90b07102d/hal/src/fsfw_hal/linux/gpio/LinuxLibgpioIF.cpp#L219
gaisser left a comment
Owner
Copy link
Copy source

There is only a "switch" left in parseFindeLineResult. This seems strange to me.

There is only a "switch" left in ``parseFindeLineResult``. This seems strange to me.
muellerr added 1 commit 2022-05-09 17:21:54 +02:00
Merge branch 'development' into mueller/missing-preproc-defs
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
18c2847b08
mohr commented 2022-05-10 09:29:12 +02:00
Owner
Copy link
Copy source

Re: the switch, this is correct. The #if as well as the #else path both have (redundant) cases, so there will always be some.

Re: the switch, this is correct. The `#if` as well as the `#else` path both have (redundant) cases, so there will always be some.
muellerr added 1 commit 2022-05-10 09:56:33 +02:00
Merge branch 'development' into mueller/missing-preproc-defs
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
458aa5c265
gaisser commented 2022-05-10 11:54:49 +02:00
Owner
Copy link
Copy source

Re: the switch, this is correct. The #if as well as the #else path both have (redundant) cases, so there will always be some.

Ah sorry, my fault.

> Re: the switch, this is correct. The `#if` as well as the `#else` path both have (redundant) cases, so there will always be some. Ah sorry, my fault.
muellerr added 1 commit 2022-05-12 17:11:01 +02:00
Merge branch 'development' into mueller/missing-preproc-defs
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
2d9d83a1c5
muellerr commented 2022-05-12 17:11:06 +02:00
Author
Owner
Copy link
Copy source

Good to merge?

Good to merge?
gaisser commented 2022-05-12 23:52:16 +02:00
Owner
Copy link
Copy source

Good to merge?

I think my other comment is correct

Missing in Line 219 4015e85506/hal/src/fsfw_hal/linux/gpio/LinuxLibgpioIF.cpp (L219)

sif::warning << "LinuxLibgpioIF::pullHigh: Unknown GPIO ID " << gpioId << std::endl;

> Good to merge? I think my other comment is correct > Missing in Line 219 4015e85506/hal/src/fsfw_hal/linux/gpio/LinuxLibgpioIF.cpp (L219) sif::warning << "LinuxLibgpioIF::pullHigh: Unknown GPIO ID " << gpioId << std::endl;
muellerr added 1 commit 2022-05-13 00:24:07 +02:00
Merge branch 'development' into mueller/missing-preproc-defs
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
ccadbb5942
muellerr added 1 commit 2022-05-13 00:26:19 +02:00
another missing preproc guard
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
c215508a12
gaisser approved these changes 2022-05-13 11:42:27 +02:00
gaisser left a comment
Owner
Copy link
Copy source

There are a few prints that will only perform if the ostreams are used but I'm ok with that.

There are a few prints that will only perform if the ostreams are used but I'm ok with that.
muellerr added 1 commit 2022-05-13 11:50:31 +02:00
Merge branch 'development' into mueller/missing-preproc-defs
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
00952e15b0
muellerr merged commit e3d1308205 into development 2022-05-13 13:22:39 +02:00
muellerr deleted branch mueller/missing-preproc-defs 2022-05-13 13:22:40 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mohr
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 Documentation
Improvement of code documentation
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone v5.0.0
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#612