changelog update

Reviewed-on: #820
Reviewed-by: Marius Eggert <eggertm@irs.uni-stuttgart.de>

CHANGELOG.md

@@ -16,6 +16,18 @@ will consitute of a breaking change warranting a new major release:
 
 # [unreleased]
 
+# [v7.3.0] 2023-11-07
+
+## Changed
+
+- Changed PDEC addresses depending on which firmware version is used. It is suspected that
+  the previous addresses were invalid and not properly covered by the Linux memory protection.
+  The OBSW will use the old addresses for older FW versions.
+
+## Added
+
+- Always add PLOC MPSoC and PLOC SUPV components for the EM as well.
+
 # [v7.2.0] 2023-10-27
 
 - `eive-tmtc` v5.10.1

CMakeLists.txt

@@ -10,7 +10,7 @@
 cmake_minimum_required(VERSION 3.13)
 
 set(OBSW_VERSION_MAJOR 7)
-set(OBSW_VERSION_MINOR 2)
+set(OBSW_VERSION_MINOR 3)
 set(OBSW_VERSION_REVISION 0)
 
 # set(CMAKE_VERBOSE TRUE)
@@ -126,13 +126,13 @@ set(OBSW_ADD_HEATERS
     1
     CACHE STRING "Add TCS heaters")
 set(OBSW_ADD_PLOC_SUPERVISOR
-    ${INIT_VAL}
+    1
     CACHE STRING "Add PLOC supervisor handler")
 set(OBSW_ADD_SA_DEPL
     ${INIT_VAL}
     CACHE STRING "Add SA deployment handler")
 set(OBSW_ADD_PLOC_MPSOC
-    ${INIT_VAL}
+    1
     CACHE STRING "Add MPSoC handler")
 set(OBSW_ADD_ACS_CTRL
     ${INIT_VAL}

bsp_q7s/boardconfig/busConf.h

@@ -18,7 +18,8 @@ static constexpr char I2C_Q7_EIVE[] = "/dev/i2c_q7";
 
 static constexpr char UART_GNSS_DEV[] = "/dev/gps0";
 static constexpr char UART_PLOC_MPSOC_DEV[] = "/dev/ul_plmpsoc";
-static constexpr char UART_PLOC_SUPERVSIOR_DEV[] = "/dev/ploc_supv";
+static constexpr char UART_PLOC_SUPERVISOR_DEV_FALLBACK[] = "/dev/ttyUL4";
+static constexpr char UART_PLOC_SUPERVISOR_DEV[] = "/dev/ploc_supv";
 static constexpr char UART_SYRLINKS_DEV[] = "/dev/ul_syrlinks";
 static constexpr char UART_STAR_TRACKER_DEV[] = "/dev/ul_str";
 static constexpr char UART_SCEX_DEV[] = "/dev/scex";

bsp_q7s/em/emObjectFactory.cpp

@@ -163,8 +163,8 @@ void ObjectFactory::produce(void* args) {
 #if OBSW_ADD_CCSDS_IP_CORES == 1
   CcsdsIpCoreHandler* ipCoreHandler = nullptr;
   CcsdsComponentArgs ccsdsArgs(*gpioComIF, *ipcStore, *tmStore, stores, *pusFunnel, *cfdpFunnel,
-                               &ipCoreHandler);
-  createCcsdsIpComponentsAddTmRouting(ccsdsArgs);
+                               &ipCoreHandler, 0, 0);
+  createCcsdsIpComponentsWrapper(ccsdsArgs);
 #endif /* OBSW_ADD_CCSDS_IP_CORES == 1 */
 
   /* Test Task */

bsp_q7s/fmObjectFactory.cpp

@@ -115,8 +115,8 @@ void ObjectFactory::produce(void* args) {
 #if OBSW_ADD_CCSDS_IP_CORES == 1
   CcsdsIpCoreHandler* ipCoreHandler = nullptr;
   CcsdsComponentArgs ccsdsArgs(*gpioComIF, *ipcStore, *tmStore, stores, *pusFunnel, *cfdpFunnel,
-                               &ipCoreHandler);
-  createCcsdsIpComponentsAddTmRouting(ccsdsArgs);
+                               &ipCoreHandler, 0, 0);
+  createCcsdsIpComponentsWrapper(ccsdsArgs);
 #endif /* OBSW_ADD_CCSDS_IP_CORES == 1 */
 
 #if OBSW_ADD_SCEX_DEVICE == 1

bsp_q7s/objectFactory.cpp

@@ -642,9 +642,13 @@ void ObjectFactory::createPayloadComponents(LinuxLibgpioIF* gpioComIF, PowerSwit
   auto supvGpioCookie = new GpioCookie;
   supvGpioCookie->addGpio(gpioIds::ENABLE_SUPV_UART, gpioConfigSupv);
   gpioComIF->addGpios(supvGpioCookie);
-  auto supervisorCookie = new SerialCookie(objects::PLOC_SUPERVISOR_HANDLER,
-                                           q7s::UART_PLOC_SUPERVSIOR_DEV, serial::PLOC_SUPV_BAUD,
-                                           supv::MAX_PACKET_SIZE * 20, UartModes::NON_CANONICAL);
+  const char* plocSupvDev = q7s::UART_PLOC_SUPERVISOR_DEV;
+  if (not std::filesystem::exists(plocSupvDev)) {
+    plocSupvDev = q7s::UART_PLOC_SUPERVISOR_DEV_FALLBACK;
+  }
+  auto supervisorCookie =
+      new SerialCookie(objects::PLOC_SUPERVISOR_HANDLER, plocSupvDev, serial::PLOC_SUPV_BAUD,
+                       supv::MAX_PACKET_SIZE * 20, UartModes::NON_CANONICAL);
   supervisorCookie->setNoFixedSizeReply();
   auto supvHelper = new PlocSupvUartManager(objects::PLOC_SUPERVISOR_HELPER);
   auto* supvHandler = new PlocSupervisorHandler(objects::PLOC_SUPERVISOR_HANDLER, supervisorCookie,
@@ -836,7 +840,7 @@ ReturnValue_t ObjectFactory::createCcsdsComponents(CcsdsComponentArgs& args) {
   uioNames.registers = q7s::UIO_PDEC_REGISTERS;
   uioNames.irq = q7s::UIO_PDEC_IRQ;
   new PdecHandler(objects::PDEC_HANDLER, objects::CCSDS_HANDLER, &args.gpioComIF,
-                  gpioIds::PDEC_RESET, uioNames);
+                  gpioIds::PDEC_RESET, uioNames, args.pdecCfgMemBaseAddr, args.pdecRamBaseAddr);
   GpioCookie* gpioRS485Chip = new GpioCookie;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::RS485_EN_TX_CLOCK, "RS485 Transceiver",
                                     Direction::OUT, Levels::LOW);
@@ -1062,7 +1066,13 @@ ReturnValue_t ObjectFactory::readFirmwareVersion() {
   return returnvalue::OK;
 }
 
-ReturnValue_t ObjectFactory::createCcsdsIpComponentsAddTmRouting(CcsdsComponentArgs& ccsdsArgs) {
+ReturnValue_t ObjectFactory::createCcsdsIpComponentsWrapper(CcsdsComponentArgs& ccsdsArgs) {
+  ccsdsArgs.pdecCfgMemBaseAddr = config::pdec::PDEC_CONFIG_BASE_ADDR;
+  ccsdsArgs.pdecRamBaseAddr = config::pdec::PDEC_RAM_ADDR;
+  if (core::FW_VERSION_MAJOR < 6) {
+    ccsdsArgs.pdecCfgMemBaseAddr = config::pdec::PDEC_CONFIG_BASE_ADDR_LEGACY;
+    ccsdsArgs.pdecRamBaseAddr = config::pdec::PDEC_RAM_ADDR_LEGACY;
+  }
   ReturnValue_t result = createCcsdsComponents(ccsdsArgs);
 #if OBSW_TM_TO_PTME == 1
   if (ccsdsArgs.normalLiveTmDest != MessageQueueIF::NO_QUEUE) {

bsp_q7s/objectFactory.h

@@ -31,14 +31,17 @@ namespace ObjectFactory {
 struct CcsdsComponentArgs {
   CcsdsComponentArgs(LinuxLibgpioIF& gpioIF, StorageManagerIF& ipcStore, StorageManagerIF& tmStore,
                      PersistentTmStores& stores, PusTmFunnel& pusFunnel, CfdpTmFunnel& cfdpFunnel,
-                     CcsdsIpCoreHandler** ipCoreHandler)
+                     CcsdsIpCoreHandler** ipCoreHandler, uint32_t pdecCfgMemBaseAddr,
+                     uint32_t pdecRamBaseAddr)
       : gpioComIF(gpioIF),
         ipcStore(ipcStore),
         tmStore(tmStore),
         stores(stores),
         pusFunnel(pusFunnel),
         cfdpFunnel(cfdpFunnel),
-        ipCoreHandler(ipCoreHandler) {}
+        ipCoreHandler(ipCoreHandler),
+        pdecCfgMemBaseAddr(pdecCfgMemBaseAddr),
+        pdecRamBaseAddr(pdecRamBaseAddr) {}
   LinuxLibgpioIF& gpioComIF;
   StorageManagerIF& ipcStore;
   StorageManagerIF& tmStore;
@@ -46,6 +49,8 @@ struct CcsdsComponentArgs {
   PusTmFunnel& pusFunnel;
   CfdpTmFunnel& cfdpFunnel;
   CcsdsIpCoreHandler** ipCoreHandler;
+  uint32_t pdecCfgMemBaseAddr;
+  uint32_t pdecRamBaseAddr;
   MessageQueueId_t normalLiveTmDest = MessageQueueIF::NO_QUEUE;
   MessageQueueId_t cfdpLiveTmDest = MessageQueueIF::NO_QUEUE;
 };
@@ -75,7 +80,7 @@ void createSolarArrayDeploymentComponents(PowerSwitchIF& pwrSwitcher, GpioIF& gp
 void createSyrlinksComponents(PowerSwitchIF* pwrSwitcher);
 void createPayloadComponents(LinuxLibgpioIF* gpioComIF, PowerSwitchIF& pwrSwitcher);
 void createReactionWheelComponents(LinuxLibgpioIF* gpioComIF, PowerSwitchIF* pwrSwitcher);
-ReturnValue_t createCcsdsIpComponentsAddTmRouting(CcsdsComponentArgs& args);
+ReturnValue_t createCcsdsIpComponentsWrapper(CcsdsComponentArgs& args);
 ReturnValue_t createCcsdsComponents(CcsdsComponentArgs& args);
 ReturnValue_t readFirmwareVersion();
 void createMiscComponents();

common/config/eive/definitions.h

@@ -115,6 +115,18 @@ static constexpr float SCHED_BLOCK_10_PERIOD =
 
 }  // namespace spiSched
 
+namespace pdec {
+
+// Pre FW v6.0.0
+static constexpr uint32_t PDEC_CONFIG_BASE_ADDR_LEGACY = 0x24000000;
+static constexpr uint32_t PDEC_RAM_ADDR_LEGACY = 0x26000000;
+
+// Post FW v6.0.0
+static constexpr uint32_t PDEC_CONFIG_BASE_ADDR = 0x4000000;
+static constexpr uint32_t PDEC_RAM_ADDR = 0x7000000;
+
+}  // namespace pdec
+
 }  // namespace config
 
 #endif /* COMMON_CONFIG_DEFINITIONS_H_ */

linux/ipcore/PdecHandler.cpp

@@ -24,12 +24,15 @@ using namespace pdec;
 uint32_t PdecHandler::CURRENT_FAR = 0;
 
 PdecHandler::PdecHandler(object_id_t objectId, object_id_t tcDestinationId,
-                         LinuxLibgpioIF* gpioComIF, gpioId_t pdecReset, UioNames names)
+                         LinuxLibgpioIF* gpioComIF, gpioId_t pdecReset, UioNames names,
+                         uint32_t cfgMemPhyAddr, uint32_t pdecRamPhyAddr)
     : SystemObject(objectId),
       tcDestinationId(tcDestinationId),
       gpioComIF(gpioComIF),
       pdecReset(pdecReset),
       actionHelper(this, nullptr),
+      cfgMemBaseAddr(cfgMemPhyAddr),
+      pdecRamBaseAddr(pdecRamPhyAddr),
       uioNames(names),
       paramHelper(this) {
   auto mqArgs = MqArgs(objectId, static_cast<void*>(this));
@@ -67,7 +70,7 @@ ReturnValue_t PdecHandler::initialize() {
   };
   memoryBaseAddress = static_cast<uint32_t*>(
       mmap(0, PDEC_CFG_MEM_SIZE, static_cast<int>(UioMapper::Permissions::READ_WRITE), MAP_SHARED,
-           fd, PDEC_CFG_MEM_PHY_ADDR));
+           fd, cfgMemBaseAddr));
   if (memoryBaseAddress == nullptr) {
     return ObjectManagerIF::CHILD_INIT_FAILED;
   }
@@ -75,7 +78,7 @@ ReturnValue_t PdecHandler::initialize() {
 
   ramBaseAddress = static_cast<uint32_t*>(mmap(0, PDEC_RAM_SIZE,
                                                static_cast<int>(UioMapper::Permissions::READ_WRITE),
-                                               MAP_SHARED, fd, PDEC_RAM_PHY_ADDR));
+                                               MAP_SHARED, fd, pdecRamBaseAddr));
   if (ramBaseAddress == nullptr) {
     return ObjectManagerIF::CHILD_INIT_FAILED;
   }
@@ -465,14 +468,7 @@ bool PdecHandler::newTcReceived() {
   return true;
 }
 
-void PdecHandler::doPeriodicWork() {
-  // scuffed test code
-  //  if(testCntr < 30) {
-  //    triggerEvent(pdec::INVALID_TC_FRAME, FRAME_DIRTY_RETVAL);
-  //    testCntr++;
-  //  }
-  checkLocks();
-}
+void PdecHandler::doPeriodicWork() { checkLocks(); }
 
 bool PdecHandler::checkFrameAna(uint32_t pdecFar) {
   bool frameValid = false;
@@ -645,7 +641,7 @@ void PdecHandler::handleNewTc() {
 }
 
 ReturnValue_t PdecHandler::readTc(uint32_t& tcLength) {
-  uint32_t tcOffset = (*(registerBaseAddress + PDEC_BPTR_OFFSET) - PHYSICAL_RAM_BASE_ADDRESS) / 4;
+  uint32_t tcOffset = (*(registerBaseAddress + PDEC_BPTR_OFFSET) - pdecRamBaseAddr) / 4;
 
 #if OBSW_DEBUG_PDEC_HANDLER == 1
   sif::debug << "PdecHandler::readTc: TC offset: 0x" << std::hex << tcOffset << std::endl;

linux/ipcore/PdecHandler.h

@@ -52,9 +52,7 @@ class PdecHandler : public SystemObject,
  public:
   static constexpr dur_millis_t IRQ_TIMEOUT_MS = 500;
   static constexpr uint32_t PDEC_CFG_MEM_SIZE = 0x1000;
-  static constexpr uint32_t PDEC_CFG_MEM_PHY_ADDR = 0x24000000;
   static constexpr uint32_t PDEC_RAM_SIZE = 0x10000;
-  static constexpr uint32_t PDEC_RAM_PHY_ADDR = 0x26000000;
 
   enum class Modes { POLLED, IRQ };
 
@@ -68,7 +66,7 @@ class PdecHandler : public SystemObject,
    * @param uioregsiters  String of uio device file same mapped to the PDEC register space
    */
   PdecHandler(object_id_t objectId, object_id_t tcDestinationId, LinuxLibgpioIF* gpioComIF,
-              gpioId_t pdecReset, UioNames names);
+              gpioId_t pdecReset, UioNames names, uint32_t cfgMemPhyAddr, uint32_t pdecRamPhyAddr);
 
   virtual ~PdecHandler();
 
@@ -103,12 +101,6 @@ class PdecHandler : public SystemObject,
   static const size_t MAX_TC_SEGMENT_SIZE = 1017;
   static const uint8_t MAP_ID_MASK = 0x3F;
 
-#ifdef TE0720_1CFA
-  static const uint32_t PHYSICAL_RAM_BASE_ADDRESS = 0x32000000;
-#else
-  static const uint32_t PHYSICAL_RAM_BASE_ADDRESS = 0x26000000;
-#endif
-
   // Expected value stored in FAR register after reset
   static const uint32_t FAR_RESET = 0x7FE0;
 
@@ -195,6 +187,9 @@ class PdecHandler : public SystemObject,
   MessageQueueId_t commandedBy = MessageQueueIF::NO_QUEUE;
   bool ptmeResetWithReinitializationPending = false;
 
+  uint32_t cfgMemBaseAddr;
+  uint32_t pdecRamBaseAddr;
+
   UioNames uioNames;
 
   ParameterHelper paramHelper;

linux/payload/PlocSupervisorHandler.cpp

@@ -223,6 +223,7 @@ ReturnValue_t PlocSupervisorHandler::buildCommandFromCommand(DeviceCommandId_t d
       break;
     }
     case RESET_MPSOC: {
+      sif::info << "PLOC SUPV: Resetting MPSoC" << std::endl;
       prepareEmptyCmd(Apid::BOOT_MAN, static_cast<uint8_t>(tc::BootManId::RESET_MPSOC));
       result = returnvalue::OK;
       break;
@@ -320,85 +321,6 @@ ReturnValue_t PlocSupervisorHandler::buildCommandFromCommand(DeviceCommandId_t d
       result = prepareWipeMramCmd(commandData);
       break;
     }
-      //    case ENABLE_NVMS: {
-      //      result = prepareEnableNvmsCommand(commandData);
-      //      break;
-      //    }
-      //    case RESTART_SUPERVISOR: {
-      //      prepareEmptyCmd(APID_RESTART_SUPERVISOR);
-      //      result = returnvalue::OK;
-      //      break;
-      //    }
-      // Removed command
-      //    case START_MPSOC_QUIET: {
-      //      prepareEmptyCmd(APID_START_MPSOC_QUIET);
-      //      result = returnvalue::OK;
-      //      break;
-      //    }
-      //    case ENABLE_AUTO_TM: {
-      //      EnableAutoTm packet(spParams);
-      //      result = packet.buildPacket();
-      //      if (result != returnvalue::OK) {
-      //        break;
-      //      }
-      //      finishTcPrep(packet.getFullPacketLen());
-      //      break;
-      //    }
-      //    case DISABLE_AUTO_TM: {
-      //      DisableAutoTm packet(spParams);
-      //      result = packet.buildPacket();
-      //      if (result != returnvalue::OK) {
-      //        break;
-      //      }
-      //      finishTcPrep(packet.getFullPacketLen());
-      //      break;
-      //    }
-      //    case LOGGING_REQUEST_COUNTERS: {
-      //      RequestLoggingData packet(spParams);
-      //      result = packet.buildPacket(RequestLoggingData::Sa::REQUEST_COUNTERS);
-      //      if (result != returnvalue::OK) {
-      //        break;
-      //      }
-      //      finishTcPrep(packet.getFullPacketLen());
-      //      break;
-      //    }
-      //    case LOGGING_CLEAR_COUNTERS: {
-      //      RequestLoggingData packet(spParams);
-      //      result = packet.buildPacket(RequestLoggingData::Sa::CLEAR_COUNTERS);
-      //      if (result != returnvalue::OK) {
-      //        break;
-      //      }
-      //      finishTcPrep(packet.getFullPacketLen());
-      //      break;
-      //    }
-      //    case LOGGING_SET_TOPIC: {
-      //      if (commandData == nullptr or commandDataLen == 0) {
-      //        return HasActionsIF::INVALID_PARAMETERS;
-      //      }
-      //      uint8_t tpc = *(commandData);
-      //      RequestLoggingData packet(spParams);
-      //      result = packet.buildPacket(RequestLoggingData::Sa::SET_LOGGING_TOPIC, tpc);
-      //      if (result != returnvalue::OK) {
-      //        break;
-      //      }
-      //      finishTcPrep(packet.getFullPacketLen());
-      //      break;
-      //    }
-      // I think this is disabled right now according to the TC excel table
-      //    case COPY_ADC_DATA_TO_MRAM: {
-      //      prepareEmptyCmd(APID_COPY_ADC_DATA_TO_MRAM);
-      //      result = returnvalue::OK;
-      //      break;
-      //    }
-      //    case REQUEST_ADC_REPORT: {
-      //      prepareEmptyCmd(APID_REQUEST_ADC_REPORT);
-      //      result = returnvalue::OK;
-      //      break;
-      //    }
-      //    case FIRST_MRAM_DUMP:
-      //    case CONSECUTIVE_MRAM_DUMP:
-      //      result = prepareDumpMramCmd(commandData);
-      //      break;
     default:
       sif::debug << "PlocSupervisorHandler::buildCommandFromCommand: Command not implemented"
                  << std::endl;
@@ -550,23 +472,17 @@ ReturnValue_t PlocSupervisorHandler::enableReplyInReplyMap(DeviceCommandMap::ite
     case SET_ADC_ENABLED_CHANNELS:
     case SET_ADC_WINDOW_AND_STRIDE:
     case SET_ADC_THRESHOLD:
-    // case COPY_ADC_DATA_TO_MRAM:
     case RUN_AUTO_EM_TESTS:
     case WIPE_MRAM:
     case SET_GPIO:
     case FACTORY_RESET:
     case READ_GPIO:
-    // case RESTART_SUPERVISOR:
     case DISABLE_PERIOIC_HK_TRANSMISSION:
-    // case START_MPSOC_QUIET:
     case SET_SHUTDOWN_TIMEOUT:
     case FACTORY_FLASH:
     case ENABLE_AUTO_TM:
     case DISABLE_AUTO_TM:
-    // case LOGGING_CLEAR_COUNTERS:
-    // case LOGGING_SET_TOPIC:
     case RESET_PL:
-      // case ENABLE_NVMS:
       enabledReplies = 2;
       break;
     default:
@@ -598,19 +514,12 @@ ReturnValue_t PlocSupervisorHandler::enableReplyInReplyMap(DeviceCommandMap::ite
 ReturnValue_t PlocSupervisorHandler::scanForReply(const uint8_t* start, size_t remainingSize,
                                                   DeviceCommandId_t* foundId, size_t* foundLen) {
   using namespace supv;
-  // TODO: Is this still required?
-  //  if (nextReplyId == FIRST_MRAM_DUMP) {
-  //    *foundId = FIRST_MRAM_DUMP;
-  //    return parseMramPackets(start, remainingSize, foundLen);
-  //  } else if (nextReplyId == CONSECUTIVE_MRAM_DUMP) {
-  //    *foundId = CONSECUTIVE_MRAM_DUMP;
-  //    return parseMramPackets(start, remainingSize, foundLen);
-  //  }
 
   tmReader.setData(start, remainingSize);
-  // sif::debug << "PlocSupervisorHandler::scanForReply: Received Packet" << std::endl;
-  // arrayprinter::print(start, remainingSize);
   uint16_t apid = tmReader.getModuleApid();
+  if (DEBUG_PLOC_SUPV) {
+    handlePacketPrint();
+  }
 
   switch (apid) {
     case (Apid::TMTC_MAN): {
@@ -664,6 +573,42 @@ ReturnValue_t PlocSupervisorHandler::scanForReply(const uint8_t* start, size_t r
   return INVALID_DATA;
 }
 
+void PlocSupervisorHandler::handlePacketPrint() {
+  if (tmReader.getModuleApid() == Apid::TMTC_MAN) {
+    if ((tmReader.getServiceId() == static_cast<uint8_t>(supv::tm::TmtcId::ACK)) or
+        (tmReader.getServiceId() == static_cast<uint8_t>(supv::tm::TmtcId::NAK))) {
+      AcknowledgmentReport ack(tmReader);
+      const char* printStr = "???";
+      if (tmReader.getServiceId() == static_cast<uint8_t>(supv::tm::TmtcId::ACK)) {
+        printStr = "ACK";
+
+      } else if (tmReader.getServiceId() == static_cast<uint8_t>(supv::tm::TmtcId::NAK)) {
+        printStr = "NAK";
+      }
+      sif::debug << "PlocSupervisorHandler: RECV " << printStr << " for APID Module ID "
+                 << (int)ack.getRefModuleApid() << " Service ID " << (int)ack.getRefServiceId()
+                 << " Seq Count " << ack.getRefSequenceCount() << std::endl;
+      return;
+    } else if ((tmReader.getServiceId() == static_cast<uint8_t>(supv::tm::TmtcId::EXEC_ACK)) or
+               (tmReader.getServiceId() == static_cast<uint8_t>(supv::tm::TmtcId::EXEC_NAK))) {
+      ExecutionReport exe(tmReader);
+      const char* printStr = "???";
+      if (tmReader.getServiceId() == static_cast<uint8_t>(supv::tm::TmtcId::EXEC_ACK)) {
+        printStr = "ACK EXE";
+
+      } else if (tmReader.getServiceId() == static_cast<uint8_t>(supv::tm::TmtcId::EXEC_NAK)) {
+        printStr = "NAK EXE";
+      }
+      sif::debug << "PlocSupervisorHandler: RECV " << printStr << " for APID Module ID "
+                 << (int)exe.getRefModuleApid() << " Service ID " << (int)exe.getRefServiceId()
+                 << " Seq Count " << exe.getRefSequenceCount() << std::endl;
+      return;
+    }
+  }
+  sif::debug << "PlocSupervisorHandler: RECV PACKET Size " << tmReader.getFullPacketLen()
+             << " Module APID " << (int)tmReader.getModuleApid() << " Service ID "
+             << (int)tmReader.getServiceId() << std::endl;
+}
 ReturnValue_t PlocSupervisorHandler::interpretDeviceReply(DeviceCommandId_t id,
                                                           const uint8_t* packet) {
   using namespace supv;
@@ -1292,7 +1237,7 @@ ReturnValue_t PlocSupervisorHandler::prepareEmptyCmd(uint16_t apid, uint8_t serv
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1303,7 +1248,7 @@ ReturnValue_t PlocSupervisorHandler::prepareSelBootImageCmd(const uint8_t* comma
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1320,7 +1265,7 @@ ReturnValue_t PlocSupervisorHandler::prepareSetTimeRefCmd() {
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1330,7 +1275,7 @@ ReturnValue_t PlocSupervisorHandler::prepareDisableHk() {
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1342,7 +1287,7 @@ ReturnValue_t PlocSupervisorHandler::prepareSetBootTimeoutCmd(const uint8_t* com
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1353,7 +1298,7 @@ ReturnValue_t PlocSupervisorHandler::prepareRestartTriesCmd(const uint8_t* comma
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1371,7 +1316,7 @@ ReturnValue_t PlocSupervisorHandler::prepareLatchupConfigCmd(const uint8_t* comm
       if (result != returnvalue::OK) {
         return result;
       }
-      finishTcPrep(packet.getFullPacketLen());
+      finishTcPrep(packet);
       break;
     }
     case (supv::DISABLE_LATCHUP_ALERT): {
@@ -1380,7 +1325,7 @@ ReturnValue_t PlocSupervisorHandler::prepareLatchupConfigCmd(const uint8_t* comm
       if (result != returnvalue::OK) {
         return result;
       }
-      finishTcPrep(packet.getFullPacketLen());
+      finishTcPrep(packet);
       break;
     }
     default: {
@@ -1407,7 +1352,7 @@ ReturnValue_t PlocSupervisorHandler::prepareSetAlertLimitCmd(const uint8_t* comm
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1418,7 +1363,7 @@ ReturnValue_t PlocSupervisorHandler::prepareSetAdcEnabledChannelsCmd(const uint8
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1432,7 +1377,7 @@ ReturnValue_t PlocSupervisorHandler::prepareSetAdcWindowAndStrideCmd(const uint8
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1444,7 +1389,7 @@ ReturnValue_t PlocSupervisorHandler::prepareSetAdcThresholdCmd(const uint8_t* co
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1458,7 +1403,7 @@ ReturnValue_t PlocSupervisorHandler::prepareRunAutoEmTest(const uint8_t* command
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1471,7 +1416,7 @@ ReturnValue_t PlocSupervisorHandler::prepareSetGpioCmd(const uint8_t* commandDat
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1483,7 +1428,7 @@ ReturnValue_t PlocSupervisorHandler::prepareReadGpioCmd(const uint8_t* commandDa
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1497,14 +1442,18 @@ ReturnValue_t PlocSupervisorHandler::prepareFactoryResetCmd(const uint8_t* comma
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(resetCmd.getFullPacketLen());
+  finishTcPrep(resetCmd);
   return returnvalue::OK;
 }
 
-void PlocSupervisorHandler::finishTcPrep(size_t packetLen) {
+void PlocSupervisorHandler::finishTcPrep(TcBase& tc) {
   nextReplyId = supv::ACK_REPORT;
   rawPacket = commandBuffer;
-  rawPacketLen = packetLen;
+  rawPacketLen = tc.getFullPacketLen();
+  if (DEBUG_PLOC_SUPV) {
+    sif::debug << "PLOC SUPV: SEND PACKET Size " << tc.getFullPacketLen() << " Module APID "
+               << (int)tc.getModuleApid() << " Service ID " << (int)tc.getServiceId() << std::endl;
+  }
 }
 
 ReturnValue_t PlocSupervisorHandler::prepareSetShutdownTimeoutCmd(const uint8_t* commandData) {
@@ -1523,7 +1472,7 @@ ReturnValue_t PlocSupervisorHandler::prepareSetShutdownTimeoutCmd(const uint8_t*
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -1740,7 +1689,7 @@ ReturnValue_t PlocSupervisorHandler::prepareWipeMramCmd(const uint8_t* commandDa
   if (result != returnvalue::OK) {
     return result;
   }
-  finishTcPrep(packet.getFullPacketLen());
+  finishTcPrep(packet);
   return returnvalue::OK;
 }
 
@@ -2006,134 +1955,3 @@ ReturnValue_t PlocSupervisorHandler::checkModeCommand(Mode_t commandedMode,
   }
   return DeviceHandlerBase::checkModeCommand(commandedMode, commandedSubmode, msToReachTheMode);
 }
-
-// ReturnValue_t PlocSupervisorHandler::checkMramPacketApid() {
-//   uint16_t apid = (spacePacketBuffer[0] << 8 | spacePacketBuffer[1]) & supv::APID_MASK;
-//  TODO: Fix
-//  if (apid != supv::APID_MRAM_DUMP_TM) {
-//    return result::NO_MRAM_PACKET;
-//  }
-// return APERIODIC_REPLY;
-//}
-
-// ReturnValue_t PlocSupervisorHandler::parseMramPackets(const uint8_t* packet, size_t
-// remainingSize,
-//                                                       size_t* foundLen) {
-//   ReturnValue_t result = IGNORE_FULL_PACKET;
-//   uint16_t packetLen = 0;
-//   *foundLen = 0;
-//
-//   for (size_t idx = 0; idx < remainingSize; idx++) {
-//     std::memcpy(spacePacketBuffer + bufferTop, packet + idx, 1);
-//     bufferTop += 1;
-//     *foundLen += 1;
-//     if (bufferTop >= ccsds::HEADER_LEN) {
-//       packetLen = readSpacePacketLength(spacePacketBuffer);
-//     }
-//
-//     if (bufferTop == ccsds::HEADER_LEN + packetLen + 1) {
-//       packetInBuffer = true;
-//       bufferTop = 0;
-//       return checkMramPacketApid();
-//     }
-//
-//     if (bufferTop == supv::MAX_PACKET_SIZE) {
-//       *foundLen = remainingSize;
-//       disableAllReplies();
-//       bufferTop = 0;
-//       sif::info << "PlocSupervisorHandler::parseMramPackets: Can not find MRAM packet in space "
-//                    "packet buffer"
-//                 << std::endl;
-//       return result::MRAM_PACKET_PARSING_FAILURE;
-//     }
-//   }
-//
-//   return result;
-// }
-
-// ReturnValue_t PlocSupervisorHandler::prepareDumpMramCmd(const uint8_t* commandData) {
-//   uint32_t start = 0;
-//   uint32_t stop = 0;
-//   size_t size = sizeof(start) + sizeof(stop);
-//   SerializeAdapter::deSerialize(&start, &commandData, &size, SerializeIF::Endianness::BIG);
-//   SerializeAdapter::deSerialize(&stop, &commandData, &size, SerializeIF::Endianness::BIG);
-//   if ((stop - start) <= 0) {
-//     return SupvReturnValuesIF::INVALID_MRAM_ADDRESSES;
-//   }
-//   supv::MramCmd packet(spParams);
-//   ReturnValue_t result = packet.buildPacket(start, stop, supv::MramCmd::MramAction::DUMP);
-//   if (result != returnvalue::OK) {
-//     return result;
-//   }
-//   expectedMramDumpPackets = (stop - start) / supv::MAX_DATA_CAPACITY;
-//   if ((stop - start) % supv::MAX_DATA_CAPACITY) {
-//     expectedMramDumpPackets++;
-//   }
-//   receivedMramDumpPackets = 0;
-//
-//   finishTcPrep(packet.getFullPacketLen());
-//   return returnvalue::OK;
-// }
-
-// ReturnValue_t PlocSupervisorHandler::prepareLoggingRequest(const uint8_t* commandData,
-//                                                            size_t commandDataLen) {
-//   using namespace supv;
-//   RequestLoggingData::Sa sa = static_cast<RequestLoggingData::Sa>(*commandData);
-//   uint8_t tpc = *(commandData + 1);
-//   RequestLoggingData packet(spParams);
-//   ReturnValue_t result = packet.buildPacket(sa, tpc);
-//   if (result != returnvalue::OK) {
-//     return result;
-//   }
-//   finishTcPrep(packet.getFullPacketLen());
-//   return returnvalue::OK;
-// }
-
-// ReturnValue_t PlocSupervisorHandler::prepareEnableNvmsCommand(const uint8_t* commandData) {
-//   using namespace supv;
-//   uint8_t nvm01 = *(commandData);
-//   uint8_t nvm3 = *(commandData + 1);
-//   EnableNvms packet(spParams);
-//   ReturnValue_t result = packet.buildPacket(nvm01, nvm3);
-//   if (result != returnvalue::OK) {
-//     return result;
-//   }
-//   finishTcPrep(packet.getFullPacketLen());
-//   return returnvalue::OK;
-// }
-
-// ReturnValue_t PlocSupervisorHandler::handleLoggingReport(const uint8_t* data) {
-//   ReturnValue_t result = returnvalue::OK;
-//
-//   result = verifyPacket(data, supv::SIZE_LOGGING_REPORT);
-//
-//   if (result == SupvReturnValuesIF::CRC_FAILURE) {
-//     sif::warning << "PlocSupervisorHandler::handleLoggingReport: Logging report has "
-//                  << "invalid crc" << std::endl;
-//     return result;
-//   }
-//
-//   const uint8_t* dataField = data + supv::PAYLOAD_OFFSET + sizeof(supv::RequestLoggingData::Sa);
-//   result = loggingReport.read();
-//   if (result != returnvalue::OK) {
-//     return result;
-//   }
-//   loggingReport.setValidityBufferGeneration(false);
-//   size_t size = loggingReport.getSerializedSize();
-//   result = loggingReport.deSerialize(&dataField, &size, SerializeIF::Endianness::BIG);
-//   if (result != returnvalue::OK) {
-//     sif::warning << "PlocSupervisorHandler::handleLoggingReport: Deserialization failed"
-//                  << std::endl;
-//   }
-//   loggingReport.setValidityBufferGeneration(true);
-//   loggingReport.setValidity(true, true);
-//   result = loggingReport.commit();
-//   if (result != returnvalue::OK) {
-//     return result;
-//   }
-// #if OBSW_VERBOSE_LEVEL >= 1 && OBSW_DEBUG_PLOC_SUPERVISOR == 1
-//   loggingReport.printSet();
-// #endif
-//   nextReplyId = supv::EXE_REPORT;
-//   return result;
-// }

linux/payload/PlocSupervisorHandler.h

@@ -18,6 +18,9 @@
 #endif
 
 using supv::ExecutionReport;
+using supv::TcBase;
+
+static constexpr bool DEBUG_PLOC_SUPV = false;
 
 /**
  * @brief	This is the device handler for the supervisor of the PLOC which is programmed by
@@ -174,6 +177,8 @@ class PlocSupervisorHandler : public DeviceHandlerBase {
    */
   void setExecutionTimeout(DeviceCommandId_t command);
 
+  void handlePacketPrint();
+
   /**
    * @brief   Handles event messages received from the supervisor helper
    */
@@ -227,7 +232,6 @@ class PlocSupervisorHandler : public DeviceHandlerBase {
 
   ReturnValue_t handleLatchupStatusReport(const uint8_t* data);
   void handleBadApidServiceCombination(Event result, unsigned int apid, unsigned int serviceId);
-  // ReturnValue_t handleLoggingReport(const uint8_t* data);
   ReturnValue_t handleAdcReport(const uint8_t* data);
 
   /**
@@ -297,16 +301,13 @@ class PlocSupervisorHandler : public DeviceHandlerBase {
   ReturnValue_t prepareSetAdcThresholdCmd(const uint8_t* commandData);
   ReturnValue_t prepareRunAutoEmTest(const uint8_t* commandData);
   ReturnValue_t prepareWipeMramCmd(const uint8_t* commandData);
-  // ReturnValue_t prepareDumpMramCmd(const uint8_t* commandData);
   ReturnValue_t prepareSetGpioCmd(const uint8_t* commandData);
   ReturnValue_t prepareReadGpioCmd(const uint8_t* commandData);
-  // ReturnValue_t prepareLoggingRequest(const uint8_t* commandData, size_t commandDataLen);
-  //  ReturnValue_t prepareEnableNvmsCommand(const uint8_t* commandData);
 
   /**
    * @brief   Copies the content of a space packet to the command buffer.
    */
-  void finishTcPrep(size_t packetLen);
+  void finishTcPrep(TcBase& tc);
 
   /**
    * @brief   In case an acknowledgment failure reply has been received this function disables
@@ -332,12 +333,6 @@ class PlocSupervisorHandler : public DeviceHandlerBase {
    */
   void disableExeReportReply();
 
-  /**
-   * @brief   Function is called in scanForReply and fills the spacePacketBuffer with the read
-   *          data until a full packet has been received.
-   */
-  // ReturnValue_t parseMramPackets(const uint8_t* packet, size_t remainingSize, size_t* foundlen);
-
   /**
    * @brief   This function generates the Service 8 packets for the MRAM dump data.
    */
@@ -350,12 +345,6 @@ class PlocSupervisorHandler : public DeviceHandlerBase {
    */
   void increaseExpectedMramReplies(DeviceCommandId_t id);
 
-  /**
-   * @brief   Function checks if the packet written to the space packet buffer is really a
-   *          MRAM dump packet.
-   */
-  // ReturnValue_t checkMramPacketApid();
-
   /**
    * @brief   Writes the data of the MRAM dump to a file. The file will be created when receiving
    *          the first packet.