eive/eive-obsw
eive/eive-obsw
12
4
Fork 0
Code Issues 4 Pull Requests 2 Releases 119 Wiki Activity

ACS Ctrl Bug Bash #439

Merged
muellerr merged 42 commits from acs-bug-bash into develop 2023-03-10 19:21:19 +01:00
Conversation 0 Commits 42 Files Changed 23 +473 -485
meggert commented 2023-03-07 10:01:19 +01:00
Owner
Copy Link

Fixes for several ACS Ctrl Bugs and additions of smaller features

Fixes for several ACS Ctrl Bugs and additions of smaller features
meggert added this to the v1.36.0 milestone 2023-03-07 10:01:19 +01:00
meggert added 18 commits 2023-03-07 10:01:20 +01:00
fixed some param types
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
22558a2f39
fixed paramerterWrapper setter to match type of parameter
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
17a1a5a655
naming fixes
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
afb9303dcb
removed AcsParameters as part of SensorProcessing
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
12ac8f7c70
changelog
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
7bf72e3c18
fixed updating wrong parameter set
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
309358f447
changed AcsParameters instance in guidance to const pointer
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
5c30adb9bb
better solution for actuatorCmd
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
26369039da
cleaned up SafeCtrl
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
d86b9d55da
cleaned up detumble and fixed gyr detumble law to actual bdot law
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
04a561b9a0
fixed gs target mode using wrong parameter set
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
84643020da
cleaned up ptgCtrl
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
737d5ecb53
fixed usage of wrong parameters
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
7b0657bb55
fixed wrong if condition
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
2c6ea8dc9f
Merge branch 'develop' into acs-bug-bash
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
EIVE/eive-obsw/pipeline/pr-develop There was a failure building this commit
Details
37673a2782
meggert added 3 commits 2023-03-07 10:13:02 +01:00
detumbleCounter doesnt hard reset anymore
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
bd295d5b52
meggert added 1 commit 2023-03-07 10:36:02 +01:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
d8a07312f2
meggert added 1 commit 2023-03-07 11:10:50 +01:00
added fdir for unrealistic gps altitudes
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
fd436dbe8b
meggert added 1 commit 2023-03-07 11:13:02 +01:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
82966eed31
meggert added 1 commit 2023-03-07 11:25:09 +01:00
fixed gpsDataProcessed dataSet size
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
903c0c8258
meggert added 2 commits 2023-03-07 13:57:47 +01:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
1cc39bb6d7
meggert added 1 commit 2023-03-07 14:13:28 +01:00
fixed naming collision with file for solar deployment
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
72ab4b1a24
meggert added 1 commit 2023-03-07 14:17:51 +01:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
5b0db43e0f
muellerr modified the milestone from v1.36.0 to v1.37.0 2023-03-09 20:46:49 +01:00
meggert added 2 commits 2023-03-10 09:27:25 +01:00
Merge branch 'develop' into acs-bug-bash
Some checks failed
EIVE/eive-obsw/pipeline/pr-develop There was a failure building this commit
Details
b6477e099d
meggert added 1 commit 2023-03-10 09:44:33 +01:00
small fixes
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
0dbd6b703d
meggert added 3 commits 2023-03-10 10:30:06 +01:00
who knows what that todo was good for
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
9a30ae5175
meggert added 1 commit 2023-03-10 11:37:09 +01:00
added protection to not command rwSpeeds larger than the allowed speed range
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
cb8a49775d
meggert added 1 commit 2023-03-10 11:39:36 +01:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
555e0ce49d
meggert added 2 commits 2023-03-10 17:31:17 +01:00
fixed rw torque scaling
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
342ff62837
meggert added 2 commits 2023-03-10 17:41:21 +01:00
changelog fix
Some checks failed
EIVE/eive-obsw/pipeline/pr-develop There was a failure building this commit
Details
b6d18ef4d2
meggert changed title from WIP: ACS Ctrl Bug Bash to ACS Ctrl Bug Bash 2023-03-10 17:41:39 +01:00
meggert requested review from muellerr 2023-03-10 17:41:57 +01:00
muellerr added 1 commit 2023-03-10 19:13:54 +01:00
Merge branch 'develop' into acs-bug-bash
Some checks are pending
EIVE/eive-obsw/pipeline/pr-develop Build started...
Details
c47a7338db
muellerr approved these changes 2023-03-10 19:21:03 +01:00
mission/controller/acs/ActuatorCmd.cpp Outdated
@ -71,0 +59,4 @@
VectorOperations<double>::maxAbsValue(dipolMomentActuatorDouble, 3, &maxIdx);
double maxAbsValue = abs(dipolMomentActuatorDouble[maxIdx]);
if (maxAbsValue > maxDipol) {
double scalingFactor = maxDipol / maxAbsValue;
muellerr commented 2023-03-08 13:24:39 +01:00
Owner
Copy Link

div by 0 ?

div by 0 ?
muellerr merged commit b4129950cf into develop 2023-03-10 19:21:19 +01:00
muellerr deleted branch acs-bug-bash 2023-03-10 19:21:20 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
muellerr
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v1.37.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#439
No description provided.
Delete Branch "acs-bug-bash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?