MPSoC Overhaul #892

Merged
muellerr merged 10 commits from mpsoc-overhaul into main 2024-05-06 14:20:48 +02:00
Owner
No description provided.
muellerr added 24 commits 2024-04-17 15:08:58 +02:00
MPSoC file split
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
398e7a3a05
that should do the job
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
6a0b18ffd0
bump tmtc
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
d60f4dd3e3
we really need to get rid of this overcomplicated crap
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
13e752d9f8
enough of this for today
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
96d957f7b1
leave the old stuff untouched
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
4a4da86060
continue the refactoring
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
63e7b928cf
this should do the job
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
2015839d60
bump fsfw
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
e552149d5d
lets enable wiretapping for the first test
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
97433359c2
need to fix some linker errors..
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
9477d04008
compiles again
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
fac688d4c9
implement transitions
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
85d0ffed0d
bump fsfw and tmtc
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
418c501acf
and now this is less confusing as well
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
d319fcfa03
some more debugging capabilities
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
7ffba2bbda
smaller fixes
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
bc4880c714
re-run generators
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
449a8a4276
bugfix for crc check
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
9b9d8bd32f
almost at the goal
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
91fdd7e7ac
re-work transition handling
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
758bc6e0e6
added new verify boot cmd
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
eb883ed93f
separate store and stream file commands
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
520b8d0700
some bugfixes
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
c64dae06d3
muellerr added 1 commit 2024-04-17 15:09:06 +02:00
Merge branch 'main' into mpsoc-overhaul
Some checks are pending
EIVE/eive-obsw/pipeline/pr-main Build queued...
4d4ab6c1d3
muellerr added 2 commits 2024-04-17 15:09:55 +02:00
muellerr added 1 commit 2024-04-17 15:11:28 +02:00
fix for CI
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
2b2f644074
muellerr changed title from MPSoC Overhaul to WIP: MPSoC Overhaul 2024-04-17 15:11:38 +02:00
muellerr added 1 commit 2024-04-17 16:15:13 +02:00
fix host build
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
9d8ad494b3
muellerr added this to the v8.0.0 milestone 2024-04-17 16:20:24 +02:00
muellerr force-pushed mpsoc-overhaul from 9d8ad494b3 to 90d784a796 2024-04-17 17:59:12 +02:00 Compare
muellerr added 1 commit 2024-04-17 18:01:51 +02:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
6319fa3e47
muellerr added 1 commit 2024-04-17 18:02:54 +02:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
1ffef6753c
muellerr added 31 commits 2024-04-25 17:29:16 +02:00
MPSoC file split
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
398e7a3a05
that should do the job
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
6a0b18ffd0
bump tmtc
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
d60f4dd3e3
we really need to get rid of this overcomplicated crap
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
13e752d9f8
enough of this for today
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
96d957f7b1
leave the old stuff untouched
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
4a4da86060
continue the refactoring
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
63e7b928cf
this should do the job
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
2015839d60
bump fsfw
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
e552149d5d
lets enable wiretapping for the first test
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
97433359c2
need to fix some linker errors..
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
9477d04008
compiles again
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
fac688d4c9
implement transitions
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
85d0ffed0d
bump fsfw and tmtc
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
418c501acf
and now this is less confusing as well
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
d319fcfa03
some more debugging capabilities
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
7ffba2bbda
smaller fixes
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
bc4880c714
re-run generators
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
449a8a4276
bugfix for crc check
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
9b9d8bd32f
almost at the goal
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
91fdd7e7ac
re-work transition handling
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
758bc6e0e6
added new verify boot cmd
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
eb883ed93f
separate store and stream file commands
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
520b8d0700
some bugfixes
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
c64dae06d3
Merge branch 'main' into mpsoc-overhaul
Some checks are pending
EIVE/eive-obsw/pipeline/pr-main Build queued...
4d4ab6c1d3
Merge branch 'mpsoc-overhaul' of egit.irs.uni-stuttgart.de:eive/eive-obsw into mpsoc-overhaul
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
dcc64046f4
fix for CI
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
2b2f644074
fix host build
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
9d8ad494b3
Merge branch 'mpsoc-overhaul' of egit.irs.uni-stuttgart.de:eive/eive-obsw into mpsoc-overhaul
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
4852f06cda
muellerr added 1 commit 2024-04-25 17:30:03 +02:00
Merge remote-tracking branch 'origin/main' into mpsoc-overhaul
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
393a4af2b4
muellerr force-pushed mpsoc-overhaul from 393a4af2b4 to b03e53b6e9 2024-04-25 17:32:16 +02:00 Compare
muellerr added 1 commit 2024-04-26 11:23:24 +02:00
allow validation of CAM cmd params in the future
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
37211e2c5f
muellerr added 1 commit 2024-04-26 14:36:30 +02:00
bugfixes and improvements
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
cc863503ac
muellerr added 1 commit 2024-04-26 16:23:37 +02:00
some important bugfixes
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
b9ad396fb4
muellerr added 1 commit 2024-04-29 12:10:51 +02:00
various fixes, store file works now
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
2431994180
muellerr added 1 commit 2024-04-29 13:19:16 +02:00
need to fix special com helper
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
c3dd2b55ee
muellerr added 1 commit 2024-04-29 13:23:16 +02:00
important bugfix
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
083b4e61ad
muellerr added 1 commit 2024-04-29 13:35:39 +02:00
some remaining low-level issue..
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
e3dc1c9a74
muellerr added 1 commit 2024-04-30 13:50:46 +02:00
small fixes for q7s-cp script
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
39f0db1db6
muellerr added 1 commit 2024-04-30 14:41:34 +02:00
small improvements
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
de75fc5531
muellerr added 1 commit 2024-04-30 15:11:26 +02:00
fixed the bug
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
acd02376c4
muellerr changed title from WIP: MPSoC Overhaul to MPSoC Overhaul 2024-04-30 15:13:48 +02:00
muellerr force-pushed mpsoc-overhaul from acd02376c4 to aa2bfb7d0e 2024-04-30 15:14:55 +02:00 Compare
muellerr added 1 commit 2024-04-30 15:18:20 +02:00
reduce printouts
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
65476f4c98
muellerr added 1 commit 2024-04-30 15:38:02 +02:00
further reduce printout
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
4a0acbf158
muellerr requested review from meggert 2024-04-30 15:38:17 +02:00
meggert added 1 commit 2024-04-30 15:57:48 +02:00
Merge branch 'main' into mpsoc-overhaul
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
f7f14ff021
meggert requested changes 2024-04-30 18:01:12 +02:00
Dismissed
meggert left a comment
Owner

Please do some cleanup. Check which todos should be done prior to this merge. Remove code which has been commented out, if it is not needed anymore

Please do some cleanup. Check which todos should be done prior to this merge. Remove code which has been commented out, if it is not needed anymore
@ -0,0 +78,4 @@
}
if (mode == MODE_NORMAL and not activeCmdInfo.pending) {
// TODO: Take care of regular periodic commanding here.
Owner

todo

todo
meggert marked this conversation as resolved
@ -0,0 +297,4 @@
break;
}
// For longer commands, do not set these.
// TODO: Do all the stuff the form buildDeviceFromDevice blah did.
Owner

todo

todo
muellerr marked this conversation as resolved
@ -0,0 +788,4 @@
if (result != returnvalue::OK) {
return result;
}
// TODO: We should find a way so this works with the old implementation.
Owner

todo

todo
muellerr marked this conversation as resolved
@ -0,0 +836,4 @@
ReturnValue_t FreshMpsocHandler::handleDeviceReply() {
ReturnValue_t result = returnvalue::OK;
// SpacePacketReader spacePacket;
Owner

is this deprecated code? why is not deleted?

is this deprecated code? why is not deleted?
muellerr marked this conversation as resolved
@ -0,0 +894,4 @@
}
}
// TODO: We should implement some way so this can also be used with the former implementation.
Owner

todo

todo
muellerr marked this conversation as resolved
@ -0,0 +897,4 @@
// TODO: We should implement some way so this can also be used with the former implementation.
uint16_t sequenceCount = replyReader.getSequenceCount();
if (sequenceCount != lastReplySequenceCount + 1) {
// TODO: Trigger event for possible missing reply packet to inform operator.
Owner

todo

todo
muellerr marked this conversation as resolved
@ -0,0 +952,4 @@
switch (replyReader.getApid()) {
case mpsoc::apid::ACK_FAILURE: {
// DeviceCommandId_t commandId = getPendingCommand();
Owner

commented code?

commented code?
muellerr marked this conversation as resolved
@ -0,0 +38,4 @@
// The packet might be garbage, with no way to recover without a data link layer.
if (spReader.getFullPacketLen() > 4096) {
readRingBuf.clear();
// TODO: Maybe we should also clear the serial input buffer in Linux?
Owner

todo

todo
Author
Owner

that will remain. I am not sure if this is a good idea, so I explicitely did not tdo that. It's still a think which theoretcally could cause issues

that will remain. I am not sure if this is a good idea, so I explicitely did not tdo that. It's still a think which theoretcally could cause issues
muellerr marked this conversation as resolved
@ -170,3 +167,3 @@
* MPSoC Handler.
*/
SerialComIF* uartComIF = nullptr;
// SerialComIF* uartComIF = nullptr;
Owner

comment

comment
Author
Owner

isn't this in the archive now? I don't think we need to keep that file top-notch anymore.. (not that any of these monstrous handlers ever were top-notch..)

isn't this in the archive now? I don't think we need to keep that file top-notch anymore.. (not that any of these monstrous handlers ever were top-notch..)
@ -108,3 +217,2 @@
static const uint16_t SIZE_EXE_REPORT = 14;
static const uint16_t SIZE_TM_MEM_READ_REPORT = 18;
static const uint16_t SIZE_TM_CAM_CMD_RPT = 18;
// static const uint16_t SIZE_TM_MEM_READ_REPORT = 18;
Owner

comment

comment
muellerr marked this conversation as resolved
@ -265,3 +354,1 @@
return calcAndSetCrc();
}
};
} // namespace statusCode
Owner

commennt

commennt
Author
Owner

I think thats an auto-generated one to now what this scope actually is

I think thats an auto-generated one to now what this scope actually is
meggert marked this conversation as resolved
muellerr added 1 commit 2024-05-02 15:42:22 +02:00
removed TODOs which are done
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
744a94704c
Author
Owner

I implemented all comments. The only remaining TODO is the periodic commanding, following soon,

I implemented all comments. The only remaining TODO is the periodic commanding, following soon,
muellerr added 1 commit 2024-05-06 13:19:28 +02:00
impl proper NORMAL mode for MPSoC
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
4fdec7a74c
meggert requested changes 2024-05-06 13:22:14 +02:00
Dismissed
@ -16,0 +113,4 @@
//! [EXPORT] : [COMMENT] SUPV not on for boot or shutdown process. P1: 0 for OFF transition, 1 for
//! ON transition.
static constexpr Event SUPV_NOT_ON = event::makeEvent(SUBSYSTEM_ID, 7, severity::LOW);
static constexpr Event SUPV_REPLY_TIMEOUT = event::makeEvent(SUBSYSTEM_ID, 8, severity::LOW);
Owner

please add event comment

please add event comment
muellerr added 1 commit 2024-05-06 13:30:36 +02:00
make marius extremely happy
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
b579cd86c1
muellerr added 1 commit 2024-05-06 13:48:36 +02:00
events
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
8103b2fa0d
meggert approved these changes 2024-05-06 13:49:38 +02:00
muellerr added 1 commit 2024-05-06 14:17:34 +02:00
better name for split file command
Some checks are pending
EIVE/eive-obsw/pipeline/pr-main Build queued...
215f2189a6
muellerr added 1 commit 2024-05-06 14:20:16 +02:00
muellerr merged commit 6bb12f28a1 into main 2024-05-06 14:20:48 +02:00
muellerr deleted branch mpsoc-overhaul 2024-05-06 14:20:48 +02:00
Sign in to join this conversation.
No description provided.