MPSoC Overhaul #892
No reviewers
Labels
No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: eive/eive-obsw#892
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "mpsoc-overhaul"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
MPSoC Overhaulto WIP: MPSoC Overhaul9d8ad494b3
to90d784a796
393a4af2b4
tob03e53b6e9
WIP: MPSoC Overhaulto MPSoC Overhaulacd02376c4
toaa2bfb7d0e
Please do some cleanup. Check which todos should be done prior to this merge. Remove code which has been commented out, if it is not needed anymore
@ -0,0 +78,4 @@
}
if (mode == MODE_NORMAL and not activeCmdInfo.pending) {
// TODO: Take care of regular periodic commanding here.
todo
@ -0,0 +297,4 @@
break;
}
// For longer commands, do not set these.
// TODO: Do all the stuff the form buildDeviceFromDevice blah did.
todo
@ -0,0 +788,4 @@
if (result != returnvalue::OK) {
return result;
}
// TODO: We should find a way so this works with the old implementation.
todo
@ -0,0 +836,4 @@
ReturnValue_t FreshMpsocHandler::handleDeviceReply() {
ReturnValue_t result = returnvalue::OK;
// SpacePacketReader spacePacket;
is this deprecated code? why is not deleted?
@ -0,0 +894,4 @@
}
}
// TODO: We should implement some way so this can also be used with the former implementation.
todo
@ -0,0 +897,4 @@
// TODO: We should implement some way so this can also be used with the former implementation.
uint16_t sequenceCount = replyReader.getSequenceCount();
if (sequenceCount != lastReplySequenceCount + 1) {
// TODO: Trigger event for possible missing reply packet to inform operator.
todo
@ -0,0 +952,4 @@
switch (replyReader.getApid()) {
case mpsoc::apid::ACK_FAILURE: {
// DeviceCommandId_t commandId = getPendingCommand();
commented code?
@ -0,0 +38,4 @@
// The packet might be garbage, with no way to recover without a data link layer.
if (spReader.getFullPacketLen() > 4096) {
readRingBuf.clear();
// TODO: Maybe we should also clear the serial input buffer in Linux?
todo
that will remain. I am not sure if this is a good idea, so I explicitely did not tdo that. It's still a think which theoretcally could cause issues
@ -170,3 +167,3 @@
* MPSoC Handler.
*/
SerialComIF* uartComIF = nullptr;
// SerialComIF* uartComIF = nullptr;
comment
isn't this in the archive now? I don't think we need to keep that file top-notch anymore.. (not that any of these monstrous handlers ever were top-notch..)
@ -108,3 +217,2 @@
static const uint16_t SIZE_EXE_REPORT = 14;
static const uint16_t SIZE_TM_MEM_READ_REPORT = 18;
static const uint16_t SIZE_TM_CAM_CMD_RPT = 18;
// static const uint16_t SIZE_TM_MEM_READ_REPORT = 18;
comment
@ -265,3 +354,1 @@
return calcAndSetCrc();
}
};
} // namespace statusCode
commennt
I think thats an auto-generated one to now what this scope actually is
I implemented all comments. The only remaining TODO is the periodic commanding, following soon,
@ -16,0 +113,4 @@
//! [EXPORT] : [COMMENT] SUPV not on for boot or shutdown process. P1: 0 for OFF transition, 1 for
//! ON transition.
static constexpr Event SUPV_NOT_ON = event::makeEvent(SUBSYSTEM_ID, 7, severity::LOW);
static constexpr Event SUPV_REPLY_TIMEOUT = event::makeEvent(SUBSYSTEM_ID, 8, severity::LOW);
please add event comment