eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

GNSS Ctrl Improvements #871

Merged
meggert merged 24 commits from gnss-ctrl-improvements into main 2024-04-10 11:40:24 +02:00
Conversation 0 Commits 24 Files Changed 10 +128 -83
meggert commented 2024-02-29 16:07:39 +01:00
Owner
Copy Link
No description provided.
meggert added this to the v7.7.1 milestone 2024-02-29 16:07:39 +01:00
meggert added 1 commit 2024-02-29 16:07:40 +01:00
this should remove the fix changed spam
Some checks are pending
EIVE/eive-obsw/pipeline/head Build queued...
Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
236916bf67
meggert added 1 commit 2024-02-29 16:09:28 +01:00
small fix
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
ffce866ad0
meggert added 1 commit 2024-03-01 10:10:03 +01:00
between how many beers was this written
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
7e7d8c249e
meggert added 1 commit 2024-03-01 10:59:48 +01:00
remove whatever this is
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
Details
8fe7307a58
meggert added 1 commit 2024-03-01 11:31:11 +01:00
boop
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
Details
b7bf927288
muellerr reviewed 2024-03-05 10:44:16 +01:00
mission/acs/archive/GPSDefinitions.h Outdated
@ -8,3 +8,3 @@
namespace GpsHyperion {
enum class FixMode : uint8_t { NOT_SEEN = 0, NO_FIX = 1, FIX_2D = 2, FIX_3D = 3, UNKNOWN = 4 };
enum FixMode : uint8_t { NOT_SEEN = 0, NO_FIX = 1, FIX_2D = 2, FIX_3D = 3 };
muellerr commented 2024-03-05 10:44:16 +01:00
Owner
Copy Link

is this still used? Because its in the archive..

is this still used? Because its in the archive..
meggert commented 2024-03-05 13:06:08 +01:00
Author
Owner
Copy Link

it is in the core ctrl. i might move the used stuff to a separate defs file

it is in the core ctrl. i might move the used stuff to a separate defs file
meggert marked this conversation as resolved
meggert removed this from the v7.7.1 milestone 2024-03-06 11:38:02 +01:00
meggert added this to the v7.7.2 milestone 2024-03-06 11:38:19 +01:00
meggert modified the milestone from v7.7.2 to v7.7.3 2024-03-06 13:32:11 +01:00
meggert added 1 commit 2024-03-13 13:48:40 +01:00
Merge branch 'main' into gnss-ctrl-improvements
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
Details
f2d1e16697
meggert added 1 commit 2024-03-13 13:54:53 +01:00
lets wait a bit longer
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
Details
8374a02ae2
meggert added 1 commit 2024-03-13 16:08:34 +01:00
idk what i am doing here
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
Details
3c869e5215
meggert modified the milestone from v7.7.3 to v7.7.4 2024-03-15 14:35:34 +01:00
meggert added 1 commit 2024-03-15 14:54:19 +01:00
better but still not fixed
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
Details
7a43e1bc67
meggert added 1 commit 2024-03-18 16:55:10 +01:00
Merge branch 'main' into gnss-ctrl-improvements
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
Details
3e1ef8bcaf
meggert added 3 commits 2024-03-18 17:21:08 +01:00
cleanup
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
f2f856e227
meggert modified the milestone from v7.7.4 to v7.8.0 2024-03-20 16:24:37 +01:00
meggert added 1 commit 2024-04-09 09:58:13 +02:00
some cleanup
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
2057ab9c10
meggert added 1 commit 2024-04-09 09:59:26 +02:00
improved event comment
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
f3d4e09487
meggert added 1 commit 2024-04-09 11:27:01 +02:00
missing reset
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
d4eb124cdf
meggert added 3 commits 2024-04-09 13:31:33 +02:00
this seems better
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
1c36f36b1f
meggert added 1 commit 2024-04-09 14:04:26 +02:00
better
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
427c53df8c
meggert added 1 commit 2024-04-09 14:43:52 +02:00
the first fix should trigger an event
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
7a12c1c8fe
meggert added 1 commit 2024-04-09 14:49:42 +02:00
Merge branch 'main' into gnss-ctrl-improvements
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
709c53d533
meggert added 1 commit 2024-04-09 15:06:37 +02:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
7b53275d61
meggert changed title from WIP: GNSS Ctrl Improvements to GNSS Ctrl Improvements 2024-04-09 15:09:29 +02:00
meggert requested review from muellerr 2024-04-09 15:09:41 +02:00
muellerr reviewed 2024-04-10 11:30:41 +02:00
linux/acs/GpsHyperionLinuxController.cpp
@ -299,3 +309,1 @@
// As specified in gps.h: Only valid if mode >= 2
if (gps.fix.mode >= 2) {
latValid = true;
if (modeIsSet) {
muellerr commented 2024-04-09 17:39:20 +02:00
Owner
Copy Link

this don't make sense if mode is not set? I think I took this from the gpsd sample code..

this don't make sense if mode is not set? I think I took this from the gpsd sample code..
linux/acs/GpsHyperionLinuxController.cpp
@ -322,2 +335,2 @@
if (gps.fix.mode == 3) {
altitudeValid = true;
if (modeIsSet) {
if (ALTITUDE_SET == (ALTITUDE_SET & gps.set) && std::isfinite(gps.fix.altitude)) {
muellerr commented 2024-04-09 17:39:00 +02:00
Owner
Copy Link

this don't make sense if mode is not set? I think I took this from the gpsd sample code..

this don't make sense if mode is not set? I think I took this from the gpsd sample code..
meggert commented 2024-04-10 11:33:06 +02:00
Author
Owner
Copy Link

If no MODE_SET then do not bother to look at the rest of the data in gpsdata.fix.

That is what gps larry wrote himself. I don't think this changes much anyways.

> If no MODE_SET then do not bother to look at the rest of the data in gpsdata.fix. That is what gps larry wrote himself. I don't think this changes much anyways.
linux/acs/GpsHyperionLinuxController.cpp
@ -330,3 +348,1 @@
if (SPEED_SET == (SPEED_SET & gps.set) && std::isfinite(gps.fix.speed)) {
gpsSet.speed.value = gps.fix.speed;
speedValid = true;
if (modeIsSet) {
muellerr commented 2024-04-09 17:39:05 +02:00
Owner
Copy Link

this don't make sense if mode is not set? I think I took this from the gpsd sample code..

this don't make sense if mode is not set? I think I took this from the gpsd sample code..
muellerr approved these changes 2024-04-10 11:35:55 +02:00
meggert added 1 commit 2024-04-10 11:40:11 +02:00
meggert merged commit 48914a2aba into main 2024-04-10 11:40:24 +02:00
meggert deleted branch gnss-ctrl-improvements 2024-04-10 11:40:25 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
muellerr
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v7.8.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#871
No description provided.
Delete Branch "gnss-ctrl-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?