update retvals

CHANGELOG.md

@@ -10,6 +10,12 @@ list yields a list of all related PRs for each release.
 
 # [unreleased]
 
+# [v2.20.1] 2023-04-01
+
+## Fixed
+
+- MEKF: Handle NOT_FINITE status (key 5)
+
 # [v2.20.0] 2023-03-28
 
 ## Changed

eive_tmtc/__init__.py

@@ -1,4 +1,4 @@
-__version__ = "2.20.0"
+__version__ = "2.20.1"
 
 import logging
 from pathlib import Path
@@ -6,7 +6,7 @@ from pathlib import Path
 SW_NAME = "eive-tmtc"
 VERSION_MAJOR = 2
 VERSION_MINOR = 20
-VERSION_REVISION = 0
+VERSION_REVISION = 1
 
 EIVE_TMTC_ROOT = Path(__file__).parent
 PACKAGE_ROOT = EIVE_TMTC_ROOT.parent

eive_tmtc/config/events.csv

@@ -203,6 +203,7 @@ Event ID (dec); Event ID (hex); Name; Severity; Description; File Path
 12801;0x3201;NOT_ENOUGH_DEVICES_DUAL_MODE;HIGH;No description;mission/system/acs/AcsBoardAssembly.h
 12802;0x3202;POWER_STATE_MACHINE_TIMEOUT;MEDIUM;No description;mission/system/acs/AcsBoardAssembly.h
 12803;0x3203;SIDE_SWITCH_TRANSITION_NOT_ALLOWED;LOW;Not implemented, would increase already high complexity. Operator should instead command the assembly off first and then command the assembly on into the desired mode/submode combination;mission/system/acs/AcsBoardAssembly.h
+12804;0x3204;DIRECT_TRANSITION_TO_DUAL_OTHER_GPS_FAULTY;MEDIUM;This is triggered when the assembly would have normally switched the board side, but the GPS device of the other side was marked faulty. P1: Current submode.;mission/system/acs/AcsBoardAssembly.h
 12900;0x3264;TRANSITION_OTHER_SIDE_FAILED;HIGH;No description;mission/system/acs/SusAssembly.h
 12901;0x3265;NOT_ENOUGH_DEVICES_DUAL_MODE;HIGH;No description;mission/system/acs/SusAssembly.h
 12902;0x3266;POWER_STATE_MACHINE_TIMEOUT;MEDIUM;No description;mission/system/acs/SusAssembly.h

eive_tmtc/config/object_ids.py

@@ -49,6 +49,9 @@ GYRO_1_L3G_HANDLER_ID = bytes([0x44, 0x12, 0x01, 0x11])
 GYRO_2_ADIS_HANDLER_ID = bytes([0x44, 0x12, 0x02, 0x12])
 GYRO_3_L3G_HANDLER_ID = bytes([0x44, 0x12, 0x03, 0x13])
 GPS_CONTROLLER = bytes([0x44, 0x13, 0x00, 0x45])
+GPS_0_HEALTH_DEV = bytes([0x44, 0x13, 0x00, 0x46])
+GPS_1_HEALTH_DEV = bytes([0x44, 0x13, 0x00, 0x47])
+
 RW1_ID = bytes([0x44, 0x12, 0x00, 0x47])
 RW2_ID = bytes([0x44, 0x12, 0x01, 0x48])
 RW3_ID = bytes([0x44, 0x12, 0x02, 0x49])

eive_tmtc/config/objects.csv

@@ -29,6 +29,8 @@
 0x44120350;RW4
 0x44130001;STAR_TRACKER
 0x44130045;GPS_CONTROLLER
+0x44130046;GPS_0_HEALTH_DEV
+0x44130047;GPS_1_HEALTH_DEV
 0x44140013;IMTQ_POLLING
 0x44140014;IMTQ_HANDLER
 0x442000A1;PCDU_HANDLER

eive_tmtc/config/returnvalues.csv

@@ -190,8 +190,8 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x2207;TMF_AllDeleted;No description;7;TM_STORE_FRONTEND_IF;fsfw/src/fsfw/tmstorage/TmStoreFrontendIF.h
 0x2208;TMF_InvalidData;No description;8;TM_STORE_FRONTEND_IF;fsfw/src/fsfw/tmstorage/TmStoreFrontendIF.h
 0x2209;TMF_NotReady;No description;9;TM_STORE_FRONTEND_IF;fsfw/src/fsfw/tmstorage/TmStoreFrontendIF.h
-0x2401;MT_TooDetailedRequest;No description;1;MATCH_TREE_CLASS;fsfw/src/fsfw/globalfunctions/matching/MatchTree.h
-0x2402;MT_TooGeneralRequest;No description;2;MATCH_TREE_CLASS;fsfw/src/fsfw/globalfunctions/matching/MatchTree.h
+0x2401;MT_NoPacketFound;No description;1;MATCH_TREE_CLASS;fsfw/src/fsfw/globalfunctions/DleParser.h
+0x2402;MT_PossiblePacketLoss;No description;2;MATCH_TREE_CLASS;fsfw/src/fsfw/globalfunctions/DleParser.h
 0x2403;MT_NoMatch;No description;3;MATCH_TREE_CLASS;fsfw/src/fsfw/globalfunctions/matching/MatchTree.h
 0x2404;MT_Full;No description;4;MATCH_TREE_CLASS;fsfw/src/fsfw/globalfunctions/matching/MatchTree.h
 0x2405;MT_NewNodeCreated;No description;5;MATCH_TREE_CLASS;fsfw/src/fsfw/globalfunctions/matching/MatchTree.h
@@ -371,8 +371,8 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x3e03;HKM_PeriodicHelperInvalid;No description;3;HOUSEKEEPING_MANAGER;fsfw/src/fsfw/datapoollocal/LocalDataPoolManager.h
 0x3e04;HKM_PoolobjectNotFound;No description;4;HOUSEKEEPING_MANAGER;fsfw/src/fsfw/datapoollocal/LocalDataPoolManager.h
 0x3e05;HKM_DatasetNotFound;No description;5;HOUSEKEEPING_MANAGER;fsfw/src/fsfw/datapoollocal/LocalDataPoolManager.h
-0x3f01;DLEE_NoPacketFound;No description;1;DLE_ENCODER;fsfw/src/fsfw/globalfunctions/DleParser.h
-0x3f02;DLEE_PossiblePacketLoss;No description;2;DLE_ENCODER;fsfw/src/fsfw/globalfunctions/DleParser.h
+0x3f01;DLEE_StreamTooShort;No description;1;DLE_ENCODER;fsfw/src/fsfw/globalfunctions/DleEncoder.h
+0x3f02;DLEE_DecodingError;No description;2;DLE_ENCODER;fsfw/src/fsfw/globalfunctions/DleEncoder.h
 0x4201;PUS11_InvalidTypeTimeWindow;No description;1;PUS_SERVICE_11;fsfw/src/fsfw/pus/Service11TelecommandScheduling.h
 0x4202;PUS11_InvalidTimeWindow;No description;2;PUS_SERVICE_11;fsfw/src/fsfw/pus/Service11TelecommandScheduling.h
 0x4203;PUS11_TimeshiftingNotPossible;No description;3;PUS_SERVICE_11;fsfw/src/fsfw/pus/Service11TelecommandScheduling.h
@@ -402,9 +402,9 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x4403;UXOS_CommandError;Command execution failed;3;LINUX_OSAL;fsfw/src/fsfw_hal/linux/CommandExecutor.h
 0x4404;UXOS_NoCommandLoadedOrPending;;4;LINUX_OSAL;fsfw/src/fsfw_hal/linux/CommandExecutor.h
 0x4406;UXOS_PcloseCallError;No description;6;LINUX_OSAL;fsfw/src/fsfw_hal/linux/CommandExecutor.h
-0x4500;HSPI_OpeningFileFailed;No description;0;HAL_SPI;fsfw/src/fsfw_hal/linux/spi/SpiComIF.h
-0x4501;HSPI_FullDuplexTransferFailed;No description;1;HAL_SPI;fsfw/src/fsfw_hal/linux/spi/SpiComIF.h
-0x4502;HSPI_HalfDuplexTransferFailed;No description;2;HAL_SPI;fsfw/src/fsfw_hal/linux/spi/SpiComIF.h
+0x4500;HSPI_HalTimeoutRetval;No description;0;HAL_SPI;fsfw/src/fsfw_hal/stm32h7/spi/spiDefinitions.h
+0x4501;HSPI_HalBusyRetval;No description;1;HAL_SPI;fsfw/src/fsfw_hal/stm32h7/spi/spiDefinitions.h
+0x4502;HSPI_HalErrorRetval;No description;2;HAL_SPI;fsfw/src/fsfw_hal/stm32h7/spi/spiDefinitions.h
 0x4601;HURT_UartReadFailure;No description;1;HAL_UART;fsfw/src/fsfw_hal/linux/serial/SerialComIF.h
 0x4602;HURT_UartReadSizeMissmatch;No description;2;HAL_UART;fsfw/src/fsfw_hal/linux/serial/SerialComIF.h
 0x4603;HURT_UartRxBufferTooSmall;No description;3;HAL_UART;fsfw/src/fsfw_hal/linux/serial/SerialComIF.h
@@ -492,10 +492,9 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x58a3;SUSS_ExecutionFailed;Command execution failed;163;SUS_HANDLER;mission/acs/RwHandler.h
 0x58a4;SUSS_CrcError;Reaction wheel reply has invalid crc;164;SUS_HANDLER;mission/acs/RwHandler.h
 0x58a5;SUSS_ValueNotRead;No description;165;SUS_HANDLER;mission/acs/RwHandler.h
-0x5900;IPCI_NoReplyAvailable;No description;0;CCSDS_IP_CORE_BRIDGE;linux/acs/ImtqPollingTask.h
-0x5901;IPCI_NoPacketFound;No description;1;CCSDS_IP_CORE_BRIDGE;linux/com/SyrlinksComHandler.h
 0x59a0;IPCI_PapbBusy;No description;160;CCSDS_IP_CORE_BRIDGE;linux/ipcore/PapbVcInterface.h
 0x5aa0;PTME_UnknownVcId;No description;160;PTME;linux/ipcore/Ptme.h
+0x5c00;STRHLP_NoReplyAvailable;No description;0;STR_HELPER;linux/acs/ImtqPollingTask.h
 0x5c01;STRHLP_SdNotMounted;SD card specified in path string not mounted;1;STR_HELPER;linux/acs/StrComHandler.h
 0x5c02;STRHLP_FileNotExists;Specified file does not exist on filesystem;2;STR_HELPER;linux/acs/StrComHandler.h
 0x5c03;STRHLP_PathNotExists;Specified path does not exist;3;STR_HELPER;linux/acs/StrComHandler.h
@@ -541,13 +540,13 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x63a0;NVMB_KeyNotExists;Specified key does not exist in json file;160;NVM_PARAM_BASE;mission/memory/NvmParameterBase.h
 0x64a0;FSHLP_SdNotMounted;SD card specified with path string not mounted;160;FILE_SYSTEM_HELPER;bsp_q7s/fs/FilesystemHelper.h
 0x64a1;FSHLP_FileNotExists;Specified file does not exist on filesystem;161;FILE_SYSTEM_HELPER;bsp_q7s/fs/FilesystemHelper.h
-0x6502;PLMPHLP_InvalidCrc;No description;2;PLOC_MPSOC_HELPER;linux/payload/ScexHelper.h
 0x65a0;PLMPHLP_FileClosedAccidentally;File accidentally close;160;PLOC_MPSOC_HELPER;linux/payload/PlocMpsocHelper.h
 0x66a0;SADPL_CommandNotSupported;No description;160;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
 0x66a1;SADPL_DeploymentAlreadyExecuting;No description;161;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
 0x66a2;SADPL_MainSwitchTimeoutFailure;No description;162;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
 0x66a3;SADPL_SwitchingDeplSa1Failed;No description;163;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
 0x66a4;SADPL_SwitchingDeplSa2Failed;No description;164;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
+0x6702;MPSOCRTVIF_InvalidCrc;No description;2;MPSOC_RETURN_VALUES_IF;linux/payload/ScexHelper.h
 0x67a0;MPSOCRTVIF_CrcFailure;Space Packet received from PLOC has invalid CRC;160;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
 0x67a1;MPSOCRTVIF_ReceivedAckFailure;Received ACK failure reply from PLOC;161;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
 0x67a2;MPSOCRTVIF_ReceivedExeFailure;Received execution failure reply from PLOC;162;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
@@ -558,6 +557,7 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x67a7;MPSOCRTVIF_MpsocFilenameTooLong;Filename of MPSoC file is to long (max. 256 bytes);167;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
 0x67a8;MPSOCRTVIF_InvalidParameter;Command has invalid parameter;168;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
 0x67a9;MPSOCRTVIF_NameTooLong;Received command has file string with invalid length;169;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x6801;SPVRTVIF_NoPacketFound;No description;1;SUPV_RETURN_VALUES_IF;linux/com/SyrlinksComHandler.h
 0x68a0;SPVRTVIF_CrcFailure;Space Packet received from PLOC supervisor has invalid CRC;160;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
 0x68a1;SPVRTVIF_InvalidServiceId;No description;161;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
 0x68a2;SPVRTVIF_ReceivedAckFailure;Received ACK failure reply from PLOC supervisor;162;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h

eive_tmtc/tmtc/acs/acs_ctrl.py

@@ -989,6 +989,7 @@ def handle_mekf_data(pw: PrintWrapper, hk_data: bytes):
         2: "NO_MODEL_VECTORS",
         3: "NO_SUS_MGM_STR_DATA",
         4: "COVARIANCE_INVERSION_FAILED",
+        5: "NOT_FINITE",
         10: "INITIALIZED",
         11: "RUNNING",
     }
@@ -1016,7 +1017,10 @@ def handle_mekf_data(pw: PrintWrapper, hk_data: bytes):
     current_idx += inc_len_vec
     status = struct.unpack(fmt_sts, hk_data[current_idx : current_idx + inc_len_sts])[0]
     current_idx += inc_len_sts
-    pw.dlog(f"{'MEKF Status'.ljust(25)}: {mekf_status[status]}")
+    if mekf_status.get(status) is not None:
+        pw.dlog(f"{'MEKF Status'.ljust(25)}: {mekf_status[status]}")
+    else:
+        pw.dlog(f"{'MEKF Raw Status (key unknown)'.ljust(25)}: {status}")
     pw.dlog(f"{'MEKF Quaternion'.ljust(25)}: {fmt_str_4.format(*quat)}")
     pw.dlog(f"{'MEKF Rotational Rate'.ljust(25)}: {fmt_str_3.format(*rates)}")
     pw.printer.print_validity_buffer(hk_data[current_idx:], num_vars=3)

eive_tmtc/tmtc/acs/gps.py

@@ -7,6 +7,7 @@ from eive_tmtc.config.definitions import CustomServiceList
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from tmtccmd.config import TmtcDefinitionWrapper, OpCodeEntry
 from tmtccmd.config.tmtc import tmtc_definitions_provider
+from tmtccmd.tc.pus_200_fsfw_mode import create_mode_command, Mode
 from tmtccmd.tc import DefaultPusQueueHelper
 from tmtccmd.tc.pus_3_fsfw_hk import (
     make_sid,
@@ -20,6 +21,8 @@ _LOGGER = logging.getLogger(__name__)
 
 
 class OpCode:
+    OFF = "off"
+    ON = "on"
     REQ_OS_HK = ["hk"]
     ENABLE_HK = ["enable_hk"]
     DISABLE_HK = ["disable_hk"]
@@ -27,6 +30,8 @@ class OpCode:
 
 
 class Info:
+    OFF = "Off"
+    ON = "On"
     REQ_OS_HK = "Request One-Shot HK"
     ENABLE_HK = "Enable HK"
     DISABLE_HK = "Disable HK"
@@ -44,6 +49,8 @@ def add_gps_cmds(defs: TmtcDefinitionWrapper):
     oce.add(keys=OpCode.REQ_OS_HK, info=Info.REQ_OS_HK)
     oce.add(keys=OpCode.ENABLE_HK, info=Info.ENABLE_HK)
     oce.add(keys=OpCode.DISABLE_HK, info=Info.DISABLE_HK)
+    oce.add(keys=OpCode.OFF, info=Info.OFF)
+    oce.add(keys=OpCode.ON, info=Info.ON)
     defs.add_service(
         name=CustomServiceList.GPS_CTRL.value,
         info="GPS/GNSS Controller",
@@ -72,6 +79,12 @@ def pack_gps_command(object_id: bytes, q: DefaultPusQueueHelper, op_code: str):
     if op_code in OpCode.REQ_OS_HK:
         q.add_log_cmd(f"GPS: {Info.REQ_OS_HK}")
         q.add_pus_tc(create_request_one_hk_command(sid=sid))
+    if op_code in OpCode.ON:
+        q.add_log_cmd(f"GPS: {Info.ON}")
+        q.add_pus_tc(create_mode_command(object_id, Mode.ON, 0))
+    if op_code in OpCode.OFF:
+        q.add_log_cmd(f"GPS: {Info.OFF}")
+        q.add_pus_tc(create_mode_command(object_id, Mode.OFF, 0))
 
 
 def handle_gps_data(printer: FsfwTmTcPrinter, hk_data: bytes):

eive_tmtc/tmtc/acs/star_tracker.py

@@ -97,12 +97,19 @@ class OpCodes:
     NORMAL = "nml"
     OFF = "off"
     PING = "ping"
-    REQUEST_SOLUTION_SET = "request_sol_set"
+    REQUEST_SOLUTION_SET_HK = "hk_req_sol"
+    REQUEST_SOLUTION_SET_ACTION = "action_req_sol"
     TAKE_IMAGE = "take_image"
+    UPLOAD_IMAGE = "upload_image"
+    SET_IMG_PROCESSOR_MODE = "set_img_proc_mode"
 
 
 class Info:
-    REQUEST_SOLUTION_SET = "Request Solution Set HK once"
+    REQUEST_SOLUTION_SET_HK = "Request Solution Set HK once"
+    REQUEST_SOLUTION_SET_ACTION = "Request Solution Set Action"
+    UPLOAD_IMAGE = "Upload Image"
+    TAKE_IMAGE = "Take Image"
+    SET_IMG_PROCESSOR_MODE = "Set Image Processor Mode"
 
 
 class SetId(enum.IntEnum):
@@ -128,7 +135,7 @@ class FileDefs:
     egse_histogram_upload_img_config = (
         "/home/pi/arcsec/json/upload-image-histogram.json"
     )
-    q7s_ground_config = "/mnt/sd0/startracker/json/ground-config.json"
+    q7s_ground_config = "/mnt/sd0/startracker/ground-config.json"
     q7s_flight_config = "/mnt/sd0/startracker/flight-config.json"
     firmware2_1 = "/home/pi/arcsec/firmware/sagitta-2-1.bin"
     firmware22_1 = "/home/pi/arcsec/firmware/sagitta-22-1.bin"
@@ -136,31 +143,31 @@ class FileDefs:
 
 
 json_dict = {
-    "1": ["Q7S flight config", FileDefs.q7s_flight_config],
-    "2": ["Q7S ground config", FileDefs.q7s_ground_config],
-    "3": ["EGSE flight config", FileDefs.egse_flight_config],
-    "4": ["EGSE ground config", FileDefs.egse_ground_config],
-    "5": [
+    "1": ("Q7S flight config", FileDefs.q7s_flight_config),
+    "2": ("Q7S ground config", FileDefs.q7s_ground_config),
+    "3": ("EGSE flight config", FileDefs.egse_flight_config),
+    "4": ("EGSE ground config", FileDefs.egse_ground_config),
+    "5": (
         "EGSE get solution, upload image config",
         FileDefs.egse_solution_upload_img_config,
-    ],
-    "6": [
+    ),
+    "6": (
         "EGSE get histogram, upload image config",
         FileDefs.egse_solution_upload_img_config,
-    ],
+    ),
 }
 
 firmware_dict = {
-    "1": ["Firmware Major = 2, Minor = 1", FileDefs.firmware2_1],
-    "2": ["Firmware Major = 22, Minor = 1", FileDefs.firmware22_1],
-    "3": ["Firmware Origin", FileDefs.firmware_origin],
+    "1": ("Firmware Major = 2, Minor = 1", FileDefs.firmware2_1),
+    "2": ("Firmware Major = 22, Minor = 1", FileDefs.firmware22_1),
+    "3": ("Firmware Origin", FileDefs.firmware_origin),
 }
 
 upload_image_dict = {
-    "1": ["q7s gemma", "/mnt/sd0/startracker/gemma.bin"],
-    "2": ["egse gemma", "/home/pi/arcsec/star-images/gemma.bin"],
-    "3": ["q7s polaris", "/mnt/sd0/startracker/polaris.bin"],
-    "4": ["egse polaris", "/home/pi/arcsec/star-images/polaris.bin"],
+    "1": ("q7s gemma", "/mnt/sd0/startracker/gemma.bin"),
+    "2": ("egse gemma", "/home/pi/arcsec/star-images/gemma.bin"),
+    "3": ("q7s polaris", "/mnt/sd0/startracker/polaris.bin"),
+    "4": ("egse polaris", "/home/pi/arcsec/star-images/polaris.bin"),
 }
 
 
@@ -204,9 +211,13 @@ def pack_star_tracker_commands(
         q.add_log_cmd("Star tracker: Mode Off")
         data = pack_mode_data(obyt, Mode.OFF, 0)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=data))
-    if op_code == OpCodes.REQUEST_SOLUTION_SET:
-        q.add_log_cmd(Info.REQUEST_SOLUTION_SET)
+    if op_code == OpCodes.REQUEST_SOLUTION_SET_HK:
+        q.add_log_cmd(Info.REQUEST_SOLUTION_SET_HK)
         q.add_pus_tc(create_request_one_diag_command(make_sid(obyt, SetId.SOLUTION)))
+    if op_code == OpCodes.REQUEST_SOLUTION_SET_ACTION:
+        q.add_log_cmd("Star tracker: Request solution")
+        data = obyt + struct.pack("!I", StarTrackerActionId.REQ_SOLUTION)
+        q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
     if op_code == "4":
         q.add_log_cmd("Star tracker: Mode Raw")
         data = pack_mode_data(obyt, Mode.RAW, 0)
@@ -254,11 +265,7 @@ def pack_star_tracker_commands(
         q.add_log_cmd("Star tracker: Request time")
         data = obyt + struct.pack("!I", StarTrackerActionId.REQ_TIME)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if op_code == "14":
-        q.add_log_cmd("Star tracker: Request solution")
-        data = obyt + struct.pack("!I", StarTrackerActionId.REQ_SOLUTION)
-        q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if op_code == "15":
+    if op_code == OpCodes.UPLOAD_IMAGE:
         q.add_log_cmd("Star tracker: Upload image")
         image = get_upload_image()
         data = (
@@ -361,7 +368,9 @@ def pack_star_tracker_commands(
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
     if op_code == OpCodes.TAKE_IMAGE:
         q.add_log_cmd("Star tracker: Take image")
-        actionid = int(input("Specify parameter ID (take image - 4): "))
+        actionid = int(
+            input("Specify parameter ID (4: take image, 7: get histogram): ")
+        )
         data = (
             obyt
             + struct.pack("!I", StarTrackerActionId.TAKE_IMAGE)
@@ -511,8 +520,8 @@ def pack_star_tracker_commands(
         q.add_log_cmd("Star tracker: Request limits")
         data = obyt + struct.pack("!I", StarTrackerActionId.REQ_LIMITS)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if op_code == "51":
-        q.add_log_cmd("Star tracker: Set image processor parameters")
+    if op_code == OpCodes.SET_IMG_PROCESSOR_MODE:
+        q.add_log_cmd(Info.SET_IMG_PROCESSOR_MODE)
         json_file = get_config_file()
         data = (
             obyt
@@ -798,10 +807,13 @@ def add_str_cmds(defs: TmtcDefinitionWrapper):
     oce.add(OpCodes.ON_FIRMWARE, "Mode On, Submode Firmware")
     oce.add(OpCodes.NORMAL, "Mode Normal")
     oce.add(OpCodes.OFF, "Mode Off")
-    oce.add("4", "Star Tracker: Mode Raw")
+    # oce.add("4", "Star Tracker: Mode Raw")
     oce.add(OpCodes.PING, "Star Tracker: Ping")
     oce.add(OpCodes.TAKE_IMAGE, "Take Image")
-    oce.add(OpCodes.REQUEST_SOLUTION_SET, "Request Solution Set HK")
+    oce.add(OpCodes.REQUEST_SOLUTION_SET_HK, Info.REQUEST_SOLUTION_SET_HK)
+    oce.add(OpCodes.REQUEST_SOLUTION_SET_ACTION, Info.REQUEST_SOLUTION_SET_ACTION)
+    oce.add(OpCodes.UPLOAD_IMAGE, Info.UPLOAD_IMAGE)
+    oce.add(OpCodes.SET_IMG_PROCESSOR_MODE, Info.SET_IMG_PROCESSOR_MODE)
     oce.add("6", "Star Tracker: Switch to bootloader program")
     oce.add("7", "Star Tracker: Request temperature")
     oce.add("8", "Star Tracker: Request version")
@@ -811,7 +823,6 @@ def add_str_cmds(defs: TmtcDefinitionWrapper):
     oce.add("12", "Star Tracker: Boot image (requires bootloader mode)")
     oce.add("13", "Star Tracker: Request time")
     oce.add("14", "Star Tracker: Request solution")
-    oce.add("15", "Star Tracker: Upload image")
     oce.add("16", "Star Tracker: Download image")
     oce.add("17", "Star Tracker: Set limit parameters")
     oce.add("17", "Star Tracker: Set limit parameters")
@@ -833,7 +844,6 @@ def add_str_cmds(defs: TmtcDefinitionWrapper):
     oce.add("37", "Star Tracker: Get checksum")
     oce.add("49", "Star Tracker: Request camera parameter")
     oce.add("50", "Star Tracker: Request limits")
-    oce.add("51", "Star Tracker: Set image processor parameters")
     oce.add("52", "Star Tracker: (EGSE only) Load camera ground config")
     oce.add("53", "Star Tracker: (EGSE only) Load camera flight config")
     oce.add("54", "Star Tracker: Request log level parameters")

eive_tmtc/tmtc/com/syrlinks_handler.py

@@ -307,7 +307,9 @@ def handle_syrlinks_rx_registers_dataset(printer: FsfwTmTcPrinter, hk_data: byte
     if rx_demod_n0 > 0:
         eb_to_n0 = 20 * math.log10(rx_demod_eb / rx_demod_n0) - 3
     else:
-        logging.getLogger(__name__).warning("RX Demod N0 is 0, can not calculate Eb to N0")
+        logging.getLogger(__name__).warning(
+            "RX Demod N0 is 0, can not calculate Eb to N0"
+        )
         eb_to_n0 = 0
     rx_data_rate_raw = hk_data[21]
     rx_data_rate = -1