CFDP Packet Stack #523

Closed
muellerr wants to merge 2 commits from KSat:mueller/cfdp-pdus into development
Owner

This PR adds the packet stack for the CCSDS File Delivery Protocol.
It also refactors the existing TMTC infastructure to allow sending
of CFDP packets to the CCSDS handlers.

This includes the whole PDU (Protocol Data Unit) stack:

  • File Data PDUs

and all file directive PDUs

  • ACK PDU
  • NAK PDU
  • Metadata PDU
  • Finished PDU
  • Prompt PDU
  • Keep Alive PDU
  • EOF PDU

The PR includes a full set of unittests for the packet stack
with a coverage of 90+ %.

The refactoring of the existing TMTC infastructure includes non-ideal
solutions like diamond inheritance.
Avoiding this solution would require refactoring the packet stack.
This would be a good idea anyway because the existing stack is tightly
coupled to the FSFW, making reuse more difficult if only the stack is
planned to be used without the store functionalities etc.

The PDU implementation provided here is only weakly coupled to the FSFW,
only using components like returnvalues or the Serialization modules.
There are dedicated serializers and deserializers, which also helps in
creating small focused modules which are easy to test.

Some of the modules here were provied by Matthias Tompert.

This PR adds the packet stack for the CCSDS File Delivery Protocol. It also refactors the existing TMTC infastructure to allow sending of CFDP packets to the CCSDS handlers. This includes the whole PDU (Protocol Data Unit) stack: - File Data PDUs and all file directive PDUs - ACK PDU - NAK PDU - Metadata PDU - Finished PDU - Prompt PDU - Keep Alive PDU - EOF PDU The PR includes a full set of unittests for the packet stack with a coverage of 90+ %. The refactoring of the existing TMTC infastructure includes non-ideal solutions like diamond inheritance. Avoiding this solution would require refactoring the packet stack. This would be a good idea anyway because the existing stack is tightly coupled to the FSFW, making reuse more difficult if only the stack is planned to be used without the store functionalities etc. The PDU implementation provided here is only weakly coupled to the FSFW, only using components like returnvalues or the Serialization modules. There are dedicated serializers and deserializers, which also helps in creating small focused modules which are easy to test. Some of the modules here were provied by Matthias Tompert.
muellerr added 108 commits 2021-11-16 22:48:50 +01:00
Reviewed-on: eive/fsfw#6
Reviewed-on: eive/fsfw#7
1. Service Interface looks better now
2. Bugfix in CommandExecutor blocking mode
Reviewed-on: eive/fsfw#8
Reviewed-on: eive/fsfw#9
Same port number used as before, but some inconsistencies fixed
Reviewed-on: eive/fsfw#11
Will be merged upstream soon
Reviewed-on: eive/fsfw#12
When using the non-canonical mode, the file descriptor can be opened
in blocking mode because the VTIME and VMIN termios parameters are
used to configure non-blocking mode. However, in canonical mode, the fd needs to be opened with O_NONBLOCK
The delayCycles variables needs to be initialized differently
for periodic replies.
It is initialized to the maxDelayCycles value now
Reviewed-on: eive/fsfw#13
Reviewed-on: eive/fsfw#14
Reviewed-on: eive/fsfw#15
Reviewed-on: eive/fsfw#16
Reviewed-on: eive/fsfw#17
muellerr added the
feature
label 2021-11-17 11:04:41 +01:00
muellerr added the
Breaking API Change
label 2021-11-19 13:47:34 +01:00
muellerr added this to the v3.0.0 milestone 2021-11-23 19:41:07 +01:00
muellerr force-pushed mueller/cfdp-pdus from 4fd092a47e to 164c871786 2021-12-03 15:31:28 +01:00 Compare
muellerr force-pushed mueller/cfdp-pdus from 164c871786 to 0ac1d1c1ca 2021-12-03 15:34:32 +01:00 Compare
muellerr changed title from WIP: CFDP Packet Stack to CFDP Packet Stack 2021-12-03 15:34:36 +01:00
muellerr added 1 commit 2021-12-03 15:35:59 +01:00
Author
Owner

reopening to make commit list smaller

reopening to make commit list smaller
muellerr closed this pull request 2021-12-03 15:36:33 +01:00

Pull request closed

Sign in to join this conversation.
No description provided.