fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

HAL GPIO: Updates for windows compatibility #556

Closed
muellerr wants to merge 68 commits from eive:mueller/gpio-hal-updates into development
pull from: eive:mueller/gpio-hal-updates
merge into: fsfw:development
Conversation 2 Commits 68 Files Changed 74 +491 -318
muellerr commented 2022-02-22 11:03:09 +01:00
Owner
Copy Link
  • Compile errors on windows due to nameclashes. Changed the name of enum entries now to fix this.
  • Increase time limit for unit tests to a much larger value because it failed
  • The other comment changes are form applying clang format

Another way would be to make these enum class types (strongly typed). This would be an event stronger API change.

- Compile errors on windows due to nameclashes. Changed the name of enum entries now to fix this. - Increase time limit for unit tests to a much larger value because it failed - The other comment changes are form applying clang format Another way would be to make these `enum class` types (strongly typed). This would be an event stronger API change.
muellerr added 1 commit 2022-02-22 11:03:17 +01:00
updated for windows compatibility
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
1e982ec00b
muellerr changed title from updated for windows compatibility to updates for windows compatibility 2022-02-22 11:03:22 +01:00
muellerr added 1 commit 2022-02-22 11:10:09 +01:00
more time
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
3a5881a0cb
muellerr added this to the v5.0.0 milestone 2022-02-22 11:13:35 +01:00
muellerr changed title from updates for windows compatibility to HAL GPIO: Updates for windows compatibility 2022-02-22 11:14:15 +01:00
muellerr added 1 commit 2022-02-22 11:15:10 +01:00
apply .clang format
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
3966b656e9
muellerr added 1 commit 2022-02-22 11:26:20 +01:00
update changelog
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
b440c30223
muellerr requested review from gaisser 2022-02-22 11:43:00 +01:00
muellerr added the
question
 label 2022-02-22 11:45:49 +01:00
muellerr added 1 commit 2022-02-23 11:02:09 +01:00
Merge branch 'development' into mueller/gpio-hal-updates
Some checks reported errors
fsfw/fsfw/pipeline/pr-development Something is wrong with the build of this commit
Details
7ce2c1b624
muellerr commented 2022-02-23 11:02:46 +01:00
Author
Owner
Copy Link

Actually I'm in favor of turning those into enum classes right now.

Actually I'm in favor of turning those into enum classes right now.
muellerr changed title from HAL GPIO: Updates for windows compatibility to WIP: HAL GPIO: Updates for windows compatibility 2022-02-23 11:02:59 +01:00
muellerr added 1 commit 2022-02-28 14:39:37 +01:00
Merge remote-tracking branch 'upstream/development' into mueller/gpio-hal-updates
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
729bcc4aaf
muellerr added the
API Change
 label 2022-02-28 14:45:24 +01:00
muellerr added 1 commit 2022-02-28 14:46:17 +01:00
use enum class
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
afd3a942e2
muellerr added 1 commit 2022-02-28 14:56:40 +01:00
some updates
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
331aa9442d
muellerr added 1 commit 2022-02-28 15:16:43 +01:00
some fixes
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
68225586d2
muellerr added 1 commit 2022-02-28 15:21:39 +01:00
Merge remote-tracking branch 'upstream/development' into mueller/gpio-hal-updates
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
27267b7cb0
muellerr changed title from WIP: HAL GPIO: Updates for windows compatibility to HAL GPIO: Updates for windows compatibility 2022-02-28 15:21:52 +01:00
muellerr added 1 commit 2022-02-28 15:22:32 +01:00
Merge remote-tracking branch 'upstream/development' into mueller/gpio-hal-updates
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
4cf2a384f3
muellerr added 8 commits 2022-02-28 15:34:49 +01:00
apply clang script
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
07cb980e06
add uio subdir
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
33386550cf
added cpp printout preprocessor guards
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
992c05df56
Merge branch 'eive/develop' into mueller/gpio-hal-updates
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
2fed161eff
muellerr added 48 commits 2022-02-28 15:49:12 +01:00
this fixes the warning
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
8030d9ac1b
this should work for c++11
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
22cd38fffd 
Reviewed-on: eive/fsfw#31
Reviewed-on: eive/fsfw#32
Reviewed-on: eive/fsfw#33
- Perform an empty SPI transfer after setting speed and mode
Reviewed-on: eive/fsfw#34
Reviewed-on: eive/fsfw#35
Merge remote-tracking branch 'origin/eive/develop' into mueller/gpio-hal-updates
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
ac036b2a70
muellerr added 1 commit 2022-02-28 15:50:35 +01:00
fix merge conflict
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
e05e203c83
muellerr commented 2022-02-28 15:53:42 +01:00
Author
Owner
Copy Link

Merged eive/develop.. kind of by accident but it makes sense to merge this stronger API change internally for EIVE first. Will be re-opened in separate PR

Merged eive/develop.. kind of by accident but it makes sense to merge this stronger API change internally for EIVE first. Will be re-opened in separate PR
muellerr closed this pull request 2022-02-28 15:53:48 +01:00
gaisser removed this from the v5.0.0 milestone 2022-03-28 15:26:33 +02:00
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
API Change
question
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#556
No description provided.
Delete Branch "eive:mueller/gpio-hal-updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?