fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Using enums to configure baudrate and bits per word in Linux HAL UART #585

Merged
mohr merged 3 commits from mohr/hal_uart into development 2022-03-28 14:47:05 +02:00
Conversation 1 Commits 3 Files Changed 4 +117 -50
mohr commented 2022-03-24 15:47:45 +01:00
Owner
Copy Link

This is an alternative/extension to #581.

As these values are used without user interaction, there is no way of returning and thus safely handling misconfiguration.
Using enums provides a set range of valid values the compiler can check at compile time.

This is an alternative/extension to #581. As these values are used without user interaction, there is no way of returning and thus safely handling misconfiguration. Using enums provides a set range of valid values the compiler can check at compile time.
mohr added 107 commits 2022-03-24 15:47:50 +01:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
2f1b923009
this module should not be needed anymore
fsfw/fsfw/pipeline/pr-development This commit looks good Details
6fb64f9ada
removed source from cmakelists.txt
fsfw/fsfw/pipeline/pr-development This commit looks good Details
025f79fcb4
apply clang format
fsfw/fsfw/pipeline/pr-development This commit looks good Details
90b8ad1e6d
apply clang format
fsfw/fsfw/pipeline/pr-development This commit looks good Details
6739890d53
add i2c wiretapping option
fsfw/fsfw/pipeline/pr-development This commit looks good Details
d119479c0a
update changelog
fsfw/fsfw/pipeline/pr-development This commit looks good Details
68ace0b74a
update changelog
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
9c2ceb4a9f
one shot flag not static anymore
fsfw/fsfw/pipeline/pr-development This commit looks good Details
aebd4817b8
periodic printouts are runtime configurable now
fsfw/fsfw/pipeline/pr-development This commit looks good Details
0c4835bfb5
update changelog
fsfw/fsfw/pipeline/pr-development This commit looks good Details
eac7e6db07
try readme tweak
fsfw/fsfw/pipeline/pr-master This commit looks good Details
a50b52df51 Fixed an issue in host OSAL and added more coverage to IER
fsfw/fsfw/pipeline/pr-master This commit looks good Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
e5e85bcff9 still clang
fsfw/fsfw/pipeline/pr-development This commit looks good Details
fdc8a3d4f7
display run commands in helper script
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
56d0c8c616 Merge branch 'development' into mueller/test-task-one-shot-flag-not-static
fsfw/fsfw/pipeline/pr-development This commit looks good Details
5f7e384442 Merge branch 'development' into mueller/hal-i2c-wiretapping
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
f99f5ed730 Merge branch 'development' into mueller/dev-printout-runtime-configurable
fsfw/fsfw/pipeline/pr-development This commit looks good Details
d6508e23b6 Added more coverage and Documentation
fsfw/fsfw/pipeline/pr-development This commit looks good Details
d4e48006f2 Merge branch 'development' into mueller/update-helper-script
fsfw/fsfw/pipeline/pr-development This commit looks good Details
e75155c329 Merge branch 'development' into mueller/apply-clang-format
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
d6d13eec95 Merge branch 'development' into gaisser_unit_test_internal_error
fsfw/fsfw/pipeline/pr-development This commit looks good Details
a10e5c6ed4 Merge branch 'development' into mueller/update-helper-script
fsfw/fsfw/pipeline/pr-development This commit looks good Details
1ef3dae72e Fixed an missing include
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
0e8328fca3 Fixed include based on Feedback
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
a6c0f3fef5 Merge remote-tracking branch 'upstream/development' into mueller/delete-obsolete-module
fsfw/fsfw/pipeline/pr-development This commit looks good Details
2635f39344 Merge branch 'development' into mueller/update-helper-script
fsfw/fsfw/pipeline/pr-development This commit looks good Details
20928732ec Merge branch 'development' into gaisser_unit_test_internal_error
fsfw/fsfw/pipeline/pr-development This commit looks good Details
68ca6fd122 Merge branch 'development' into gaisser_compiler_flags
fsfw/fsfw/pipeline/head Build started... Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
f659f13759 Changing build to -j4 from -j to lessen load on build server
fsfw/fsfw/pipeline/pr-development This commit looks good Details
117747970d some forgotten size_t
fsfw/fsfw/pipeline/pr-development This commit looks good Details
14b44f8bb2 Merge branch 'development' into gaisser_compiler_flags
fsfw/fsfw/pipeline/pr-development This commit looks good Details
d06eecf9b0 small test device handler fixes
fsfw/fsfw/pipeline/pr-development This commit looks good Details
41a82e923c
update changelog
fsfw/fsfw/pipeline/pr-development This commit looks good Details
32f420c4f0
SPI HAL improvement 
- Initialize line state
fsfw/fsfw/pipeline/pr-development This commit looks good Details
983fa346b3
update CHANGELOG
8b1af232c3 Added Tests for CCSDS Time, fixed LPM Test 
Changed behaviour of Host and Linux Clock
fsfw/fsfw/pipeline/pr-development This commit looks good Details
a4f97a7ba7 Fixed another issue of time checks
fsfw/fsfw/pipeline/pr-development This commit looks good Details
e5a9cab34e
fix changelog
fsfw/fsfw/pipeline/pr-development This commit looks good Details
d6856fc54a
another minor changelog update
fsfw/fsfw/pipeline/pr-development This commit looks good Details
89c1878622
add link to PR
fsfw/fsfw/pipeline/pr-development Build started... Details
14620fdd72
minor correction
fsfw/fsfw/pipeline/pr-development This commit looks good Details
77e5fba7fd
update changelog
fsfw/fsfw/pipeline/pr-development This commit looks good Details
7932afc315
small form change
fsfw/fsfw/pipeline/pr-development This commit looks good Details
238baa8597 call setTimeout
fsfw/fsfw/pipeline/pr-development This commit looks good Details
445d5dd6f0 Added Checks for CDSShort in unittests
fsfw/fsfw/pipeline/pr-development This commit looks good Details
345a799031 improved version.h
fsfw/fsfw/pipeline/pr-development This commit looks good Details
ca508bfe61 getter not required anymore
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
7daa9812ff added tests
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
949549178a
update changelog
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
3779b44813
added some more minor tests
fsfw/fsfw/pipeline/pr-development This commit looks good Details
6b1a81ee92
minor tweaks
fsfw/fsfw/pipeline/pr-development This commit looks good Details
14ac852b7e
this tests even a bit more
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
e684680d60
avoid namespace pollution
fsfw/fsfw/pipeline/pr-development This commit looks good Details
0bdcb40609 minor event changes
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
97c93afeff Merge remote-tracking branch 'upstream/development' into mueller/version-getter-upstream
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
ce5bcc5897
bugfix
fsfw/fsfw/pipeline/pr-development This commit looks good Details
48c5c3fbd5 Merge branch 'development' into mueller/event-update
fsfw/fsfw/pipeline/pr-development This commit looks good Details
7c64797f03
Add more baud rates
fsfw/fsfw/pipeline/pr-development This commit looks good Details
f441505476
update changelog
fsfw/fsfw/pipeline/head This commit looks good Details
fsfw/fsfw/pipeline/pr-master This commit looks good Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
c60aa68d00 changed hal linux uart baudrate and bits per word to enums
mohr changed target branch from master to development 2022-03-24 15:48:41 +01:00
mohr requested review from muellerr 2022-03-24 15:54:48 +01:00
mohr requested review from meierj 2022-03-24 15:54:48 +01:00
muellerr commented 2022-03-24 16:41:17 +01:00
Owner
Copy Link

Seems very useful. LGTM

Seems very useful. LGTM
muellerr approved these changes 2022-03-24 16:41:32 +01:00
meierj approved these changes 2022-03-24 20:05:20 +01:00
gaisser added this to the v5.0.0 milestone 2022-03-28 14:46:36 +02:00
mohr added the
Breaking API Change
 label 2022-03-28 14:46:39 +02:00
mohr self-assigned this 2022-03-28 14:46:53 +02:00
mohr merged commit d43caa8296 into development 2022-03-28 14:47:05 +02:00
mohr deleted branch mohr/hal_uart 2022-03-28 14:47:10 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
muellerr
meierj
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
mohr
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#585
No description provided.
Delete Branch "mohr/hal_uart"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?