Using enums to configure baudrate and bits per word in Linux HAL UART #585

Merged

mohr merged 3 commits from mohr/hal_uart into development 2022-03-28 14:47:05 +02:00

Conversation 3 Commits 3 Files Changed 4

+117 -50

mohr commented 2022-03-24 15:47:45 +01:00

Owner

Copy link

Copy source

This is an alternative/extension to #581.

As these values are used without user interaction, there is no way of returning and thus safely handling misconfiguration.
Using enums provides a set range of valid values the compiler can check at compile time.

This is an alternative/extension to #581. As these values are used without user interaction, there is no way of returning and thus safely handling misconfiguration. Using enums provides a set range of valid values the compiler can check at compile time.

mohr added 107 commits 2022-03-24 15:47:50 +01:00

WIP unit tests b7f3eff742

Still test for InternalError Reporter 45ea09291a

this module should not be needed anymore 2f1b923009

removed source from cmakelists.txt 6fb64f9ada

apply clang format 025f79fcb4

apply clang format 90b8ad1e6d

add i2c wiretapping option 6739890d53

update changelog d119479c0a

update changelog 68ace0b74a

one shot flag not static anymore 9c2ceb4a9f

periodic printouts are runtime configurable now aebd4817b8

update changelog 0c4835bfb5

try readme tweak eac7e6db07

Fixed an issue in host OSAL and added more coverage to IER a50b52df51

Clang format 4862edfdb5

still clang e5e85bcff9

display run commands in helper script fdc8a3d4f7

Merge pull request 'README tweak' (#562) from eive/fsfw:mueller/readme-tweak into development ... 5ff0f8ea10

Reviewed-on: #562

Merge branch 'development' into mueller/test-task-one-shot-flag-not-static 56d0c8c616

Merge branch 'development' into mueller/hal-i2c-wiretapping 5f7e384442

Merge branch 'development' into mueller/dev-printout-runtime-configurable f99f5ed730

Removed unused code 2cb254a556

Added more coverage and Documentation d6508e23b6

Merge branch 'development' into mueller/update-helper-script d4e48006f2

Merge branch 'development' into mueller/apply-clang-format e75155c329

Merge pull request 'apply clang format' (#558) from eive/fsfw:mueller/apply-clang-format into development ... 457bc6609e

Reviewed-on: #558

Merge branch 'development' into gaisser_unit_test_internal_error d6d13eec95

Merge branch 'development' into mueller/update-helper-script a10e5c6ed4

WIP compiler Flags and new unit tests for fixes f6357b4531

Clang format 09815f5cce

Fixed an issue with wrong buffer size 32381a7872

Fixed an missing include 1ef3dae72e

Fixed include based on Feedback 0e8328fca3

Merge remote-tracking branch 'upstream/development' into mueller/delete-obsolete-module a6c0f3fef5

Merge pull request 'Linux HAL: Add I2C wiretapping option' (#559) from eive/fsfw:mueller/hal-i2c-wiretapping into development ... bbacdc5cac

Reviewed-on: #559

Merge remote-tracking branch 'upstream/development' into mueller/test-task-one-shot-flag-not-static f4520ea346

Merge remote-tracking branch 'upstream/development' into mueller/test-task-one-shot-flag-not-static 9d9f19781d

Merge remote-tracking branch 'upstream/development' into mueller/delete-obsolete-module c0fa365f8f

Merge remote-tracking branch 'upstream/development' into mueller/dev-printout-runtime-configurable cf45eca100

Merge pull request 'HkSwitchHelper should not be needed anymore' (#557) from eive/fsfw:mueller/delete-obsolete-module into development ... 89327463e3

Reviewed-on: #557

Merge branch 'development' into mueller/update-helper-script 2635f39344

Merge pull request 'display run commands in helper script' (#564) from eive/fsfw:mueller/update-helper-script into development ... a8426750f2

Reviewed-on: #564

Merge branch 'development' into gaisser_unit_test_internal_error 20928732ec

Merge remote-tracking branch 'upstream/development' into mueller/test-task-one-shot-flag-not-static af286d3bc6

Merge remote-tracking branch 'upstream/development' into mueller/dev-printout-runtime-configurable 19d217e3b9

Merge pull request 'Unit test for Internal Error Reporter' (#563) from gaisser/fsfw:gaisser_unit_test_internal_error into development ... 33e9592659

Reviewed-on: #563

Merge branch 'development' into gaisser_compiler_flags 68ca6fd122

Merge branch 'development' into mueller/test-task-one-shot-flag-not-static 2d12618c96

Merge pull request 'one shot flag not static anymore' (#560) from eive/fsfw:mueller/test-task-one-shot-flag-not-static into development ... 8920255565

Reviewed-on: #560

Merge remote-tracking branch 'upstream/development' into mueller/dev-printout-runtime-configurable 95078e1103

Changing build to -j4 from -j to lessen load on build server f659f13759

Merge pull request 'Changing build to -j4 from -j to lessen load on build server' (#569) from mohr/slowbuild into development ... c6540650e2

Reviewed-on: #569

some forgotten size_t 117747970d

Merge branch 'development' into gaisser_compiler_flags 14b44f8bb2

Merge pull request 'some forgotten size_t' (#570) from eive/fsfw:mohr/sizes into development ... dbe31dd339

Reviewed-on: #570

Merge branch 'development' into mueller/dev-printout-runtime-configurable 10ffa2f44a

Merge pull request 'HAL Devicehandlers: Periodic printouts are runtime configurable now' (#561) from eive/fsfw:mueller/dev-printout-runtime-configurable into development ... c88b931ef1

Reviewed-on: #561

Merge branch 'development' into gaisser_compiler_flags 7db11588b4

Merge pull request 'Activates new gcc compiler flags' (#568) from gaisser/fsfw:gaisser_compiler_flags into development ... 5912ddd2a2

Reviewed-on: #568

small test device handler fixes d06eecf9b0

GPIO update 5ddac36314

update changelog 41a82e923c

SPI HAL improvement ... 32f420c4f0

- Initialize line state

update CHANGELOG 983fa346b3

Added Tests for CCSDS Time, fixed LPM Test ... 8b1af232c3

Changed behaviour of Host and Linux Clock

Fixed another issue of time checks a4f97a7ba7

fix changelog e5a9cab34e

another minor changelog update d6856fc54a

add link to PR 89c1878622

minor correction 14620fdd72

function to get fsfw version ca70c8c614

update changelog 77e5fba7fd

define FSFW_DISABLE_PRINTOUT in any case d1e3dc4d49

small form change 7932afc315

call setTimeout 238baa8597

Added Checks for CDSShort in unittests 445d5dd6f0

improved version.h 345a799031

getter not required anymore ca508bfe61

added tests 7daa9812ff

update changelog 949549178a

added some more minor tests 3779b44813

minor tweaks 6b1a81ee92

this tests even a bit more 14ac852b7e

undef major and minor aa5d1042f0

avoid namespace pollution e684680d60

minor event changes 0bdcb40609

Merge pull request 'small test device handler fixes' (#571) from eive/fsfw:mueller/small-dh-test-foxes into development ... f4922a8686

Reviewed-on: #571

Merge pull request 'HAL: Update for GPIO code' (#572) from eive/fsfw:mueller/gpio-update into development ... 378c6c8006

Reviewed-on: #572

Merge remote-tracking branch 'upstream/development' into mueller/spi-initialize-line-state 5d6de90859

Merge pull request 'SPI HAL improvement' (#573) from eive/fsfw:mueller/spi-initialize-line-state into development ... 5a1585bd00

Reviewed-on: #573

Merge pull request 'Fixed test issue with overflow of times' (#574) from gaisser/fsfw:gaisser_ccsds_time_tests into development ... 8704b9ab06

Reviewed-on: #574

Merge remote-tracking branch 'upstream/development' into mueller/version-getter-upstream 97c93afeff

bugfix ce5bcc5897

Merge remote-tracking branch 'upstream/development' into mueller/version-getter-upstream 522cbc7f3d

Merge pull request 'Version Getter Function' (#575) from eive/fsfw:mueller/version-getter-upstream into development ... 288d453978

Reviewed-on: #575

Merge branch 'development' into mueller/countdown-improvement-upstream 24ad858b64

Merge branch 'development' into mueller/define-fsfw-disabled-printout-upstream 6998626ad4

Merge pull request 'call setTimeout in Countdown ctor' (#577) from eive/fsfw:mueller/countdown-improvement-upstream into development ... b694aea100

Reviewed-on: #577

Merge branch 'development' into mueller/event-update 48c5c3fbd5

run auto-formatter fca43b3d34

Merge branch 'mueller/event-update' of https://egit.irs.uni-stuttgart.de/eive/fsfw into mueller/event-update bc95e7c886

Merge pull request 'minor event changes' (#578) from eive/fsfw:mueller/event-update into development ... b7a617dab3

Reviewed-on: #578

Merge branch 'development' into mueller/define-fsfw-disabled-printout-upstream d2dd16aef3

Merge pull request 'Always define FSFW_DISABLE_PRINTOUT' (#576) from eive/fsfw:mueller/define-fsfw-disabled-printout-upstream into development ... e08bdd3e35

Reviewed-on: #576

Add more baud rates 7c64797f03

update changelog f441505476

changed hal linux uart baudrate and bits per word to enums c60aa68d00

mohr changed target branch from master to development 2022-03-24 15:48:41 +01:00

mohr requested review from muellerr 2022-03-24 15:54:48 +01:00

mohr requested review from meierj 2022-03-24 15:54:48 +01:00

muellerr commented 2022-03-24 16:41:17 +01:00

Owner

Copy link

Copy source

Seems very useful. LGTM

Seems very useful. LGTM

muellerr approved these changes 2022-03-24 16:41:32 +01:00

meierj approved these changes 2022-03-24 20:05:20 +01:00

gaisser referenced this pull request 2022-03-28 14:44:31 +02:00

Add more baud rates #581

gaisser added this to the v5.0.0 milestone 2022-03-28 14:46:36 +02:00

mohr added the Breaking API Change label 2022-03-28 14:46:39 +02:00

mohr self-assigned this 2022-03-28 14:46:53 +02:00

mohr merged commit d43caa8296 into development 2022-03-28 14:47:05 +02:00

mohr referenced this issue from a commit 2022-03-28 14:47:06 +02:00

Merge pull request 'Using enums to configure baudrate and bits per word in Linux HAL UART' (#585) from mohr/hal_uart into development

mohr deleted branch mohr/hal_uart 2022-03-28 14:47:10 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

muellerr

meierj

Labels

Clear labels

API Change

Changes the API, so Users need to adapted

Breaking API Change

Changes the API in a non backwards compatible way

Documentation

Improvement of code documentation

Refactor

Contains a refactoring of some code

Tests

Issues related to testing code

bug

Something is not working

build

Issues related to the buildsystem, including CI

cosmetics

Small change most users won't notice

duplicate

This issue or pull request already exists

feature

New feature

help wanted

Need some help

hotfix

Quick or important fix that is merged directly into master, causing a new revision

invalid

#worksforme

question

More information is needed

wontfix

This won't be fixed

No labels Breaking API Change

Milestone

No items

No Milestone v5.0.0

Assignees

Clear assignees

ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)

No Assignees mohr

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#585