Merge pull request 'dependency fix' (#303) from tmtc-dep-fix into main

Reviewed-on: #303

.gitignore

@@ -6,6 +6,7 @@ log
 /gps_log.txt
 /config/*.json
 
+/.tmtc-history.txt
 /scex_conf.json
 /tmtc_conf.json
 /seqcnt*.txt
@@ -27,3 +28,7 @@ log
 /.installed.cfg
 /*.egg
 /MANIFEST
+
+# Telemetry database.
+/tm.db
+

CHANGELOG.md

@@ -10,6 +10,101 @@ list yields a list of all related PRs for each release.
 
 # [unreleased]
 
+# [v7.1.1] 2025-02-10
+
+- Bumped `tmtccmd` to v8.2.0
+
+# [v7.1.0] 2025-01-17
+
+- Bumped `tmtccmd` to v8.1.0
+
+## Fixed
+
+- Use new mode TM API.
+
+# [v7.0.0] 2024-05-06
+
+- Reworked PLOC MPSoC commanding to be inline with OBSW update.
+
+## Fixed
+
+- GNSS commands working again (again).
+
+## Added
+
+- Added handling for new clock events.
+
+# [v6.2.0] 2024-04-10
+
+## Added
+
+- Added version set for STR.
+- Command for relative timeshift.
+- Health commands for payload components.
+
+## Fixed
+
+- EPS power commands working again.
+- GNSS commands working again.
+
+## Changed
+
+- Fixed PLOC commanding
+
+# [v6.1.1] 2024-03-06
+
+## Added
+
+- Added Core Ctrl cmd to update leap seconds.
+
+# [v6.1.0] 2024-02-29
+
+## Added
+
+- Added commands to unlock and use STR secondary firmware slot.
+- STR BlobStats TM handling
+- New ACS CTRL commands.
+
+## Fixed
+
+- RW commanding
+
+# [v6.0.0] 2024-02-08
+
+## Changed
+
+- Bumped `tmccmd` to `v8.0.0rc1` to introduce new command tree handling.
+- Added new PLOC SUPV commands to test sets, cleaned up PLOC SUPV commanding.
+
+# [v5.13.0] 2024-01-30
+
+## Added
+
+- First variant of TM handling with a DB which might serve as a foundation for better TM
+  handling with an ORM in the future.
+- Added new parameter commands for PLOC MPSoC to skip SUPV commanding.
+
+# [v5.12.1] 2023-12-13
+
+## Added
+
+- A few new commands to test the TC scheduler.
+
+# [v5.12.0] 2023-12-06
+
+## Added
+
+- New ACS controller commands.
+
+# [v5.11.0] 2023-11-30
+
+## Added
+
+- Added new commands to disable channel order checks partially for the payload PCDU normal modes.
+- Core controller auto switch enable and disable command.
+- Star Tracker JSON reload command. Reboot still required.
+- PLOC SUPV ADC and Counters report TM handling.
+
 # [v5.10.1] 2023-10-27
 
 - Minor improvements, update event translation.

eive_tmtc/cfdp/fault_handler.py

@@ -1,20 +1,28 @@
 import logging
 
-from spacepackets.cfdp import ConditionCode
-from tmtccmd.cfdp.mib import DefaultFaultHandlerBase
+from spacepackets.cfdp import ConditionCode, TransactionId
+from cfdppy.mib import DefaultFaultHandlerBase
 
 _LOGGER = logging.getLogger(__name__)
 
 
 class EiveCfdpFaultHandler(DefaultFaultHandlerBase):
-    def notice_of_suspension_cb(self, cond: ConditionCode):
+    def notice_of_suspension_cb(
+        self, transaction_id: TransactionId, cond: ConditionCode, progress: int
+    ):
         _LOGGER.info(f"Received notice of suspension: {cond!r}")
 
-    def notice_of_cancellation_cb(self, cond: ConditionCode):
+    def notice_of_cancellation_cb(
+        self, transaction_id: TransactionId, cond: ConditionCode, progress: int
+    ):
         _LOGGER.info(f"Received notice of cancellation: {cond!r}")
 
-    def abandoned_cb(self, cond: ConditionCode):
+    def abandoned_cb(
+        self, transaction_id: TransactionId, cond: ConditionCode, progress: int
+    ):
         _LOGGER.info(f"Abandoned transaction: {cond!r}")
 
-    def ignore_cb(self, cond: ConditionCode):
+    def ignore_cb(
+        self, transaction_id: TransactionId, cond: ConditionCode, progress: int
+    ):
         _LOGGER.info(f"Ignored transaction: {cond!r}")

eive_tmtc/cfdp/handler.py

@@ -0,0 +1,253 @@
+from dataclasses import dataclass
+from typing import Optional, Tuple
+
+import deprecation
+from spacepackets import PacketType, SpacePacket, SpacePacketHeader
+from spacepackets.cfdp import GenericPduPacket, PduFactory
+from spacepackets.cfdp.pdu import PduHolder
+from cfdppy import (
+    CfdpUserBase,
+    LocalEntityCfg,
+    RemoteEntityCfgTable,
+)
+from cfdppy.defs import CfdpState
+from cfdppy.handler import (
+    DestHandler,
+    DestStateWrapper,
+    SourceHandler,
+    SourceStateWrapper,
+)
+from cfdppy.handler.common import PacketDestination, get_packet_destination
+from cfdppy.mib import CheckTimerProvider
+from cfdppy.request import PutRequest
+from spacepackets.seqcount import ProvidesSeqCount
+from tmtccmd.version import get_version
+
+
+@dataclass
+class StateWrapper:
+    source_handler_state = SourceStateWrapper()
+    dest_handler_state = DestStateWrapper()
+
+
+class CfdpHandler:
+    """Wrapper class which wraps both the :py:class:`tmtccmd.cfdp.handler.source.SourceHandler` and
+    :py:class:`tmtccmd.cfdp.handler.dest.DestHandler` in a sensible way.
+
+    If you have special requirements, for example you want to spawn a new destination handler
+    for each file copy transfer to allow multiple consecutive file transfers, it might be a good
+    idea to write a custom wrapper."""
+
+    def __init__(
+        self,
+        cfg: LocalEntityCfg,
+        user: CfdpUserBase,
+        seq_cnt_provider: ProvidesSeqCount,
+        remote_cfg_table: RemoteEntityCfgTable,
+        check_timer_provider: CheckTimerProvider,
+    ):
+        self.remote_cfg_table = remote_cfg_table
+        self.dest_handler = DestHandler(
+            cfg=cfg,
+            user=user,
+            remote_cfg_table=remote_cfg_table,
+            check_timer_provider=check_timer_provider,
+        )
+        self.source_handler = SourceHandler(
+            cfg=cfg,
+            seq_num_provider=seq_cnt_provider,
+            user=user,
+            remote_cfg_table=remote_cfg_table,
+            check_timer_provider=check_timer_provider,
+        )
+
+    def put_request(self, request: PutRequest):
+        self.source_handler.put_request(request)
+
+    def pull_next_source_packet(self) -> Optional[PduHolder]:
+        res = self.source_handler.state_machine()
+        if res.states.num_packets_ready:
+            return self.source_handler.get_next_packet()
+        return None
+
+    def pull_next_dest_packet(self) -> Optional[PduHolder]:
+        res = self.dest_handler.state_machine()
+        if res.states.packets_ready:
+            return self.dest_handler.get_next_packet()
+        return None
+
+    def __iter__(self):
+        return self
+
+    def __next__(self) -> Tuple[Optional[PduHolder], Optional[PduHolder]]:
+        """The iterator for this class will returns a tuple of optional PDUs wrapped b a
+        :py:class:`PduHolder`.
+
+        :return: Can be a tuple where the first entry can hold a source packet and the second entry
+            can be a destination packet. If both packets are None, a StopIteration will be raised.
+        """
+        next_source_packet = self.pull_next_source_packet()
+        next_dest_packet = self.pull_next_dest_packet()
+        if not next_dest_packet and not next_source_packet:
+            raise StopIteration
+        return next_source_packet, next_dest_packet
+
+    def put_request_pending(self) -> bool:
+        return self.source_handler.states.state != CfdpState.IDLE
+
+    @deprecation.deprecated(
+        deprecated_in="6.0.0rc0",
+        current_version=get_version(),
+        details="Use insert_packet instead",
+    )
+    def pass_packet(self, packet: GenericPduPacket):
+        self.insert_packet(packet)
+
+    def insert_packet(self, packet: GenericPduPacket):
+        """This function routes the packets based on PDU type and directive type if applicable.
+
+        The routing is based on section 4.5 of the CFDP standard which specifies the PDU forwarding
+        procedure."""
+        if get_packet_destination(packet) == PacketDestination.DEST_HANDLER:
+            self.dest_handler.insert_packet(packet)
+        elif get_packet_destination(packet) == PacketDestination.SOURCE_HANDLER:
+            self.source_handler.insert_packet(packet)  # type: ignore
+
+
+class CfdpInCcsdsHandler:
+    """Wrapper helper type used to wrap PDU packets into CCSDS packets and to extract PDU
+    packets from CCSDS packets.
+
+    :param cfg: Local CFDP entity configuration.
+    :param user: User wrapper. This contains the indication callback implementations and the
+        virtual filestore implementation.
+    :param cfdp_seq_cnt_provider: Every CFDP file transfer has a transaction sequence number.
+        This provider is used to retrieve that sequence number.
+    :param ccsds_seq_cnt_provider: Each CFDP PDU is wrapped into a CCSDS space packet, and each
+        space packet has a dedicated sequence count. This provider is used to retrieve the
+        sequence count.
+    :param ccsds_apid: APID to use for the CCSDS space packet header wrapped around each PDU.
+        This is important so that the OBSW can distinguish between regular PUS packets and
+        CFDP packets."""
+
+    def __init__(
+        self,
+        cfg: LocalEntityCfg,
+        user: CfdpUserBase,
+        remote_cfg_table: RemoteEntityCfgTable,
+        ccsds_apid: int,
+        cfdp_seq_cnt_provider: ProvidesSeqCount,
+        ccsds_seq_cnt_provider: ProvidesSeqCount,
+        check_timer_provider: CheckTimerProvider,
+    ):
+        self.cfdp_handler = CfdpHandler(
+            cfg=cfg,
+            user=user,
+            seq_cnt_provider=cfdp_seq_cnt_provider,
+            remote_cfg_table=remote_cfg_table,
+            check_timer_provider=check_timer_provider,
+        )
+        self.ccsds_seq_cnt_provider = ccsds_seq_cnt_provider
+        self.ccsds_apid = ccsds_apid
+
+    def put_request_pending(self):
+        return self.cfdp_handler.put_request_pending()
+
+    def state_machine(self):
+        self.source_handler.state_machine()
+        self.dest_handler.state_machine()
+
+    @deprecation.deprecated(
+        deprecated_in="6.0.0rc1",
+        current_version=get_version(),
+        details="Use state_machine instead",
+    )
+    def fsm(self):
+        self.state_machine()
+
+    @property
+    def source_handler(self):
+        return self.cfdp_handler.source_handler
+
+    @property
+    def dest_handler(self):
+        return self.cfdp_handler.dest_handler
+
+    def pull_next_source_packet(self) -> Optional[Tuple[PduHolder, SpacePacket]]:
+        """Retrieves the next PDU to send and wraps it into a space packet"""
+        next_packet = self.cfdp_handler.pull_next_source_packet()
+        if next_packet is None:
+            return next_packet
+        sp_header = SpacePacketHeader(
+            packet_type=PacketType.TC,
+            apid=self.ccsds_apid,
+            seq_count=self.ccsds_seq_cnt_provider.get_and_increment(),
+            data_len=next_packet.packet_len - 1,
+        )
+        return next_packet, SpacePacket(sp_header, None, next_packet.pack())
+
+    def pull_next_dest_packet(self) -> Optional[Tuple[PduHolder, SpacePacket]]:
+        """Retrieves the next PDU to send and wraps it into a space packet"""
+        next_packet = self.cfdp_handler.pull_next_dest_packet()
+        if next_packet is None:
+            return next_packet
+        sp_header = SpacePacketHeader(
+            packet_type=PacketType.TC,
+            apid=self.ccsds_apid,
+            seq_count=self.ccsds_seq_cnt_provider.get_and_increment(),
+            data_len=next_packet.packet_len - 1,
+        )
+        return next_packet, SpacePacket(sp_header, None, next_packet.pack())
+
+    @deprecation.deprecated(
+        deprecated_in="6.0.0rc1",
+        current_version=get_version(),
+        details="Use insert_space_packet instead",
+    )
+    def pass_space_packet(self, space_packet: SpacePacket):
+        self.insert_space_packet(space_packet)
+
+    def insert_space_packet(self, space_packet: SpacePacket) -> bool:
+        if space_packet.user_data is None:
+            raise ValueError(
+                "space packet is empty, expected packet containing a CFDP PDU"
+            )
+        # Unwrap the user data and pass it to the handler
+        pdu_raw = space_packet.user_data
+        pdu_base = PduFactory.from_raw(pdu_raw)
+        if pdu_base:
+            self.insert_pdu_packet(pdu_base)
+            return True
+        return False
+
+    def insert_pdu_packet(self, pdu: GenericPduPacket):
+        self.cfdp_handler.insert_packet(pdu)
+
+    @deprecation.deprecated(
+        deprecated_in="6.0.0rc1",
+        current_version=get_version(),
+        details="Use insert_pdu_packet instead",
+    )
+    def pass_pdu_packet(self, pdu_base: GenericPduPacket):
+        self.insert_pdu_packet(pdu_base)
+
+    def __iter__(self):
+        return self
+
+    def __next__(
+        self,
+    ) -> Tuple[
+        Optional[Tuple[PduHolder, SpacePacket]],
+        Optional[Tuple[PduHolder, SpacePacket]],
+    ]:
+        """The iterator for this class will returns a tuple of optional PDUs wrapped b a
+        :py:class:`PduHolder`.
+
+        :return: Can be a tuple where the first entry can hold a source packet and the second entry
+            can be a destination packet. If both packets are None, a StopIteration will be raised.
+        """
+        next_source_tuple = self.pull_next_source_packet()
+        next_dest_tuple = self.pull_next_dest_packet()
+        if not next_source_tuple and not next_dest_tuple:
+            raise StopIteration
+        return next_source_tuple, next_dest_tuple

eive_tmtc/cfdp/tm.py

@@ -1,27 +1,29 @@
 import logging
+from typing import Any
 
 from eive_tmtc.config.definitions import CFDP_APID
 from spacepackets.ccsds import SPACE_PACKET_HEADER_SIZE
-from spacepackets.cfdp import PduFactory, PduType, DirectiveType
-from tmtccmd.cfdp.handler import CfdpInCcsdsHandler
-from tmtccmd.tm import SpecificApidHandlerBase
+from spacepackets.cfdp import PduFactory, PduType
+from eive_tmtc.cfdp.handler import CfdpInCcsdsHandler
+from tmtccmd.tmtc import SpecificApidHandlerBase
 
 _LOGGER = logging.getLogger(__name__)
 
 
 class CfdpInCcsdsWrapper(SpecificApidHandlerBase):
     def __init__(self, cfdp_in_ccsds_handler: CfdpInCcsdsHandler):
-        super().__init__(CFDP_APID, None)
         self.handler = cfdp_in_ccsds_handler
+        super().__init__(CFDP_APID, None)
 
-    def handle_tm(self, packet: bytes, _user_args: any):
+    def handle_tm(self, packet: bytes, _user_args: Any):
         # Ignore the space packet header. Its only purpose is to use the same protocol and
         # have a seaprate APID for space packets. If this function is called, the APID is correct.
         pdu = packet[SPACE_PACKET_HEADER_SIZE:]
-        pdu_base = PduFactory.from_raw(pdu)
-        if pdu_base.pdu_type == PduType.FILE_DATA:
+        generic_pdu = PduFactory.from_raw(pdu)
+        assert generic_pdu is not None
+        if generic_pdu.pdu_type == PduType.FILE_DATA:
             _LOGGER.info("Received File Data PDU")
         else:
-            directive_type = DirectiveType(pdu_base.directive_type)
+            directive_type = PduFactory.pdu_directive_type(pdu)
             _LOGGER.info(f"Received File Directive PDU with type {directive_type!r}")
-        self.handler.insert_pdu_packet(pdu_base)
+        self.handler.insert_pdu_packet(generic_pdu)

eive_tmtc/cfdp/user.py

@@ -1,28 +1,48 @@
+from datetime import timedelta
 import logging
 
 from spacepackets.cfdp import ConditionCode
-from tmtccmd.cfdp import CfdpUserBase, TransactionId
-from tmtccmd.cfdp.user import (
+from spacepackets.util import UnsignedByteField
+from cfdppy import CfdpUserBase, TransactionId
+from cfdppy.mib import CheckTimerProvider, EntityType
+from spacepackets.countdown import Countdown
+from cfdppy.user import (
     TransactionFinishedParams,
     MetadataRecvParams,
     FileSegmentRecvdParams,
+    TransactionParams,
 )
 
 _LOGGER = logging.getLogger(__name__)
 
 
+class EiveCheckTimerProvider(CheckTimerProvider):
+    def provide_check_timer(
+        self,
+        local_entity_id: UnsignedByteField,
+        remote_entity_id: UnsignedByteField,
+        entity_type: EntityType,
+    ) -> Countdown:
+        return Countdown(timedelta(seconds=5.0))
+
+
 class EiveCfdpUser(CfdpUserBase):
-    def transaction_indication(self, transaction_id: TransactionId):
-        _LOGGER.info(f"CFDP User: Start of File {transaction_id}")
+    def transaction_indication(
+        self,
+        transaction_indication_params: TransactionParams,
+    ):
+        _LOGGER.info(
+            f"CFDP User: Start of File {transaction_indication_params.transaction_id}"
+        )
 
     def eof_sent_indication(self, transaction_id: TransactionId):
         _LOGGER.info(f"CFDP User: EOF sent for {transaction_id}")
 
     def transaction_finished_indication(self, params: TransactionFinishedParams):
         _LOGGER.info(f"CFDP User: {params.transaction_id} finished")
-        _LOGGER.info(f"Delivery Code: {params.delivery_code!r}")
-        _LOGGER.info(f"Condition code: {params.condition_code!r}")
-        _LOGGER.info(f"File delivery status: {params.delivery_code!r}")
+        _LOGGER.info(f"Delivery Code: {params.finished_params.delivery_code!r}")
+        _LOGGER.info(f"Condition code: {params.finished_params.condition_code!r}")
+        _LOGGER.info(f"File delivery status: {params.finished_params.delivery_code!r}")
 
     def metadata_recv_indication(self, params: MetadataRecvParams):
         pass

eive_tmtc/config/__init__.py

@@ -0,0 +1 @@
+from .definitions import *  # noqa

eive_tmtc/config/custom_mode_op.py

@@ -3,6 +3,7 @@
 @details    Template configuration file. Copy this folder to the TMTC commander root and adapt
             it to your needs.
 """
+
 import enum
 
 from tmtccmd import CcsdsTmtcBackend

eive_tmtc/config/definitions.py

@@ -11,6 +11,15 @@ from spacepackets.ccsds import PacketId
 from spacepackets.util import UnsignedByteField
 
 
+TM_DB_PATH = "tm.db"
+# Separate DB or not? Not sure..
+# RAW_TM_PATH = "raw_tm.db"
+
+# TODO: The cleanest way would be to load those from the config file..
+PRINT_RAW_HK_B64_STR = False
+PRINT_RAW_ACTION_DATA_REPLY_B64_STR = True
+PRINT_RAW_EVENTS_B64_STR = False
+
 PUS_APID = 0x65
 CFDP_APID = 0x66
 PUS_PACKET_ID = PacketId(PacketType.TM, True, PUS_APID)

eive_tmtc/config/events.csv

@@ -75,9 +75,12 @@ Event ID (dec); Event ID (hex); Name; Severity; Description; File Path
 7902;0x1ede;BIT_LOCK;INFO;A Bit Lock signal. Was detected. P1: raw BLO state, P2: 0;fsfw/src/fsfw/datalinklayer/DataLinkLayer.h
 7903;0x1edf;BIT_LOCK_LOST;INFO;A previously found Bit Lock signal was lost. P1: raw BLO state, P2: 0;fsfw/src/fsfw/datalinklayer/DataLinkLayer.h
 7905;0x1ee1;FRAME_PROCESSING_FAILED;LOW;The CCSDS Board could not interpret a TC;fsfw/src/fsfw/datalinklayer/DataLinkLayer.h
-8900;0x22c4;CLOCK_SET;INFO;No description;fsfw/src/fsfw/pus/Service9TimeManagement.h
-8901;0x22c5;CLOCK_DUMP;INFO;No description;fsfw/src/fsfw/pus/Service9TimeManagement.h
-8902;0x22c6;CLOCK_SET_FAILURE;LOW;No description;fsfw/src/fsfw/pus/Service9TimeManagement.h
+8900;0x22c4;CLOCK_SET;INFO;Clock has been set. P1: old timeval seconds. P2: new timeval seconds.;fsfw/src/fsfw/pus/Service9TimeManagement.h
+8901;0x22c5;CLOCK_DUMP_LEGACY;INFO;Clock dump event. P1: timeval seconds P2: timeval milliseconds.;fsfw/src/fsfw/pus/Service9TimeManagement.h
+8902;0x22c6;CLOCK_SET_FAILURE;LOW;Clock could not be set. P1: Returncode.;fsfw/src/fsfw/pus/Service9TimeManagement.h
+8903;0x22c7;CLOCK_DUMP;INFO;Clock dump event. P1: timeval seconds P2: timeval microseconds.;fsfw/src/fsfw/pus/Service9TimeManagement.h
+8904;0x22c8;CLOCK_DUMP_BEFORE_SETTING_TIME;INFO;No description;fsfw/src/fsfw/pus/Service9TimeManagement.h
+8905;0x22c9;CLOCK_DUMP_AFTER_SETTING_TIME;INFO;No description;fsfw/src/fsfw/pus/Service9TimeManagement.h
 9100;0x238c;TC_DELETION_FAILED;MEDIUM;Deletion of a TC from the map failed. P1: First 32 bit of request ID, P2. Last 32 bit of Request ID;fsfw/src/fsfw/pus/Service11TelecommandScheduling.h
 9700;0x25e4;TEST;INFO;No description;fsfw/src/fsfw/pus/Service17Test.h
 10600;0x2968;CHANGE_OF_SETUP_PARAMETER;LOW;No description;fsfw/src/fsfw_hal/devicehandlers/MgmLIS3MDLHandler.h
@@ -88,14 +91,17 @@ Event ID (dec); Event ID (hex); Name; Severity; Description; File Path
 10804;0x2a34;FILENAME_TOO_LARGE_ERROR;LOW;P1: Transaction step ID, P2: 0 for source file name, 1 for dest file name;fsfw/src/fsfw/cfdp/handler/defs.h
 10805;0x2a35;HANDLING_CFDP_REQUEST_FAILED;LOW;CFDP request handling failed. P2: Returncode.;fsfw/src/fsfw/cfdp/handler/defs.h
 11200;0x2bc0;SAFE_RATE_VIOLATION;MEDIUM;The limits for the rotation in safe mode were violated.;mission/acs/defs.h
-11201;0x2bc1;SAFE_RATE_RECOVERY;MEDIUM;The system has recovered from a safe rate rotation violation.;mission/acs/defs.h
+11201;0x2bc1;RATE_RECOVERY;MEDIUM;The system has recovered from a rate rotation violation.;mission/acs/defs.h
 11202;0x2bc2;MULTIPLE_RW_INVALID;HIGH;Multiple RWs are invalid, uncommandable and therefore higher ACS modes cannot be maintained.;mission/acs/defs.h
 11203;0x2bc3;MEKF_INVALID_INFO;INFO;MEKF was not able to compute a solution. P1: MEKF state on exit;mission/acs/defs.h
 11204;0x2bc4;MEKF_RECOVERY;INFO;MEKF is able to compute a solution again.;mission/acs/defs.h
 11205;0x2bc5;MEKF_AUTOMATIC_RESET;INFO;MEKF performed an automatic reset after detection of nonfinite values.;mission/acs/defs.h
-11206;0x2bc6;MEKF_INVALID_MODE_VIOLATION;HIGH;MEKF was not able to compute a solution during any pointing ACS mode for a prolonged time.;mission/acs/defs.h
+11206;0x2bc6;PTG_CTRL_NO_ATTITUDE_INFORMATION;HIGH;For a prolonged time, no attitude information was available for the Pointing Controller. Falling back to Safe Mode.;mission/acs/defs.h
 11207;0x2bc7;SAFE_MODE_CONTROLLER_FAILURE;HIGH;The ACS safe mode controller was not able to compute a solution and has failed. P1: Missing information about magnetic field, P2: Missing information about rotational rate;mission/acs/defs.h
 11208;0x2bc8;TLE_TOO_OLD;INFO;The TLE for the SGP4 Propagator has become too old.;mission/acs/defs.h
+11209;0x2bc9;TLE_FILE_READ_FAILED;LOW;The TLE could not be read from the filesystem.;mission/acs/defs.h
+11210;0x2bca;PTG_RATE_VIOLATION;MEDIUM;The limits for the rotation in pointing mode were violated.;mission/acs/defs.h
+11211;0x2bcb;DETUMBLE_TRANSITION_FAILED;HIGH;The detumble transition has failed. //! P1: Last detumble state before failure.;mission/acs/defs.h
 11300;0x2c24;SWITCH_CMD_SENT;INFO;Indicates that a FSFW object requested setting a switch P1: 1 if on was requested, 0 for off | P2: Switch Index;mission/power/defs.h
 11301;0x2c25;SWITCH_HAS_CHANGED;INFO;Indicated that a switch state has changed P1: New switch state, 1 for on, 0 for off | P2: Switch Index;mission/power/defs.h
 11302;0x2c26;SWITCHING_Q7S_DENIED;MEDIUM;No description;mission/power/defs.h
@@ -122,14 +128,15 @@ Event ID (dec); Event ID (hex); Name; Severity; Description; File Path
 11506;0x2cf2;DEPL_SA1_GPIO_SWTICH_OFF_FAILED;HIGH;No description;mission/SolarArrayDeploymentHandler.h
 11507;0x2cf3;DEPL_SA2_GPIO_SWTICH_OFF_FAILED;HIGH;No description;mission/SolarArrayDeploymentHandler.h
 11508;0x2cf4;AUTONOMOUS_DEPLOYMENT_COMPLETED;INFO;No description;mission/SolarArrayDeploymentHandler.h
-11601;0x2d51;MEMORY_READ_RPT_CRC_FAILURE;LOW;PLOC crc failure in telemetry packet;linux/payload/PlocMpsocHandler.h
-11602;0x2d52;ACK_FAILURE;LOW;PLOC receive acknowledgment failure report P1: Command Id which leads the acknowledgment failure report P2: The status field inserted by the MPSoC into the data field;linux/payload/PlocMpsocHandler.h
-11603;0x2d53;EXE_FAILURE;LOW;PLOC receive execution failure report P1: Command Id which leads the execution failure report P2: The status field inserted by the MPSoC into the data field;linux/payload/PlocMpsocHandler.h
-11604;0x2d54;MPSOC_HANDLER_CRC_FAILURE;LOW;PLOC reply has invalid crc;linux/payload/PlocMpsocHandler.h
-11605;0x2d55;MPSOC_HANDLER_SEQUENCE_COUNT_MISMATCH;LOW;Packet sequence count in received space packet does not match expected count P1: Expected sequence count P2: Received sequence count;linux/payload/PlocMpsocHandler.h
-11606;0x2d56;MPSOC_SHUTDOWN_FAILED;HIGH;Supervisor fails to shutdown MPSoC. Requires to power off the PLOC and thus also to shutdown the supervisor.;linux/payload/PlocMpsocHandler.h
-11607;0x2d57;SUPV_NOT_ON;LOW;SUPV not on for boot or shutdown process. P1: 0 for OFF transition, 1 for ON transition.;linux/payload/PlocMpsocHandler.h
-11608;0x2d58;SUPV_REPLY_TIMEOUT;LOW;No description;linux/payload/PlocMpsocHandler.h
+11601;0x2d51;MEMORY_READ_RPT_CRC_FAILURE;LOW;PLOC crc failure in telemetry packet;linux/payload/plocMpsocHelpers.h
+11602;0x2d52;ACK_FAILURE;LOW;PLOC receive acknowledgment failure report P1: Command Id which leads the acknowledgment failure report P2: The status field inserted by the MPSoC into the data field;linux/payload/plocMpsocHelpers.h
+11603;0x2d53;EXE_FAILURE;LOW;PLOC receive execution failure report P1: Command Id which leads the execution failure report P2: The status field inserted by the MPSoC into the data field;linux/payload/plocMpsocHelpers.h
+11604;0x2d54;MPSOC_HANDLER_CRC_FAILURE;LOW;PLOC reply has invalid crc;linux/payload/plocMpsocHelpers.h
+11605;0x2d55;MPSOC_HANDLER_SEQUENCE_COUNT_MISMATCH;LOW;Packet sequence count in received space packet does not match expected count P1: Expected sequence count P2: Received sequence count;linux/payload/plocMpsocHelpers.h
+11606;0x2d56;MPSOC_SHUTDOWN_FAILED;HIGH;Supervisor fails to shutdown MPSoC. Requires to power off the PLOC and thus also to shutdown the supervisor.;linux/payload/plocMpsocHelpers.h
+11607;0x2d57;SUPV_NOT_ON;LOW;SUPV not on for boot or shutdown process. P1: 0 for OFF transition, 1 for ON transition.;linux/payload/plocMpsocHelpers.h
+11608;0x2d58;SUPV_REPLY_TIMEOUT;LOW;SUPV reply timeout.;linux/payload/plocMpsocHelpers.h
+11609;0x2d59;CAM_MUST_BE_ON_FOR_SNAPSHOT_MODE;LOW;Camera must be commanded on first.;linux/payload/plocMpsocHelpers.h
 11701;0x2db5;SELF_TEST_I2C_FAILURE;LOW;Get self test result returns I2C failure P1: Indicates on which axis the failure occurred. 0 -> INIT, 1 -> +X, 2 -> -X, 3 -> +Y, 4 -> -Y, 5 -> +Z, 6 -> -Z, 7 -> FINA;mission/acs/ImtqHandler.h
 11702;0x2db6;SELF_TEST_SPI_FAILURE;LOW;Get self test result returns SPI failure. This concerns the MTM connectivity. P1: Indicates on which axis the failure occurred. 0 -> INIT, 1 -> +X, 2 -> -X, 3 -> +Y, 4 -> -Y, 5 -> +Z, 6 -> -Z, 7 -> FINA;mission/acs/ImtqHandler.h
 11703;0x2db7;SELF_TEST_ADC_FAILURE;LOW;Get self test result returns failure in measurement of current and temperature. P1: Indicates on which axis the failure occurred. 0 -> INIT, 1 -> +X, 2 -> -X, 3 -> +Y, 4 -> -Y, 5 -> +Z, 6 -> -Z, 7 -> FINA;mission/acs/ImtqHandler.h
@@ -143,14 +150,16 @@ Event ID (dec); Event ID (hex); Name; Severity; Description; File Path
 11901;0x2e7d;BOOTING_FIRMWARE_FAILED_EVENT;LOW;Failed to boot firmware;mission/acs/str/StarTrackerHandler.h
 11902;0x2e7e;BOOTING_BOOTLOADER_FAILED_EVENT;LOW;Failed to boot star tracker into bootloader mode;mission/acs/str/StarTrackerHandler.h
 11903;0x2e7f;COM_ERROR_REPLY_RECEIVED;LOW;Received COM error. P1:  Communication Error ID (datasheet p32);mission/acs/str/StarTrackerHandler.h
-12001;0x2ee1;SUPV_MEMORY_READ_RPT_CRC_FAILURE;LOW;PLOC supervisor crc failure in telemetry packet;linux/payload/PlocSupervisorHandler.h
-12002;0x2ee2;SUPV_UNKNOWN_TM;LOW;Unhandled event. P1: APID, P2: Service ID;linux/payload/PlocSupervisorHandler.h
-12003;0x2ee3;SUPV_UNINIMPLEMENTED_TM;LOW;No description;linux/payload/PlocSupervisorHandler.h
-12004;0x2ee4;SUPV_ACK_FAILURE;LOW;PLOC supervisor received acknowledgment failure report;linux/payload/PlocSupervisorHandler.h
-12005;0x2ee5;SUPV_EXE_FAILURE;LOW;PLOC received execution failure report P1: ID of command for which the execution failed P2: Status code sent by the supervisor handler;linux/payload/PlocSupervisorHandler.h
-12006;0x2ee6;SUPV_CRC_FAILURE_EVENT;LOW;PLOC supervisor reply has invalid crc;linux/payload/PlocSupervisorHandler.h
-12007;0x2ee7;SUPV_HELPER_EXECUTING;LOW;Supervisor helper currently executing a command;linux/payload/PlocSupervisorHandler.h
-12008;0x2ee8;SUPV_MPSOC_SHUTDOWN_BUILD_FAILED;LOW;Failed to build the command to shutdown the MPSoC;linux/payload/PlocSupervisorHandler.h
+12001;0x2ee1;SUPV_MEMORY_READ_RPT_CRC_FAILURE;LOW;PLOC supervisor crc failure in telemetry packet;linux/payload/plocSupvDefs.h
+12002;0x2ee2;SUPV_UNKNOWN_TM;LOW;Unhandled event. P1: APID, P2: Service ID;linux/payload/plocSupvDefs.h
+12003;0x2ee3;SUPV_UNINIMPLEMENTED_TM;LOW;No description;linux/payload/plocSupvDefs.h
+12004;0x2ee4;SUPV_ACK_FAILURE;LOW;PLOC supervisor received acknowledgment failure report;linux/payload/plocSupvDefs.h
+12005;0x2ee5;SUPV_EXE_FAILURE;LOW;PLOC received execution failure report P1: ID of command for which the execution failed P2: Status code sent by the supervisor handler;linux/payload/plocSupvDefs.h
+12006;0x2ee6;SUPV_CRC_FAILURE_EVENT;LOW;PLOC supervisor reply has invalid crc;linux/payload/plocSupvDefs.h
+12007;0x2ee7;SUPV_HELPER_EXECUTING;LOW;Supervisor helper currently executing a command;linux/payload/plocSupvDefs.h
+12008;0x2ee8;SUPV_MPSOC_SHUTDOWN_BUILD_FAILED;LOW;Failed to build the command to shutdown the MPSoC;linux/payload/plocSupvDefs.h
+12009;0x2ee9;SUPV_ACK_UNKNOWN_COMMAND;LOW;Received ACK, but no related command is unknown or has not been sent  by this software instance. P1: Module APID. P2: Service ID.;linux/payload/plocSupvDefs.h
+12010;0x2eea;SUPV_EXE_ACK_UNKNOWN_COMMAND;LOW;Received ACK EXE, but no related command is unknown or has not been sent  by this software instance. P1: Module APID. P2: Service ID.;linux/payload/plocSupvDefs.h
 12100;0x2f44;SANITIZATION_FAILED;LOW;No description;bsp_q7s/fs/SdCardManager.h
 12101;0x2f45;MOUNTED_SD_CARD;INFO;No description;bsp_q7s/fs/SdCardManager.h
 12300;0x300c;SEND_MRAM_DUMP_FAILED;LOW;Failed to send mram dump command to supervisor handler P1: Return value of commandAction function P2: Start address of MRAM to dump with this command;linux/payload/PlocMemoryDumper.h
@@ -228,8 +237,9 @@ Event ID (dec); Event ID (hex); Name; Severity; Description; File Path
 12902;0x3266;POWER_STATE_MACHINE_TIMEOUT;MEDIUM;No description;mission/system/acs/SusAssembly.h
 12903;0x3267;SIDE_SWITCH_TRANSITION_NOT_ALLOWED;LOW;Not implemented, would increase already high complexity. Operator should instead command the assembly off first and then command the assembly on into the desired mode/submode combination;mission/system/acs/SusAssembly.h
 13000;0x32c8;CHILDREN_LOST_MODE;MEDIUM;No description;mission/system/tcs/TcsBoardAssembly.h
-13100;0x332c;GPS_FIX_CHANGE;INFO;Fix has changed. P1: Old fix. P2: New fix 0: Not seen, 1: No Fix, 2: 2D-Fix, 3: 3D-Fix;mission/acs/archive/GPSDefinitions.h
-13101;0x332d;CANT_GET_FIX;LOW;Could not get fix in maximum allowed time. P1: Maximum allowed time to get a fix after the GPS was switched on.;mission/acs/archive/GPSDefinitions.h
+13100;0x332c;GPS_FIX_CHANGE;INFO;Fix has changed. P1: New fix. P2: Missed fix changes 0: Not seen, 1: No Fix, 2: 2D-Fix, 3: 3D-Fix;linux/acs/GPSDefinitions.h
+13101;0x332d;CANT_GET_FIX;MEDIUM;Could not get fix in maximum allowed time. Trying to reset both GNSS devices. P1: Maximum allowed time to get a fix after the GPS was switched on.;linux/acs/GPSDefinitions.h
+13102;0x332e;RESET_FAIL;HIGH;Failed to reset an GNNS Device. P1: Board-Side.;linux/acs/GPSDefinitions.h
 13200;0x3390;P60_BOOT_COUNT;INFO;P60 boot count is broadcasted once at SW startup. P1: Boot count;mission/power/P60DockHandler.h
 13201;0x3391;BATT_MODE;INFO;Battery mode is broadcasted at startup. P1: Mode;mission/power/P60DockHandler.h
 13202;0x3392;BATT_MODE_CHANGED;MEDIUM;Battery mode has changed. P1: Old mode. P2: New mode;mission/power/P60DockHandler.h

eive_tmtc/config/hook.py

@@ -1,33 +1,147 @@
 from typing import Optional
 
-from eive_tmtc.config.definitions import SPACE_PACKET_IDS
-from tmtccmd import HookBase, CcsdsTmtcBackend
+from prompt_toolkit.history import FileHistory
+from tmtccmd import CcsdsTmtcBackend, HookBase
 from tmtccmd.com import ComInterface
-from tmtccmd.config import TmtcDefinitionWrapper
-
-from eive_tmtc.config.retvals import get_retval_dict
-from eive_tmtc.pus_tc.cmd_definitions import get_eive_service_op_code_dict
+from tmtccmd.config import CmdTreeNode
+from tmtccmd.config.hook import History
 from tmtccmd.util import ObjectIdDictT, RetvalDictT
 
+from eive_tmtc.config.definitions import SPACE_PACKET_IDS
+from eive_tmtc.config.retvals import get_retval_dict
+from eive_tmtc.tmtc.acs.acs_board import create_acs_board_node
+from eive_tmtc.tmtc.acs.acs_ctrl import create_acs_ctrl_node
+from eive_tmtc.tmtc.acs.gps import create_gnss_node
+from eive_tmtc.tmtc.acs.gyros import create_gyros_node
+from eive_tmtc.tmtc.acs.imtq import create_mgt_node
+from eive_tmtc.tmtc.acs.mgms import create_mgms_node
+from eive_tmtc.tmtc.acs.reaction_wheels import (
+    create_reaction_wheel_assembly_node,
+    create_reaction_wheels_nodes,
+)
+from eive_tmtc.tmtc.acs.star_tracker import create_str_node
+from eive_tmtc.tmtc.acs.subsystem import create_acs_subsystem_node
+from eive_tmtc.tmtc.com.ccsds_handler import create_ccsds_node
+from eive_tmtc.tmtc.com.subsystem import create_com_subsystem_node
+from eive_tmtc.tmtc.com.syrlinks_handler import create_syrlinks_node
+from eive_tmtc.tmtc.core import create_core_node
+from eive_tmtc.tmtc.health import create_global_health_node
+from eive_tmtc.tmtc.payload.ploc_mpsoc import create_ploc_mpsoc_node
+from eive_tmtc.tmtc.payload.ploc_supervisor import create_ploc_supv_node
+from eive_tmtc.tmtc.payload.plpcdu import create_pl_pcdu_node
+from eive_tmtc.tmtc.payload.scex import create_scex_node
+from eive_tmtc.tmtc.payload.subsystem import create_payload_subsystem_node
+from eive_tmtc.tmtc.power.acu import create_acu_node
+from eive_tmtc.tmtc.power.bpx_batt import create_bpx_batt_node
+from eive_tmtc.tmtc.power.p60dock import create_p60_dock_node
+from eive_tmtc.tmtc.power.pdu1 import create_pdu1_node
+from eive_tmtc.tmtc.power.pdu2 import create_pdu2_node
+from eive_tmtc.tmtc.power.power import create_power_node
+from eive_tmtc.tmtc.power.pwr_ctrl import create_pwr_ctrl_node
+from eive_tmtc.tmtc.power.subsystem import create_eps_subsystem_node
+from eive_tmtc.tmtc.system import create_system_node
+from eive_tmtc.tmtc.tcs.ctrl import create_tcs_ctrl_node
+from eive_tmtc.tmtc.tcs.heater import create_heater_node
+from eive_tmtc.tmtc.tcs.rtd import create_rtd_node
+from eive_tmtc.tmtc.tcs.tmp1075 import create_tmp_sens_node
+from eive_tmtc.tmtc.test import create_test_node
+from eive_tmtc.tmtc.time import create_time_node
+from eive_tmtc.tmtc.tm_store import create_persistent_tm_store_node
+from eive_tmtc.tmtc.wdt import create_wdt_node
+
 
 class EiveHookObject(HookBase):
     def __init__(self, json_cfg_path: str):
-        super().__init__(json_cfg_path=json_cfg_path)
+        super().__init__(json_cfg_path)
 
-    def get_tmtc_definitions(self) -> TmtcDefinitionWrapper:
-        return get_eive_service_op_code_dict()
-
-    def assign_communication_interface(self, com_if_key: str) -> Optional[ComInterface]:
-        from tmtccmd.config.com import (
-            create_com_interface_default,
-            create_com_interface_cfg_default,
+    def get_command_definitions(self) -> CmdTreeNode:
+        root_node = CmdTreeNode.root_node()
+        acs_node = create_acs_subsystem_node()
+        acs_brd_assy_node = create_acs_board_node()
+        acs_brd_assy_node.add_child(create_mgms_node())
+        acs_brd_assy_node.add_child(create_gyros_node())
+        acs_ctrl = create_acs_ctrl_node()
+        rw_list = create_reaction_wheels_nodes()
+        rws = CmdTreeNode("rws", "Reaction Wheel Devices")
+        for rw in rw_list:
+            rws.add_child(rw)
+        rws.add_child(create_reaction_wheel_assembly_node())
+        star_tracker = create_str_node()
+        star_tracker_img_helper = CmdTreeNode(
+            "str_img_helper", "Star Tracker Image Helper"
         )
+        star_tracker.add_child(star_tracker_img_helper)
+        gnss_devs = create_gnss_node()
+
+        acs_node.add_child(acs_brd_assy_node)
+        acs_node.add_child(acs_ctrl)
+        acs_node.add_child(rws)
+        acs_node.add_child(create_mgt_node())
+        acs_node.add_child(star_tracker)
+        acs_node.add_child(gnss_devs)
+
+        tcs_node = CmdTreeNode("tcs", "TCS Subsystem")
+        tmp_1075_node = create_tmp_sens_node()
+        rtds_node = create_rtd_node()
+        heaters_node = create_heater_node()
+        tcs_ctrl = create_tcs_ctrl_node()
+        tcs_node.add_child(rtds_node)
+        tcs_node.add_child(tmp_1075_node)
+        tcs_node.add_child(tcs_ctrl)
+        tcs_node.add_child(heaters_node)
+        tcs_brd_assy = CmdTreeNode("tcs_brd_assy", "TCS Board Assembly")
+        tcs_node.add_child(tcs_brd_assy)
+
+        com_node = create_com_subsystem_node()
+        com_node.add_child(create_syrlinks_node())
+        com_node.add_child(create_ccsds_node())
+
+        eps_node = create_eps_subsystem_node()
+        eps_node.add_child(create_pwr_ctrl_node())
+        eps_node.add_child(create_power_node())
+        eps_node.add_child(create_acu_node())
+        eps_node.add_child(create_pdu1_node())
+        eps_node.add_child(create_pdu2_node())
+        eps_node.add_child(create_p60_dock_node())
+        eps_node.add_child(create_bpx_batt_node())
+
+        payload_node = create_payload_subsystem_node()
+        payload_node.add_child(create_pl_pcdu_node())
+        payload_node.add_child(create_scex_node())
+        payload_node.add_child(create_ploc_mpsoc_node())
+        payload_node.add_child(create_ploc_supv_node())
+
+        obdh_node = CmdTreeNode("obdh", "OBDH Subsystem")
+        obdh_node.add_child(create_wdt_node())
+        obdh_node.add_child(create_core_node())
+        obdh_node.add_child(create_time_node())
+        obdh_node.add_child(create_persistent_tm_store_node())
+
+        root_node.add_child(create_test_node())
+        root_node.add_child(create_system_node())
+        root_node.add_child(create_global_health_node())
+        root_node.add_child(acs_node)
+        root_node.add_child(tcs_node)
+        root_node.add_child(com_node)
+        root_node.add_child(eps_node)
+        root_node.add_child(payload_node)
+        root_node.add_child(obdh_node)
+        return root_node
+
+    def get_communication_interface(self, com_if_key: str) -> Optional[ComInterface]:
+        from tmtccmd.config.com import (
+            create_com_interface_cfg_default,
+            create_com_interface_default,
+        )
+
+        assert self.cfg_path is not None
 
         cfg = create_com_interface_cfg_default(
             com_if_key=com_if_key,
             json_cfg_path=self.cfg_path,
             space_packet_ids=SPACE_PACKET_IDS,
         )
+        assert cfg is not None
         return create_com_interface_default(cfg)
 
     def perform_mode_operation(self, tmtc_backend: CcsdsTmtcBackend, mode: int):
@@ -42,3 +156,6 @@ class EiveHookObject(HookBase):
 
     def get_retval_dict(self) -> RetvalDictT:
         return get_retval_dict()
+
+    def get_cmd_history(self) -> Optional[History]:
+        return FileHistory(".tmtc-history.txt")

eive_tmtc/config/object_ids.py

@@ -3,6 +3,7 @@
 @details    Template configuration file. Copy this folder to the TMTC commander root and adapt
             it to your needs.
 """
+
 import logging
 import os.path
 from typing import Dict
@@ -167,6 +168,9 @@ NOT_OK_TM_STORE = bytes([0x73, 0x02, 0x00, 0x03])
 HK_TM_STORE = bytes([0x73, 0x02, 0x00, 0x04])
 CFDP_TM_STORE = bytes([0x73, 0x03, 0x00, 0x00])
 
+
+SUPV_FILTER_SET = [PLOC_SUPV_ID, PDU_2_HANDLER_ID, PDU_1_HANDLER_ID]
+
 ObjectIdDict = Dict[bytes, ObjectIdU32]
 
 

eive_tmtc/config/objects.csv

@@ -56,6 +56,7 @@
 0x44330015;PLOC_MPSOC_HANDLER
 0x44330016;PLOC_SUPERVISOR_HANDLER
 0x44330017;PLOC_SUPERVISOR_HELPER
+0x44330018;PLOC_MPSOC_COMMUNICATION
 0x44330032;SCEX
 0x444100A2;SOLAR_ARRAY_DEPL_HANDLER
 0x444100A4;HEATER_HANDLER

eive_tmtc/config/returnvalues.csv

@@ -387,6 +387,7 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x4304;PUS11_InvalidRelativeTime;No description;4;PUS_SERVICE_11;fsfw/src/fsfw/pus/Service11TelecommandScheduling.h
 0x4305;PUS11_ContainedTcTooSmall;No description;5;PUS_SERVICE_11;fsfw/src/fsfw/pus/Service11TelecommandScheduling.h
 0x4306;PUS11_ContainedTcCrcMissmatch;No description;6;PUS_SERVICE_11;fsfw/src/fsfw/pus/Service11TelecommandScheduling.h
+0x4307;PUS11_MapIsFull;No description;7;PUS_SERVICE_11;fsfw/src/fsfw/pus/Service11TelecommandScheduling.h
 0x4400;FILS_GenericFileError;No description;0;FILE_SYSTEM;fsfw/src/fsfw/filesystem/HasFileSystemIF.h
 0x4401;FILS_GenericDirError;No description;1;FILE_SYSTEM;fsfw/src/fsfw/filesystem/HasFileSystemIF.h
 0x4402;FILS_FilesystemInactive;No description;2;FILE_SYSTEM;fsfw/src/fsfw/filesystem/HasFileSystemIF.h
@@ -453,6 +454,12 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x5208;IMTQ_CmdErrUnknown;No description;8;IMTQ_HANDLER;mission/acs/imtqHelpers.h
 0x5209;IMTQ_StartupCfgError;No description;9;IMTQ_HANDLER;mission/acs/imtqHelpers.h
 0x520a;IMTQ_UnexpectedSelfTestReply;The status reply to a self test command was received but no self test command has been sent. This should normally never happen.;10;IMTQ_HANDLER;mission/acs/imtqHelpers.h
+0x53a0;RWHA_InvalidSpeed;Action Message with invalid speed was received. Valid speeds must be in the range of [-65000, 1000] or [1000, 65000];160;RW_HANDLER;mission/acs/RwHandler.h
+0x53a1;RWHA_InvalidRampTime;Action Message with invalid ramp time was received.;161;RW_HANDLER;mission/acs/RwHandler.h
+0x53a2;RWHA_SetSpeedCommandInvalidLength;Received set speed command has invalid length. Should be 6.;162;RW_HANDLER;mission/acs/RwHandler.h
+0x53a3;RWHA_ExecutionFailed;Command execution failed;163;RW_HANDLER;mission/acs/RwHandler.h
+0x53a4;RWHA_CrcError;Reaction wheel reply has invalid crc;164;RW_HANDLER;mission/acs/RwHandler.h
+0x53a5;RWHA_ValueNotRead;No description;165;RW_HANDLER;mission/acs/RwHandler.h
 0x53b0;RWHA_SpiWriteFailure;No description;176;RW_HANDLER;mission/acs/rwHelpers.h
 0x53b1;RWHA_SpiReadFailure;Used by the spi send function to tell a failing read call;177;RW_HANDLER;mission/acs/rwHelpers.h
 0x53b2;RWHA_MissingStartSign;Can be used by the HDLC decoding mechanism to inform about a missing start sign 0x7E;178;RW_HANDLER;mission/acs/rwHelpers.h
@@ -498,12 +505,8 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x58a1;PLSPVhLP_ProcessTerminated;Process has been terminated by command;161;PLOC_SUPV_HELPER;linux/payload/PlocSupvUartMan.h
 0x58a2;PLSPVhLP_PathNotExists;Received command with invalid pathname;162;PLOC_SUPV_HELPER;linux/payload/PlocSupvUartMan.h
 0x58a3;PLSPVhLP_EventBufferReplyInvalidApid;Expected event buffer TM but received space packet with other APID;163;PLOC_SUPV_HELPER;linux/payload/PlocSupvUartMan.h
-0x59a0;SUSS_InvalidSpeed;Action Message with invalid speed was received. Valid speeds must be in the range of [-65000, 1000] or [1000, 65000];160;SUS_HANDLER;mission/acs/RwHandler.h
-0x59a1;SUSS_InvalidRampTime;Action Message with invalid ramp time was received.;161;SUS_HANDLER;mission/acs/RwHandler.h
-0x59a2;SUSS_SetSpeedCommandInvalidLength;Received set speed command has invalid length. Should be 6.;162;SUS_HANDLER;mission/acs/RwHandler.h
-0x59a3;SUSS_ExecutionFailed;Command execution failed;163;SUS_HANDLER;mission/acs/RwHandler.h
-0x59a4;SUSS_CrcError;Reaction wheel reply has invalid crc;164;SUS_HANDLER;mission/acs/RwHandler.h
-0x59a5;SUSS_ValueNotRead;No description;165;SUS_HANDLER;mission/acs/RwHandler.h
+0x59a0;SUSS_ErrorUnlockMutex;No description;160;SUS_HANDLER;mission/acs/archive/LegacySusHandler.h
+0x59a1;SUSS_ErrorLockMutex;No description;161;SUS_HANDLER;mission/acs/archive/LegacySusHandler.h
 0x5aa0;IPCI_PapbBusy;No description;160;CCSDS_IP_CORE_BRIDGE;linux/ipcore/PapbVcInterface.h
 0x5ba0;PTME_UnknownVcId;No description;160;PTME;linux/ipcore/Ptme.h
 0x5d01;STRHLP_SdNotMounted;SD card specified in path string not mounted;1;STR_HELPER;linux/acs/StrComHandler.h
@@ -558,16 +561,17 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x67a2;SADPL_MainSwitchTimeoutFailure;No description;162;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
 0x67a3;SADPL_SwitchingDeplSa1Failed;No description;163;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
 0x67a4;SADPL_SwitchingDeplSa2Failed;No description;164;SA_DEPL_HANDLER;mission/SolarArrayDeploymentHandler.h
-0x68a0;MPSOCRTVIF_CrcFailure;Space Packet received from PLOC has invalid CRC;160;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
-0x68a1;MPSOCRTVIF_ReceivedAckFailure;Received ACK failure reply from PLOC;161;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
-0x68a2;MPSOCRTVIF_ReceivedExeFailure;Received execution failure reply from PLOC;162;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
-0x68a3;MPSOCRTVIF_InvalidApid;Received space packet with invalid APID from PLOC;163;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
-0x68a4;MPSOCRTVIF_InvalidLength;Received command with invalid length;164;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
-0x68a5;MPSOCRTVIF_FilenameTooLong;Filename of file in OBC filesystem is too long;165;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
-0x68a6;MPSOCRTVIF_MpsocHelperExecuting;MPSoC helper is currently executing a command;166;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
-0x68a7;MPSOCRTVIF_MpsocFilenameTooLong;Filename of MPSoC file is to long (max. 256 bytes);167;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
-0x68a8;MPSOCRTVIF_InvalidParameter;Command has invalid parameter;168;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
-0x68a9;MPSOCRTVIF_NameTooLong;Received command has file string with invalid length;169;MPSOC_RETURN_VALUES_IF;linux/payload/mpsocRetvals.h
+0x6810;MPSOCRTVIF_CommandTimeout;Command has timed out.;16;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a0;MPSOCRTVIF_CrcFailure;Space Packet received from PLOC has invalid CRC;160;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a1;MPSOCRTVIF_ReceivedAckFailure;Received ACK failure reply from PLOC;161;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a2;MPSOCRTVIF_ReceivedExeFailure;Received execution failure reply from PLOC;162;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a3;MPSOCRTVIF_InvalidApid;Received space packet with invalid APID from PLOC;163;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a4;MPSOCRTVIF_InvalidLength;Received command with invalid length;164;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a5;MPSOCRTVIF_FilenameTooLong;Filename of file in OBC filesystem is too long;165;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a6;MPSOCRTVIF_MpsocHelperExecuting;MPSoC helper is currently executing a command;166;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a7;MPSOCRTVIF_MpsocFilenameTooLong;Filename of MPSoC file is to long (max. 256 bytes);167;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a8;MPSOCRTVIF_InvalidParameter;Command has invalid parameter;168;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
+0x68a9;MPSOCRTVIF_NameTooLong;Received command has file string with invalid length;169;MPSOC_RETURN_VALUES_IF;linux/payload/plocMpsocHelpers.h
 0x69a0;SPVRTVIF_CrcFailure;Space Packet received from PLOC supervisor has invalid CRC;160;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
 0x69a1;SPVRTVIF_InvalidServiceId;No description;161;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
 0x69a2;SPVRTVIF_ReceivedAckFailure;Received ACK failure reply from PLOC supervisor;162;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
@@ -592,7 +596,11 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x69b5;SPVRTVIF_SupvHelperExecuting;Supervisor helper task ist currently executing a command (wait until helper tas has finished or interrupt by sending the terminate command);181;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
 0x69c0;SPVRTVIF_BufTooSmall;No description;192;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
 0x69c1;SPVRTVIF_NoReplyTimeout;No description;193;SUPV_RETURN_VALUES_IF;linux/payload/plocSupvDefs.h
-0x6a00;ACSCTRL_FileDeletionFailed;File deletion failed and at least one file is still existent.;0;ACS_CTRL;mission/controller/AcsController.h
+0x6aa0;ACSCTRL_FileDeletionFailed;File deletion failed and at least one file is still existent.;160;ACS_CTRL;mission/controller/controllerdefinitions/AcsCtrlDefinitions.h
+0x6aa1;ACSCTRL_WriteFileFailed;Writing the TLE to the file has failed.;161;ACS_CTRL;mission/controller/controllerdefinitions/AcsCtrlDefinitions.h
+0x6aa2;ACSCTRL_ReadFileFailed;Reading the TLE to the file has failed.;162;ACS_CTRL;mission/controller/controllerdefinitions/AcsCtrlDefinitions.h
+0x6aa3;ACSCTRL_SingleRwUnavailable;A single RW has failed.;163;ACS_CTRL;mission/controller/controllerdefinitions/AcsCtrlDefinitions.h
+0x6aa4;ACSCTRL_MultipleRwUnavailable;Multiple RWs have failed.;164;ACS_CTRL;mission/controller/controllerdefinitions/AcsCtrlDefinitions.h
 0x6b02;ACSMEKF_MekfUninitialized;No description;2;ACS_MEKF;mission/controller/acs/MultiplicativeKalmanFilter.h
 0x6b03;ACSMEKF_MekfNoGyrData;No description;3;ACS_MEKF;mission/controller/acs/MultiplicativeKalmanFilter.h
 0x6b04;ACSMEKF_MekfNoModelVectors;No description;4;ACS_MEKF;mission/controller/acs/MultiplicativeKalmanFilter.h
@@ -617,5 +625,9 @@ Full ID (hex); Name; Description; Unique ID; Subsytem Name; File Path
 0x6f00;TMS_IsBusy;No description;0;TM_SINK;mission/tmtc/DirectTmSinkIF.h
 0x6f01;TMS_PartiallyWritten;No description;1;TM_SINK;mission/tmtc/DirectTmSinkIF.h
 0x6f02;TMS_NoWriteActive;No description;2;TM_SINK;mission/tmtc/DirectTmSinkIF.h
+0x6f03;TMS_Timeout;No description;3;TM_SINK;mission/tmtc/DirectTmSinkIF.h
 0x7000;VCS_ChannelDoesNotExist;No description;0;VIRTUAL_CHANNEL;mission/com/VirtualChannel.h
-0x7200;SCBU_KeyNotFound;No description;0;SCRATCH_BUFFER;bsp_q7s/memory/scratchApi.h
+0x7100;PLMPCOM_PacketReceived;No description;0;PLOC_MPSOC_COM;linux/payload/MpsocCommunication.h
+0x7101;PLMPCOM_FaultyPacketSize;No description;1;PLOC_MPSOC_COM;linux/payload/MpsocCommunication.h
+0x7102;PLMPCOM_CrcCheckFailed;No description;2;PLOC_MPSOC_COM;linux/payload/MpsocCommunication.h
+0x7300;SCBU_KeyNotFound;No description;0;SCRATCH_BUFFER;bsp_q7s/memory/scratchApi.h

eive_tmtc/gomspace/gomspace_common.py

@@ -11,8 +11,8 @@ import struct
 from typing import Union
 
 from spacepackets.ecss import PusTelecommand
-from tmtccmd.tc import DefaultPusQueueHelper
-from tmtccmd.pus.s8_fsfw_funccmd import create_action_cmd
+from tmtccmd.tmtc import DefaultPusQueueHelper
+from tmtccmd.pus.s8_fsfw_action import create_action_cmd
 from tmtccmd.util import ObjectIdU32, ObjectIdBase
 
 

eive_tmtc/pus_tc/cmd_definitions.py

@@ -1,21 +0,0 @@
-from tmtccmd.config import TmtcDefinitionWrapper, OpCodeEntry, CoreServiceList
-from tmtccmd.config.tmtc import (
-    call_all_definitions_providers,
-)
-from tmtccmd.config.globals import get_default_tmtc_defs
-
-
-def get_eive_service_op_code_dict() -> TmtcDefinitionWrapper:
-    """Call all registered TMTC definition providers. They were registered using
-    the :py:func:`tmtc_definitions_provider` decorator.
-    """
-    def_wrapper = get_default_tmtc_defs()
-    srv_5 = OpCodeEntry()
-    srv_5.add("0", "Event Test")
-    def_wrapper.add_service(
-        name=CoreServiceList.SERVICE_5.value,
-        info="PUS Service 5 Event",
-        op_code_entry=srv_5,
-    )
-    call_all_definitions_providers(def_wrapper)
-    return def_wrapper

eive_tmtc/pus_tc/cmd_demux.py

@@ -0,0 +1,309 @@
+"""Hook function which packs telecommands based on service and operation code string
+"""
+
+import logging
+from typing import List, cast
+
+from tmtccmd import TreeCommandingProcedure
+from tmtccmd.tmtc import DefaultPusQueueHelper
+from tmtccmd.util import ObjectIdU32
+
+import eive_tmtc.config.object_ids as oids
+from eive_tmtc.config.object_ids import (
+    ACU_HANDLER_ID,
+    CCSDS_HANDLER_ID,
+    HEATER_CONTROLLER_ID,
+    IMTQ_HANDLER_ID,
+    P60_DOCK_HANDLER,
+    PDEC_HANDLER_ID,
+    PDU_1_HANDLER_ID,
+    PDU_2_HANDLER_ID,
+    RAD_SENSOR_ID,
+    RW1_ID,
+    RW2_ID,
+    RW3_ID,
+    RW4_ID,
+    RW_ASSEMBLY,
+    STAR_TRACKER_ID,
+    STR_IMG_HELPER_ID,
+    SYRLINKS_HANDLER_ID,
+    TMP1075_HANDLER_IF_BRD_ID,
+    TMP1075_HANDLER_PLPCDU_0_ID,
+    TMP1075_HANDLER_TCS_BRD_0_ID,
+    TMP1075_HANDLER_TCS_BRD_1_ID,
+    get_object_ids,
+)
+from eive_tmtc.tmtc.acs.acs_board import pack_acs_board_command
+from eive_tmtc.tmtc.acs.acs_ctrl import pack_acs_ctrl_command
+from eive_tmtc.tmtc.acs.gps import pack_gps_command
+from eive_tmtc.tmtc.acs.gyros import handle_gyr_cmd
+from eive_tmtc.tmtc.acs.imtq import create_imtq_command
+from eive_tmtc.tmtc.acs.mgms import handle_mgm_cmd
+from eive_tmtc.tmtc.acs.reaction_wheels import (
+    create_single_rw_cmd,
+    pack_rw_ass_cmds,
+)
+from eive_tmtc.tmtc.acs.star_tracker import pack_star_tracker_commands
+from eive_tmtc.tmtc.acs.str_img_helper import pack_str_img_helper_command
+from eive_tmtc.tmtc.acs.subsystem import build_acs_subsystem_cmd
+from eive_tmtc.tmtc.com.ccsds_handler import pack_ccsds_handler_command
+from eive_tmtc.tmtc.com.pdec_handler import pack_pdec_handler_commands
+from eive_tmtc.tmtc.com.subsystem import build_com_subsystem_procedure
+from eive_tmtc.tmtc.com.syrlinks_handler import pack_syrlinks_command
+from eive_tmtc.tmtc.core import pack_core_commands
+from eive_tmtc.tmtc.health import build_health_cmds
+from eive_tmtc.tmtc.payload.subsystem import create_payload_subsystem_cmd
+from eive_tmtc.tmtc.payload.ploc_mpsoc import pack_ploc_mpsoc_commands
+from eive_tmtc.tmtc.payload.ploc_supervisor import pack_ploc_supv_commands
+from eive_tmtc.tmtc.payload.plpcdu import pack_pl_pcdu_commands
+from eive_tmtc.tmtc.payload.rad_sensor import create_rad_sensor_cmd
+from eive_tmtc.tmtc.payload.scex import pack_scex_cmds
+from eive_tmtc.tmtc.power.acu import pack_acu_commands
+from eive_tmtc.tmtc.power.p60dock import pack_p60dock_cmds
+from eive_tmtc.tmtc.power.pdu1 import pack_pdu1_commands
+from eive_tmtc.tmtc.power.pdu2 import pack_pdu2_commands
+from eive_tmtc.tmtc.power.power import pack_power_commands
+from eive_tmtc.tmtc.power.pwr_ctrl import pack_power_ctrl_command
+from eive_tmtc.tmtc.system import build_system_cmds
+from eive_tmtc.tmtc.tcs.ctrl import pack_tcs_ctrl_commands
+from eive_tmtc.tmtc.tcs.heater import pack_heater_cmds
+from eive_tmtc.tmtc.tcs.rtd import pack_rtd_commands
+from eive_tmtc.tmtc.tcs.subsystem import pack_tcs_sys_commands
+from eive_tmtc.tmtc.tcs.tmp1075 import pack_tmp1075_test_into
+from eive_tmtc.tmtc.test import build_test_commands
+from eive_tmtc.tmtc.time import pack_time_management_cmd
+from eive_tmtc.tmtc.tm_store import pack_tm_store_commands
+from eive_tmtc.tmtc.wdt import pack_wdt_commands
+from eive_tmtc.utility.input_helper import InputHelper
+
+
+def handle_pus_procedure(
+    info: TreeCommandingProcedure,
+    queue_helper: DefaultPusQueueHelper,
+):
+    cmd_path = info.cmd_path
+    assert cmd_path is not None
+    cmd_path_list = cmd_path.split("/")
+    if cmd_path_list[0] == "":
+        cmd_path_list = cmd_path_list[1:]
+    if len(cmd_path_list) == 0:
+        raise ValueError(
+            "command path list empty. Full command path {cmd_path} might have invalid format"
+        )
+    if cmd_path_list[0] == "system":
+        assert len(cmd_path_list) >= 1
+        return build_system_cmds(queue_helper, cmd_path_list[1])
+    if cmd_path_list[0] == "health":
+        assert len(cmd_path_list) >= 1
+        return build_health_cmds(queue_helper, cmd_path_list[1])
+    if cmd_path_list[0] == "eps":
+        return handle_eps_procedure(queue_helper, cmd_path_list[1:])
+    if cmd_path_list[0] == "tcs":
+        return handle_tcs_procedure(queue_helper, cmd_path_list[1:])
+    if cmd_path_list[0] == "acs":
+        return handle_acs_procedure(queue_helper, cmd_path_list[1:])
+    if cmd_path_list[0] == "payload":
+        return handle_payload_procedure(queue_helper, cmd_path_list[1:])
+    if cmd_path_list[0] == "obdh":
+        return handle_obdh_procedure(queue_helper, cmd_path_list[1:])
+    if cmd_path_list[0] == "test":
+        assert len(cmd_path_list) >= 1
+        return build_test_commands(queue_helper, cmd_path_list[1])
+    if cmd_path_list[0] == "com":
+        return handle_com_procedure(queue_helper, cmd_path_list[1:])
+    logging.getLogger(__name__).warning(
+        f"invalid or unimplemented command path {cmd_path}"
+    )
+
+
+def handle_eps_procedure(queue_helper: DefaultPusQueueHelper, cmd_path_list: List[str]):
+    obj_id_man = get_object_ids()
+    assert len(cmd_path_list) >= 1
+    if cmd_path_list[0] == "power":
+        return pack_power_commands(queue_helper, cmd_path_list[1])
+    if cmd_path_list[0] == "pwr_ctrl":
+        return pack_power_ctrl_command(queue_helper, cmd_path_list[1])
+    if cmd_path_list[0] == "p60_dock":
+        object_id = cast(ObjectIdU32, obj_id_man.get(P60_DOCK_HANDLER))
+        return pack_p60dock_cmds(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+    if cmd_path_list[0] == "pdu1":
+        object_id = cast(ObjectIdU32, obj_id_man.get(PDU_1_HANDLER_ID))
+        return pack_pdu1_commands(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+    if cmd_path_list[0] == "pdu2":
+        object_id = cast(ObjectIdU32, obj_id_man.get(PDU_2_HANDLER_ID))
+        return pack_pdu2_commands(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+    if cmd_path_list[0] == "acu":
+        object_id = cast(ObjectIdU32, obj_id_man.get(ACU_HANDLER_ID))
+        return pack_acu_commands(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+
+
+def handle_tcs_procedure(queue_helper: DefaultPusQueueHelper, cmd_path_list: List[str]):
+    obj_id_man = get_object_ids()
+    if len(cmd_path_list) == 1:
+        return pack_tcs_sys_commands(q=queue_helper, cmd_str=cmd_path_list[0])
+    assert len(cmd_path_list) >= 2
+    if cmd_path_list[0] == "tcs_brd_assy":
+        return pack_tcs_sys_commands(q=queue_helper, cmd_str=cmd_path_list[1])
+    if cmd_path_list[0] == "rtd_devs":
+        assert len(cmd_path_list) >= 2
+        return pack_rtd_commands(
+            object_id=None, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+    if cmd_path_list[0] == "tcs_ctrl":
+        assert len(cmd_path_list) >= 2
+        return pack_tcs_ctrl_commands(q=queue_helper, cmd_str=cmd_path_list[2])
+    if cmd_path_list[0] == "tmp1075_devs":
+        menu_dict = {
+            "0": ("TMP1075 TCS Board 0", TMP1075_HANDLER_TCS_BRD_0_ID),
+            "1": ("TMP1075 TCS Board 1", TMP1075_HANDLER_TCS_BRD_1_ID),
+            "2": ("TMP1075 PL PCDU 0", TMP1075_HANDLER_PLPCDU_0_ID),
+            "3": ("TMP1075 PL PCDU 1", oids.TMP1075_HANDLER_PLPCDU_1_ID),
+            "4": ("TMP1075 IF Board", TMP1075_HANDLER_IF_BRD_ID),
+        }
+        input_helper = InputHelper(menu_dict)
+        tmp_select = input_helper.get_key()
+        assert len(cmd_path_list) >= 2
+        object_id = obj_id_man.get(menu_dict[tmp_select][1])
+        assert object_id is not None
+        return pack_tmp1075_test_into(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+    if cmd_path_list[0] == "heaters":
+        object_id = HEATER_CONTROLLER_ID
+        return pack_heater_cmds(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+
+
+def handle_acs_procedure(queue_helper: DefaultPusQueueHelper, cmd_path_list: List[str]):
+    obj_id_man = get_object_ids()
+    if len(cmd_path_list) == 1:
+        return build_acs_subsystem_cmd(queue_helper, cmd_path_list[0])
+    assert len(cmd_path_list) >= 2
+    if cmd_path_list[0] == "mgt":
+        object_id = cast(ObjectIdU32, obj_id_man.get(IMTQ_HANDLER_ID))
+        return create_imtq_command(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+    if cmd_path_list[0] == "str":
+        object_id = cast(ObjectIdU32, obj_id_man.get(STAR_TRACKER_ID))
+        return pack_star_tracker_commands(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+
+    if cmd_path_list[0] == "rws":
+        assert len(cmd_path_list) >= 2
+        if cmd_path_list[1] == "rw_assy":
+            assert len(cmd_path_list) >= 3
+            return pack_rw_ass_cmds(
+                q=queue_helper, object_id=RW_ASSEMBLY, cmd_str=cmd_path_list[2]
+            )
+        if cmd_path_list[1] == "rw_1":
+            assert len(cmd_path_list) >= 3
+            return create_single_rw_cmd(
+                object_id=RW1_ID, rw_idx=1, q=queue_helper, cmd_str=cmd_path_list[2]
+            )
+        if cmd_path_list[1] == "rw_2":
+            assert len(cmd_path_list) >= 3
+            return create_single_rw_cmd(
+                object_id=RW2_ID, rw_idx=2, q=queue_helper, cmd_str=cmd_path_list[2]
+            )
+        if cmd_path_list[1] == "rw_3":
+            assert len(cmd_path_list) >= 3
+            return create_single_rw_cmd(
+                object_id=RW3_ID, rw_idx=3, q=queue_helper, cmd_str=cmd_path_list[2]
+            )
+        if cmd_path_list[1] == "rw_4":
+            assert len(cmd_path_list) >= 3
+            return create_single_rw_cmd(
+                object_id=RW4_ID, rw_idx=4, q=queue_helper, cmd_str=cmd_path_list[2]
+            )
+
+    if cmd_path_list[0] == "gnss_ctrl":
+        return pack_gps_command(
+            object_id=oids.GPS_CONTROLLER, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+    if cmd_path_list[0] == "acs_brd_assy":
+        if len(cmd_path_list) == 2:
+            return pack_acs_board_command(q=queue_helper, cmd_str=cmd_path_list[1])
+        else:
+            if cmd_path_list[1] == "mgm_devs":
+                return handle_mgm_cmd(q=queue_helper, cmd_str=cmd_path_list[2])
+            if cmd_path_list[1] == "gyro_devs":
+                assert len(cmd_path_list) >= 3
+                return handle_gyr_cmd(q=queue_helper, cmd_str=cmd_path_list[2])
+    if cmd_path_list[0] == "str_img_helper":
+        object_id = cast(ObjectIdU32, obj_id_man.get(STR_IMG_HELPER_ID))
+        return pack_str_img_helper_command(
+            object_id=object_id, q=queue_helper, op_code=cmd_path_list[1]
+        )
+    if cmd_path_list[0] == "acs_ctrl":
+        return pack_acs_ctrl_command(queue_helper, cmd_path_list[1])
+
+
+def handle_payload_procedure(
+    queue_helper: DefaultPusQueueHelper, cmd_path_list: List[str]
+):
+    obj_id_man = get_object_ids()
+    if cmd_path_list[0] == "subsystem":
+        return create_payload_subsystem_cmd(queue_helper, cmd_path_list[1])
+    if cmd_path_list[0] == "ploc_mpsoc":
+        return pack_ploc_mpsoc_commands(queue_helper, cmd_path_list[1])
+    if cmd_path_list[0] == "ploc_supv":
+        return pack_ploc_supv_commands(queue_helper, cmd_path_list[1])
+    if cmd_path_list[0] == "rad_sensor":
+        assert len(cmd_path_list) >= 3
+        object_id = cast(ObjectIdU32, obj_id_man.get(RAD_SENSOR_ID))
+        return create_rad_sensor_cmd(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[1]
+        )
+    if cmd_path_list[0] == "pl_pcdu":
+        return pack_pl_pcdu_commands(q=queue_helper, cmd_str=cmd_path_list[1])
+    if cmd_path_list[0] == "scex":
+        return pack_scex_cmds(
+            cmd_str=cmd_path_list[1],
+            q=queue_helper,
+        )
+
+
+def handle_obdh_procedure(
+    queue_helper: DefaultPusQueueHelper, cmd_path_list: List[str]
+):
+    assert len(cmd_path_list) >= 2
+    if cmd_path_list[0] == "core":
+        return pack_core_commands(q=queue_helper, cmd_str=cmd_path_list[1])
+    if cmd_path_list[0] == "xiphos_wdt":
+        return pack_wdt_commands(queue_helper, cmd_path_list[1])
+    if cmd_path_list[0] == "time":
+        return pack_time_management_cmd(queue_helper, cmd_path_list[1])
+    if cmd_path_list[0] == "tm_store":
+        return pack_tm_store_commands(queue_helper, cmd_path_list[1])
+
+
+def handle_com_procedure(queue_helper: DefaultPusQueueHelper, cmd_path_list: List[str]):
+    obj_id_man = get_object_ids()
+    if len(cmd_path_list) == 1:
+        return build_com_subsystem_procedure(queue_helper, cmd_path_list[0])
+    assert len(cmd_path_list) >= 2
+    if cmd_path_list[0] == "ccsds":
+        object_id = cast(ObjectIdU32, obj_id_man.get(CCSDS_HANDLER_ID))
+        return pack_ccsds_handler_command(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[2]
+        )
+    if cmd_path_list[0] == "pdec":
+        return pack_pdec_handler_commands(
+            object_id=PDEC_HANDLER_ID, q=queue_helper, cmd_str=cmd_path_list[2]
+        )
+    if cmd_path_list[0] == "syrlinks":
+        object_id = cast(ObjectIdU32, obj_id_man.get(SYRLINKS_HANDLER_ID))
+        return pack_syrlinks_command(
+            object_id=object_id, q=queue_helper, cmd_str=cmd_path_list[2]
+        )

eive_tmtc/pus_tc/procedure_packer.py

@@ -1,220 +0,0 @@
-"""Hook function which packs telecommands based on service and operation code string
-"""
-import logging
-from typing import cast
-
-from eive_tmtc.tmtc.acs.gyros import handle_gyr_cmd
-from eive_tmtc.tmtc.acs.mgms import handle_mgm_cmd
-from eive_tmtc.tmtc.power.power import pack_power_commands
-from eive_tmtc.tmtc.tcs.ctrl import pack_tcs_ctrl_commands
-from eive_tmtc.tmtc.tcs.rtd import pack_rtd_commands
-from eive_tmtc.tmtc.payload.scex import pack_scex_cmds
-from eive_tmtc.tmtc.tcs.subsystem import pack_tcs_sys_commands
-from tmtccmd import DefaultProcedureInfo, TcHandlerBase
-from tmtccmd.config import CoreServiceList
-from tmtccmd.tc import DefaultPusQueueHelper
-from tmtccmd.tc.decorator import (
-    route_to_registered_service_handlers,
-    ServiceProviderParams,
-)
-
-from eive_tmtc.tmtc.misc.s200_test import pack_service_200_test_into
-from eive_tmtc.tmtc.power.p60dock import pack_p60dock_cmds
-from eive_tmtc.tmtc.power.pdu2 import pack_pdu2_commands
-from eive_tmtc.tmtc.power.pdu1 import pack_pdu1_commands
-from eive_tmtc.tmtc.power.acu import pack_acu_commands
-from eive_tmtc.tmtc.acs.imtq import pack_imtq_test_into
-from eive_tmtc.tmtc.tcs.heater import pack_heater_cmds
-from eive_tmtc.tmtc.acs.reaction_wheels import (
-    pack_single_rw_test_into,
-    pack_rw_ass_cmds,
-)
-from eive_tmtc.tmtc.payload.ploc_memory_dumper import pack_ploc_memory_dumper_cmd
-from eive_tmtc.tmtc.com.ccsds_handler import pack_ccsds_handler_command
-from eive_tmtc.tmtc.core import pack_core_commands
-from eive_tmtc.tmtc.acs.star_tracker import pack_star_tracker_commands
-from eive_tmtc.tmtc.com.syrlinks_handler import pack_syrlinks_command
-from eive_tmtc.tmtc.com.pdec_handler import pack_pdec_handler_test
-from eive_tmtc.tmtc.wdt import pack_wdt_commands
-from eive_tmtc.tmtc.acs.acs_board import pack_acs_command
-from eive_tmtc.config.definitions import CustomServiceList
-from eive_tmtc.config.object_ids import (
-    P60_DOCK_HANDLER,
-    PDU_1_HANDLER_ID,
-    PDU_2_HANDLER_ID,
-    ACU_HANDLER_ID,
-    TMP1075_HANDLER_TCS_BRD_0_ID,
-    TMP1075_HANDLER_TCS_BRD_1_ID,
-    TMP1075_HANDLER_PLPCDU_0_ID,
-    TMP1075_HANDLER_IF_BRD_ID,
-    HEATER_CONTROLLER_ID,
-    IMTQ_HANDLER_ID,
-    RW1_ID,
-    RW2_ID,
-    RW3_ID,
-    RW4_ID,
-    RAD_SENSOR_ID,
-    STAR_TRACKER_ID,
-    PLOC_MEMORY_DUMPER_ID,
-    CCSDS_HANDLER_ID,
-    PDEC_HANDLER_ID,
-    STR_IMG_HELPER_ID,
-    SYRLINKS_HANDLER_ID,
-    RW_ASSEMBLY,
-    get_object_ids,
-)
-
-from eive_tmtc.tmtc.tcs.tmp1075 import pack_tmp1075_test_into
-from eive_tmtc.tmtc.acs.gps import pack_gps_command
-from eive_tmtc.tmtc.payload.rad_sensor import pack_rad_sensor_test_into
-from eive_tmtc.tmtc.payload.plpcdu import pack_pl_pcdu_commands
-from eive_tmtc.tmtc.acs.str_img_helper import pack_str_img_helper_command
-from eive_tmtc.pus_tc.system.proc import pack_proc_commands
-
-import eive_tmtc.config.object_ids as oids
-from tmtccmd.util import ObjectIdU32
-
-from eive_tmtc.utility.input_helper import InputHelper
-
-
-def handle_default_procedure(  # noqa C901: Complexity okay here.
-    tc_base: TcHandlerBase,
-    info: DefaultProcedureInfo,
-    queue_helper: DefaultPusQueueHelper,
-):
-    service = info.service
-    op_code = info.op_code
-    obj_id_man = get_object_ids()
-    if service == CoreServiceList.SERVICE_200.value:
-        return pack_service_200_test_into(q=queue_helper)
-    if service == CustomServiceList.P60DOCK.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(P60_DOCK_HANDLER))
-        return pack_p60dock_cmds(object_id=object_id, q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.RTD.value:
-        return pack_rtd_commands(object_id=None, q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.PDU1.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(PDU_1_HANDLER_ID))
-        return pack_pdu1_commands(object_id=object_id, q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.PDU2.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(PDU_2_HANDLER_ID))
-        return pack_pdu2_commands(object_id=object_id, q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.ACU.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(ACU_HANDLER_ID))
-        return pack_acu_commands(object_id=object_id, q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.TCS_SS.value:
-        return pack_tcs_sys_commands(q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.TCS_CTRL.value:
-        return pack_tcs_ctrl_commands(q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.TMP1075.value:
-        menu_dict = {
-            "0": ("TMP1075 TCS Board 0", TMP1075_HANDLER_TCS_BRD_0_ID),
-            "1": ("TMP1075 TCS Board 1", TMP1075_HANDLER_TCS_BRD_1_ID),
-            "2": ("TMP1075 PL PCDU 0", TMP1075_HANDLER_PLPCDU_0_ID),
-            "3": ("TMP1075 PL PCDU 1", oids.TMP1075_HANDLER_PLPCDU_1_ID),
-            "4": ("TMP1075 IF Board", TMP1075_HANDLER_IF_BRD_ID),
-        }
-        input_helper = InputHelper(menu_dict)
-        tmp_select = input_helper.get_key()
-        object_id = obj_id_man.get(menu_dict[tmp_select][1])
-        return pack_tmp1075_test_into(
-            object_id=object_id, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.HEATER.value:
-        object_id = HEATER_CONTROLLER_ID
-        return pack_heater_cmds(object_id=object_id, q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.IMTQ.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(IMTQ_HANDLER_ID))
-        return pack_imtq_test_into(object_id=object_id, q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.REACTION_WHEEL_1.value:
-        return pack_single_rw_test_into(
-            object_id=RW1_ID, rw_idx=1, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.REACTION_WHEEL_2.value:
-        return pack_single_rw_test_into(
-            object_id=RW2_ID, rw_idx=2, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.REACTION_WHEEL_3.value:
-        return pack_single_rw_test_into(
-            object_id=RW3_ID, rw_idx=3, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.REACTION_WHEEL_4.value:
-        return pack_single_rw_test_into(
-            object_id=RW4_ID, rw_idx=4, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.MGMS.value:
-        return handle_mgm_cmd(q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.RAD_SENSOR.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(RAD_SENSOR_ID))
-        return pack_rad_sensor_test_into(
-            object_id=object_id, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.STAR_TRACKER.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(STAR_TRACKER_ID))
-        return pack_star_tracker_commands(
-            object_id=object_id, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.STR_IMG_HELPER.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(STR_IMG_HELPER_ID))
-        return pack_str_img_helper_command(
-            object_id=object_id, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.CORE.value:
-        return pack_core_commands(q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.PLOC_MEMORY_DUMPER.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(PLOC_MEMORY_DUMPER_ID))
-        return pack_ploc_memory_dumper_cmd(
-            object_id=object_id, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.POWER.value:
-        return pack_power_commands(queue_helper, op_code)
-    if service == CustomServiceList.ACS.value:
-        return pack_acs_command(q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.GPS_CTRL.value:
-        return pack_gps_command(
-            object_id=oids.GPS_CONTROLLER, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.CCSDS_HANDLER.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(CCSDS_HANDLER_ID))
-        return pack_ccsds_handler_command(
-            object_id=object_id, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.PDEC_HANDLER.value:
-        return pack_pdec_handler_test(
-            object_id=PDEC_HANDLER_ID, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.SYRLINKS.value:
-        object_id = cast(ObjectIdU32, obj_id_man.get(SYRLINKS_HANDLER_ID))
-        return pack_syrlinks_command(
-            object_id=object_id, q=queue_helper, op_code=op_code
-        )
-    if service == CustomServiceList.GYRO.value:
-        return handle_gyr_cmd(q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.PROCEDURE.value:
-        return pack_proc_commands(q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.PL_PCDU.value:
-        return pack_pl_pcdu_commands(q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.TCS_ASS.value:
-        return pack_tcs_sys_commands(q=queue_helper, op_code=op_code)
-    if service == CustomServiceList.RW_ASSEMBLY.value:
-        return pack_rw_ass_cmds(q=queue_helper, object_id=RW_ASSEMBLY, op_code=op_code)
-    if service == CustomServiceList.SCEX.value:
-        return pack_scex_cmds(
-            ServiceProviderParams(
-                handler_base=tc_base,
-                op_code=op_code,
-                info=info,
-                queue_helper=queue_helper,
-            )
-        )
-    if service == CustomServiceList.XIPHOS_WDT.value:
-        return pack_wdt_commands(queue_helper, op_code)
-    if not route_to_registered_service_handlers(
-        service,
-        ServiceProviderParams(
-            handler_base=tc_base,
-            op_code=op_code,
-            info=info,
-            queue_helper=queue_helper,
-        ),
-    ):
-        logging.getLogger(__name__).warning(f"Invalid Service {service}")

eive_tmtc/pus_tc/system/controllers.py

@@ -1,7 +1,7 @@
 from typing import Union
 
-from tmtccmd.tc import DefaultPusQueueHelper
-from tmtccmd.tc.pus_200_fsfw_mode import Mode
+from tmtccmd.tmtc import DefaultPusQueueHelper
+from tmtccmd.pus.s200_fsfw_mode import Mode
 from tmtccmd.util import ObjectIdU32, ObjectIdBase
 
 from eive_tmtc.tmtc.common import pack_mode_cmd_with_info

eive_tmtc/pus_tc/system/proc.py

@@ -10,7 +10,7 @@ from spacepackets.ecss import PusTelecommand
 from tmtccmd.config import TmtcDefinitionWrapper, OpCodeEntry
 from tmtccmd.config.tmtc import tmtc_definitions_provider
 
-from tmtccmd.tc import DefaultPusQueueHelper
+from tmtccmd.tmtc import DefaultPusQueueHelper
 from tmtccmd.pus.s11_tc_sched import (
     create_time_tagged_cmd,
     create_enable_tc_sched_cmd,
@@ -34,9 +34,9 @@ from eive_tmtc.pus_tc.system.controllers import (
     pack_cmd_ctrl_to_off,
     pack_cmd_ctrl_to_nml,
 )
-from eive_tmtc.tmtc.acs.acs_board import pack_acs_command
+from eive_tmtc.tmtc.acs.acs_board import pack_acs_board_command
 from eive_tmtc.tmtc.acs.sus_board import pack_sus_cmds
-from eive_tmtc.tmtc.acs.imtq import pack_imtq_test_into, pack_dipole_command
+from eive_tmtc.tmtc.acs.imtq import create_imtq_command, pack_dipole_command
 from eive_tmtc.tmtc.acs.star_tracker import pack_star_tracker_commands
 from eive_tmtc.tmtc.acs.reaction_wheels import pack_rw_ass_cmds, pack_set_speed_command
 
@@ -50,7 +50,7 @@ from eive_tmtc.tmtc.acs.gyros import (
     L3gGyroSetId as L3gGyroSetIds_1_3,
 )
 from eive_tmtc.tmtc.acs.gps import SetId as GpsSetIds
-from tmtccmd.tc.pus_3_fsfw_hk import (
+from tmtccmd.pus.tc.s3_fsfw_hk import (
     make_sid,
     disable_periodic_hk_command,
     create_enable_periodic_hk_command_with_interval,
@@ -312,7 +312,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
         # Enable scheduling
         q.add_pus_tc(create_enable_tc_sched_cmd())
         # check whether tcs_assembly also has to be commanded to NORMAL Mode
-        pack_tcs_sys_commands(q=q, op_code=TcsOpCodes.TCS_BOARD_ASS_NORMAL[0])
+        pack_tcs_sys_commands(q=q, cmd_str=TcsOpCodes.TCS_BOARD_ASS_NORMAL[0])
         pack_cmd_ctrl_to_nml(q=q, object_id=obj_id_dict.get(oids.THERMAL_CONTROLLER_ID))
 
     if op_code in OpCode.TV_TEARDOWN_TCS_FT_OFF:
@@ -337,7 +337,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
         ]
         d_side_pairs = a_side_pairs + b_side_pairs
         diag_list = [False, False, True, False, False]
-        pack_acs_command(q=q, op_code="acs-a")
+        pack_acs_board_command(q=q, cmd_str="acs-a")
 
         for a_side_dev in a_side_pairs:
             oid = a_side_dev[0]
@@ -351,9 +351,9 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=GenericHkListeningCfg.default(),
         )
 
-        pack_acs_command(q=q, op_code="acs-off")
+        pack_acs_board_command(q=q, cmd_str="acs-off")
         q.add_wait_seconds(5.0)
-        pack_acs_command(q=q, op_code="acs-b")
+        pack_acs_board_command(q=q, cmd_str="acs-b")
 
         sid_list.clear()
         diag_list = [False, False, True, False, False]
@@ -370,9 +370,9 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=GenericHkListeningCfg.default(),
         )
 
-        pack_acs_command(q=q, op_code="acs-off")
+        pack_acs_board_command(q=q, cmd_str="acs-off")
         q.add_wait_seconds(5.0)
-        pack_acs_command(q=q, op_code="acs-d")
+        pack_acs_board_command(q=q, cmd_str="acs-d")
 
         sid_list.clear()
 
@@ -400,7 +400,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=GenericHkListeningCfg.default(),
         )
 
-        pack_acs_command(q=q, op_code="acs-off")
+        pack_acs_board_command(q=q, cmd_str="acs-off")
 
     if op_code in OpCode.MGT_FT:
         key = KAI.MGT_FT[0]
@@ -416,10 +416,10 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
         ]
 
         # Command MGT to mode on
-        pack_imtq_test_into(oids.IMTQ_HANDLER_ID, q=q, op_code="1")
+        create_imtq_command(oids.IMTQ_HANDLER_ID, q=q, cmd_str="1")
         q.add_wait_seconds(5.0)
         # Command MGT to normal mode
-        pack_imtq_test_into(oids.IMTQ_HANDLER_ID, q=q, op_code="2")
+        create_imtq_command(oids.IMTQ_HANDLER_ID, q=q, cmd_str="2")
 
         for imtq_dev in imtq_pairs:
             oid = imtq_dev[0]
@@ -433,7 +433,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=GenericHkListeningCfg.default(),
         )
 
-        pack_imtq_test_into(oids.IMTQ_HANDLER_ID, q=q, op_code="0")
+        create_imtq_command(oids.IMTQ_HANDLER_ID, q=q, cmd_str="0")
 
     if op_code in OpCode.MGT_FT_DP:
         key = KAI.MGT_FT_DP[0]
@@ -472,12 +472,12 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             True,
             True,
         ]
-        pack_acs_command(q=q, op_code="acs-d")
+        pack_acs_board_command(q=q, cmd_str="acs-d")
         # Command MGT to mode on
-        pack_imtq_test_into(oids.IMTQ_HANDLER_ID, q=q, op_code="1")
+        create_imtq_command(oids.IMTQ_HANDLER_ID, q=q, cmd_str="1")
         q.add_wait_seconds(20.0)
         # Command MGT to normal mode
-        pack_imtq_test_into(oids.IMTQ_HANDLER_ID, q=q, op_code="2")
+        create_imtq_command(oids.IMTQ_HANDLER_ID, q=q, cmd_str="2")
 
         for d_side_and_imtq_dev in d_side_and_imtq_pairs:
             oid = d_side_and_imtq_dev[0]
@@ -494,8 +494,8 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=cfg,
         )
 
-        pack_imtq_test_into(oids.IMTQ_HANDLER_ID, q=q, op_code="0")
-        pack_acs_command(q=q, op_code="acs-off")
+        create_imtq_command(oids.IMTQ_HANDLER_ID, q=q, cmd_str="0")
+        pack_acs_board_command(q=q, cmd_str="acs-off")
 
     if op_code in OpCode.SUS_FT:
         key = KAI.SUS_FT[0]
@@ -538,7 +538,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=GenericHkListeningCfg.default(),
         )
 
-        pack_acs_command(q=q, op_code="sus-off")
+        pack_acs_board_command(q=q, cmd_str="sus-off")
         q.add_wait_seconds(5.0)
         pack_sus_cmds(q=q, op_code="sus-red")
 
@@ -562,7 +562,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=GenericHkListeningCfg.default(),
         )
 
-        pack_acs_command(q=q, op_code="sus-off")
+        pack_acs_board_command(q=q, cmd_str="sus-off")
         q.add_wait_seconds(5.0)
         pack_sus_cmds(q=q, op_code="sus-d")
 
@@ -593,7 +593,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=GenericHkListeningCfg.default(),
         )
 
-        pack_acs_command(q=q, op_code="sus-off")
+        pack_acs_board_command(q=q, cmd_str="sus-off")
 
     if op_code in OpCode.SYRLINKS_FT:
         key = KAI.SYRLINKS_FT[0]
@@ -612,7 +612,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
     if op_code in OpCode.STR_FT:
         key = KAI.STR_FT[0]
 
-        pack_star_tracker_commands(object_id=oids.STAR_TRACKER_ID, q=q, op_code="2")
+        pack_star_tracker_commands(object_id=oids.STAR_TRACKER_ID, q=q, cmd_str="2")
 
         # STR
         sid_list.append(make_sid(oids.STAR_TRACKER_ID, StrSetIds.TEMPERATURE))
@@ -625,7 +625,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=GenericHkListeningCfg.default(),
         )
 
-        pack_star_tracker_commands(object_id=oids.STAR_TRACKER_ID, q=q, op_code="3")
+        pack_star_tracker_commands(object_id=oids.STAR_TRACKER_ID, q=q, cmd_str="3")
 
     if op_code in OpCode.RW_FT_ONE_RW:
         key = KAI.RW_FT_ONE_RW[0]
@@ -658,7 +658,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             False,
         ]
         # RW NORMAL
-        pack_rw_ass_cmds(object_id=oids.RW_ASSEMBLY, q=q, op_code="nml")
+        pack_rw_ass_cmds(object_id=oids.RW_ASSEMBLY, q=q, cmd_str="nml")
 
         # RW HK für alle RWs nur einzeln
         for rw_dev in rw_pairs:
@@ -673,7 +673,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=GenericHkListeningCfg(mgt=False, one_rw=True, two_rws=False),
         )
         # RW OFF
-        pack_rw_ass_cmds(object_id=oids.RW_ASSEMBLY, q=q, op_code="off")
+        pack_rw_ass_cmds(object_id=oids.RW_ASSEMBLY, q=q, cmd_str="off")
 
     # ass command with 2 rws to speed
     if op_code in OpCode.RW_FT_TWO_RWS:
@@ -715,7 +715,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             False,
         ]
         # RW NORMAL
-        pack_rw_ass_cmds(object_id=oids.RW_ASSEMBLY, q=q, op_code="nml")
+        pack_rw_ass_cmds(object_id=oids.RW_ASSEMBLY, q=q, cmd_str="nml")
 
         # RW
         for rw_dev in rw_pairs:
@@ -730,7 +730,7 @@ def pack_proc_commands(  # noqa C901: Complexity is okay here.
             cfg=GenericHkListeningCfg(mgt=False, one_rw=False, two_rws=True),
         )
         # RW OFF
-        pack_rw_ass_cmds(object_id=oids.RW_ASSEMBLY, q=q, op_code="off")
+        pack_rw_ass_cmds(object_id=oids.RW_ASSEMBLY, q=q, cmd_str="off")
 
 
 def enable_listen_to_hk_for_x_seconds(

eive_tmtc/pus_tc/tc_handler.py

@@ -6,13 +6,13 @@ from eive_tmtc.config.definitions import (
     PUS_APID,
     CFDP_LOCAL_ENTITY_ID,
 )
-from eive_tmtc.pus_tc.procedure_packer import handle_default_procedure
+from eive_tmtc.pus_tc.cmd_demux import handle_pus_procedure
+from eive_tmtc.cfdp.handler import CfdpInCcsdsHandler
 from tmtccmd import TcHandlerBase, ProcedureWrapper
-from tmtccmd.cfdp.defs import CfdpRequestType
-from tmtccmd.cfdp.handler import CfdpInCcsdsHandler
+from cfdppy.defs import CfdpRequestType
 from tmtccmd.logging import get_current_time_string
 from tmtccmd.logging.pus import RawTmtcTimedLogWrapper
-from tmtccmd.tc import (
+from tmtccmd.tmtc import (
     DefaultPusQueueHelper,
     QueueWrapper,
     FeedWrapper,
@@ -22,7 +22,7 @@ from tmtccmd.tc import (
 )
 from tmtccmd.config.cfdp import generic_cfdp_params_to_put_request
 from spacepackets.ecss import PusVerificator
-from tmtccmd.util import FileSeqCountProvider
+from spacepackets.seqcount import FileSeqCountProvider
 from spacepackets.cfdp import PduHolder, DirectiveType
 
 
@@ -68,8 +68,8 @@ class TcHandler(TcHandlerBase):
 
     def feed_cb(self, info: ProcedureWrapper, wrapper: FeedWrapper):
         self.queue_helper.queue_wrapper = wrapper.queue_wrapper
-        if info.proc_type == TcProcedureType.DEFAULT:
-            handle_default_procedure(self, info.to_def_procedure(), self.queue_helper)
+        if info.proc_type == TcProcedureType.TREE_COMMANDING:
+            handle_pus_procedure(info.to_tree_commanding_procedure(), self.queue_helper)
         elif info.proc_type == TcProcedureType.CFDP:
             self.handle_cfdp_procedure(info)
 
@@ -124,40 +124,38 @@ class TcHandler(TcHandlerBase):
                 _LOGGER.info(
                     f"CFDP: Starting file put request with parameters:\n{put_req}"
                 )
+                assert put_req is not None
                 self.cfdp_in_ccsds_handler.cfdp_handler.put_request(put_req)
                 self.cfdp_handler_started = True
 
-                for source_pair, dest_pair in self.cfdp_in_ccsds_handler:
-                    pdu, sp = source_pair
-                    pdu = cast(PduHolder, pdu)
-                    if pdu.is_file_directive:
-                        if pdu.pdu_directive_type == DirectiveType.METADATA_PDU:
-                            metadata = pdu.to_metadata_pdu()
+                for source_pair, _ in self.cfdp_in_ccsds_handler:
+                    if source_pair is not None:
+                        pdu, sp = source_pair
+                        pdu = cast(PduHolder, pdu)
+                        if pdu.is_file_directive:
+                            if pdu.pdu_directive_type == DirectiveType.METADATA_PDU:
+                                metadata = pdu.to_metadata_pdu()
+                                self.queue_helper.add_log_cmd(
+                                    "CFDP Source: Sending Metadata PDU for file with size "
+                                    f"{metadata.file_size}"
+                                )
+                            elif pdu.pdu_directive_type == DirectiveType.EOF_PDU:
+                                self.queue_helper.add_log_cmd(
+                                    "CFDP Source: Sending EOF PDU"
+                                )
+                        else:
+                            fd_pdu = pdu.to_file_data_pdu()
                             self.queue_helper.add_log_cmd(
-                                "CFDP Source: Sending Metadata PDU for file with size "
-                                f"{metadata.file_size}"
+                                "CFDP Source: Sending File Data PDU for segment at offset "
+                                f"{fd_pdu.offset} with length {len(fd_pdu.file_data)}"
                             )
-                        elif pdu.pdu_directive_type == DirectiveType.EOF_PDU:
-                            self.queue_helper.add_log_cmd(
-                                "CFDP Source: Sending EOF PDU"
-                            )
-                    else:
-                        fd_pdu = pdu.to_file_data_pdu()
-                        self.queue_helper.add_log_cmd(
-                            "CFDP Source: Sending File Data PDU for segment at offset "
-                            f"{fd_pdu.offset} with length {len(fd_pdu.file_data)}"
-                        )
-                    self.queue_helper.add_ccsds_tc(sp)
-                    self.cfdp_in_ccsds_handler.confirm_source_packet_sent()
+                        self.queue_helper.add_ccsds_tc(sp)
                 self.cfdp_in_ccsds_handler.source_handler.state_machine()
 
     def queue_finished_cb(self, info: ProcedureWrapper):
         if info is not None:
             if info.proc_type == TcQueueEntryType.PUS_TC:
-                def_proc = info.to_def_procedure()
-                _LOGGER.info(
-                    f"Finished queue for service {def_proc.service} and op code"
-                    f" {def_proc.op_code}"
-                )
+                def_proc = info.to_tree_commanding_procedure()
+                _LOGGER.info(f"Finished queue for command {def_proc.cmd_path}")
             elif info.proc_type == TcProcedureType.CFDP:
                 _LOGGER.info("Finished CFDP queue")

eive_tmtc/pus_tm/action_reply_handler.py

@@ -1,5 +1,10 @@
+import base64
 import logging
 import struct
+
+from spacepackets.ecss import PusTm
+from tmtccmd.pus.s8_fsfw_action_defs import CustomSubservice
+from eive_tmtc.config.definitions import PRINT_RAW_ACTION_DATA_REPLY_B64_STR
 from eive_tmtc.config.object_ids import (
     ACU_HANDLER_ID,
     PDU_1_HANDLER_ID,
@@ -10,6 +15,7 @@ from eive_tmtc.config.object_ids import (
     CORE_CONTROLLER_ID,
     STAR_TRACKER_ID,
     P60_DOCK_HANDLER,
+    ACS_CONTROLLER,
 )
 from eive_tmtc.tmtc.acs.imtq import ImtqActionId
 from eive_tmtc.pus_tm.defs import PrintWrapper
@@ -17,55 +23,78 @@ from eive_tmtc.tmtc.core import handle_core_ctrl_action_replies
 from eive_tmtc.tmtc.payload.ploc_mpsoc import handle_mpsoc_data_reply
 from eive_tmtc.tmtc.payload.ploc_supervisor import SupvActionId
 from eive_tmtc.tmtc.acs.star_tracker import handle_star_tracker_action_replies
+from eive_tmtc.tmtc.acs.acs_ctrl import handle_acs_ctrl_action_replies
 from eive_tmtc.tmtc.power.tm import handle_get_param_data_reply
-from tmtccmd.tm import Service8FsfwTm
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
 from spacepackets.ccsds.time import CdsShortTimestamp
-from tmtccmd.util import ObjectIdDictT
+from tmtccmd.util import ObjectIdBase, ObjectIdDictT, ObjectIdU32
 
 _LOGGER = logging.getLogger(__name__)
 
 
-def handle_action_reply(
-    raw_tm: bytes, printer: FsfwTmTcPrinter, obj_id_dict: ObjectIdDictT
+_LOGGER = logging.getLogger(__name__)
+
+
+def handle_action_service_tm(
+    raw_tm: bytes, pw: PrintWrapper, obj_id_dict: ObjectIdDictT
 ):
     """Core Action reply handler
     :return:
     """
-    tm_packet = Service8FsfwTm.unpack(
-        raw_telemetry=raw_tm, time_reader=CdsShortTimestamp.empty()
-    )
-    object_id = obj_id_dict.get(tm_packet.source_object_id_as_bytes)
-    pw = PrintWrapper(printer.file_logger)
-    custom_data = tm_packet.custom_data
-    action_id = tm_packet.action_id
-    generic_print_str = printer.generic_action_packet_tm_print(
-        packet=tm_packet, obj_id=object_id
-    )
-    pw.dlog(generic_print_str)
-    if object_id.as_bytes == IMTQ_HANDLER_ID:
-        return handle_imtq_replies(action_id, pw, custom_data)
-    elif object_id.as_bytes == PLOC_MPSOC_ID:
-        return handle_mpsoc_data_reply(action_id, pw, custom_data)
-    elif object_id.as_bytes == PLOC_SUPV_ID:
-        return handle_supervisor_replies(action_id, pw, custom_data)
-    elif object_id.as_bytes == CORE_CONTROLLER_ID:
-        return handle_core_ctrl_action_replies(action_id, pw, custom_data)
-    elif object_id.as_bytes == STAR_TRACKER_ID:
-        return handle_star_tracker_action_replies(action_id, pw, custom_data)
-    elif object_id.as_bytes in [
-        ACU_HANDLER_ID,
-        PDU_1_HANDLER_ID,
-        PDU_2_HANDLER_ID,
-        P60_DOCK_HANDLER,
-    ]:
-        return handle_get_param_data_reply(object_id, action_id, pw, custom_data)
+    tm_packet = PusTm.unpack(raw_tm, timestamp_len=CdsShortTimestamp.TIMESTAMP_SIZE)
+    if len(tm_packet.source_data) < 8:
+        _LOGGER.warning(
+            "received action service reply with source data smaller than 8 bytes"
+        )
+        return
+    object_id_raw = struct.unpack("!I", tm_packet.source_data[0:4])[0]
+    action_id = struct.unpack("!I", tm_packet.source_data[4:8])[0]
+    object_id = obj_id_dict.get(object_id_raw)
+    custom_data = tm_packet.source_data[8:]
+    if object_id is None:
+        object_id = ObjectIdU32(object_id_raw, "Unknown ID")
+    if tm_packet.subservice == CustomSubservice.TM_DATA_REPLY:
+        if PRINT_RAW_ACTION_DATA_REPLY_B64_STR:
+            print(f"PUS TM Base64: {base64.b64encode(raw_tm)}")
+        if object_id.as_bytes == IMTQ_HANDLER_ID:
+            return handle_imtq_replies(action_id, pw, custom_data)
+        elif object_id.as_bytes == PLOC_MPSOC_ID:
+            return handle_mpsoc_data_reply(action_id, pw, custom_data)
+        elif object_id.as_bytes == PLOC_SUPV_ID:
+            return handle_supervisor_replies(action_id, pw, custom_data)
+        elif object_id.as_bytes == CORE_CONTROLLER_ID:
+            return handle_core_ctrl_action_replies(action_id, pw, custom_data)
+        elif object_id.as_bytes == STAR_TRACKER_ID:
+            return handle_star_tracker_action_replies(action_id, pw, custom_data)
+        elif object_id.as_bytes == ACS_CONTROLLER:
+            return handle_acs_ctrl_action_replies(action_id, pw, custom_data)
+        elif object_id.as_bytes in [
+            ACU_HANDLER_ID,
+            PDU_1_HANDLER_ID,
+            PDU_2_HANDLER_ID,
+            P60_DOCK_HANDLER,
+        ]:
+            return handle_get_param_data_reply(object_id, action_id, pw, custom_data)
+        else:
+            # TODO: Could add a handler here depending on action ID and object ID.
+            handle_action_data_reply(tm_packet, object_id, action_id, pw)
     else:
-        pw.dlog(f"No dedicated action reply handler found for reply from {object_id}")
-        pw.dlog(f"Raw Data: {tm_packet.custom_data.hex(sep=',')}")
+        pw.dlog(
+            f"service 8 packet from {object_id} with action ID {action_id} "
+            f"and unknown subservice {tm_packet.subservice}"
+        )
 
 
-def handle_imtq_replies(action_id: int, pw: PrintWrapper, custom_data: bytearray):
+def handle_action_data_reply(
+    tm_packet: PusTm, named_obj_id: ObjectIdBase, action_id: int, printer: PrintWrapper
+):
+    print_string = (
+        f"service 8 data reply from {named_obj_id} with action ID {action_id} "
+        f"and data size {len(tm_packet.tm_data[8:])}"
+    )
+    printer.dlog(print_string)
+
+
+def handle_imtq_replies(action_id: int, pw: PrintWrapper, custom_data: bytes):
     if action_id == struct.unpack("!I", ImtqActionId.get_commanded_dipole)[0]:
         header_list = [
             "Commanded X-Dipole",
@@ -78,7 +107,7 @@ def handle_imtq_replies(action_id: int, pw: PrintWrapper, custom_data: bytearray
         pw.dlog(f"{content_list}")
 
 
-def handle_supervisor_replies(action_id: int, pw: PrintWrapper, custom_data: bytearray):
+def handle_supervisor_replies(action_id: int, pw: PrintWrapper, custom_data: bytes):
     if action_id == SupvActionId.DUMP_MRAM:
         header_list = ["MRAM Dump"]
         content_list = [custom_data[: len(custom_data)]]

eive_tmtc/pus_tm/event_handler.py

@@ -1,17 +1,19 @@
 import logging
 import datetime
 import sys
+import base64
 
+from eive_tmtc.config.definitions import PRINT_RAW_EVENTS_B64_STR
 from eive_tmtc.config.events import get_event_dict
 from eive_tmtc.config.object_ids import get_object_ids
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from eive_tmtc.pus_tm.verification_handler import generic_retval_printout
 from eive_tmtc.tmtc.acs.subsystem import AcsMode
 from eive_tmtc.tmtc.core import SdState, SdCardSelect
-from tmtccmd.tc.pus_200_fsfw_mode import Mode
-from tmtccmd.tc.pus_201_fsfw_health import FsfwHealth
+from tmtccmd.pus.s200_fsfw_mode import Mode
+from tmtccmd.pus.s201_fsfw_health import FsfwHealth
 
-from tmtccmd.tm import Service5Tm
+from tmtccmd.pus.s5_fsfw_event import Service5Tm
 from tmtccmd.fsfw import EventInfo
 from spacepackets.ccsds.time import CdsShortTimestamp
 
@@ -21,7 +23,9 @@ _LOGGER = logging.getLogger(__name__)
 def handle_event_packet(  # noqa C901: Complexity okay here
     raw_tm: bytes, pw: PrintWrapper
 ):  # noqa C901: Complexity okay here
-    tm = Service5Tm.unpack(data=raw_tm, time_reader=CdsShortTimestamp.empty())
+    if PRINT_RAW_EVENTS_B64_STR:
+        print(f"PUS Event TM Base64: {base64.b64encode(raw_tm)}")
+    tm = Service5Tm.unpack(data=raw_tm, timestamp_len=CdsShortTimestamp.TIMESTAMP_SIZE)
     event_dict = get_event_dict()
     event_def = tm.event_definition
     info = event_dict.get(event_def.event_id)
@@ -36,9 +40,10 @@ def handle_event_packet(  # noqa C901: Complexity okay here
         obj_name = event_def.reporter_id.hex(sep=",")
     else:
         obj_name = obj_id_obj.name
+    timestamp = CdsShortTimestamp.unpack(tm.timestamp)
     generic_event_string = (
         f"Object {obj_name} generated Event {info.name} (ID: {event_def.event_id:#04x})"
-        f" at {tm.time_provider.as_date_time()}"
+        f" at {timestamp.as_date_time()}"
     )
     _LOGGER.info(generic_event_string)
     pw.file_logger.info(
@@ -122,12 +127,22 @@ def handle_event_packet(  # noqa C901: Complexity okay here
         new_time_dt = datetime.datetime.fromtimestamp(new_time, datetime.timezone.utc)
         pw.dlog(f"Old time (UTC): {old_time_dt}")
         pw.dlog(f"New time (UTC): {new_time_dt}")
-    if info.name == "CLOCK_DUMP":
+    if info.name == "CLOCK_DUMP_LEGACY":
         specific_handler = True
         # param 1 is timeval seconds, param 2 is timeval subsecond milliseconds
         time = event_def.param1 + event_def.param2 / 1000.0
         time_dt = datetime.datetime.fromtimestamp(time, datetime.timezone.utc)
         pw.dlog(f"Current time: {time_dt}")
+    if (
+        info.name == "CLOCK_DUMP"
+        or info.name == "CLOCK_DUMP_BEFORE_SETTING_TIME"
+        or info.name == "CLOCK_DUMP_AFTER_SETTING_TIME"
+    ):
+        specific_handler = True
+        # param 1 is timeval seconds, param 2 is timeval subsecond microseconds
+        time = event_def.param1 + event_def.param2 / 1000000.0
+        time_dt = datetime.datetime.fromtimestamp(time, datetime.timezone.utc)
+        pw.dlog(f"Clock dump event {info.name}. Current time: {time_dt}")
     if info.name == "ACTIVE_SD_INFO":
         sd_0_state = (event_def.param2 >> 16) & 0xFFFF
         sd_1_state = event_def.param2 & 0xFFFF

eive_tmtc/pus_tm/hk.py

@@ -0,0 +1,18 @@
+import uuid
+import dataclasses
+import datetime
+import sqlite3
+from spacepackets.ecss.tm import CdsShortTimestamp, PusTm
+
+
+@dataclasses.dataclass
+class HkTmInfo:
+    packet_uuid: uuid.UUID
+    hk_packet: PusTm
+    set_id: int
+    db_con: sqlite3.Connection
+    hk_data: bytes
+
+    @property
+    def packet_datetime(self) -> datetime.datetime:
+        return CdsShortTimestamp.unpack(self.hk_packet.timestamp).as_datetime()

eive_tmtc/pus_tm/hk_handler.py

@@ -1,7 +1,17 @@
 """HK Handling for EIVE OBSW"""
+
 import dataclasses
 import logging
-from typing import List
+import base64
+import sqlite3
+import struct
+from typing import List, cast
+from uuid import UUID
+
+from spacepackets.ccsds.time import CdsShortTimestamp
+from spacepackets.ecss import PusTm
+from eive_tmtc.config.definitions import PRINT_RAW_HK_B64_STR
+from eive_tmtc.pus_tm.hk import HkTmInfo
 
 from eive_tmtc.tmtc.acs.acs_ctrl import handle_acs_ctrl_hk_data
 from eive_tmtc.tmtc.internal_err_reporter import handle_ier_hk_data
@@ -13,15 +23,11 @@ from eive_tmtc.tmtc.payload.rad_sensor import handle_rad_sensor_data
 from eive_tmtc.tmtc.acs.sus import handle_sus_hk
 from eive_tmtc.tmtc.payload.ploc_supervisor import handle_supv_hk_data
 from eive_tmtc.tmtc.acs.reaction_wheels import handle_rw_hk_data
+from eive_tmtc.tmtc.power.pwr_ctrl import handle_pwr_ctrl_hk_data
 from eive_tmtc.tmtc.com.syrlinks_handler import handle_syrlinks_hk_data
 from eive_tmtc.tmtc.tcs import handle_thermal_controller_hk_data
 from eive_tmtc.tmtc.tcs.tmp1075 import handle_tmp_1075_hk_data
-from spacepackets.ecss import PusTelemetry
-from tmtccmd.tm.pus_3_fsfw_hk import (
-    Service3Base,
-    HkContentType,
-    Service3FsfwTm,
-)
+from tmtccmd.pus.tm.s3_hk_base import HkContentType
 from tmtccmd.util.obj_id import ObjectIdU32, ObjectIdDictT
 
 from eive_tmtc.tmtc.power.bpx_batt import handle_bpx_hk_data
@@ -50,45 +56,54 @@ FORWARD_SENSOR_TEMPS = False
 
 @dataclasses.dataclass
 class HkFilter:
-    object_ids: List[ObjectIdU32]
+    object_ids: List[bytes]
     set_ids: List[int]
 
 
 def handle_hk_packet(
     raw_tm: bytes,
+    packet_uuid: UUID,
     obj_id_dict: ObjectIdDictT,
     printer: FsfwTmTcPrinter,
     hk_filter: HkFilter,
     hk_level: int,
+    db_con: sqlite3.Connection,
 ):
-    tm_packet = Service3FsfwTm.unpack(raw_telemetry=raw_tm, custom_hk_handling=False)
-    named_obj_id = obj_id_dict.get(tm_packet.object_id.as_bytes)
+    tm_packet = PusTm.unpack(raw_tm, CdsShortTimestamp.TIMESTAMP_SIZE)
+    obj_id_raw = struct.unpack("!I", tm_packet.tm_data[0:4])[0]
+    named_obj_id = cast(ObjectIdU32, obj_id_dict.get(obj_id_raw))
     if named_obj_id is None:
-        named_obj_id = tm_packet.object_id
+        named_obj_id = ObjectIdU32(obj_id_raw, "Unknown ID")
     if tm_packet.subservice == 25 or tm_packet.subservice == 26:
+        set_id = struct.unpack("!I", tm_packet.tm_data[4:8])[0]
         hk_data = tm_packet.tm_data[8:]
-
-        if named_obj_id in hk_filter.object_ids:
+        if named_obj_id.as_bytes in hk_filter.object_ids:
+            if PRINT_RAW_HK_B64_STR:
+                print(f"PUS TM Base64: {base64.b64encode(raw_tm)}")
             handle_regular_hk_print(
                 printer=printer,
+                set_id=set_id,
+                packet_uuid=packet_uuid,
                 object_id=named_obj_id,
                 hk_packet=tm_packet,
-                tm=tm_packet.pus_tm,
                 hk_data=hk_data,
+                db=db_con,
             )
             return
         try:
             if hk_level >= 1:
                 printer.generic_hk_tm_print(
-                    HkContentType.HK, named_obj_id, tm_packet.set_id, hk_data
+                    HkContentType.HK, named_obj_id, set_id, hk_data
                 )
             if hk_level >= 1:
                 handle_regular_hk_print(
                     printer=printer,
+                    set_id=set_id,
+                    packet_uuid=packet_uuid,
                     object_id=named_obj_id,
                     hk_packet=tm_packet,
-                    tm=tm_packet.pus_tm,
                     hk_data=hk_data,
+                    db=db_con,
                 )
         except ValueError as e:
             _LOGGER.exception(
@@ -99,26 +114,41 @@ def handle_hk_packet(
 
 
 def handle_regular_hk_print(  # noqa C901: Complexity okay here
-    printer: FsfwTmTcPrinter,
-    object_id: ObjectIdU32,
-    hk_packet: Service3Base,
-    tm: PusTelemetry,
+    hk_packet: PusTm,
+    set_id: int,
+    packet_uuid: UUID,
     hk_data: bytes,
+    db: sqlite3.Connection,
+    object_id: ObjectIdU32,
+    printer: FsfwTmTcPrinter,
 ):
     objb = object_id.as_bytes
-    set_id = hk_packet.set_id
-    packet_dt = tm.time_provider.as_date_time()
+    hk_info = HkTmInfo(
+        packet_uuid=packet_uuid,
+        hk_packet=hk_packet,
+        db_con=db,
+        hk_data=hk_data,
+        set_id=set_id,
+    )
+    timestamp = CdsShortTimestamp.unpack(hk_packet.timestamp)
+    packet_dt = timestamp.as_datetime()
     pw = PrintWrapper(printer.file_logger)
     """This function is called when a Service 3 Housekeeping packet is received."""
     if objb in [obj_ids.RW1_ID, obj_ids.RW2_ID, obj_ids.RW3_ID, obj_ids.RW4_ID]:
         return handle_rw_hk_data(pw, object_id, set_id, hk_data)
     elif objb == obj_ids.SYRLINKS_HANDLER_ID:
-        return handle_syrlinks_hk_data(pw=pw, hk_data=hk_data, set_id=set_id)
+        return handle_syrlinks_hk_data(
+            hk_info=hk_info,
+            pw=pw,
+        )
     elif objb == obj_ids.IMTQ_HANDLER_ID:
         return handle_imtq_hk(pw=pw, hk_data=hk_data, set_id=set_id)
     elif objb == obj_ids.GPS_CONTROLLER:
         return handle_gps_data(
-            pw=pw, set_id=set_id, hk_data=hk_data, packet_time=packet_dt
+            pw=pw,
+            set_id=set_id,
+            hk_data=hk_data,
+            packet_time=timestamp.as_datetime(),
         )
     elif objb == obj_ids.PCDU_HANDLER_ID:
         return handle_pcdu_hk(pw=pw, set_id=set_id, hk_data=hk_data)
@@ -127,9 +157,21 @@ def handle_regular_hk_print(  # noqa C901: Complexity okay here
     elif objb == obj_ids.CORE_CONTROLLER_ID:
         return handle_core_hk_data(pw=pw, hk_data=hk_data, set_id=set_id)
     elif objb == obj_ids.PDU_1_HANDLER_ID:
-        return handle_pdu_data(pw=pw, pdu_idx=1, set_id=set_id, hk_data=hk_data)
+        return handle_pdu_data(
+            hk_info=hk_info,
+            pw=pw,
+            pdu_idx=1,
+            set_id=set_id,
+            hk_data=hk_data,
+        )
     elif objb == obj_ids.PDU_2_HANDLER_ID:
-        return handle_pdu_data(pw=pw, pdu_idx=2, set_id=set_id, hk_data=hk_data)
+        return handle_pdu_data(
+            hk_info=hk_info,
+            pw=pw,
+            pdu_idx=2,
+            set_id=set_id,
+            hk_data=hk_data,
+        )
     elif objb == obj_ids.PLOC_MPSOC_ID:
         return handle_ploc_mpsoc_hk_data(pw=pw, hk_data=hk_data, set_id=set_id)
     elif objb == obj_ids.ACU_HANDLER_ID:
@@ -201,6 +243,10 @@ def handle_regular_hk_print(  # noqa C901: Complexity okay here
         return handle_acs_ctrl_hk_data(
             pw=pw, set_id=set_id, hk_data=hk_data, packet_time=packet_dt
         )
+    elif objb == obj_ids.PWR_CONTROLLER:
+        return handle_pwr_ctrl_hk_data(
+            pw=pw, set_id=set_id, hk_data=hk_data, packet_time=packet_dt
+        )
     else:
         _LOGGER.info(
             f"Service 3 TM: Parsing for object {object_id} and set ID {set_id} "

eive_tmtc/pus_tm/pus_demux.py

@@ -1,125 +0,0 @@
-"""Core EIVE TM handler module
-"""
-import logging
-
-from eive_tmtc.config.object_ids import get_object_ids
-from spacepackets.ecss import PusTelemetry
-from spacepackets.ecss.pus_17_test import Service17Tm
-from spacepackets.util import PrintFormats
-from spacepackets.ccsds.time import CdsShortTimestamp
-from tmtccmd.logging.pus import RawTmtcTimedLogWrapper
-from tmtccmd.pus import VerificationWrapper
-from tmtccmd.tm import Service20FsfwTm, Service200FsfwTm
-from tmtccmd.tm.pus_20_fsfw_param import Service20ParamDumpWrapper
-from tmtccmd.pus.s20_fsfw_param_defs import CustomSubservice as ParamSubservice
-from tmtccmd.tm.pus_200_fsfw_mode import Subservice as ModeSubservice
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
-from .defs import PrintWrapper
-
-from .event_handler import handle_event_packet
-from .verification_handler import handle_service_1_fsfw_packet, generic_retval_printout
-from .hk_handler import handle_hk_packet, HkFilter
-from .action_reply_handler import handle_action_reply
-
-_LOGGER = logging.getLogger(__name__)
-
-
-def pus_factory_hook(  # noqa C901 : Complexity okay here
-    packet: bytes,
-    verif_wrapper: VerificationWrapper,
-    printer: FsfwTmTcPrinter,
-    raw_logger: RawTmtcTimedLogWrapper,
-    hk_level: int,
-    hk_filter: HkFilter,
-):
-    if len(packet) < 8:
-        _LOGGER.warning("Detected packet shorter than 8 bytes!")
-        return
-    try:
-        tm_packet = PusTelemetry.unpack(packet, CdsShortTimestamp.empty())
-        # _LOGGER.info(f"Sequence count: {tm_packet.seq_count}")
-    except ValueError as value_error:
-        _LOGGER.warning(f"{value_error}")
-        _LOGGER.warning("Could not generate PUS TM object from raw data")
-        _LOGGER.warning(f"Raw Packet: [{packet.hex(sep=',')}], REPR: {packet!r}")
-        return
-    service = tm_packet.service
-    obj_id_dict = get_object_ids()
-    pw = PrintWrapper(printer.file_logger)
-    dedicated_handler = True
-    if service == 1:
-        handle_service_1_fsfw_packet(wrapper=verif_wrapper, raw_tm=packet)
-    elif service == 3:
-        handle_hk_packet(
-            printer=printer,
-            raw_tm=packet,
-            obj_id_dict=obj_id_dict,
-            hk_level=hk_level,
-            hk_filter=hk_filter,
-        )
-    elif service == 5:
-        handle_event_packet(raw_tm=packet, pw=pw)
-    elif service == 8:
-        handle_action_reply(raw_tm=packet, printer=printer, obj_id_dict=obj_id_dict)
-    elif service == 17:
-        tm_packet = Service17Tm.unpack(
-            data=packet, time_reader=CdsShortTimestamp.empty()
-        )
-        if tm_packet.subservice == 2:
-            verif_wrapper.dlog("Received Ping Reply TM[17,2]")
-        dedicated_handler = True
-    elif service == 20:
-        param_packet = Service20FsfwTm.unpack(
-            raw_telemetry=packet, time_reader=CdsShortTimestamp.empty()
-        )
-        if tm_packet.subservice == ParamSubservice.TM_DUMP_REPLY:
-            param_wrapper = Service20ParamDumpWrapper(param_tm=param_packet)
-            try:
-                param = param_wrapper.get_param()
-                obj = obj_id_dict.get(param_wrapper.param_tm.object_id)
-                pw.dlog(f"Received parameter dump TM from {obj}")
-                pw.dlog(f"Parameter: {param}")
-                if param.rows == 1 and param.columns == 1:
-                    try:
-                        scalar_param = param.parse_scalar_param()
-                        if isinstance(scalar_param, int):
-                            pw.dlog(f"Scalar integer parameter: {scalar_param}")
-                        elif isinstance(scalar_param, float):
-                            pw.dlog(f"Scalar floating point parameter: {scalar_param}")
-                    except ValueError as e:
-                        pw.dlog(f"received {e} trying to parse scalar parameter")
-                else:
-                    # TODO: Could improve display further by actually displaying a matrix as a
-                    #       matrix using row and column information
-                    pw.dlog(
-                        "Received vector or matrix data:"
-                        f" {param.param_raw.hex(sep=',')}"
-                    )
-            except ValueError as e:
-                pw.dlog(f"received {e} when trying to parse parameters")
-            except NotImplementedError as e:
-                pw.dlog(f"received {e} when trying to parse parameters")
-        else:
-            pw.dlog(f"unknown subservice {tm_packet.subservice} for parameter service")
-    elif service == 200:
-        tm_packet = Service200FsfwTm.unpack(
-            raw_telemetry=packet, time_reader=CdsShortTimestamp.empty()
-        )
-        if tm_packet.subservice == ModeSubservice.TM_CANT_REACH_MODE:
-            obj_id = tm_packet.object_id
-            obj_id_obj = obj_id_dict.get(obj_id)
-            retval = tm_packet.return_value
-            string_list = generic_retval_printout(retval)
-            pw.dlog(f"Received Mode Reply from {obj_id_obj}: Can't reach mode.")
-            for string in string_list:
-                pw.dlog(f"Reason: {string}")
-            dedicated_handler = True
-        else:
-            dedicated_handler = False
-    else:
-        _LOGGER.info(f"The service {service} is not implemented in Telemetry Factory")
-        tm_packet.print_source_data(PrintFormats.HEX)
-        dedicated_handler = True
-    if not dedicated_handler and tm_packet is not None:
-        printer.handle_long_tm_print(packet_if=tm_packet, info_if=tm_packet)
-    raw_logger.log_tm(tm_packet)

eive_tmtc/pus_tm/pus_handler.py

@@ -0,0 +1,218 @@
+"""Core EIVE TM handler module
+"""
+
+import logging
+import sqlite3
+import uuid
+from typing import Any
+
+from spacepackets.ccsds.time import CdsShortTimestamp
+from spacepackets.ecss import PusTelemetry
+from spacepackets.ecss.pus_17_test import Service17Tm
+from spacepackets.util import PrintFormats
+from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.logging.pus import RawTmtcTimedLogWrapper
+from tmtccmd.pus import VerificationWrapper
+from tmtccmd.pus.s20_fsfw_param import Service20FsfwTm, Service20ParamDumpWrapper
+from tmtccmd.pus.s20_fsfw_param_defs import CustomSubservice as ParamSubservice
+from tmtccmd.pus.s200_fsfw_mode import Service200FsfwReader, Service200FsfwTm
+from tmtccmd.pus.s200_fsfw_mode import Subservice as ModeSubservice
+from tmtccmd.tmtc import GenericApidHandlerBase, SpecificApidHandlerBase
+from eive_tmtc.config.definitions import TM_DB_PATH, PUS_APID
+
+from eive_tmtc.config.object_ids import get_object_ids
+
+from .action_reply_handler import handle_action_service_tm
+from .defs import PrintWrapper
+from .event_handler import handle_event_packet
+from .hk_handler import HkFilter, handle_hk_packet
+from .verification_handler import generic_retval_printout, handle_service_1_fsfw_packet
+
+_LOGGER = logging.getLogger(__name__)
+
+
+class PusHandler(SpecificApidHandlerBase):
+    def __init__(
+        self,
+        wrapper: VerificationWrapper,
+        printer: FsfwTmTcPrinter,
+        raw_logger: RawTmtcTimedLogWrapper,
+        hk_level: int,
+    ):
+        super().__init__(PUS_APID, None)
+        self.printer = printer
+        self.verif_wrapper = wrapper
+        self.raw_logger = raw_logger
+        self.hk_level = hk_level
+        self.these_objs_hk_only = []
+        self.hk_filter = HkFilter(object_ids=self.these_objs_hk_only, set_ids=[])
+        self.obj_id_dict = get_object_ids()
+        self.pw = PrintWrapper(printer.file_logger)
+
+    def handle_tm(self, packet: bytes, _user_args: Any):
+        self.pus_handler(
+            packet,
+        )
+
+    def pus_handler(  # noqa C901 : Complexity okay here
+        self,
+        packet: bytes,
+    ):
+        packet_uuid = uuid.uuid4()
+        if len(packet) < 8:
+            _LOGGER.warning("Detected packet shorter than 8 bytes!")
+            return
+        try:
+            tm_packet = PusTelemetry.unpack(packet, CdsShortTimestamp.TIMESTAMP_SIZE)
+            # _LOGGER.info(f"Sequence count: {tm_packet.seq_count}")
+        except ValueError as value_error:
+            _LOGGER.warning(f"{value_error}")
+            _LOGGER.warning("Could not generate PUS TM object from raw data")
+            _LOGGER.warning(f"Raw Packet: [{packet.hex(sep=',')}], REPR: {packet!r}")
+            return
+        timestamp = CdsShortTimestamp.unpack(tm_packet.timestamp)
+        db_con = sqlite3.connect(TM_DB_PATH)
+        self._store_packet_in_db(
+            db_con=db_con,
+            packet=packet,
+            tm_packet=tm_packet,
+            timestamp=timestamp,
+            packet_uuid=packet_uuid,
+        )
+        service = tm_packet.service
+        dedicated_handler = True
+        if service == 1:
+            handle_service_1_fsfw_packet(wrapper=self.verif_wrapper, raw_tm=packet)
+        elif service == 3:
+            handle_hk_packet(
+                db_con=db_con,
+                packet_uuid=packet_uuid,
+                printer=self.printer,
+                raw_tm=packet,
+                obj_id_dict=self.obj_id_dict,
+                hk_level=self.hk_level,
+                hk_filter=self.hk_filter,
+            )
+        elif service == 5:
+            handle_event_packet(raw_tm=packet, pw=self.pw)
+        elif service == 8:
+            handle_action_service_tm(
+                raw_tm=packet, pw=self.pw, obj_id_dict=self.obj_id_dict
+            )
+        elif service == 17:
+            pus17_tm = Service17Tm.unpack(
+                data=packet, timestamp_len=CdsShortTimestamp.TIMESTAMP_SIZE
+            )
+            if pus17_tm.subservice == 2:
+                self.verif_wrapper.dlog("Received Ping Reply TM[17,2]")
+            dedicated_handler = True
+        elif service == 20:
+            self._handle_param_packet(packet, tm_packet)
+        elif service == 200:
+            dedicated_handler = self._handle_mode_packet(tm_packet)
+        else:
+            _LOGGER.info(
+                f"The service {service} is not implemented in Telemetry Factory"
+            )
+            tm_packet.print_source_data(PrintFormats.HEX)
+            dedicated_handler = True
+        if not dedicated_handler and tm_packet is not None:
+            _LOGGER.info(
+                f"TM [{service},{tm_packet.subservice}] does not have a dedicated handler"
+            )
+        self.raw_logger.log_tm(tm_packet)
+
+    def _store_packet_in_db(
+        self,
+        db_con: sqlite3.Connection,
+        packet: bytes,
+        timestamp: CdsShortTimestamp,
+        tm_packet: PusTelemetry,
+        packet_uuid: uuid.UUID,
+    ):
+        cursor = db_con.cursor()
+        cursor.execute(
+            """
+            CREATE TABLE IF NOT EXISTS pus_tm(
+                packet_uuid TEXT PRIMARY KEY,
+                generation_time TEXT,
+                service NUM,
+                subservice NUM,
+                data_len NUM,
+                raw_data BLOB
+            )"""
+        )
+        cursor.execute(
+            "INSERT INTO pus_tm VALUES(?, ?, ?, ?, ?, ?)",
+            (
+                str(packet_uuid),
+                timestamp.as_datetime(),
+                tm_packet.service,
+                tm_packet.subservice,
+                len(packet),
+                packet,
+            ),
+        )
+        db_con.commit()
+
+    def _handle_param_packet(self, raw_data: bytes, tm_packet: PusTelemetry):
+        param_packet = Service20FsfwTm.unpack(
+            raw_telemetry=raw_data, timestamp_len=CdsShortTimestamp.TIMESTAMP_SIZE
+        )
+        if tm_packet.subservice == ParamSubservice.TM_DUMP_REPLY:
+            param_wrapper = Service20ParamDumpWrapper(param_tm=param_packet)
+            try:
+                param = param_wrapper.get_param()
+                obj = self.obj_id_dict.get(param_wrapper.param_tm.object_id)
+                self.pw.dlog(f"Received parameter dump TM from {obj}")
+                self.pw.dlog(f"Parameter: {param}")
+                if param.rows == 1 and param.columns == 1:
+                    try:
+                        scalar_param = param.parse_scalar_param()
+                        if isinstance(scalar_param, int):
+                            self.pw.dlog(f"Scalar integer parameter: {scalar_param}")
+                        elif isinstance(scalar_param, float):
+                            self.pw.dlog(
+                                f"Scalar floating point parameter: {scalar_param}"
+                            )
+                    except ValueError as e:
+                        self.pw.dlog(f"received {e} trying to parse scalar parameter")
+                else:
+                    # TODO: Could improve display further by actually displaying a matrix as a
+                    #       matrix using row and column information
+                    self.pw.dlog(
+                        "Received vector or matrix data:"
+                        f" {param.param_raw.hex(sep=',')}"
+                    )
+            except ValueError as e:
+                self.pw.dlog(f"received {e} when trying to parse parameters")
+            except NotImplementedError as e:
+                self.pw.dlog(f"received {e} when trying to parse parameters")
+        else:
+            self.pw.dlog(
+                f"unknown subservice {tm_packet.subservice} for parameter service"
+            )
+
+    def _handle_mode_packet(self, pus_tm: PusTelemetry) -> bool:
+        tm_packet = Service200FsfwReader(pus_tm)
+        if tm_packet.tm.subservice == ModeSubservice.TM_CANT_REACH_MODE:
+            obj_id = tm_packet.object_id
+            obj_id_obj = self.obj_id_dict.get(obj_id)
+            retval = tm_packet.return_value
+            assert retval is not None
+            string_list = generic_retval_printout(retval)
+            self.pw.dlog(f"Received Mode Reply from {obj_id_obj}: Can't reach mode.")
+            for string in string_list:
+                self.pw.dlog(f"Reason: {string}")
+            return True
+        if tm_packet.tm.subservice == ModeSubservice.TM_WRONG_MODE_REPLY:
+            self.pw.dlog(f"Received Mode TM wrong mode reply, mode: {tm_packet.mode}")
+            return True
+        return False
+
+
+class UnknownApidHandler(GenericApidHandlerBase):
+    def handle_tm(self, apid: int, packet: bytes, _user_args: Any):
+        _LOGGER.warning(
+            f"Packet with unknown APID {apid} detected: {packet.hex(sep=',')}"
+        )

eive_tmtc/pus_tm/verification_handler.py

@@ -4,7 +4,7 @@ from typing import List, Optional
 from spacepackets.ccsds import CdsShortTimestamp
 from spacepackets.ecss.pus_1_verification import UnpackParams, Service1Tm
 from tmtccmd.pus import VerificationWrapper
-from tmtccmd.tm.pus_1_verification import Service1FsfwWrapper
+from tmtccmd.pus.s1_verification import Service1FsfwWrapper
 from eive_tmtc.config.retvals import get_retval_dict
 
 _LOGGER = logging.getLogger(__name__)
@@ -17,7 +17,7 @@ def handle_service_1_fsfw_packet(wrapper: VerificationWrapper, raw_tm: bytes):
         )
     # Error code with length 2 is FSFW specific
     tm_packet = Service1Tm.unpack(
-        data=raw_tm, params=UnpackParams(CdsShortTimestamp.empty(), 1, 2)
+        data=raw_tm, params=UnpackParams(CdsShortTimestamp.TIMESTAMP_SIZE, 1, 2)
     )
     fsfw_wrapper = Service1FsfwWrapper(tm_packet)
     res = wrapper.verificator.add_tm(tm_packet)

eive_tmtc/tmtc/__init__.py

@@ -1,8 +1,3 @@
-from .payload.subsystem import add_payload_subsystem_cmds
-from .solar_array_deployment import add_sa_depl_cmds
-from .test import add_test_defs
-from .time import add_time_cmds
-from .health import add_health_cmd_defs
 from .system import add_system_cmd_defs
 from .tm_store import add_persistent_tm_store_cmd_defs
 from .tcs import add_tmp_sens_cmds

eive_tmtc/tmtc/acs/acs_board.py

@@ -1,16 +1,16 @@
 import enum
 
-from eive_tmtc.config.definitions import CustomServiceList
 from tmtccmd.config.tmtc import (
-    tmtc_definitions_provider,
-    TmtcDefinitionWrapper,
+    CmdTreeNode,
     OpCodeEntry,
+    TmtcDefinitionWrapper,
+    tmtc_definitions_provider,
 )
-from tmtccmd.tc import service_provider, DefaultPusQueueHelper
-from tmtccmd.tc.decorator import ServiceProviderParams
-from tmtccmd.tc.pus_200_fsfw_mode import Mode
-from eive_tmtc.config.object_ids import ACS_BOARD_ASS_ID
+from tmtccmd.pus.s200_fsfw_mode import Mode
+from tmtccmd.tmtc import DefaultPusQueueHelper
 
+from eive_tmtc.config.definitions import CustomServiceList
+from eive_tmtc.config.object_ids import ACS_BOARD_ASS_ID
 from eive_tmtc.tmtc.common import pack_mode_cmd_with_info
 
 
@@ -30,8 +30,8 @@ class DualSideSubmode(enum.IntEnum):
     DUAL_SIDE = 2
 
 
-def pack_acs_command(q: DefaultPusQueueHelper, op_code: str):
-    if op_code in AcsOpCodes.ACS_ASS_A_SIDE:
+def pack_acs_board_command(q: DefaultPusQueueHelper, cmd_str: str):
+    if cmd_str in AcsOpCodes.ACS_ASS_A_SIDE:
         pack_mode_cmd_with_info(
             object_id=ACS_BOARD_ASS_ID,
             mode=Mode.NORMAL,
@@ -39,7 +39,7 @@ def pack_acs_command(q: DefaultPusQueueHelper, op_code: str):
             q=q,
             info="Switching to ACS board assembly A side",
         )
-    if op_code in AcsOpCodes.ACS_ASS_B_SIDE:
+    if cmd_str in AcsOpCodes.ACS_ASS_B_SIDE:
         pack_mode_cmd_with_info(
             object_id=ACS_BOARD_ASS_ID,
             mode=Mode.NORMAL,
@@ -47,7 +47,7 @@ def pack_acs_command(q: DefaultPusQueueHelper, op_code: str):
             q=q,
             info="Switching to ACS board assembly B side",
         )
-    if op_code in AcsOpCodes.ACS_ASS_DUAL_MODE:
+    if cmd_str in AcsOpCodes.ACS_ASS_DUAL_MODE:
         pack_mode_cmd_with_info(
             object_id=ACS_BOARD_ASS_ID,
             mode=Mode.NORMAL,
@@ -55,7 +55,7 @@ def pack_acs_command(q: DefaultPusQueueHelper, op_code: str):
             q=q,
             info="Switching to ACS board assembly dual mode",
         )
-    if op_code in AcsOpCodes.ACS_ASS_A_ON:
+    if cmd_str in AcsOpCodes.ACS_ASS_A_ON:
         pack_mode_cmd_with_info(
             object_id=ACS_BOARD_ASS_ID,
             mode=Mode.ON,
@@ -63,7 +63,7 @@ def pack_acs_command(q: DefaultPusQueueHelper, op_code: str):
             q=q,
             info="Switching ACS board assembly A side on",
         )
-    if op_code in AcsOpCodes.ACS_ASS_B_ON:
+    if cmd_str in AcsOpCodes.ACS_ASS_B_ON:
         pack_mode_cmd_with_info(
             object_id=ACS_BOARD_ASS_ID,
             mode=Mode.ON,
@@ -71,7 +71,7 @@ def pack_acs_command(q: DefaultPusQueueHelper, op_code: str):
             q=q,
             info="Switching ACS board assembly B side on",
         )
-    if op_code in AcsOpCodes.ACS_ASS_DUAL_ON:
+    if cmd_str in AcsOpCodes.ACS_ASS_DUAL_ON:
         pack_mode_cmd_with_info(
             object_id=ACS_BOARD_ASS_ID,
             mode=Mode.ON,
@@ -79,7 +79,7 @@ def pack_acs_command(q: DefaultPusQueueHelper, op_code: str):
             q=q,
             info="Switching ACS board assembly dual side on",
         )
-    if op_code in AcsOpCodes.ACS_ASS_OFF:
+    if cmd_str in AcsOpCodes.ACS_ASS_OFF:
         pack_mode_cmd_with_info(
             object_id=ACS_BOARD_ASS_ID,
             mode=Mode.OFF,
@@ -89,11 +89,51 @@ def pack_acs_command(q: DefaultPusQueueHelper, op_code: str):
         )
 
 
-@service_provider(CustomServiceList.ACS_BRD_ASS)
-def pack_acs_command_provider(p: ServiceProviderParams):
-    op_code = p.op_code
-    q = p.queue_helper
-    pack_acs_command(q, op_code)
+def create_acs_board_node() -> CmdTreeNode:
+    node = CmdTreeNode("acs_brd", "ACS Board", hide_children_which_are_leaves=True)
+    node.add_child(
+        CmdTreeNode(
+            AcsOpCodes.ACS_ASS_A_SIDE[1],
+            "Switch to ACS board A side",
+        )
+    )
+    node.add_child(
+        CmdTreeNode(
+            AcsOpCodes.ACS_ASS_B_SIDE[1],
+            "Switch to ACS board B side",
+        )
+    )
+    node.add_child(
+        CmdTreeNode(
+            AcsOpCodes.ACS_ASS_DUAL_MODE[1],
+            "Switch to ACS board dual mode",
+        )
+    )
+    node.add_child(
+        CmdTreeNode(
+            AcsOpCodes.ACS_ASS_A_ON[1],
+            "Switch ACS board A side on",
+        )
+    )
+    node.add_child(
+        CmdTreeNode(
+            AcsOpCodes.ACS_ASS_B_ON[1],
+            "Switch ACS board B side on",
+        )
+    )
+    node.add_child(
+        CmdTreeNode(
+            AcsOpCodes.ACS_ASS_DUAL_ON[1],
+            "Switch ACS board dual mode on",
+        )
+    )
+    node.add_child(
+        CmdTreeNode(
+            AcsOpCodes.ACS_ASS_OFF[1],
+            "Switch off ACS board",
+        )
+    )
+    return node
 
 
 @tmtc_definitions_provider

eive_tmtc/tmtc/acs/acs_ctrl.py

@@ -1,49 +1,40 @@
 import datetime
 import enum
 import logging
+import math
 import socket
 import struct
-import math
 from socket import AF_INET
 from typing import Tuple
 
-from eive_tmtc.config.definitions import CustomServiceList
+from tmtccmd.config.tmtc import CmdTreeNode
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
+from tmtccmd.pus.s8_fsfw_action import create_action_cmd
+from tmtccmd.pus.s20_fsfw_param import create_load_param_cmd
+from tmtccmd.pus.s20_fsfw_param_defs import (
+    create_matrix_double_parameter,
+    create_matrix_float_parameter,
+    create_scalar_double_parameter,
+    create_scalar_float_parameter,
+    create_scalar_i32_parameter,
+    create_scalar_u8_parameter,
+    create_scalar_u16_parameter,
+    create_vector_double_parameter,
+    create_vector_float_parameter,
+)
+from tmtccmd.pus.s200_fsfw_mode import Mode, pack_mode_command
+from tmtccmd.pus.tc.s3_fsfw_hk import (
+    create_request_one_diag_command,
+    create_request_one_hk_command,
+    disable_periodic_hk_command,
+    enable_periodic_hk_command_with_interval,
+    make_sid,
+)
+from tmtccmd.tmtc.queue import DefaultPusQueueHelper
+
 from eive_tmtc.config.object_ids import ACS_CONTROLLER
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from eive_tmtc.tmtc.acs.defs import AcsMode, SafeSubmode
-from tmtccmd.config.tmtc import (
-    tmtc_definitions_provider,
-    TmtcDefinitionWrapper,
-    OpCodeEntry,
-)
-from tmtccmd.tc import service_provider
-from tmtccmd.tc.queue import DefaultPusQueueHelper
-from tmtccmd.tc.pus_200_fsfw_mode import Mode, pack_mode_command
-from tmtccmd.tc.decorator import ServiceProviderParams
-from tmtccmd.tc.pus_3_fsfw_hk import (
-    generate_one_hk_command,
-    make_sid,
-    enable_periodic_hk_command_with_interval,
-    disable_periodic_hk_command,
-    create_request_one_diag_command,
-)
-from tmtccmd.pus.s8_fsfw_funccmd import create_action_cmd
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
-
-from tmtccmd.tc.pus_20_fsfw_param import create_load_param_cmd
-
-from tmtccmd.pus.s20_fsfw_param_defs import (
-    create_scalar_u8_parameter,
-    create_scalar_u16_parameter,
-    create_scalar_i32_parameter,
-    create_scalar_float_parameter,
-    create_scalar_double_parameter,
-    create_vector_float_parameter,
-    create_vector_double_parameter,
-    create_matrix_float_parameter,
-    create_matrix_double_parameter,
-)
-
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -56,10 +47,17 @@ class SetId(enum.IntEnum):
     GYR_RAW_SET = 4
     GYR_PROC_SET = 5
     GPS_PROC_SET = 6
-    MEKF_DATA = 7
+    ATTITUDE_ESTIMATION_DATA = 7
     CTRL_VAL_DATA = 8
     ACTUATOR_CMD_DATA = 9
     FUSED_ROT_RATE_DATA = 10
+    FUSED_ROT_RATE_SOURCE_DATA = 11
+
+
+class DataSetRequest(enum.IntEnum):
+    ONESHOT = 0
+    ENABLE = 1
+    DISABLE = 2
 
 
 class ActionId(enum.IntEnum):
@@ -67,6 +65,8 @@ class ActionId(enum.IntEnum):
     RESET_MEKF = 1
     RESTORE_MEKF_NONFINITE_RECOVERY = 2
     UPDATE_TLE = 3
+    READ_TLE = 4
+    UPDATE_MEKF_STANDARD_DEVIATIONS = 5
 
 
 CTRL_STRAT_DICT = {
@@ -87,67 +87,47 @@ CTRL_STRAT_DICT = {
     19: "SAFE_ECLIPSE_IDELING",
     20: "DETUMBLE_FULL",
     21: "DETUMBLE_DETERIORATED",
-    30: "PTG_MEKF",
-    31: "PTG_RAW",
+    100: "PTG_MEKF",
+    101: "PTG_STR",
+    102: "PTG_QUEST",
 }
 
-GPS_COURCE_DICT = {
+GPS_SOURCE_DICT = {
     0: "NONE",
     1: "GPS",
     2: "GPS_EXTRAPOLATED",
     3: "SGP4",
 }
 
+FUSED_ROT_RATE_SOURCE_DICT = {
+    0: "NONE",
+    1: "SUSMGM",
+    2: "QUEST",
+    3: "STR",
+}
+
 
 class OpCodes:
-    OFF = ["off"]
-    SAFE = ["safe"]
-    DTBL = ["safe_detumble"]
-    IDLE = ["ptg_idle"]
-    NADIR = ["ptg_nadir"]
-    TARGET = ["ptg_target"]
-    GS = ["ptg_target_gs"]
-    INERTIAL = ["ptg_inertial"]
-    SAFE_PTG = ["confirm_deployment"]
-    RESET_MEKF = ["reset_mekf"]
-    RESTORE_MEKF_NONFINITE_RECOVERY = ["restore_mekf_nonfinite_recovery"]
-    UPDATE_TLE = ["update_tle"]
-    SET_PARAMETER_SCALAR = ["set_scalar_param"]
-    SET_PARAMETER_VECTOR = ["set_vector_param"]
-    SET_PARAMETER_MATRIX = ["set_matrix_param"]
-    REQUEST_RAW_MGM_HK = ["mgm_raw_hk"]
-    ENABLE_RAW_MGM_HK = ["mgm_raw_enable_hk"]
-    DISABLE_RAW_MGM_HK = ["mgm_raw_disable_hk"]
-    REQUEST_PROC_MGM_HK = ["mgm_proc_hk"]
-    ENABLE_PROC_MGM_HK = ["mgm_proc_enable_hk"]
-    DISABLE_PROC_MGM_HK = ["mgm_proc_disable_hk"]
-    REQUEST_RAW_SUS_HK = ["sus_raw_hk"]
-    ENABLE_RAW_SUS_HK = ["sus_raw_enable_hk"]
-    DISABLE_RAW_SUS_HK = ["sus_raw_disable_hk"]
-    REQUEST_PROC_SUS_HK = ["sus_proc_hk"]
-    ENABLE_PROC_SUS_HK = ["sus_proc_enable_hk"]
-    DISABLE_PROC_SUS_HK = ["sus_proc_disable_hk"]
-    REQUEST_RAW_GYR_HK = ["gyr_raw_hk"]
-    ENABLE_RAW_GYR_HK = ["gyr_raw_enable_hk"]
-    DISABLE_RAW_GYR_HK = ["gyr_raw_disable_hk"]
-    REQUEST_PROC_GYR_HK = ["gyr_proc_hk"]
-    ENABLE_PROC_GYR_HK = ["gyr_proc_enable_hk"]
-    DISABLE_PROC_GYR_HK = ["gyr_proc_disable_hk"]
-    REQUEST_PROC_GPS_HK = ["gps_proc_hk"]
-    ENABLE_PROC_GPS_HK = ["gps_proc_enable_hk"]
-    DISABLE_PROC_GPS_HK = ["gps_proc_disable_hk"]
-    REQUEST_MEKF_HK = ["mekf_hk"]
-    ENABLE_MEKF_HK = ["mekf_enable_hk"]
-    DISABLE_MEKF_HK = ["mekf_disable_hk"]
-    REQUEST_CTRL_VAL_HK = ["ctrl_val_hk"]
-    ENABLE_CTRL_VAL_HK = ["ctrl_val_enable_hk"]
-    DISABLE_CTRL_VAL_HK = ["ctrl_val_disable_hk"]
-    REQUEST_ACT_CMD_HK = ["act_cmd_hk"]
-    ENABLE_ACT_CMD_HK = ["act_cmd_enable_hk"]
-    DISABLE_ACT_CMD_HK = ["act_cmd_disable_hk"]
-    REQUEST_FUSED_ROT_RATE_HK = ["f_rot_rate_hk"]
-    ENABLE_FUSED_ROT_RATE_HK = ["f_rot_rate_enable_hk"]
-    DISABLE_FUSED_ROT_RATE_HK = ["f_rot_rate_disable_hk"]
+    OFF = "off"
+    SAFE = "safe"
+    DTBL = "safe_detumble"
+    IDLE = "ptg_idle"
+    NADIR = "ptg_nadir"
+    TARGET = "ptg_target"
+    GS = "ptg_target_gs"
+    INERTIAL = "ptg_inertial"
+    SAFE_PTG = "confirm_deployment"
+    RESET_MEKF = "reset_mekf"
+    RESTORE_MEKF_NONFINITE_RECOVERY = "restore_mekf_nonfinite_recovery"
+    UPDATE_TLE = "update_tle"
+    READ_TLE = "read_tle"
+    UPDATE_MEKF_STANDARD_DEVIATIONS = "update_mekf_standard_deviations"
+    SET_PARAMETER_SCALAR = "set_scalar_param"
+    SET_PARAMETER_VECTOR = "set_vector_param"
+    SET_PARAMETER_MATRIX = "set_matrix_param"
+    ONE_SHOOT_HK = "one_shot_hk"
+    ENABLE_HK = "enable_hk"
+    DISABLE_HK = "disable_hk"
 
 
 class Info:
@@ -163,42 +143,17 @@ class Info:
     RESET_MEKF = "Reset the MEKF"
     RESTORE_MEKF_NONFINITE_RECOVERY = "Restore MEKF non-finite recovery"
     UPDATE_TLE = "Update TLE"
+    READ_TLE = "Read the currently stored TLE"
+    UPDATE_MEKF_STANDARD_DEVIATIONS = (
+        "Update the Standard Deviations within the MEKF to the current ACS Parameter "
+        "Values"
+    )
     SET_PARAMETER_SCALAR = "Set Scalar Parameter"
     SET_PARAMETER_VECTOR = "Set Vector Parameter"
     SET_PARAMETER_MATRIX = "Set Matrix Parameter"
-    REQUEST_RAW_MGM_HK = "Request Raw MGM HK once"
-    ENABLE_RAW_MGM_HK = "Enable Raw MGM HK data generation"
-    DISABLE_RAW_MGM_HK = "Disable Raw MGM HK data generation"
-    REQUEST_PROC_MGM_HK = "Request Processed MGM HK"
-    ENABLE_PROC_MGM_HK = "Enable Processed MGM HK data generation"
-    DISABLE_PROC_MGM_HK = "Disable Processed MGM HK data generation"
-    REQUEST_RAW_SUS_HK = "Request Raw SUS HK"
-    ENABLE_RAW_SUS_HK = "Enable Raw SUS HK data generation"
-    DISABLE_RAW_SUS_HK = "Disable Raw SUS HK data generation"
-    REQUEST_PROC_SUS_HK = "Request Processed SUS HK"
-    ENABLE_PROC_SUS_HK = "Enable Processed SUS HK data generation"
-    DISABLE_PROC_SUS_HK = "Disable Processed MGM HK data generation"
-    REQUEST_RAW_GYR_HK = "Request Raw GYR HK"
-    ENABLE_RAW_GYR_HK = "Enable Raw GYR HK data generation"
-    DISABLE_RAW_GYR_HK = "Disable Raw GYR HK data generation"
-    REQUEST_PROC_GYR_HK = "Request Processed GYR HK"
-    ENABLE_PROC_GYR_HK = "Enable Processed GYR HK data generation"
-    DISABLE_PROC_GYR_HK = "Disable Processed GYR HK data generation"
-    REQUEST_PROC_GPS_HK = "Request Processed GPS HK"
-    ENABLE_PROC_GPS_HK = "Enable Processed GPS HK data generation"
-    DISABLE_PROC_GPS_HK = "Disable Processed GPS HK data generation"
-    REQUEST_MEKF_HK = "Request MEKF HK"
-    ENABLE_MEKF_HK = "Enable MEKF HK data generation"
-    DISABLE_MEKF_HK = "Disable MEKF HK data generation"
-    REQUEST_CTRL_VAL_HK = "Request Control Values HK"
-    ENABLE_CTRL_VAL_HK = "Enable Control Values HK data generation"
-    DISABLE_CTRL_VAL_HK = "Disable Control Values HK data generation"
-    REQUEST_ACT_CMD_HK = "Request Actuator Commands HK"
-    ENABLE_ACT_CMD_HK = "Enable Actuator Commands HK data generation"
-    DISABLE_ACT_CMD_HK = "Disable Actuator Commands HK data generation"
-    REQUEST_FUSED_ROT_RATE_HK = "Request Fused Rotational Rates HK"
-    ENABLE_FUSED_ROT_RATE_HK = "Enable Fused Rotational Rates HK data generation"
-    DISABLE_FUSED_ROT_RATE_HK = "Disable Fused Rotational Rates HK data generation"
+    ONE_SHOOT_HK = "One shoot HK Set"
+    ENABLE_HK = "Enable Periodic HK"
+    DISABLE_HK = "Disable Periodic HK"
 
 
 PERFORM_MGM_CALIBRATION = False
@@ -213,113 +168,66 @@ if PERFORM_MGM_CALIBRATION:
     CALIBR_SOCKET.connect(CALIBRATION_ADDR)
 
 
-@tmtc_definitions_provider
-def acs_cmd_defs(defs: TmtcDefinitionWrapper):
-    oce = OpCodeEntry()
-    oce.add(keys=OpCodes.OFF, info=Info.OFF)
-    oce.add(keys=OpCodes.SAFE, info=Info.SAFE)
-    oce.add(keys=OpCodes.DTBL, info=Info.DTBL)
-    oce.add(keys=OpCodes.IDLE, info=Info.IDLE)
-    oce.add(keys=OpCodes.NADIR, info=Info.NADIR)
-    oce.add(keys=OpCodes.TARGET, info=Info.TARGET)
-    oce.add(keys=OpCodes.GS, info=Info.GS)
-    oce.add(keys=OpCodes.INERTIAL, info=Info.INERTIAL)
-    oce.add(keys=OpCodes.SAFE_PTG, info=Info.SAFE_PTG)
-    oce.add(keys=OpCodes.RESET_MEKF, info=Info.RESET_MEKF)
-    oce.add(
-        keys=OpCodes.RESTORE_MEKF_NONFINITE_RECOVERY,
-        info=Info.RESTORE_MEKF_NONFINITE_RECOVERY,
-    )
-    oce.add(keys=OpCodes.UPDATE_TLE, info=Info.UPDATE_TLE)
-    oce.add(keys=OpCodes.SET_PARAMETER_SCALAR, info=Info.SET_PARAMETER_SCALAR)
-    oce.add(keys=OpCodes.SET_PARAMETER_VECTOR, info=Info.SET_PARAMETER_VECTOR)
-    oce.add(keys=OpCodes.SET_PARAMETER_MATRIX, info=Info.SET_PARAMETER_MATRIX)
-    oce.add(keys=OpCodes.REQUEST_RAW_MGM_HK, info=Info.REQUEST_RAW_MGM_HK)
-    oce.add(keys=OpCodes.ENABLE_RAW_MGM_HK, info=Info.ENABLE_RAW_MGM_HK)
-    oce.add(keys=OpCodes.DISABLE_RAW_MGM_HK, info=Info.DISABLE_RAW_MGM_HK)
-    oce.add(keys=OpCodes.REQUEST_PROC_MGM_HK, info=Info.REQUEST_PROC_MGM_HK)
-    oce.add(keys=OpCodes.ENABLE_PROC_MGM_HK, info=Info.ENABLE_PROC_MGM_HK)
-    oce.add(keys=OpCodes.DISABLE_PROC_MGM_HK, info=Info.DISABLE_PROC_MGM_HK)
-    oce.add(keys=OpCodes.REQUEST_RAW_SUS_HK, info=Info.REQUEST_RAW_SUS_HK)
-    oce.add(keys=OpCodes.ENABLE_RAW_SUS_HK, info=Info.ENABLE_RAW_SUS_HK)
-    oce.add(keys=OpCodes.DISABLE_RAW_SUS_HK, info=Info.DISABLE_RAW_SUS_HK)
-    oce.add(keys=OpCodes.REQUEST_PROC_SUS_HK, info=Info.REQUEST_PROC_SUS_HK)
-    oce.add(keys=OpCodes.ENABLE_PROC_SUS_HK, info=Info.ENABLE_PROC_SUS_HK)
-    oce.add(keys=OpCodes.DISABLE_PROC_SUS_HK, info=Info.DISABLE_PROC_SUS_HK)
-    oce.add(keys=OpCodes.REQUEST_RAW_GYR_HK, info=Info.REQUEST_RAW_GYR_HK)
-    oce.add(keys=OpCodes.ENABLE_RAW_GYR_HK, info=Info.ENABLE_RAW_GYR_HK)
-    oce.add(keys=OpCodes.DISABLE_RAW_GYR_HK, info=Info.DISABLE_RAW_GYR_HK)
-    oce.add(keys=OpCodes.REQUEST_PROC_GYR_HK, info=Info.REQUEST_PROC_GYR_HK)
-    oce.add(keys=OpCodes.ENABLE_PROC_GYR_HK, info=Info.ENABLE_PROC_GYR_HK)
-    oce.add(keys=OpCodes.DISABLE_PROC_GYR_HK, info=Info.DISABLE_PROC_GYR_HK)
-    oce.add(keys=OpCodes.REQUEST_PROC_GPS_HK, info=Info.REQUEST_PROC_GPS_HK)
-    oce.add(keys=OpCodes.ENABLE_PROC_GPS_HK, info=Info.ENABLE_PROC_GPS_HK)
-    oce.add(keys=OpCodes.DISABLE_PROC_GPS_HK, info=Info.DISABLE_PROC_GPS_HK)
-    oce.add(keys=OpCodes.REQUEST_MEKF_HK, info=Info.REQUEST_MEKF_HK)
-    oce.add(keys=OpCodes.ENABLE_MEKF_HK, info=Info.ENABLE_MEKF_HK)
-    oce.add(keys=OpCodes.DISABLE_MEKF_HK, info=Info.DISABLE_MEKF_HK)
-    oce.add(keys=OpCodes.REQUEST_CTRL_VAL_HK, info=Info.REQUEST_CTRL_VAL_HK)
-    oce.add(keys=OpCodes.ENABLE_CTRL_VAL_HK, info=Info.ENABLE_CTRL_VAL_HK)
-    oce.add(keys=OpCodes.DISABLE_CTRL_VAL_HK, info=Info.DISABLE_CTRL_VAL_HK)
-    oce.add(keys=OpCodes.REQUEST_ACT_CMD_HK, info=Info.REQUEST_ACT_CMD_HK)
-    oce.add(keys=OpCodes.ENABLE_ACT_CMD_HK, info=Info.ENABLE_ACT_CMD_HK)
-    oce.add(keys=OpCodes.DISABLE_ACT_CMD_HK, info=Info.DISABLE_ACT_CMD_HK)
-    oce.add(keys=OpCodes.REQUEST_FUSED_ROT_RATE_HK, info=Info.REQUEST_FUSED_ROT_RATE_HK)
-    oce.add(keys=OpCodes.ENABLE_FUSED_ROT_RATE_HK, info=Info.ENABLE_FUSED_ROT_RATE_HK)
-    oce.add(keys=OpCodes.DISABLE_FUSED_ROT_RATE_HK, info=Info.DISABLE_FUSED_ROT_RATE_HK)
-    defs.add_service(
-        name=CustomServiceList.ACS_CTRL.value, info="ACS Controller", op_code_entry=oce
+def create_acs_ctrl_node() -> CmdTreeNode:
+    # Zip the two classes together into a dictionary
+    op_code_strs = [
+        getattr(OpCodes, key) for key in dir(OpCodes) if not key.startswith("__")
+    ]
+    info_strs = [getattr(Info, key) for key in dir(OpCodes) if not key.startswith("__")]
+    combined_dict = dict(zip(op_code_strs, info_strs))
+    acs_ctrl = CmdTreeNode(
+        "acs_ctrl", "ACS Controller", hide_children_which_are_leaves=True
     )
+    for op_code, info in combined_dict.items():
+        acs_ctrl.add_child(CmdTreeNode(op_code, info))
+    return acs_ctrl
 
 
-@service_provider(CustomServiceList.ACS_CTRL.value)
-def pack_acs_ctrl_command(p: ServiceProviderParams):  # noqa C901
-    op_code = p.op_code
-    q = p.queue_helper
-    if op_code in OpCodes.OFF:
+def pack_acs_ctrl_command(q: DefaultPusQueueHelper, cmd_str: str):  # noqa C901
+    if cmd_str in OpCodes.OFF:
         q.add_log_cmd(f"{Info.OFF}")
         q.add_pus_tc(pack_mode_command(ACS_CONTROLLER, Mode.OFF, 0))
-    elif op_code in OpCodes.SAFE:
+    elif cmd_str in OpCodes.SAFE:
         q.add_log_cmd(f"{Info.SAFE}")
         q.add_pus_tc(
             pack_mode_command(ACS_CONTROLLER, AcsMode.SAFE, SafeSubmode.DEFAULT)
         )
-    elif op_code in OpCodes.DTBL:
+    elif cmd_str in OpCodes.DTBL:
         q.add_log_cmd(f"{Info.DTBL}")
         q.add_pus_tc(
             pack_mode_command(ACS_CONTROLLER, AcsMode.SAFE, SafeSubmode.DETUMBLE)
         )
-    elif op_code in OpCodes.IDLE:
+    elif cmd_str in OpCodes.IDLE:
         q.add_log_cmd(f"{Info.IDLE}")
         q.add_pus_tc(pack_mode_command(ACS_CONTROLLER, AcsMode.IDLE, 0))
-    elif op_code in OpCodes.NADIR:
+    elif cmd_str in OpCodes.NADIR:
         q.add_log_cmd(f"{Info.NADIR}")
         q.add_pus_tc(pack_mode_command(ACS_CONTROLLER, AcsMode.PTG_NADIR, 0))
-    elif op_code in OpCodes.TARGET:
+    elif cmd_str in OpCodes.TARGET:
         q.add_log_cmd(f"{Info.TARGET}")
         q.add_pus_tc(pack_mode_command(ACS_CONTROLLER, AcsMode.PTG_TARGET, 0))
-    elif op_code in OpCodes.GS:
+    elif cmd_str in OpCodes.GS:
         q.add_log_cmd(f"{Info.GS}")
         q.add_pus_tc(pack_mode_command(ACS_CONTROLLER, AcsMode.PTG_TARGET_GS, 0))
-    elif op_code in OpCodes.INERTIAL:
+    elif cmd_str in OpCodes.INERTIAL:
         q.add_log_cmd(f"{Info.INERTIAL}")
         q.add_pus_tc(pack_mode_command(ACS_CONTROLLER, AcsMode.PTG_INERTIAL, 0))
-    elif op_code in OpCodes.SAFE_PTG:
+    elif cmd_str in OpCodes.SAFE_PTG:
         q.add_log_cmd(f"{Info.SAFE_PTG}")
         q.add_pus_tc(
             create_action_cmd(
                 ACS_CONTROLLER, ActionId.SOLAR_ARRAY_DEPLOYMENT_SUCCESSFUL
             )
         )
-    elif op_code in OpCodes.RESET_MEKF:
+    elif cmd_str in OpCodes.RESET_MEKF:
         q.add_log_cmd(f"{Info.RESET_MEKF}")
         q.add_pus_tc(create_action_cmd(ACS_CONTROLLER, ActionId.RESET_MEKF))
-    elif op_code in OpCodes.RESTORE_MEKF_NONFINITE_RECOVERY:
+    elif cmd_str in OpCodes.RESTORE_MEKF_NONFINITE_RECOVERY:
         q.add_log_cmd(f"{Info.RESTORE_MEKF_NONFINITE_RECOVERY}")
         q.add_pus_tc(
             create_action_cmd(ACS_CONTROLLER, ActionId.RESTORE_MEKF_NONFINITE_RECOVERY)
         )
-    elif op_code in OpCodes.UPDATE_TLE:
+    elif cmd_str in OpCodes.UPDATE_TLE:
         q.add_log_cmd(f"{Info.UPDATE_TLE}")
         while True:
             line1 = input("Please input the first line of the TLE: ")
@@ -335,237 +243,82 @@ def pack_acs_ctrl_command(p: ServiceProviderParams):  # noqa C901
                 print("The line does not have the required length of 69 characters")
         tle = line1.encode() + line2.encode()
         q.add_pus_tc(create_action_cmd(ACS_CONTROLLER, ActionId.UPDATE_TLE, tle))
-    elif op_code in OpCodes.SET_PARAMETER_SCALAR:
+    elif cmd_str == OpCodes.READ_TLE:
+        q.add_log_cmd(f"{Info.READ_TLE}")
+        q.add_pus_tc(create_action_cmd(ACS_CONTROLLER, ActionId.READ_TLE))
+    elif cmd_str == OpCodes.UPDATE_MEKF_STANDARD_DEVIATIONS:
+        q.add_log_cmd(f"{Info.UPDATE_MEKF_STANDARD_DEVIATIONS}")
+        q.add_pus_tc(
+            create_action_cmd(ACS_CONTROLLER, ActionId.UPDATE_MEKF_STANDARD_DEVIATIONS)
+        )
+    elif cmd_str == OpCodes.SET_PARAMETER_SCALAR:
         q.add_log_cmd(f"{Info.SET_PARAMETER_SCALAR}")
         set_acs_ctrl_param_scalar(q)
-    elif op_code in OpCodes.SET_PARAMETER_VECTOR:
+    elif cmd_str == OpCodes.SET_PARAMETER_VECTOR:
         q.add_log_cmd(f"{Info.SET_PARAMETER_VECTOR}")
         set_acs_ctrl_param_vector(q)
-    elif op_code in OpCodes.SET_PARAMETER_MATRIX:
+    elif cmd_str == OpCodes.SET_PARAMETER_MATRIX:
         q.add_log_cmd(f"{Info.SET_PARAMETER_MATRIX}")
         set_acs_ctrl_param_matrix(q)
-    elif op_code in OpCodes.REQUEST_RAW_MGM_HK:
-        q.add_log_cmd(Info.REQUEST_RAW_MGM_HK)
-        q.add_pus_tc(
-            generate_one_hk_command(make_sid(ACS_CONTROLLER, SetId.MGM_RAW_SET))
-        )
-    elif op_code in OpCodes.ENABLE_RAW_MGM_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_RAW_MGM_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            False, make_sid(ACS_CONTROLLER, SetId.MGM_RAW_SET), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_RAW_MGM_HK:
-        q.add_log_cmd(Info.DISABLE_RAW_MGM_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(
-                False, make_sid(ACS_CONTROLLER, SetId.MGM_RAW_SET)
-            )
-        )
-    elif op_code in OpCodes.REQUEST_PROC_MGM_HK:
-        q.add_log_cmd(Info.REQUEST_PROC_MGM_HK)
-        q.add_pus_tc(
-            generate_one_hk_command(make_sid(ACS_CONTROLLER, SetId.MGM_PROC_SET))
-        )
-    elif op_code in OpCodes.ENABLE_PROC_MGM_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_PROC_MGM_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            False, make_sid(ACS_CONTROLLER, SetId.MGM_PROC_SET), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_PROC_MGM_HK:
-        q.add_log_cmd(Info.DISABLE_PROC_MGM_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(
-                False, make_sid(ACS_CONTROLLER, SetId.MGM_PROC_SET)
-            )
-        )
-    elif op_code in OpCodes.REQUEST_RAW_SUS_HK:
-        q.add_log_cmd(Info.REQUEST_RAW_SUS_HK)
-        q.add_pus_tc(
-            generate_one_hk_command(make_sid(ACS_CONTROLLER, SetId.SUS_RAW_SET))
-        )
-    elif op_code in OpCodes.ENABLE_RAW_SUS_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_RAW_SUS_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            False, make_sid(ACS_CONTROLLER, SetId.SUS_RAW_SET), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_RAW_SUS_HK:
-        q.add_log_cmd(Info.DISABLE_RAW_SUS_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(
-                False, make_sid(ACS_CONTROLLER, SetId.SUS_RAW_SET)
-            )
-        )
-    elif op_code in OpCodes.REQUEST_PROC_SUS_HK:
-        q.add_log_cmd(Info.REQUEST_PROC_SUS_HK)
-        q.add_pus_tc(
-            generate_one_hk_command(make_sid(ACS_CONTROLLER, SetId.SUS_PROC_SET))
-        )
-    elif op_code in OpCodes.ENABLE_PROC_SUS_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_PROC_SUS_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            False, make_sid(ACS_CONTROLLER, SetId.SUS_PROC_SET), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_PROC_SUS_HK:
-        q.add_log_cmd(Info.DISABLE_PROC_SUS_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(
-                False, make_sid(ACS_CONTROLLER, SetId.SUS_PROC_SET)
-            )
-        )
-    elif op_code in OpCodes.REQUEST_RAW_GYR_HK:
-        q.add_log_cmd(Info.REQUEST_RAW_GYR_HK)
-        q.add_pus_tc(
-            create_request_one_diag_command(make_sid(ACS_CONTROLLER, SetId.GYR_RAW_SET))
-        )
-    elif op_code in OpCodes.ENABLE_RAW_GYR_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_RAW_GYR_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            True, make_sid(ACS_CONTROLLER, SetId.GYR_RAW_SET), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_RAW_GYR_HK:
-        q.add_log_cmd(Info.DISABLE_RAW_GYR_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(
-                True, make_sid(ACS_CONTROLLER, SetId.GYR_RAW_SET)
-            )
-        )
-    elif op_code in OpCodes.REQUEST_PROC_GYR_HK:
-        q.add_log_cmd(Info.REQUEST_PROC_GYR_HK)
-        q.add_pus_tc(
-            create_request_one_diag_command(
-                make_sid(ACS_CONTROLLER, SetId.GYR_PROC_SET)
-            )
-        )
-    elif op_code in OpCodes.ENABLE_PROC_GYR_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_PROC_GYR_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            True, make_sid(ACS_CONTROLLER, SetId.GYR_PROC_SET), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_PROC_GYR_HK:
-        q.add_log_cmd(Info.DISABLE_PROC_GYR_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(
-                True, make_sid(ACS_CONTROLLER, SetId.GYR_PROC_SET)
-            )
-        )
-    elif op_code in OpCodes.REQUEST_PROC_GPS_HK:
-        q.add_log_cmd(Info.REQUEST_PROC_GPS_HK)
-        q.add_pus_tc(
-            generate_one_hk_command(make_sid(ACS_CONTROLLER, SetId.GPS_PROC_SET))
-        )
-    elif op_code in OpCodes.ENABLE_PROC_GPS_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_PROC_GPS_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            False, make_sid(ACS_CONTROLLER, SetId.GPS_PROC_SET), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_PROC_GPS_HK:
-        q.add_log_cmd(Info.DISABLE_PROC_GPS_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(
-                False, make_sid(ACS_CONTROLLER, SetId.GPS_PROC_SET)
-            )
-        )
-    elif op_code in OpCodes.REQUEST_MEKF_HK:
-        q.add_log_cmd(Info.REQUEST_MEKF_HK)
-        q.add_pus_tc(
-            create_request_one_diag_command(make_sid(ACS_CONTROLLER, SetId.MEKF_DATA))
-        )
-    elif op_code in OpCodes.ENABLE_MEKF_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_MEKF_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            True, make_sid(ACS_CONTROLLER, SetId.MEKF_DATA), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_MEKF_HK:
-        q.add_log_cmd(Info.DISABLE_MEKF_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(True, make_sid(ACS_CONTROLLER, SetId.MEKF_DATA))
-        )
-    elif op_code in OpCodes.REQUEST_CTRL_VAL_HK:
-        q.add_log_cmd(Info.REQUEST_CTRL_VAL_HK)
-        q.add_pus_tc(
-            generate_one_hk_command(make_sid(ACS_CONTROLLER, SetId.CTRL_VAL_DATA))
-        )
-    elif op_code in OpCodes.ENABLE_CTRL_VAL_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_CTRL_VAL_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            False, make_sid(ACS_CONTROLLER, SetId.CTRL_VAL_DATA), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_CTRL_VAL_HK:
-        q.add_log_cmd(Info.DISABLE_CTRL_VAL_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(
-                False, make_sid(ACS_CONTROLLER, SetId.CTRL_VAL_DATA)
-            )
-        )
-    elif op_code in OpCodes.REQUEST_ACT_CMD_HK:
-        q.add_log_cmd(Info.REQUEST_ACT_CMD_HK)
-        q.add_pus_tc(
-            generate_one_hk_command(make_sid(ACS_CONTROLLER, SetId.ACTUATOR_CMD_DATA))
-        )
-    elif op_code in OpCodes.ENABLE_ACT_CMD_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_ACT_CMD_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            False, make_sid(ACS_CONTROLLER, SetId.ACTUATOR_CMD_DATA), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_ACT_CMD_HK:
-        q.add_log_cmd(Info.DISABLE_ACT_CMD_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(
-                False, make_sid(ACS_CONTROLLER, SetId.ACTUATOR_CMD_DATA)
-            )
-        )
-    elif op_code in OpCodes.REQUEST_FUSED_ROT_RATE_HK:
-        q.add_log_cmd(Info.REQUEST_FUSED_ROT_RATE_HK)
-        q.add_pus_tc(
-            generate_one_hk_command(make_sid(ACS_CONTROLLER, SetId.FUSED_ROT_RATE_DATA))
-        )
-    elif op_code in OpCodes.ENABLE_FUSED_ROT_RATE_HK:
-        interval = float(input("Please specify interval in floating point seconds: "))
-        q.add_log_cmd(Info.ENABLE_FUSED_ROT_RATE_HK)
-        cmd_tuple = enable_periodic_hk_command_with_interval(
-            False, make_sid(ACS_CONTROLLER, SetId.FUSED_ROT_RATE_DATA), interval
-        )
-        q.add_pus_tc(cmd_tuple[0])
-        q.add_pus_tc(cmd_tuple[1])
-    elif op_code in OpCodes.DISABLE_FUSED_ROT_RATE_HK:
-        q.add_log_cmd(Info.DISABLE_FUSED_ROT_RATE_HK)
-        q.add_pus_tc(
-            disable_periodic_hk_command(
-                False, make_sid(ACS_CONTROLLER, SetId.FUSED_ROT_RATE_DATA)
-            )
-        )
+    elif cmd_str == OpCodes.ONE_SHOOT_HK:
+        q.add_log_cmd(Info.ONE_SHOOT_HK)
+        request_dataset(q, DataSetRequest.ONESHOT)
+    elif cmd_str == OpCodes.ENABLE_HK:
+        q.add_log_cmd(Info.ENABLE_HK)
+        request_dataset(q, DataSetRequest.ENABLE)
+    elif cmd_str == OpCodes.DISABLE_HK:
+        q.add_log_cmd(Info.DISABLE_HK)
+        request_dataset(q, DataSetRequest.DISABLE)
     else:
-        logging.getLogger(__name__).info(f"Unknown op code {op_code}")
+        logging.getLogger(__name__).info(f"Unknown op code {cmd_str}")
+
+
+def request_dataset(q: DefaultPusQueueHelper, req_type: DataSetRequest):
+    for val in SetId:
+        print("{:<2}: {:<20}".format(val, val.name))
+    set_id = int(input("Specify the dataset \n" ""))
+    if set_id in [
+        SetId.GYR_RAW_SET,
+        SetId.GPS_PROC_SET,
+        SetId.ATTITUDE_ESTIMATION_DATA,
+    ]:
+        is_diag = True
+    else:
+        is_diag = False
+    match req_type:
+        case DataSetRequest.ONESHOT:
+            if is_diag:
+                q.add_pus_tc(
+                    create_request_one_diag_command(make_sid(ACS_CONTROLLER, set_id))
+                )
+            else:
+                q.add_pus_tc(
+                    create_request_one_hk_command(make_sid(ACS_CONTROLLER, set_id))
+                )
+        case DataSetRequest.ENABLE:
+            interval = float(
+                input("Please specify interval in floating point seconds: ")
+            )
+
+            if is_diag:
+                cmd_tuple = enable_periodic_hk_command_with_interval(
+                    True, make_sid(ACS_CONTROLLER, set_id), interval
+                )
+            else:
+                cmd_tuple = enable_periodic_hk_command_with_interval(
+                    False, make_sid(ACS_CONTROLLER, set_id), interval
+                )
+            q.add_pus_tc(cmd_tuple[0])
+            q.add_pus_tc(cmd_tuple[1])
+        case DataSetRequest.DISABLE:
+            if is_diag:
+                q.add_pus_tc(
+                    disable_periodic_hk_command(True, make_sid(ACS_CONTROLLER, set_id))
+                )
+            else:
+                q.add_pus_tc(
+                    disable_periodic_hk_command(False, make_sid(ACS_CONTROLLER, set_id))
+                )
 
 
 def set_acs_ctrl_param_scalar(q: DefaultPusQueueHelper):
@@ -661,7 +414,7 @@ def set_acs_ctrl_param_vector(q: DefaultPusQueueHelper):
                             domain_id=sid,
                             unique_id=pid,
                             parameters=param,
-                        ).pack()
+                        )
                     )
                 )
             else:
@@ -773,14 +526,16 @@ def handle_acs_ctrl_hk_data(
             handle_gyr_data_processed(pw, hk_data)
         case SetId.GPS_PROC_SET:
             handle_gps_data_processed(pw, hk_data)
-        case SetId.MEKF_DATA:
-            handle_mekf_data(pw, hk_data)
+        case SetId.ATTITUDE_ESTIMATION_DATA:
+            handle_attitude_estimation_data(pw, hk_data)
         case SetId.CTRL_VAL_DATA:
             handle_ctrl_val_data(pw, hk_data)
         case SetId.ACTUATOR_CMD_DATA:
             handle_act_cmd_data(pw, hk_data)
         case SetId.FUSED_ROT_RATE_DATA:
             handle_fused_rot_rate_data(pw, hk_data)
+        case SetId.FUSED_ROT_RATE_SOURCE_DATA:
+            handle_fused_rot_rate_source_data(pw, hk_data)
 
 
 def handle_acs_ctrl_sus_raw_data(pw: PrintWrapper, hk_data: bytes):
@@ -802,7 +557,7 @@ def handle_acs_ctrl_sus_raw_data(pw: PrintWrapper, hk_data: bytes):
         sus_list_formatted = vec_fmt.format(*sus_list)
         current_idx += length
         pw.dlog(f"SUS {idx} RAW: {sus_list_formatted}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=12)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=12))
 
 
 def handle_acs_ctrl_sus_processed_data(pw: PrintWrapper, hk_data: bytes):
@@ -838,7 +593,7 @@ def handle_acs_ctrl_sus_processed_data(pw: PrintWrapper, hk_data: bytes):
     sun_ijk_model = vec_fmt.format(*sun_ijk_model)
     current_idx += inc_len
     pw.dlog(f"{'SUS ijk Model'.ljust(25)}: {sun_ijk_model}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=15)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=15))
 
 
 def handle_raw_mgm_data(pw: PrintWrapper, hk_data: bytes):
@@ -852,7 +607,7 @@ def handle_raw_mgm_data(pw: PrintWrapper, hk_data: bytes):
         pw.dlog(f"Raw Data: {hk_data.hex(sep=',')}")
         return
 
-    def unpack_float_tuple(idx: int) -> (tuple, int):
+    def unpack_float_tuple(idx: int) -> Tuple[tuple, int]:
         f_tuple = struct.unpack(
             float_tuple_fmt_str,
             hk_data[idx : idx + struct.calcsize(float_tuple_fmt_str)],
@@ -894,7 +649,7 @@ def handle_raw_mgm_data(pw: PrintWrapper, hk_data: bytes):
         pw.dlog(f"{entry[0].ljust(28)}: {entry[1]}")
     current_idx += 1
     assert current_idx == 61
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=6)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=6))
 
 
 def handle_mgm_data_processed(pw: PrintWrapper, hk_data: bytes):
@@ -948,7 +703,7 @@ def handle_mgm_data_processed(pw: PrintWrapper, hk_data: bytes):
     current_idx += inc_len
     if PERFORM_MGM_CALIBRATION:
         perform_mgm_calibration(pw, mgm_3)
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=8)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=8))
 
 
 def handle_gyr_data_raw(pw: PrintWrapper, hk_data: bytes):
@@ -982,7 +737,7 @@ def handle_gyr_data_raw(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"{'GYR 1 L3'.ljust(15)}: {float_str_fmt.format(*gyr_1_l3)}")
     pw.dlog(f"{'GYR 2 ADIS'.ljust(15)}: {float_str_fmt.format(*gyr_2_adis)}")
     pw.dlog(f"{'GYR 3 L3'.ljust(15)}: {float_str_fmt.format(*gyr_3_l3)}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], 4)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], 4))
 
 
 GYR_NAMES = ["GYR 0 ADIS", "GYR 1 L3", "GYR 2 ADIS", "GYR 3 L3"]
@@ -1008,7 +763,7 @@ def handle_gyr_data_processed(pw: PrintWrapper, hk_data: bytes):
     ]
     pw.dlog(f"GYR Vec Total: {gyr_vec_tot}")
     current_idx += inc_len
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=5)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=5))
 
 
 def handle_gps_data_processed(pw: PrintWrapper, hk_data: bytes):
@@ -1062,8 +817,8 @@ def handle_gps_data_processed(pw: PrintWrapper, hk_data: bytes):
         fmt_source, hk_data[current_idx : current_idx + inc_len_source]
     )[0]
     current_idx += inc_len_source
-    if GPS_COURCE_DICT.get(source) is not None:
-        pw.dlog(f"GPS Source: {GPS_COURCE_DICT[source]}")
+    if GPS_SOURCE_DICT.get(source) is not None:
+        pw.dlog(f"GPS Source: {GPS_SOURCE_DICT[source]}")
     else:
         pw.dlog(f"'GPS Source (key unknown)': {source}")
     pw.dlog(f"GPS Latitude: {lat} [deg]")
@@ -1071,10 +826,10 @@ def handle_gps_data_processed(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"GPS Altitude: {alt} [m]")
     pw.dlog(f"GPS Position: {pos} [m]")
     pw.dlog(f"GPS Velocity: {velo} [m/s]")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=6)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=6))
 
 
-def handle_mekf_data(pw: PrintWrapper, hk_data: bytes):
+def handle_attitude_estimation_data(pw: PrintWrapper, hk_data: bytes):
     mekf_status = {
         0: "UNINITIALIZED",
         1: "NO_GYR_DATA",
@@ -1085,7 +840,7 @@ def handle_mekf_data(pw: PrintWrapper, hk_data: bytes):
         10: "INITIALIZED",
         11: "RUNNING",
     }
-    pw.dlog("Received MEKF Set")
+    pw.dlog("Received Attitude Estimation Set")
     fmt_quat = "!dddd"
     fmt_str_4 = "[{:8.3f}, {:8.3f}, {:8.3f}, {:8.3f}]"
     fmt_str_3 = "[{:8.3f}, {:8.3f}, {:8.3f}]"
@@ -1094,11 +849,16 @@ def handle_mekf_data(pw: PrintWrapper, hk_data: bytes):
     inc_len_quat = struct.calcsize(fmt_quat)
     inc_len_vec = struct.calcsize(fmt_vec)
     inc_len_sts = struct.calcsize(fmt_sts)
-    if len(hk_data) < inc_len_quat + inc_len_vec + inc_len_sts:
-        pw.dlog("Received HK set too small")
+    old_size = inc_len_quat + inc_len_vec + inc_len_sts + 1
+    new_size = 2 * inc_len_quat + inc_len_vec + inc_len_sts + 1
+    size = len(hk_data)
+    if size not in [old_size, new_size]:
+        pw.dlog(f"Received Attitude Estimation HK Set of unexpected size: {size}")
         return
     current_idx = 0
-    quat = struct.unpack(fmt_quat, hk_data[current_idx : current_idx + inc_len_quat])
+    mekf_quat = struct.unpack(
+        fmt_quat, hk_data[current_idx : current_idx + inc_len_quat]
+    )
     current_idx += inc_len_quat
     rates = [
         rate * 180 / math.pi
@@ -1113,9 +873,17 @@ def handle_mekf_data(pw: PrintWrapper, hk_data: bytes):
         pw.dlog(f"{'MEKF Status'.ljust(25)}: {mekf_status[status]}")
     else:
         pw.dlog(f"{'MEKF Raw Status (key unknown)'.ljust(25)}: {status}")
-    pw.dlog(f"{'MEKF Quaternion'.ljust(25)}: {fmt_str_4.format(*quat)}")
+    pw.dlog(f"{'MEKF Quaternion'.ljust(25)}: {fmt_str_4.format(*mekf_quat)}")
     pw.dlog(f"{'MEKF Rotational Rate'.ljust(25)}: {fmt_str_3.format(*rates)}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=3)
+    if size == new_size:
+        quest_quat = struct.unpack(
+            fmt_quat, hk_data[current_idx : current_idx + inc_len_quat]
+        )
+        current_idx += inc_len_quat
+        pw.dlog(f"{'QUEST Quaternion'.ljust(25)}: {fmt_str_4.format(*quest_quat)}")
+        pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=4))
+        return
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=3))
 
 
 def handle_ctrl_val_data(pw: PrintWrapper, hk_data: bytes):
@@ -1165,14 +933,14 @@ def handle_ctrl_val_data(pw: PrintWrapper, hk_data: bytes):
     ]
     current_idx += inc_len_vec
     if CTRL_STRAT_DICT.get(strat) is not None:
-        pw.dlog(f"{'Safe Ctrl Strategy'.ljust(25)}: {CTRL_STRAT_DICT[strat]}")
+        pw.dlog(f"{'Ctrl Strategy'.ljust(25)}: {CTRL_STRAT_DICT[strat]}")
     else:
-        pw.dlog(f"{'Safe Ctrl Strategy (key unknown)'.ljust(25)}: {strat}")
+        pw.dlog(f"{'Ctrl Strategy (key unknown)'.ljust(25)}: {strat}")
     pw.dlog(f"Control Values Target Quaternion: {tgt_quat}")
     pw.dlog(f"Control Values Error Quaternion: {err_quat}")
     pw.dlog(f"Control Values Error Angle: {err_ang} [deg]")
     pw.dlog(f"Control Values Target Rotational Rate: {tgt_rot} [deg/s]")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=5)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=5))
 
 
 def handle_act_cmd_data(pw: PrintWrapper, hk_data: bytes):
@@ -1211,15 +979,20 @@ def handle_act_cmd_data(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"Actuator Commands RW Target Torque: {rw_tgt_torque}")
     pw.dlog(f"Actuator Commands RW Target Speed: {rw_tgt_speed}")
     pw.dlog(f"Actuator Commands MTQ Target Dipole: {mtq_tgt_dipole}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=3)
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=3))
 
 
 def handle_fused_rot_rate_data(pw: PrintWrapper, hk_data: bytes):
     pw.dlog("Received Fused Rotation Rates Data Set")
     fmt_vec3_double = "!ddd"
     inc_len_vec3_double = struct.calcsize(fmt_vec3_double)
-    if len(hk_data) < 3 * inc_len_vec3_double:
-        pw.dlog("Received HK set too small")
+    fmt_source = "!B"
+    inc_len_source = struct.calcsize(fmt_source)
+    old_size = 3 * inc_len_vec3_double + 1
+    new_size = 3 * inc_len_vec3_double + inc_len_source + 1
+    size = len(hk_data)
+    if size not in [old_size, new_size]:
+        pw.dlog(f"Received Fused Rot Rate HK set of unexpected size: {len(hk_data)}")
         return
     current_idx = 0
     rot_rate_orthogonal = [
@@ -1246,13 +1019,100 @@ def handle_fused_rot_rate_data(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"Fused Rotational Rate Orthogonal: {rot_rate_orthogonal} [deg/s]")
     pw.dlog(f"Fused Rotational Rate Parallel: {rot_rate_parallel} [deg/s]")
     pw.dlog(f"Fused Rotational Rate Total: {rot_rate_total} [deg/s]")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], num_vars=3)
+    if size == new_size:
+        rot_rate_source = struct.unpack(
+            fmt_source, hk_data[current_idx : current_idx + inc_len_source]
+        )[0]
+        current_idx += inc_len_source
+        if FUSED_ROT_RATE_SOURCE_DICT.get(rot_rate_source) is not None:
+            pw.dlog(
+                f"Fused Rotational Rate Source: {FUSED_ROT_RATE_SOURCE_DICT[rot_rate_source]}"
+            )
+        else:
+            pw.dlog(f"Ctrl Strategy (key unknown): {rot_rate_source}")
+        pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=4))
+        return
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=3))
+
+
+def handle_fused_rot_rate_source_data(pw: PrintWrapper, hk_data: bytes):
+    pw.dlog("Received Fused Rotation Rates Sources Data Set")
+    fmt_vec3_double = "!ddd"
+    inc_len_vec3_double = struct.calcsize(fmt_vec3_double)
+    if len(hk_data) < 5 * inc_len_vec3_double:
+        pw.dlog("Received HK set too small")
+        return
+    current_idx = 0
+    rot_rate_orthogonal_susmgm = [
+        f"{val*180/math.pi:8.3f}"
+        for val in struct.unpack(
+            fmt_vec3_double, hk_data[current_idx : current_idx + inc_len_vec3_double]
+        )
+    ]
+    current_idx += inc_len_vec3_double
+    rot_rate_parallel_susmgm = [
+        f"{val*180/math.pi:8.3f}"
+        for val in struct.unpack(
+            fmt_vec3_double, hk_data[current_idx : current_idx + inc_len_vec3_double]
+        )
+    ]
+    current_idx += inc_len_vec3_double
+    rot_rate_total_susmgm = [
+        f"{val*180/math.pi:8.3f}"
+        for val in struct.unpack(
+            fmt_vec3_double, hk_data[current_idx : current_idx + inc_len_vec3_double]
+        )
+    ]
+    current_idx += inc_len_vec3_double
+    rot_rate_total_quest = [
+        f"{val * 180 / math.pi:8.3f}"
+        for val in struct.unpack(
+            fmt_vec3_double, hk_data[current_idx : current_idx + inc_len_vec3_double]
+        )
+    ]
+    current_idx += inc_len_vec3_double
+    rot_rate_total_str = [
+        f"{val * 180 / math.pi:8.3f}"
+        for val in struct.unpack(
+            fmt_vec3_double, hk_data[current_idx : current_idx + inc_len_vec3_double]
+        )
+    ]
+    current_idx += inc_len_vec3_double
+    pw.dlog(
+        f"Fused Rotational Rate Orthogonal SUSMGM: {rot_rate_orthogonal_susmgm} [deg/s]"
+    )
+    pw.dlog(
+        f"Fused Rotational Rate Parallel SUSMGM: {rot_rate_parallel_susmgm} [deg/s]"
+    )
+    pw.dlog(f"Fused Rotational Rate Total SUSMGM: {rot_rate_total_susmgm} [deg/s]")
+    pw.dlog(f"Fused Rotational Rate Total QUEST: {rot_rate_total_quest} [deg/s]")
+    pw.dlog(f"Fused Rotational Rate Total STR: {rot_rate_total_str} [deg/s]")
+    pw.dlog(get_validity_buffer_str(hk_data[current_idx:], num_vars=5))
+
+
+def handle_acs_ctrl_action_replies(
+    action_id: int, pw: PrintWrapper, custom_data: bytes
+):
+    if action_id == ActionId.READ_TLE:
+        handle_read_tle(pw, custom_data)
+
+
+def handle_read_tle(pw: PrintWrapper, custom_data: bytes):
+    pw.dlog("Received TLE")
+    data_length = 69 * 2
+    if len(custom_data) != data_length:
+        raise ValueError(f"Received data of unexpected length {len(custom_data)}")
+    tle = custom_data.decode()
+    pw.dlog(f"{tle[0:69]}\n{tle[69:69*2]}")
 
 
 def perform_mgm_calibration(  # noqa C901: Complexity okay
     pw: PrintWrapper, mgm_tuple: Tuple
 ):  # noqa C901: Complexity okay
     global CALIBR_SOCKET, CALIBRATION_ADDR
+    if not PERFORM_MGM_CALIBRATION:
+        return
+    assert CALIBR_SOCKET is not None
     try:
         declare_api_cmd = "declare_api_version 2"
         CALIBR_SOCKET.sendall(f"{declare_api_cmd}\n".encode())

eive_tmtc/tmtc/acs/gps.py

@@ -3,19 +3,18 @@ import enum
 import logging
 import struct
 
-from eive_tmtc.config.definitions import CustomServiceList
 from eive_tmtc.pus_tm.defs import PrintWrapper
-from tmtccmd.config import TmtcDefinitionWrapper, OpCodeEntry
-from tmtccmd.config.tmtc import tmtc_definitions_provider
-from tmtccmd.tc.pus_200_fsfw_mode import create_mode_command, Mode
-from tmtccmd.tc import DefaultPusQueueHelper
-from tmtccmd.tc.pus_3_fsfw_hk import (
+from tmtccmd.config import CmdTreeNode
+from tmtccmd.pus.s200_fsfw_mode import create_mode_command, Mode
+from tmtccmd.tmtc import DefaultPusQueueHelper
+from tmtccmd.pus.tc.s3_fsfw_hk import (
     make_sid,
     create_request_one_hk_command,
     create_enable_periodic_hk_command_with_interval_with_diag,
     create_disable_periodic_hk_command_with_diag,
 )
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.pus.tc.s8_fsfw_action import create_action_cmd
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -24,16 +23,25 @@ class GpsInfo:
     MAX_SATELLITES = 30
 
 
+class ActIds:
+    RESET_GNSS = 5
+
+
+class AcsBoardSides(enum.IntEnum):
+    A_SIDE = 0
+    B_SIDE = 1
+
+
 class OpCode:
     OFF = "off"
     ON = "on"
-    REQ_CORE_HK = ["core_hk_request"]
-    ENABLE_CORE_HK = ["core_hk_enable"]
-    DISABLE_CORE_HK = ["core_hk_disable"]
-    REQ_SKYVIEW_HK = ["skyview_hk_request"]
-    ENABLE_SKYVIEW_HK = ["skyview_hk_enable"]
-    DISABLE_SKYVIEW_HK = ["skyview_hk_disable"]
-    RESET_GNSS = ["reset"]
+    REQ_CORE_HK = "core_hk_request"
+    ENABLE_CORE_HK = "core_hk_enable"
+    DISABLE_CORE_HK = "core_hk_disable"
+    REQ_SKYVIEW_HK = "skyview_hk_request"
+    ENABLE_SKYVIEW_HK = "skyview_hk_enable"
+    DISABLE_SKYVIEW_HK = "skyview_hk_disable"
+    RESET_GNSS = "reset_gnss"
 
 
 class Info:
@@ -53,32 +61,34 @@ class SetId(enum.IntEnum):
     SKYVIEW_HK = 1
 
 
-@tmtc_definitions_provider
-def add_gps_cmds(defs: TmtcDefinitionWrapper):
-    oce = OpCodeEntry()
-    oce.add(keys=OpCode.OFF, info=Info.OFF)
-    oce.add(keys=OpCode.ON, info=Info.ON)
-    oce.add(keys=OpCode.RESET_GNSS, info=Info.RESET_GNSS)
-    oce.add(keys=OpCode.REQ_CORE_HK, info=Info.REQ_CORE_HK)
-    oce.add(keys=OpCode.ENABLE_CORE_HK, info=Info.ENABLE_CORE_HK)
-    oce.add(keys=OpCode.DISABLE_CORE_HK, info=Info.DISABLE_CORE_HK)
-    oce.add(keys=OpCode.REQ_SKYVIEW_HK, info=Info.REQ_SKYVIEW_HK)
-    oce.add(keys=OpCode.ENABLE_SKYVIEW_HK, info=Info.ENABLE_SKYVIEW_HK)
-    oce.add(keys=OpCode.DISABLE_SKYVIEW_HK, info=Info.DISABLE_SKYVIEW_HK)
-    defs.add_service(
-        name=CustomServiceList.GPS_CTRL.value,
-        info="GPS/GNSS Controller",
-        op_code_entry=oce,
-    )
+def create_gnss_node() -> CmdTreeNode:
+    op_code_strs = [
+        getattr(OpCode, key) for key in dir(OpCode) if not key.startswith("__")
+    ]
+    info_strs = [getattr(Info, key) for key in dir(OpCode) if not key.startswith("__")]
+    combined_dict = dict(zip(op_code_strs, info_strs))
+    node = CmdTreeNode("gnss_ctrl", "GNSS Ctrl", hide_children_for_print=True)
+    for op_code, info in combined_dict.items():
+        node.add_child(CmdTreeNode(op_code, info))
+    return node
 
 
 def pack_gps_command(  # noqa: C901
-    object_id: bytes, q: DefaultPusQueueHelper, op_code: str
+    object_id: bytes, q: DefaultPusQueueHelper, cmd_str: str
 ):  # noqa: C901:
-    if op_code in OpCode.RESET_GNSS:
-        # TODO: This needs to be re-implemented
-        _LOGGER.warning("Reset pin handling needs to be re-implemented")
-    if op_code in OpCode.ENABLE_CORE_HK:
+    if cmd_str == OpCode.RESET_GNSS:
+        for val in AcsBoardSides:
+            print("{:<2}: {:<20}".format(val, val.name))
+        board_side = int(input("Select Board Side \n" ""))
+        q.add_log_cmd(f"GPS: {Info.RESET_GNSS}")
+        q.add_pus_tc(
+            create_action_cmd(
+                object_id=object_id,
+                action_id=ActIds.RESET_GNSS,
+                user_data=bytearray([board_side]),
+            )
+        )
+    if cmd_str == OpCode.ENABLE_CORE_HK:
         interval = float(input("Please specify interval in floating point seconds: "))
         if interval <= 0:
             raise ValueError("invalid interval")
@@ -90,21 +100,21 @@ def pack_gps_command(  # noqa: C901
         )
         for cmd in cmds:
             q.add_pus_tc(cmd)
-    if op_code in OpCode.DISABLE_CORE_HK:
+    if cmd_str == OpCode.DISABLE_CORE_HK:
         q.add_log_cmd(f"gps: {Info.DISABLE_CORE_HK}")
         q.add_pus_tc(
             create_disable_periodic_hk_command_with_diag(
                 diag=False, sid=make_sid(object_id=object_id, set_id=SetId.CORE_HK)
             )
         )
-    if op_code in OpCode.REQ_CORE_HK:
+    if cmd_str == OpCode.REQ_CORE_HK:
         q.add_log_cmd(f"GPS: {Info.REQ_CORE_HK}")
         q.add_pus_tc(
             create_request_one_hk_command(
                 sid=make_sid(object_id=object_id, set_id=SetId.CORE_HK)
             )
         )
-    if op_code in OpCode.ENABLE_SKYVIEW_HK:
+    if cmd_str == OpCode.ENABLE_SKYVIEW_HK:
         interval = float(input("Please specify interval in floating point seconds: "))
         if interval <= 0:
             raise ValueError("invalid interval")
@@ -116,24 +126,24 @@ def pack_gps_command(  # noqa: C901
         )
         for cmd in cmds:
             q.add_pus_tc(cmd)
-    if op_code in OpCode.DISABLE_SKYVIEW_HK:
+    if cmd_str == OpCode.DISABLE_SKYVIEW_HK:
         q.add_log_cmd(f"gps: {Info.DISABLE_SKYVIEW_HK}")
         q.add_pus_tc(
             create_disable_periodic_hk_command_with_diag(
                 diag=False, sid=make_sid(object_id=object_id, set_id=SetId.SKYVIEW_HK)
             )
         )
-    if op_code in OpCode.REQ_SKYVIEW_HK:
+    if cmd_str == OpCode.REQ_SKYVIEW_HK:
         q.add_log_cmd(f"GPS: {Info.REQ_SKYVIEW_HK}")
         q.add_pus_tc(
             create_request_one_hk_command(
                 sid=make_sid(object_id=object_id, set_id=SetId.SKYVIEW_HK)
             )
         )
-    if op_code in OpCode.ON:
+    if cmd_str == OpCode.ON:
         q.add_log_cmd(f"GPS: {Info.ON}")
         q.add_pus_tc(create_mode_command(object_id, Mode.ON, 0))
-    if op_code in OpCode.OFF:
+    if cmd_str == OpCode.OFF:
         q.add_log_cmd(f"GPS: {Info.OFF}")
         q.add_pus_tc(create_mode_command(object_id, Mode.OFF, 0))
 
@@ -193,9 +203,7 @@ def handle_core_data(pw: PrintWrapper, hk_data: bytes):
     )
     pw.dlog(f"GNSS Date: {date_string}")
     pw.dlog(f"Unix seconds {unix_seconds}")
-    FsfwTmTcPrinter.get_validity_buffer(
-        validity_buffer=hk_data[current_idx:], num_vars=14
-    )
+    pw.dlog(get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=14))
 
 
 def handle_skyview_data(pw: PrintWrapper, hk_data: bytes):
@@ -255,6 +263,4 @@ def handle_skyview_data(pw: PrintWrapper, hk_data: bytes):
                 used[idx],
             )
         )
-    FsfwTmTcPrinter.get_validity_buffer(
-        validity_buffer=hk_data[current_idx:], num_vars=6
-    )
+    pw.dlog(get_validity_buffer_str(validity_buffer=hk_data[current_idx:], num_vars=6))

eive_tmtc/tmtc/acs/gyros.py

@@ -3,13 +3,14 @@ import logging
 import struct
 
 from spacepackets.ecss import PusTelecommand
-from tmtccmd.tc import DefaultPusQueueHelper
-from tmtccmd.tc.pus_201_fsfw_health import pack_set_health_cmd_data, FsfwHealth
+from tmtccmd.config import CmdTreeNode
+from tmtccmd.tmtc import DefaultPusQueueHelper
+from tmtccmd.pus.s201_fsfw_health import pack_set_health_cmd_data, FsfwHealth
 from tmtccmd.pus.s201_fsfw_health import Subservice
 
 import eive_tmtc.config.object_ids as obj_ids
-from tmtccmd.tc.pus_200_fsfw_mode import create_mode_command, Mode
-from tmtccmd.tc.pus_3_fsfw_hk import create_request_one_hk_command, make_sid
+from tmtccmd.pus.s200_fsfw_mode import create_mode_command, Mode
+from tmtccmd.pus.tc.s3_fsfw_hk import create_request_one_hk_command, make_sid
 from tmtccmd.config.tmtc import (
     tmtc_definitions_provider,
     OpCodeEntry,
@@ -59,7 +60,7 @@ GYR_SEL_DICT = {
 }
 
 
-def handle_gyr_cmd(q: DefaultPusQueueHelper, op_code: str):
+def handle_gyr_cmd(q: DefaultPusQueueHelper, cmd_str: str):
     print("Please select the Gyro Device")
     for k, v in GYR_SEL_DICT.items():
         print(f"{k}: {v[0]}")
@@ -72,23 +73,23 @@ def handle_gyr_cmd(q: DefaultPusQueueHelper, op_code: str):
         core_hk_id = AdisGyroSetId.CORE_HK
     else:
         core_hk_id = L3gGyroSetId.CORE_HK
-    if op_code == OpCode.NML:
+    if cmd_str == OpCode.NML:
         q.add_log_cmd(f"Gyro {gyr_info[0]} NORMAL mode")
         q.add_pus_tc(create_mode_command(gyr_obj_id, Mode.NORMAL, 0))
-    if op_code == OpCode.OFF:
+    if cmd_str == OpCode.OFF:
         q.add_log_cmd(f"Gyro {gyr_info[0]} OFF mode")
         q.add_pus_tc(create_mode_command(gyr_obj_id, Mode.OFF, 0))
-    elif op_code == OpCode.CORE_HK:
+    elif cmd_str == OpCode.CORE_HK:
         q.add_log_cmd(f"Gyro  {gyr_info[0]} Core HK")
         q.add_pus_tc(create_request_one_hk_command(make_sid(gyr_obj_id, core_hk_id)))
-    elif op_code == OpCode.CFG_HK:
+    elif cmd_str == OpCode.CFG_HK:
         if not is_adis:
             raise ValueError("No config HK for L3 device")
         q.add_log_cmd(f"Gyro {gyr_info[0]} CFG HK")
         q.add_pus_tc(
             create_request_one_hk_command(make_sid(gyr_obj_id, AdisGyroSetId.CFG_HK))
         )
-    elif op_code == OpCode.SET_FAULTY:
+    elif cmd_str == OpCode.SET_FAULTY:
         q.add_log_cmd(f"Gyro {gyr_info[0]} set faulty")
         q.add_pus_tc(
             PusTelecommand(
@@ -101,7 +102,7 @@ def handle_gyr_cmd(q: DefaultPusQueueHelper, op_code: str):
         )
     else:
         logging.getLogger(__name__).warning(
-            f"invalid op code {op_code} for gyro command"
+            f"invalid op code {cmd_str} for gyro command"
         )
 
 
@@ -177,6 +178,16 @@ def handle_l3g_gyro_hk(
         pw.dlog(f"Temperature {temp} °C")
 
 
+def create_gyros_node() -> CmdTreeNode:
+    node = CmdTreeNode("gyros", "Gyroscope devices")
+    node.add_child(CmdTreeNode(OpCode.CORE_HK, "Request Core HK"))
+    node.add_child(CmdTreeNode(OpCode.CFG_HK, "Request CFG HK"))
+    node.add_child(CmdTreeNode(OpCode.NML, "Normal Mode"))
+    node.add_child(CmdTreeNode(OpCode.OFF, "Off Mode"))
+    node.add_child(CmdTreeNode(OpCode.SET_FAULTY, "Set Faulty"))
+    return node
+
+
 @tmtc_definitions_provider
 def add_gyr_cmd_defs(defs: TmtcDefinitionWrapper):
     oce = OpCodeEntry()

eive_tmtc/tmtc/acs/imtq.py

@@ -10,6 +10,8 @@ import logging
 import struct
 from typing import List
 
+from tmtccmd.config import CmdTreeNode
+
 from eive_tmtc.config.definitions import CustomServiceList
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from spacepackets.ecss.tc import PusTelecommand
@@ -18,8 +20,8 @@ from tmtccmd.config.tmtc import (
     OpCodeEntry,
     TmtcDefinitionWrapper,
 )
-from tmtccmd.tc import DefaultPusQueueHelper
-from tmtccmd.tc.pus_3_fsfw_hk import (
+from tmtccmd.tmtc import DefaultPusQueueHelper
+from tmtccmd.pus.tc.s3_fsfw_hk import (
     make_sid,
     generate_one_diag_command,
     generate_one_hk_command,
@@ -27,9 +29,9 @@ from tmtccmd.tc.pus_3_fsfw_hk import (
     create_enable_periodic_hk_command_with_interval_with_diag,
     create_disable_periodic_hk_command_with_diag,
 )
-from tmtccmd.tc.pus_200_fsfw_mode import pack_mode_data, Mode
+from tmtccmd.pus.s200_fsfw_mode import pack_mode_data, Mode
 from tmtccmd.util import ObjectIdU32
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 
 _LOGGER = logging.getLogger(__name__)
@@ -91,6 +93,74 @@ class ImtqActionId:
     read_self_test_results = bytearray([0x0, 0x0, 0x0, 0x0D])
 
 
+CTN = CmdTreeNode
+
+
+def create_mgt_node() -> CmdTreeNode:
+    node = CmdTreeNode(
+        "mgt", "iMTQ MGT device node", hide_children_which_are_leaves=True
+    )
+    node.add_child(CmdTreeNode(OpCode.OFF, "Mode OFF"))
+    node.add_child(CmdTreeNode(OpCode.ON, "Mode ON"))
+    node.add_child(CmdTreeNode(OpCode.NORMAL, "Mode Normal"))
+    node.add_child(CmdTreeNode(OpCode.OFF, "Mode OFF"))
+    node.add_child(
+        CmdTreeNode(OpCode.REQUEST_ENG_HK_NO_TORQUE, "Request Engineering HK One Shot")
+    )
+    node.add_child(
+        CmdTreeNode(
+            OpCode.REQUEST_ENG_HK_WITH_TORQUE,
+            "Request Engineering HK One Shot during Torque",
+        )
+    )
+    node.add_child(
+        CmdTreeNode(OpCode.ENABLE_ENG_HK_NO_TORQUE, "Enable ENG HK not torque")
+    )
+    node.add_child(
+        CmdTreeNode(OpCode.ENABLE_ENG_HK_WITH_TORQUE, "Enable ENG HK with torque")
+    )
+    node.add_child(
+        CmdTreeNode(OpCode.DISABLE_ENG_HK_NO_TORQUE, "Disable ENG HK not torque")
+    )
+    node.add_child(
+        CmdTreeNode(OpCode.DISABLE_ENG_HK_WITH_TORQUE, "Disable ENG HK with torque")
+    )
+    node.add_child(
+        CmdTreeNode(
+            OpCode.REQUEST_MGM_RAW_NO_TORQUE,
+            "Request MGM Raw Without Torque HK One Shot",
+        )
+    )
+    node.add_child(
+        CmdTreeNode(OpCode.ENABLE_MGM_RAW_NO_TORQUE, "Enable MGM Raw Without Torque HK")
+    )
+    node.add_child(
+        CmdTreeNode(
+            OpCode.DISABLE_MGM_RAW_NO_TORQUE, "Disable MGM Raw Without Torque HK"
+        )
+    )
+    node.add_child(
+        CmdTreeNode(
+            OpCode.REQUEST_MGM_RAW_WITH_TORQUE,
+            "Request MGM Raw With Torque HK One Shot",
+        )
+    )
+    node.add_child(
+        CmdTreeNode(OpCode.ENABLE_MGM_RAW_WITH_TORQUE, "Enable MGM Raw With Torque HK")
+    )
+    node.add_child(
+        CTN(OpCode.DISABLE_MGM_RAW_WITH_TORQUE, "Disable MGM Raw With Torque HK")
+    )
+    node.add_child(CTN(OpCode.POS_X_SELF_TEST, "IMTQ perform pos X self test"))
+    node.add_child(CTN(OpCode.NEG_X_SELF_TEST, "IMTQ perform neg X self test"))
+    node.add_child(CTN(OpCode.POS_Y_SELF_TEST, "IMTQ perform pos Y self test"))
+    node.add_child(CTN(OpCode.NEG_Y_SELF_TEST, "IMTQ perform neg Y self test"))
+    node.add_child(CTN(OpCode.POS_Z_SELF_TEST, "IMTQ perform pos Z self test"))
+    node.add_child(CTN(OpCode.NEG_Z_SELF_TEST, "IMTQ perform neg Z self test"))
+    node.add_child(CTN(OpCode.SET_DIPOLE, "IMTQ command dipole"))
+    return node
+
+
 @tmtc_definitions_provider
 def add_imtq_cmds(defs: TmtcDefinitionWrapper):
     oce = OpCodeEntry()
@@ -128,26 +198,26 @@ def add_imtq_cmds(defs: TmtcDefinitionWrapper):
     defs.add_service(CustomServiceList.IMTQ.value, "IMQT Device", oce)
 
 
-def pack_imtq_test_into(  # noqa C901
-    object_id: ObjectIdU32, q: DefaultPusQueueHelper, op_code: str
+def create_imtq_command(  # noqa C901
+    object_id: ObjectIdU32, q: DefaultPusQueueHelper, cmd_str: str
 ):
     q.add_log_cmd(
         f"Testing ISIS IMTQ handler with object id: {object_id.as_hex_string}"
     )
 
-    if op_code == OpCode.OFF:
+    if cmd_str == OpCode.OFF:
         q.add_log_cmd("IMTQ: Set mode off")
         command = pack_mode_data(object_id.as_bytes, Mode.OFF, 0)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=command))
-    if op_code == OpCode.ON:
+    if cmd_str == OpCode.ON:
         q.add_log_cmd("IMTQ: Set mode on")
         command = pack_mode_data(object_id.as_bytes, Mode.ON, 0)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=command))
-    if op_code == OpCode.NORMAL:
+    if cmd_str == OpCode.NORMAL:
         q.add_log_cmd("IMTQ: Mode Normal")
         command = pack_mode_data(object_id.as_bytes, Mode.NORMAL, 0)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=command))
-    if op_code == OpCode.POS_X_SELF_TEST:
+    if cmd_str == OpCode.POS_X_SELF_TEST:
         q.add_log_cmd("IMTQ: Perform positive x self test")
         command = object_id.as_bytes + ImtqActionId.perform_positive_x_test
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
@@ -160,7 +230,7 @@ def pack_imtq_test_into(  # noqa C901
         sid = make_sid(object_id.as_bytes, ImtqSetId.POSITIVE_X_TEST)
         q.add_pus_tc(generate_one_hk_command(sid))
 
-    if op_code == OpCode.NEG_X_SELF_TEST:
+    if cmd_str == OpCode.NEG_X_SELF_TEST:
         q.add_log_cmd("IMTQ: Perform negative x self test")
         command = object_id.as_bytes + ImtqActionId.perform_negative_x_test
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
@@ -171,7 +241,7 @@ def pack_imtq_test_into(  # noqa C901
         sid = make_sid(object_id.as_bytes, ImtqSetId.NEGATIVE_X_TEST)
         q.add_pus_tc(generate_one_hk_command(sid))
 
-    if op_code == OpCode.POS_Y_SELF_TEST:
+    if cmd_str == OpCode.POS_Y_SELF_TEST:
         q.add_log_cmd("IMTQ: Perform positive y self test")
         command = object_id.as_bytes + ImtqActionId.perform_positive_y_test
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
@@ -183,7 +253,7 @@ def pack_imtq_test_into(  # noqa C901
         sid = make_sid(object_id.as_bytes, ImtqSetId.POSITIVE_Y_TEST)
         q.add_pus_tc(generate_one_hk_command(sid))
 
-    if op_code == OpCode.NEG_Y_SELF_TEST:
+    if cmd_str == OpCode.NEG_Y_SELF_TEST:
         q.add_log_cmd("IMTQ: Perform negative y self test")
         command = object_id.as_bytes + ImtqActionId.perform_negative_y_test
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
@@ -196,7 +266,7 @@ def pack_imtq_test_into(  # noqa C901
         sid = make_sid(object_id.as_bytes, ImtqSetId.NEGATIVE_Y_TEST)
         q.add_pus_tc(generate_one_hk_command(sid))
 
-    if op_code == OpCode.POS_Z_SELF_TEST:
+    if cmd_str == OpCode.POS_Z_SELF_TEST:
         q.add_log_cmd("IMTQ: Perform positive z self test")
         command = object_id.as_bytes + ImtqActionId.perform_positive_z_test
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
@@ -209,7 +279,7 @@ def pack_imtq_test_into(  # noqa C901
         sid = make_sid(object_id.as_bytes, ImtqSetId.POSITIVE_Y_TEST)
         q.add_pus_tc(generate_one_hk_command(sid))
 
-    if op_code == OpCode.NEG_Z_SELF_TEST:
+    if cmd_str == OpCode.NEG_Z_SELF_TEST:
         q.add_log_cmd("IMTQ: Perform negative z self test")
         command = object_id.as_bytes + ImtqActionId.perform_negative_z_test
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
@@ -220,7 +290,7 @@ def pack_imtq_test_into(  # noqa C901
         sid = make_sid(object_id.as_bytes, ImtqSetId.NEGATIVE_Z_TEST)
         q.add_pus_tc(generate_one_hk_command(sid))
 
-    if op_code in OpCode.SET_DIPOLE:
+    if cmd_str in OpCode.SET_DIPOLE:
         x_dipole = int(input("Specify X dipole [range [0, 2000] * 10^-4 * Am^2]: "))
         y_dipole = int(input("Specify Y dipole [range [0, 2000] * 10^-4 * Am^2]: "))
         z_dipole = int(input("Specify Z dipole [range [0, 2000] * 10^-4 * Am^2]: "))
@@ -241,12 +311,12 @@ def pack_imtq_test_into(  # noqa C901
             )
         )
 
-    if op_code == "10":  # doesnt seem to work anymore
+    if cmd_str == "10":  # doesnt seem to work anymore
         q.add_log_cmd("IMTQ: Get commanded dipole")
         command = object_id.as_bytes + ImtqActionId.get_commanded_dipole
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=command))
 
-    if op_code == OpCode.ENABLE_ENG_HK_NO_TORQUE:
+    if cmd_str == OpCode.ENABLE_ENG_HK_NO_TORQUE:
         q.add_log_cmd("IMTQ: Enable ENG HK")
         interval = float(input("Please enter collection interval in seconds: "))
         cmds = create_enable_periodic_hk_command_with_interval_with_diag(
@@ -256,14 +326,14 @@ def pack_imtq_test_into(  # noqa C901
         )
         for cmd in cmds:
             q.add_pus_tc(cmd)
-    if op_code == OpCode.DISABLE_ENG_HK_NO_TORQUE:
+    if cmd_str == OpCode.DISABLE_ENG_HK_NO_TORQUE:
         q.add_log_cmd("IMTQ: Disable ENG HK (No Torque)")
         q.add_pus_tc(
             create_disable_periodic_hk_command_with_diag(
                 True, make_sid(object_id.as_bytes, ImtqSetId.ENG_HK_NO_TORQUE)
             )
         )
-    if op_code == OpCode.REQUEST_ENG_HK_WITH_TORQUE:
+    if cmd_str == OpCode.REQUEST_ENG_HK_WITH_TORQUE:
         q.add_log_cmd("IMTQ: Get engineering hk set with torque")
         q.add_pus_tc(
             create_request_one_diag_command(
@@ -273,7 +343,7 @@ def pack_imtq_test_into(  # noqa C901
                 )
             )
         )
-    if op_code == OpCode.ENABLE_ENG_HK_WITH_TORQUE:
+    if cmd_str == OpCode.ENABLE_ENG_HK_WITH_TORQUE:
         q.add_log_cmd("IMTQ: Enable ENG HK with torque")
         interval = float(input("Please enter collection interval in seconds: "))
         cmds = create_enable_periodic_hk_command_with_interval_with_diag(
@@ -283,14 +353,14 @@ def pack_imtq_test_into(  # noqa C901
         )
         for cmd in cmds:
             q.add_pus_tc(cmd)
-    if op_code == OpCode.DISABLE_ENG_HK_WITH_TORQUE:
+    if cmd_str == OpCode.DISABLE_ENG_HK_WITH_TORQUE:
         q.add_log_cmd("IMTQ: Disable ENG HK with Torque")
         q.add_pus_tc(
             create_disable_periodic_hk_command_with_diag(
                 True, make_sid(object_id.as_bytes, ImtqSetId.ENG_HK_SET_WITH_TORQUE)
             )
         )
-    if op_code == OpCode.REQUEST_ENG_HK_NO_TORQUE:
+    if cmd_str == OpCode.REQUEST_ENG_HK_NO_TORQUE:
         q.add_log_cmd("IMTQ: Get engineering hk set (no torque)")
         q.add_pus_tc(
             generate_one_diag_command(
@@ -300,7 +370,7 @@ def pack_imtq_test_into(  # noqa C901
             )
         )
 
-    if op_code == "12":
+    if cmd_str == "12":
         q.add_log_cmd("IMTQ: Get calibrated MTM hk set")
         q.add_pus_tc(
             create_request_one_diag_command(
@@ -308,7 +378,7 @@ def pack_imtq_test_into(  # noqa C901
             )
         )
 
-    if op_code == OpCode.REQUEST_MGM_RAW_NO_TORQUE:
+    if cmd_str == OpCode.REQUEST_MGM_RAW_NO_TORQUE:
         q.add_log_cmd("IMTQ: Get raw MTM hk set")
         q.add_pus_tc(
             create_request_one_diag_command(
@@ -318,14 +388,14 @@ def pack_imtq_test_into(  # noqa C901
             )
         )
 
-    if op_code == OpCode.DISABLE_MGM_RAW_NO_TORQUE:
+    if cmd_str == OpCode.DISABLE_MGM_RAW_NO_TORQUE:
         q.add_log_cmd("IMTQ: Disable MGM RAW HK (No Torque)")
         q.add_pus_tc(
             create_disable_periodic_hk_command_with_diag(
                 True, make_sid(object_id.as_bytes, ImtqSetId.RAW_MTM_NO_TORQUE)
             )
         )
-    if op_code == OpCode.ENABLE_MGM_RAW_NO_TORQUE:
+    if cmd_str == OpCode.ENABLE_MGM_RAW_NO_TORQUE:
         q.add_log_cmd("IMTQ: Enable MGM RAW HK (No Torque)")
         interval = float(input("Please enter collection interval in seconds: "))
         cmds = create_enable_periodic_hk_command_with_interval_with_diag(
@@ -335,7 +405,7 @@ def pack_imtq_test_into(  # noqa C901
         )
         for cmd in cmds:
             q.add_pus_tc(cmd)
-    if op_code == OpCode.REQUEST_MGM_RAW_WITH_TORQUE:
+    if cmd_str == OpCode.REQUEST_MGM_RAW_WITH_TORQUE:
         q.add_log_cmd("IMTQ: Get raw MTM hk set")
         q.add_pus_tc(
             create_request_one_diag_command(
@@ -344,7 +414,7 @@ def pack_imtq_test_into(  # noqa C901
                 )
             )
         )
-    if op_code == OpCode.ENABLE_MGM_RAW_WITH_TORQUE:
+    if cmd_str == OpCode.ENABLE_MGM_RAW_WITH_TORQUE:
         q.add_log_cmd("IMTQ: Enable MGM RAW HK (No Torque)")
         interval = float(input("Please enter collection interval in seconds: "))
         cmds = create_enable_periodic_hk_command_with_interval_with_diag(
@@ -354,7 +424,7 @@ def pack_imtq_test_into(  # noqa C901
         )
         for cmd in cmds:
             q.add_pus_tc(cmd)
-    if op_code == OpCode.DISABLE_MGM_RAW_WITH_TORQUE:
+    if cmd_str == OpCode.DISABLE_MGM_RAW_WITH_TORQUE:
         q.add_log_cmd("IMTQ: Disable MGM RAW HK (No Torque)")
         q.add_pus_tc(
             create_disable_periodic_hk_command_with_diag(
@@ -473,7 +543,7 @@ def handle_dipole_set(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(f"Dipole Y: {dipole_y}")
     pw.dlog(f"Dipole Z: {dipole_z}")
     pw.dlog(f"Current torque duration: {current_torque_duration}")
-    FsfwTmTcPrinter.get_validity_buffer(hk_data[fmt_len:], 2)
+    pw.dlog(get_validity_buffer_str(hk_data[fmt_len:], 2))
 
 
 def unpack_eng_hk(hk_data: bytes) -> List:
@@ -513,9 +583,7 @@ def handle_eng_set(pw: PrintWrapper, hk_data: bytes, torque_on: bool):
     for k, v in zip(ENG_HK_HEADERS, content_list):
         pw.dlog(f"{k.ljust(30)}: {v}")
     pw.dlog(
-        FsfwTmTcPrinter.get_validity_buffer(
-            validity_buffer=validity_buffer, num_vars=num_of_vars
-        )
+        get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=num_of_vars)
     )
 
 
@@ -527,9 +595,7 @@ def handle_status_set(pw: PrintWrapper, hk_data: bytes):
     for k, v in zip(STATUS_HEADERS, content_list):
         pw.dlog(f"{k.ljust(30)}: {v}")
     pw.dlog(
-        FsfwTmTcPrinter.get_validity_buffer(
-            validity_buffer=validity_buffer, num_vars=num_of_vars
-        )
+        get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=num_of_vars)
     )
 
 
@@ -550,9 +616,7 @@ def handle_calibrated_mtm_measurement(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(str(header_list))
     pw.dlog(str(content_list))
     pw.dlog(
-        FsfwTmTcPrinter.get_validity_buffer(
-            validity_buffer=validity_buffer, num_vars=num_of_vars
-        )
+        get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=num_of_vars)
     )
 
 
@@ -574,9 +638,7 @@ def handle_raw_mtm_measurement(pw: PrintWrapper, hk_data: bytes, torque_status:
     pw.dlog(str(header_list))
     pw.dlog(str(content_list))
     pw.dlog(
-        FsfwTmTcPrinter.get_validity_buffer(
-            validity_buffer=validity_buffer, num_vars=num_of_vars
-        )
+        get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=num_of_vars)
     )
 
 
@@ -713,7 +775,5 @@ def handle_self_test_data(pw: PrintWrapper, hk_data: bytes):
     pw.dlog(str(header_list))
     pw.dlog(str(content_list))
     pw.dlog(
-        FsfwTmTcPrinter.get_validity_buffer(
-            validity_buffer=validity_buffer, num_vars=num_of_vars
-        )
+        get_validity_buffer_str(validity_buffer=validity_buffer, num_vars=num_of_vars)
     )

eive_tmtc/tmtc/acs/mgms.py

@@ -2,7 +2,7 @@ import enum
 import struct
 
 from eive_tmtc.config.definitions import CustomServiceList
-from tmtccmd.config import OpCodeEntry
+from tmtccmd.config import CmdTreeNode, OpCodeEntry
 
 import eive_tmtc.config.object_ids as obj_ids
 from eive_tmtc.config.object_ids import (
@@ -14,8 +14,8 @@ from eive_tmtc.config.object_ids import (
 
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from tmtccmd.config.tmtc import tmtc_definitions_provider, TmtcDefinitionWrapper
-from tmtccmd.tc import DefaultPusQueueHelper
-from tmtccmd.tc.pus_200_fsfw_mode import create_mode_command, Mode
+from tmtccmd.tmtc import DefaultPusQueueHelper
+from tmtccmd.pus.s200_fsfw_mode import create_mode_command, Mode
 from tmtccmd.util import ObjectIdU32
 
 
@@ -47,17 +47,17 @@ MGM_SEL_DICT = {
 }
 
 
-def handle_mgm_cmd(q: DefaultPusQueueHelper, op_code: str):
+def handle_mgm_cmd(q: DefaultPusQueueHelper, cmd_str: str):
     print("Please select the MGM Device")
     for k, v in MGM_SEL_DICT.items():
         print(f"{k}: {v[0]}")
     sel_idx = int(input("Select MGM device by index: "))
     mgm_info = MGM_SEL_DICT[MgmSel(sel_idx)]
     mgm_obj_id = mgm_info[1]
-    if op_code == OpCode.NORMAL:
+    if cmd_str == OpCode.NORMAL:
         q.add_log_cmd(f"Gyro {mgm_info[0]} NORMAL mode")
         q.add_pus_tc(create_mode_command(mgm_obj_id, Mode.NORMAL, 0))
-    if op_code == OpCode.OFF:
+    if cmd_str == OpCode.OFF:
         q.add_log_cmd(f"Gyro {mgm_info[0]} OFF mode")
         q.add_pus_tc(create_mode_command(mgm_obj_id, Mode.OFF, 0))
 
@@ -107,6 +107,13 @@ def handle_mgm_rm3100_hk_data(
         )
 
 
+def create_mgms_node() -> CmdTreeNode:
+    node = CmdTreeNode("mgms", "Magnetometer devices")
+    node.add_child(CmdTreeNode(OpCode.NORMAL, "Normal Mode"))
+    node.add_child(CmdTreeNode(OpCode.OFF, "Off Mode"))
+    return node
+
+
 @tmtc_definitions_provider
 def add_mgm_cmd_defs(defs: TmtcDefinitionWrapper):
     oce = OpCodeEntry()

eive_tmtc/tmtc/acs/reaction_wheels.py

@@ -6,26 +6,24 @@
 """
 import enum
 import struct
-from typing import List
+from typing import List, Tuple
 
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from eive_tmtc.config.object_ids import RW1_ID, RW2_ID, RW3_ID, RW4_ID
-from tmtccmd.config import TmtcDefinitionWrapper, OpCodeEntry
-from tmtccmd.config.tmtc import tmtc_definitions_provider
-from tmtccmd.tc import DefaultPusQueueHelper
-from tmtccmd.tc.pus_3_fsfw_hk import (
+from tmtccmd.config import CmdTreeNode
+from tmtccmd.tmtc import DefaultPusQueueHelper
+from tmtccmd.pus.tc.s3_fsfw_hk import (
     generate_one_hk_command,
     generate_one_diag_command,
     make_sid,
     enable_periodic_hk_command_with_interval,
     disable_periodic_hk_command,
 )
-from tmtccmd.tc.pus_8_fsfw_funccmd import create_action_cmd
+from tmtccmd.pus.s8_fsfw_action import create_action_cmd
 from spacepackets.ecss.tc import PusTelecommand
-from tmtccmd.tc.pus_200_fsfw_mode import pack_mode_data, Mode, Subservice
-from eive_tmtc.config.definitions import CustomServiceList
+from tmtccmd.pus.s200_fsfw_mode import pack_mode_data, Mode, Subservice
 from tmtccmd.util import ObjectIdU32
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 
 
 class OpCodesDev:
@@ -53,11 +51,11 @@ class InfoDev:
 
 
 class OpCodesAss:
-    ON = ["0", "on"]
-    NML = ["1", "nml"]
-    OFF = ["2", "off"]
-    ALL_SPEED_UP = ["3", "speed_up"]
-    ALL_SPEED_OFF = ["4", "speed_off"]
+    ON = "on"
+    NML = "nml"
+    OFF = "off"
+    ALL_SPEED_UP = "speed_up"
+    ALL_SPEED_OFF = "speed_off"
 
 
 class ActionId:
@@ -99,55 +97,45 @@ class RampTime:
     MS_1000 = 1000
 
 
-@tmtc_definitions_provider
-def add_rw_cmds(defs: TmtcDefinitionWrapper):
-    oce = OpCodeEntry()
-    oce.add(info=InfoDev.SPEED, keys=OpCodesDev.SPEED)
-    oce.add(info=InfoDev.ON, keys=OpCodesDev.ON)
-    oce.add(info=InfoDev.OFF, keys=OpCodesDev.OFF)
-    oce.add(info=InfoDev.NML, keys=OpCodesDev.NML)
-    oce.add(info=InfoDev.REQ_TM, keys=OpCodesDev.REQ_TM)
-    oce.add(info=InfoDev.GET_STATUS, keys=OpCodesDev.GET_STATUS)
-    oce.add(info=InfoDev.GET_TM, keys=OpCodesDev.GET_TM)
-    oce.add(info=InfoDev.ENABLE_STATUS_HK, keys=OpCodesDev.ENABLE_STATUS_HK)
-    oce.add(info=InfoDev.DISABLE_STATUS_HK, keys=OpCodesDev.DISABLE_STATUS_HK)
-    defs.add_service(
-        name=CustomServiceList.REACTION_WHEEL_1.value,
-        info="Reaction Wheel 1",
-        op_code_entry=oce,
-    )
-    defs.add_service(
-        name=CustomServiceList.REACTION_WHEEL_2.value,
-        info="Reaction Wheel 2",
-        op_code_entry=oce,
-    )
-    defs.add_service(
-        name=CustomServiceList.REACTION_WHEEL_3.value,
-        info="Reaction Wheel 3",
-        op_code_entry=oce,
-    )
-    defs.add_service(
-        name=CustomServiceList.REACTION_WHEEL_4.value,
-        info="Reaction Wheel 4",
-        op_code_entry=oce,
-    )
-    oce = OpCodeEntry()
-    oce.add(info=InfoAss.ON, keys=OpCodesAss.ON)
-    oce.add(info=InfoAss.NML, keys=OpCodesAss.NML)
-    oce.add(info=InfoAss.OFF, keys=OpCodesAss.OFF)
-    oce.add(info=InfoAss.ALL_SPEED_UP, keys=OpCodesAss.ALL_SPEED_UP)
-    oce.add(info=InfoAss.ALL_SPEED_OFF, keys=OpCodesAss.ALL_SPEED_OFF)
-    defs.add_service(
-        name=CustomServiceList.RW_ASSEMBLY.value,
-        info="Reaction Wheel Assembly",
-        op_code_entry=oce,
-    )
+def create_reaction_wheels_nodes() -> List[CmdTreeNode]:
+    nodes = []
+    for i in range(4):
+        next_node = CmdTreeNode(
+            f"rw_{i}", f"Reaction Wheel {i}", hide_children_which_are_leaves=True
+        )
+        next_node.add_child(CmdTreeNode(InfoDev.SPEED, OpCodesDev.SPEED))
+        next_node.add_child(CmdTreeNode(InfoDev.ON, OpCodesDev.ON))
+        next_node.add_child(CmdTreeNode(InfoDev.OFF, OpCodesDev.OFF))
+        next_node.add_child(CmdTreeNode(InfoDev.NML, OpCodesDev.NML))
+        next_node.add_child(CmdTreeNode(InfoDev.REQ_TM, OpCodesDev.REQ_TM))
+        next_node.add_child(CmdTreeNode(InfoDev.GET_STATUS, OpCodesDev.GET_STATUS))
+        next_node.add_child(CmdTreeNode(InfoDev.GET_TM, OpCodesDev.GET_TM))
+        next_node.add_child(
+            CmdTreeNode(InfoDev.ENABLE_STATUS_HK, OpCodesDev.ENABLE_STATUS_HK)
+        )
+        next_node.add_child(
+            CmdTreeNode(InfoDev.DISABLE_STATUS_HK, OpCodesDev.DISABLE_STATUS_HK)
+        )
+        nodes.append(next_node)
+    return nodes
 
 
-def pack_single_rw_test_into(  # noqa C901: Complexity is okay here.
-    object_id: bytes, rw_idx: int, q: DefaultPusQueueHelper, op_code: str
+def create_reaction_wheel_assembly_node() -> CmdTreeNode:
+    node = CmdTreeNode(
+        "rw_assy", "Reaction Wheels Assembly", hide_children_which_are_leaves=True
+    )
+    node.add_child(CmdTreeNode(OpCodesAss.ON, InfoAss.ON))
+    node.add_child(CmdTreeNode(OpCodesAss.NML, InfoAss.NML))
+    node.add_child(CmdTreeNode(OpCodesAss.OFF, InfoAss.OFF))
+    node.add_child(CmdTreeNode(OpCodesAss.ALL_SPEED_UP, InfoAss.ALL_SPEED_UP))
+    node.add_child(CmdTreeNode(OpCodesAss.ALL_SPEED_OFF, InfoAss.ALL_SPEED_OFF))
+    return node
+
+
+def create_single_rw_cmd(  # noqa C901: Complexity is okay here.
+    object_id: bytes, rw_idx: int, q: DefaultPusQueueHelper, cmd_str: str
 ):
-    if op_code == OpCodesDev.SPEED:
+    if cmd_str == OpCodesDev.SPEED:
         speed, ramp_time = prompt_speed_ramp_time()
         q.add_log_cmd(
             f"RW {rw_idx}: {InfoDev.SPEED} with target "
@@ -155,41 +143,41 @@ def pack_single_rw_test_into(  # noqa C901: Complexity is okay here.
         )
         q.add_pus_tc(pack_set_speed_command(object_id, speed, ramp_time))
 
-    if op_code == OpCodesDev.ON:
+    if cmd_str == OpCodesDev.ON:
         q.add_log_cmd(f"RW {rw_idx}: {InfoDev.ON}")
         mode_data = pack_mode_data(object_id, Mode.ON, 0)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=mode_data))
 
-    if op_code == OpCodesDev.NML:
+    if cmd_str == OpCodesDev.NML:
         q.add_log_cmd(f"RW {rw_idx}: {InfoDev.NML}")
         mode_data = pack_mode_data(object_id, Mode.NORMAL, 0)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=mode_data))
 
-    if op_code == OpCodesDev.OFF:
+    if cmd_str == OpCodesDev.OFF:
         q.add_log_cmd(f"RW {rw_idx}: {InfoDev.OFF}")
         mode_data = pack_mode_data(object_id, Mode.OFF, 0)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=mode_data))
 
-    if op_code == OpCodesDev.GET_TM:
+    if cmd_str == OpCodesDev.GET_TM:
         q.add_log_cmd(f"RW {rw_idx}: {InfoDev.GET_TM}")
         q.add_pus_tc(
             generate_one_hk_command(
                 sid=make_sid(object_id=object_id, set_id=RwSetId.TM_SET)
             )
         )
-    if op_code == OpCodesDev.REQ_TM:
+    if cmd_str == OpCodesDev.REQ_TM:
         q.add_log_cmd(f"RW {rw_idx}: {InfoDev.REQ_TM}")
         q.add_pus_tc(
             create_action_cmd(object_id=object_id, action_id=ActionId.REQUEST_TM)
         )
-    if op_code in OpCodesDev.GET_STATUS:
+    if cmd_str == OpCodesDev.GET_STATUS:
         q.add_log_cmd(f"RW {rw_idx}: {InfoDev.GET_STATUS}")
         q.add_pus_tc(
             generate_one_diag_command(
                 sid=make_sid(object_id=object_id, set_id=RwSetId.STATUS_SET_ID)
             )
         )
-    if op_code in OpCodesDev.ENABLE_STATUS_HK:
+    if cmd_str == OpCodesDev.ENABLE_STATUS_HK:
         q.add_log_cmd(f"RW {rw_idx}: {InfoDev.ENABLE_STATUS_HK}")
         interval = float(input("Please enter HK interval in floating point seconds: "))
         cmds = enable_periodic_hk_command_with_interval(
@@ -197,7 +185,7 @@ def pack_single_rw_test_into(  # noqa C901: Complexity is okay here.
         )
         for cmd in cmds:
             q.add_pus_tc(cmd)
-    if op_code in OpCodesDev.DISABLE_STATUS_HK:
+    if cmd_str == OpCodesDev.DISABLE_STATUS_HK:
         q.add_log_cmd(f"RW {rw_idx}: {InfoDev.DISABLE_STATUS_HK}")
         q.add_pus_tc(
             disable_periodic_hk_command(
@@ -206,38 +194,38 @@ def pack_single_rw_test_into(  # noqa C901: Complexity is okay here.
         )
 
 
-def pack_rw_ass_cmds(q: DefaultPusQueueHelper, object_id: bytes, op_code: str):
-    if op_code in OpCodesAss.OFF:
+def pack_rw_ass_cmds(q: DefaultPusQueueHelper, object_id: bytes, cmd_str: str):
+    if cmd_str in OpCodesAss.OFF:
         data = pack_mode_data(object_id=object_id, mode=Mode.OFF, submode=0)
         q.add_pus_tc(
             PusTelecommand(
                 service=200, subservice=Subservice.TC_MODE_COMMAND, app_data=data
             )
         )
-    if op_code in OpCodesAss.ON:
+    if cmd_str in OpCodesAss.ON:
         data = pack_mode_data(object_id=object_id, mode=Mode.ON, submode=0)
         q.add_pus_tc(
             PusTelecommand(
                 service=200, subservice=Subservice.TC_MODE_COMMAND, app_data=data
             )
         )
-    if op_code in OpCodesAss.NML:
+    if cmd_str in OpCodesAss.NML:
         data = pack_mode_data(object_id=object_id, mode=Mode.NORMAL, submode=0)
         q.add_pus_tc(
             PusTelecommand(
                 service=200, subservice=Subservice.TC_MODE_COMMAND, app_data=data
             )
         )
-    if op_code in OpCodesAss.ALL_SPEED_UP:
+    if cmd_str in OpCodesAss.ALL_SPEED_UP:
         speed, ramp_time = prompt_speed_ramp_time()
         rw_speed_up_cmd_consec(q, [RW1_ID, RW2_ID, RW3_ID, RW4_ID], speed, ramp_time)
-    if op_code in OpCodesAss.ALL_SPEED_OFF:
+    if cmd_str in OpCodesAss.ALL_SPEED_OFF:
         rw_speed_down_cmd_consec(
             q, [RW1_ID, RW2_ID, RW3_ID, RW4_ID], prompt_ramp_time()
         )
 
 
-def prompt_speed_ramp_time() -> (int, int):
+def prompt_speed_ramp_time() -> Tuple[int, int]:
     speed = int(
         input("Specify speed [0.1 RPM, 0 or range [-65000, -1000] and [1000, 65000]: ")
     )
@@ -313,7 +301,7 @@ def handle_rw_hk_data(
             f"Current Limit Control mode {clc_mode}. 0: Low Current Mode (0.3 A), "
             "1: High Current Mode (0.6 A)"
         )
-        pw.dlog(FsfwTmTcPrinter.get_validity_buffer(hk_data[current_idx:], 5))
+        pw.dlog(get_validity_buffer_str(hk_data[current_idx:], 5))
     if set_id == RwSetId.LAST_RESET:
         pw.dlog(
             f"Received Last Reset HK (ID {set_id}) from Reaction Wheel {object_id.name}"
@@ -402,7 +390,7 @@ def handle_rw_hk_data(
         )
         if current_idx > 0:
             pw.dlog(
-                FsfwTmTcPrinter.get_validity_buffer(
+                get_validity_buffer_str(
                     validity_buffer=hk_data[current_idx:], num_vars=27
                 )
             )

eive_tmtc/tmtc/acs/star_tracker.py

@@ -9,30 +9,40 @@ import datetime
 import enum
 import logging
 import struct
+from typing import List, Tuple
 
-from eive_tmtc.config.definitions import CustomServiceList
 from eive_tmtc.pus_tm.defs import PrintWrapper
 from eive_tmtc.utility.input_helper import InputHelper
 from spacepackets.ecss.tc import PusTelecommand
-from tmtccmd.config import TmtcDefinitionWrapper, OpCodeEntry
-from tmtccmd.config.tmtc import tmtc_definitions_provider
-from tmtccmd.tc.pus_3_fsfw_hk import (
+from tmtccmd.config import CmdTreeNode
+from tmtccmd.pus.tc.s3_fsfw_hk import (
     create_request_one_diag_command,
     create_request_one_hk_command,
     enable_periodic_hk_command_with_interval,
     disable_periodic_hk_command,
     make_sid,
 )
-from tmtccmd.pus.s8_fsfw_funccmd import create_action_cmd
-from tmtccmd.tc import DefaultPusQueueHelper
-from tmtccmd.tc.pus_200_fsfw_mode import pack_mode_data, Mode
+from tmtccmd.pus.s20_fsfw_param import create_load_param_cmd, create_scalar_u8_parameter
+from tmtccmd.pus.s8_fsfw_action import create_action_cmd
+from tmtccmd.tmtc import DefaultPusQueueHelper
+from tmtccmd.pus.s200_fsfw_mode import pack_mode_data, Mode
 from tmtccmd.util import ObjectIdU32
-from tmtccmd.fsfw.tmtc_printer import FsfwTmTcPrinter
+from tmtccmd.fsfw.tmtc_printer import get_validity_buffer_str
 from eive_tmtc.config.object_ids import STR_ASSEMBLY, STAR_TRACKER_ID
 
 _LOGGER = logging.getLogger(__name__)
 
 
+class FirmwareTarget(enum.IntEnum):
+    MAIN = 1
+    BACKUP = 10
+
+
+class ParamId(enum.IntEnum):
+    FIRMWARE_TARGET = 1
+    FIRMWARE_TARGET_PERSISTENT = 2
+
+
 class StarTrackerActionId(enum.IntEnum):
     PING = 0
     BOOT = 1
@@ -95,14 +105,18 @@ class StarTrackerActionId(enum.IntEnum):
     LOGLEVEL = 81
     LOG_SUBSCRIPTION = 82
     DEBUG_CAMERA = 83
+    # Legacy variable.
     FIRMWARE_UPDATE = 84
+    FIRMWARE_UPDATE_MAIN = 84
+    FIRMWARE_UPDATE_BACKUP = 101
     SET_TIME_FROM_SYS_TIME = 87
     ADD_SECONDARY_TM_TO_NORMAL_MODE = 95
     RESET_SECONDARY_TM_SET = 96
     READ_SECONDARY_TM_SET = 97
+    RELOAD_JSON_CFG_FILE = 100
 
 
-class OpCodes:
+class OpCode:
     ON_BOOTLOADER = "on_bootloader"
     ON_FIRMWARE = "on_firmware"
     NORMAL = "nml"
@@ -118,11 +132,23 @@ class OpCodes:
     UPLOAD_IMAGE = "upload_image"
     DOWNLOAD_IMAGE = "download_image"
     SET_IMG_PROCESSOR_MODE = "set_img_proc_mode"
-    FW_UPDATE = "fw_update"
+    FW_UPDATE_MAIN = "fw_update_main"
     SET_TIME_FROM_SYS_TIME = "set_time"
+    RELOAD_JSON_CFG_FILE = "reload_json_cfg"
+    FW_UPDATE_BACKUP = "fw_update_backup"
+    SELECT_TARGET_FIRMWARE_MAIN = "fw_main"
+    SELECT_TARGET_FIRMWARE_BACKUP = "fw_backup"
+    SELECT_TARGET_FIRMWARE_MAIN_PERSISTENT = "fw_main_persistent"
+    SELECT_TARGET_FIRMWARE_BACKUP_PERSISTENT = "fw_backup_persistent"
+    REQUEST_VERSION = "request_version"
 
 
 class Info:
+    ON_BOOTLOADER = "Switch to Mode On, Submode Bootloder"
+    ON_FIRMWARE = "Switch to Mode On, Submode Firmware"
+    NORMAL = "Switch to Mode Normal"
+    OFF = "Switch to Mode Off"
+    PING = "Send Ping"
     ONE_SHOOT_HK = "One shoot HK Set"
     ENABLE_HK = "Enable Periodic HK"
     DISABLE_HK = "Disable Periodic HK"
@@ -133,8 +159,17 @@ class Info:
     DOWNLOAD_IMAGE = "Download Optical Image"
     TAKE_IMAGE = "Take Image"
     SET_IMG_PROCESSOR_MODE = "Set Image Processor Mode"
-    FW_UPDATE = "Firmware Update"
+    FW_UPDATE_MAIN = "Update Main Firmware Slot"
+    FW_UPDATE_BACKUP = "Update Backup Firmware Slot"
     SET_TIME_FROM_SYS_TIME = "Set time from system time"
+    RELOAD_JSON_CFG_FILE = "Reload JSON configuration file. Reboot still required."
+    SELECT_TARGET_FIRMWARE_MAIN = "Select main firmware slot"
+    SELECT_TARGET_FIRMWARE_BACKUP = "Select backup firmware slot"
+    SELECT_TARGET_FIRMWARE_MAIN_PERSISTENT = "Select main firmware slot persistently"
+    SELECT_TARGET_FIRMWARE_BACKUP_PERSISTENT = (
+        "Select backup firmware slot persistently"
+    )
+    REQUEST_VERSION = "Request the active Firmware Version"
 
 
 class SetId(enum.IntEnum):
@@ -156,6 +191,7 @@ class SetId(enum.IntEnum):
     BLOBS = 92
     CENTROID = 93
     CENTROIDS = 94
+    BLOB_STATS = 102
 
 
 class DataSetRequest(enum.IntEnum):
@@ -238,68 +274,64 @@ def prompt_object_id_mode_cmd() -> bytes:
 
 
 def pack_star_tracker_commands(  # noqa C901
-    object_id: ObjectIdU32, q: DefaultPusQueueHelper, op_code: str
+    object_id: ObjectIdU32, q: DefaultPusQueueHelper, cmd_str: str
 ):
     q.add_log_cmd(
         f"Generate command for star tracker with object id: {object_id.as_hex_string}"
     )
     obyt = object_id.as_bytes
-    if op_code == OpCodes.ON_BOOTLOADER:
+    if cmd_str == OpCode.ON_BOOTLOADER:
         q.add_log_cmd("Star tracker: Mode On, Submode Bootloader")
         data = pack_mode_data(prompt_object_id_mode_cmd(), Mode.ON, Submode.BOOTLOADER)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=data))
-    if op_code == OpCodes.ON_FIRMWARE:
+    if cmd_str == OpCode.ON_FIRMWARE:
         q.add_log_cmd("Star tracker: Mode On, Submode Firmware")
         data = pack_mode_data(prompt_object_id_mode_cmd(), Mode.ON, Submode.FIRMWARE)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=data))
-    if op_code == OpCodes.NORMAL:
+    if cmd_str == OpCode.NORMAL:
         q.add_log_cmd("Star tracker: Mode Normal")
         data = pack_mode_data(prompt_object_id_mode_cmd(), Mode.NORMAL, 0)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=data))
-    if op_code == OpCodes.OFF:
+    if cmd_str == OpCode.OFF:
         q.add_log_cmd("Star tracker: Mode Off")
         data = pack_mode_data(prompt_object_id_mode_cmd(), Mode.OFF, 0)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=data))
-    if op_code == OpCodes.ONE_SHOOT_HK:
+    if cmd_str == OpCode.ONE_SHOOT_HK:
         q.add_log_cmd(Info.ONE_SHOOT_HK)
         request_dataset(q, DataSetRequest.ONESHOT)
-    if op_code == OpCodes.ENABLE_HK:
+    if cmd_str == OpCode.ENABLE_HK:
         q.add_log_cmd(Info.ENABLE_HK)
         request_dataset(q, DataSetRequest.ENABLE)
-    if op_code == OpCodes.DISABLE_HK:
+    if cmd_str == OpCode.DISABLE_HK:
         q.add_log_cmd(Info.DISABLE_HK)
         request_dataset(q, DataSetRequest.DISABLE)
-    if op_code == "4":
+    if cmd_str == "4":
         q.add_log_cmd("Star tracker: Mode Raw")
         data = pack_mode_data(obyt, Mode.RAW, 0)
         q.add_pus_tc(PusTelecommand(service=200, subservice=1, app_data=data))
-    if op_code == OpCodes.PING:
+    if cmd_str == OpCode.PING:
         q.add_log_cmd("Star tracker: Ping")
         data = obyt + struct.pack("!I", StarTrackerActionId.PING)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if op_code == "6":
+    if cmd_str == "6":
         q.add_log_cmd("Star tracker:  Switch to bootloader program")
         data = obyt + struct.pack(
             "!I", StarTrackerActionId.SWITCH_TO_BOOTLOADER_PROGRAM
         )
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if op_code == "7":
+    if cmd_str == "7":
         q.add_log_cmd("Star tracker: Temperature request")
         data = obyt + struct.pack("!I", StarTrackerActionId.REQ_TEMPERATURE)
         q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if op_code == "8":
-        q.add_log_cmd("Star tracker: Request version")
-        data = obyt + struct.pack("!I", StarTrackerActionId.REQ_VERSION)
-        q.add_pus_tc(PusTelecommand(service=8, subservice=128, app_data=data))
-    if op_code == "9":
+    if cmd_str == "9":
         q.add_log_cmd("Star tracker: Request interface")
         data = obyt + struct.pack("!I", StarTrackerActionId.REQ_INTERFACE)
         q.add_pus_tc(PusTelecommand(